* refs/pull/25849/head:
qa/suites/rados/upgrade: one mon per node, and enable-msgr2 at end
qa/rados/thrash-old-clients: avoid msgr2
mon: make bootstrap rank check more robust
mon: clean up probe debug output a bit
msg/async: use v1 for v1 <-> [v2,v1] peers
msg/async/AsyncMessenger: drop single-use _send_to
mon/HealthMonitor: raise MON_MSGR2_NOT_ENABLED if mons not bound to msgr2
doc/rados/operations/health-checks: document MON_* health warnings
mon/MonMapMonitor: add 'mon enable-msgr2' command
mon: respawn if rank addr changes
mon/MonMap: calc_addr_mons() after setting rank addrvec
Reviewed-by: Ricardo Dias <rdias@suse.com>
If the Grafana URL contains a trailing slash, this endpoint ends up
returning a 404, disabling the integration entirely. Fix that.
Signed-off-by: Zack Cerza <zack@redhat.com>
* refs/pull/25934/head:
msg/msg_type: entity_addr_t: fix legacy decode
msg/msg_types: make set_sockaddr() work with AF_UNSPEC (i.e., zeroed)
msg/msg_types: make set_sockaddr() a bit more robust
msg/async: fix IP inference
Reviewed-by: Kefu Chai <kchai@redhat.com>
If we decode a zeroed sockaddr, we should end up with a TYPE_NONE
entity_addr_t, not v1::/0.
This was obscured by unit test TestAddrvecEncodeAddrDecode3, which
took an addrvec with all v2 addrs, decoded to an addr variable that
previously had v1:1.2.3.4:/0, and asserted the result was not v1::/0.
The test passed before because the set_sockaddr() failed on AF_UNSPEC
and the addr kept v1:1.2.3.4, but with the previous commit it failed
because it equaled v1::/0. In reality, addr should get - (addr TYPE_NONE).
The TestEmptyAddrvecEncodeAddrDecode test case is similarly adjusted.
Signed-off-by: Sage Weil <sage@redhat.com>
mgr/dashboard: RbdMirroringService test suite fails in dev mode
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
With automatic balancing on, and if mode is set to upmap,
balancer will fail silently if min_compat_client is lower than
luminous.
You can't figure out that unless you take a closer look at the
mgr log, which is super annoying..
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
The dashboard ganesha management code requires the rados:// config
URL for the nfs-ganesha daemons. Ensure that we populate that.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
rook is lowercasing this tag in the CRD in response to review comments.
Change the orchestrator accordingly.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Changes needed to replace the obsolete get_config by the new get_module_option manager module method
Signed-off-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
If we search for myaddrs, then we will detect our rank properly if we were
[a,b] and the a addr got removed.
Signed-off-by: Sage Weil <sage@redhat.com>
If *peers* are communicating, i.e. there may be bidirectional connection
attempts, we must use the same protocol version from both ends or else
we will get very confused.
Fix this by forcing the use of v1 when we
- are bound to a v1 endpoint only (people can't connect to us via v2)
- we are connecting to a *peer*
If it is a non-peer, then connections are uni-directional. If we both
have v2, we will both use v2.
If we ever switch to [v2,v1], it will be as part of a restart.
Signed-off-by: Sage Weil <sage@redhat.com>
If the ms_bind_msgr2 option is enabled, and all mons are nautilus,
raise a health alert if any mons aren't bound to msgr2 addresses.
Whitelist tests that mon_bind_addrvec=false or mon_bind_msgr2=false.
Signed-off-by: Sage Weil <sage@redhat.com>
This switches any monitor listening on v1:...:6789 only to v2 (on
3300) + v1 (on 6789). It should be run after upgrading all monitors
to nautilus.
Signed-off-by: Sage Weil <sage@redhat.com>
This is to prevent fmtflags changes from a previous use (e.g. debug message)
leaking into the the next (i.e. the next debug message).
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>