Commit Graph

120331 Commits

Author SHA1 Message Date
Nathan Cutler
4d47f8a928
Merge pull request #39762 from smithfarm/wip-support-leap-15.3
rpm/luarocks: simplify conditional and support Leap 15.3

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Reviewed-by: Kyr Shatskyy <kyrylo.shatskyy@suse.de>
2021-03-03 18:05:07 +01:00
Sebastian Wagner
86b25bc0be
Merge pull request #39789 from zdover23/wip-doc-cephadm-convert--bash-shells-2021-Mar-03
doc/cephadm: add prompts to adoption.rst

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-03-03 16:45:00 +01:00
Casey Bodley
fc03ae8f12
Merge pull request #39794 from cbodley/wip-qa-rgw-valgrind-supp-librados-delete
valgrind: suppress operator delete[] for tcmalloc

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2021-03-03 10:38:36 -05:00
Sebastian Wagner
089938a1af
Merge pull request #39558 from sebastian-philipp/doc-rados-rm-toctree-cephadm
doc/rados: avoid including cephadm into the toctree

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Zac Dover <zac.dover@gmail.com>
2021-03-03 16:17:51 +01:00
Daniel Gryniewicz
bfde964cf0
Merge pull request #39399 from dang/wip-dang-zipper-10
RGW - Zipper 10: The Great Zippening
2021-03-03 08:56:04 -05:00
Sage Weil
5290ed3777 Merge PR #38909 into master
* refs/pull/38909/head:
	PendingReleaseNotes: document option osd_fast_shutdown_notify_mon
	osd: add osd_fast_shutdown_notify_mon option (default false)

Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-03-03 08:38:58 -05:00
Sage Weil
67e842d519 Merge PR #39654 into master
* refs/pull/39654/head:
	common/options: drop ms_async_max_op_threads
	msg/async: drop Stack::num_workers
	msg/async: s/num_workers/workers.size()/
	msg/async: use range-based loop in NetworkStack
	msg/async: do not pass worker id to Stack::spawn_worker()
	async/Stack: pass Worker* to NetworkStack::add_thread()
	async/rdma: do not reference worker id in RDMAStack::spawn_worker()
	async/dpdk: do not use worker id when creating worker
	async/PosixStack: do not reference worker id in ctor
	async/rdma: initialize worker in RDMAStack::create_worker()
	async/rdma: move RDMAStack::create_worker() to .cc

Reviewed-by: luo runbing <luo.runbing@zte.com.cn>
Reviewed-by: Haomai Wang <haomai@xsky.com>
2021-03-03 08:38:21 -05:00
Sage Weil
bdff94a09d Merge PR #39665 into master
* refs/pull/39665/head:
	qa/rados/dashbord use "random" objectore

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-03-03 08:35:51 -05:00
Sage Weil
86b824ec60 Merge PR #39689 into master
* refs/pull/39689/head:
	src/global/signal_handler.h: fix preprocessor logic for alpine

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-03-03 08:33:28 -05:00
Sage Weil
cb98159b12 Merge PR #39750 into master
* refs/pull/39750/head:
	mgr: create client messenger using ms_public_type

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-03-03 08:32:41 -05:00
Sebastian Wagner
d4292afebf
Merge pull request #39770 from liewegas/bug-46745
cephadm: add docker.service dependency in systemd units

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-03-03 10:51:47 +01:00
Mykola Golub
7c214b24ce
Merge pull request #39795 from dillaman/wip-migration-import-docs
doc/rbd: clarify QCOW2 migration support

Reviewed-by: Mykola Golub <mgolub@suse.com>
2021-03-03 10:45:35 +02:00
Kefu Chai
163f3b81b9
Merge pull request #39555 from tchaikov/wip-drop-pre-nautilus
*: drop backward compatibility with pre-nautilus versions

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2021-03-03 16:39:46 +08:00
Kefu Chai
de049079fb
Merge pull request #39798 from tchaikov/wip-crimson-monc-copy-sent
crimson/mon: keep a copy of sent MMonCommand messages

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-03-03 12:31:39 +08:00
Kefu Chai
a977061602 crimson/mon: keep a copy of sent MMonCommand messages
as per Yingxin Cheng,

> The send process can be asynchronous (there is a conn.out_q, or if the
> underlying socket lives in a different core in the m:n model to be
> ordered there). If user really wants to reuse a message, they must be
> careful not to modify it because it may result in modifing the pending
> messages.
>
> I think the best way is to copy the message if user want to resend it,
> and keep the ceph_assert(!msg->get_seq()). It may looks good to reuse a
> message under lossy policy, but the correctness is now up to user not to
> modify it inplace.

see also https://github.com/ceph/ceph/pull/39786

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-03-03 11:41:38 +08:00
Jason Dillaman
68fda590cf doc/rbd: clarify QCOW2 migration support
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2021-03-02 17:29:41 -05:00
Casey Bodley
bf087c3f84 valgrind: suppress operator delete[] for tcmalloc
suppresses a mismatched operator delete[] from the librados client's
destructor:

<error>
  <unique>0xeef7eb</unique>
  <tid>1</tid>
  <kind>MismatchedFree</kind>
  <what>Mismatched free() / delete / delete []</what>
  <stack>
    <frame>
      <ip>0x4C32EA0</ip>
      <obj>/usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so</obj>
      <fn>operator delete[](void*, unsigned long)</fn>
      <dir>/builddir/build/BUILD/valgrind-3.16.0/coregrind/m_replacemalloc</dir>
      <file>vg_replace_malloc.c</file>
      <line>660</line>
    </frame>
    <frame>
      <ip>0x5FBEB86</ip>
      <obj>/usr/lib64/librados.so.2.0.0</obj>
    </frame>
    <frame>
      <ip>0x5FBEF2C</ip>
      <obj>/usr/lib64/librados.so.2.0.0</obj>
    </frame>
    <frame>
      <ip>0x5F7F7C5</ip>
      <obj>/usr/lib64/librados.so.2.0.0</obj>
      <fn>librados::v14_2_0::Rados::shutdown()</fn>
    </frame>

Fixes: https://tracker.ceph.com/issues/49501

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2021-03-02 15:38:41 -05:00
Sage Weil
d4a6a97f5b Merge PR #39730 into master
* refs/pull/39730/head:
	cephadm: fix escaping/quoting of stderr-prefix arg for ceph daemons

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
2021-03-02 13:56:01 -05:00
Zac Dover
7eb65fe2cf doc/cephadm: add prompts to adoption.rst
This PR formats the bash prompts. It also formats the
bash output so that it appears in the correct (easily
copy-and-pasteable) format. This PR will be followed by
a grammar-improving PR, but this PR is just a
formatting PR.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2021-03-03 04:22:51 +10:00
Ilya Dryomov
9611104a19
Merge pull request #39781 from idryomov/wip-krbd-xfstests-fixes
qa/suites/krbd: address recent issues caused by newer kernels

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2021-03-02 18:43:20 +01:00
Sage Weil
0b91432170 Merge PR #39723 into master
* refs/pull/39723/head:
	mon/ConfigMonitor: make config changes via KVMonitor's pending set

Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-03-02 12:08:52 -05:00
Sage Weil
3ea514c552 cephadm: fix escaping/quoting of stderr-prefix arg for ceph daemons
On some versions of podman doing

   --default-log-stderr-prefix="debug "

seems to work okay, but on others it does not, producing lines like

   /usr/bin/ceph-mon: "debug "2021-02-26T15:30:36.266+0000 7f3d8a955700  4 rocksdb:                    Options.db_write_buffer_size: 0

Quote things properly for the unit.run bash script.

Signed-off-by: Sage Weil <sage@newdream.net>
2021-03-02 10:35:41 -06:00
Sage Weil
65724b1f97 Merge PR #39739 into master
* refs/pull/39739/head:
	cephadm: set CEPH_USE_RANDOM_NONCE if using --init
	msg/Messenger: use random nonce if CEPH_USE_RANDOM_NONCE or pid == 1
	Revert "Merge PR #39482 into master"

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
2021-03-02 11:32:12 -05:00
Daniel Gryniewicz
c107f970ca RGW - Fix mock User class in Lua test
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2021-03-02 10:51:12 -05:00
Sage Weil
0b5bc8fc2e cephadm: add docker.service dependency in systemd units
This ensures that (1) we start after the docker daemon is running, and
(2) a restart of docker will also restart the ceph services.

Fixes: https://tracker.ceph.com/issues/46745
Signed-off-by: Sage Weil <sage@newdream.net>
2021-03-02 09:50:49 -05:00
Patrick Donnelly
150868a489
Merge PR #39679 into master
* refs/pull/39679/head:
	Revert "mon/MDSMonitor: add missing frozen checks"

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
2021-03-02 06:40:50 -08:00
Sebastian Wagner
c28524d301
Merge pull request #38995 from mgfritch/cephadm-check-host-errors
cephadm: remove redundant `ERROR` during check-host

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-03-02 15:33:04 +01:00
Sebastian Wagner
06258eafd1
Merge pull request #39722 from p-se/wip-pse-cephadm-SUSE-alertmanager
cephadm: `cephadm ls` broken for SUSE downstream alertmanager container

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-03-02 15:30:17 +01:00
Sebastian Wagner
5dd8c08c53
Merge pull request #38915 from Daniel-Pivonka/clientsoktostop
mgr/cephadm: add ok-to-stop functions for ceph client services

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-03-02 15:28:58 +01:00
Sebastian Wagner
0cbec89deb
Merge pull request #39352 from sebastian-philipp/orch-remove-promise
mgr/orch: Make orchestrator interface synchronous

Reviewed-by: Varsha Rao <varao@redhat.com>
2021-03-02 15:25:02 +01:00
Sebastian Wagner
a171b32a21
Merge pull request #39612 from jmolmo/fix_rook_orch_ls
mgr/orchestrator: Fix ceph orch ls in Rook

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
Reviewed-by: Varsha Rao <varao@redhat.com>
2021-03-02 14:47:25 +01:00
Kefu Chai
504aaaa9e5
Merge pull request #39784 from rzarzynski/wip-crimson-monc-close-active-conn-on-reset
crimson/monc: close() active_con before destructing it on resets.

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-03-02 20:48:35 +08:00
Kefu Chai
11cd800fe6
Merge pull request #39783 from tchaikov/wip-crimson-clang
crimson/os: fix clang build and cleanups.

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-03-02 20:45:24 +08:00
Radoslaw Zarzynski
1dc78fd5b2 crimson/monc: close() active_con before destructing it on resets.
`ProtocolV2` expects `AuthClient` implementations to withstand
calling `get_auth_request()` and `handle_auth_reply_more()` even
if `handle_auth_done()` had been already called. This is because
a network fault may happen on e.g. `AuthSignatureFrame` which is
put on the wire after the `AuthDone` handling.

`crimson::mon::Client` deals with that by returning `auth::error`
from both `get_auth_request()` and `handle_auth_reply_more()` as
the preceding invocation of `handle_auth_done()` had already
cleared `pending_conns` (and set `active_con`). This leads to
`abort_in_close()` and finally to dispatching `ms_handle_reset()`
on `mon::Client` which is fine in general but, when comes to the
current implementation, it destroys `active_con` without closing
it first.
One of the consequence is breaking the `mon::Connection::reply`
promise; another one is missed `mark_down()` call.

```
DEBUG 2021-03-01 18:10:50,489 [shard 0] ms - [osd.0(client) v2:172.21.15.110:6800/33954@56752 >> mon.? v2:172.21.15.110:3300/0] GOT AuthDoneFrame: gid=4121, con_mode=se
cure, payload_len=995
DEBUG 2021-03-01 18:10:50,489 [shard 0] ms - [osd.0(client) v2:172.21.15.110:6800/33954@56752 >> mon.? v2:172.21.15.110:3300/0] WRITE AuthSignatureFrame: signature=60ca
f49e5a6cf3cc39c4160cb9d09032db5f794e29655dc0124cf5f42b7546fb
DEBUG 2021-03-01 18:10:50,489 [shard 0] ms - authenticated_encrypt_update plaintext.length()=80 buffer.length()=80
DEBUG 2021-03-01 18:10:50,489 [shard 0] ms - authenticated_encrypt_final buffer.length()=96 final_len=0
INFO  2021-03-01 18:10:50,489 [shard 0] monc - found mon.noname-a
INFO  2021-03-01 18:10:50,489 [shard 0] monc - sending auth(proto 2 2 bytes epoch 0) v1
INFO  2021-03-01 18:10:50,489 [shard 0] monc - waiting
DEBUG 2021-03-01 18:10:50,489 [shard 0] ms - [osd.0(client) v2:172.21.15.110:6800/33954@56752 >> mon.? v2:172.21.15.110:3300/0] GOT AuthSignatureFrame: signature=ea04f1
318cf76808414a853ed37fd232ae886bef036cb4248079c6cba89d669a
DEBUG 2021-03-01 18:10:50,490 [shard 0] ms - [osd.0(client) v2:172.21.15.110:6800/33954@56752 >> mon.? v2:172.21.15.110:3300/0] WRITE ClientIdentFrame: addrs=v2:172.21.
15.110:6800/33954, target=v2:172.21.15.110:3300/0, gid=0, gs=1, features_supported=4540138303579357183, features_required=576460752303432193, flags=1, cookie=9231904580
14536120
...
INFO  2021-03-01 18:10:50,490 [shard 0] ms - [osd.0(client) v2:172.21.15.110:6800/33954@56752 >> mon.? v2:172.21.15.110:3300/0] execute_connecting(): fault at CONNECTIN
G, going to WAIT -- std::system_error (error crimson::net:4, read eof)
...
DEBUG 2021-03-01 18:10:50,690 [shard 0] ms - [osd.0(client) v2:172.21.15.110:6800/33954@0 >> mon.? v2:172.21.15.110:3300/0] GOT HelloFrame: my_type=mon peer_addr=v2:172.21.15.110:63960/0
INFO  2021-03-01 18:10:50,690 [shard 0] monc - get_auth_request(con=[osd.0(client) v2:172.21.15.110:6800/33954@63960 >> mon.? v2:172.21.15.110:3300/0], auth_method=0)
ERROR 2021-03-01 18:10:50,690 [shard 0] ms - [osd.0(client) v2:172.21.15.110:6800/33954@63960 >> mon.? v2:172.21.15.110:3300/0] get_initial_auth_request returned crimson::auth::error (unknown connection)
INFO  2021-03-01 18:10:50,690 [shard 0] ms - [osd.0(client) v2:172.21.15.110:6800/33954@63960 >> mon.? v2:172.21.15.110:3300/0] closing: reset yes, replace no
DEBUG 2021-03-01 18:10:50,690 [shard 0] ms - [osd.0(client) v2:172.21.15.110:6800/33954@63960 >> mon.? v2:172.21.15.110:3300/0] TRIGGER CLOSING, was CONNECTING
...
INFO  2021-03-01 18:10:50,690 [shard 0] ms - [osd.0(client) v2:172.21.15.110:6800/33954@63960 >> mon.? v2:172.21.15.110:3300/0] write_event: dropped
INFO  2021-03-01 18:10:50,690 [shard 0] ms - [osd.0(client) v2:172.21.15.110:6800/33954@63960 >> mon.? v2:172.21.15.110:3300/0] execute_connecting(): protocol aborted at CLOSING -- std::system_error (error crimson::net:6, protocol aborted)
INFO  2021-03-01 18:10:50,690 [shard 0] ms - [osd.0(client) v2:172.21.15.110:6800/33954@63960 >> mon.? v2:172.21.15.110:3300/0] closing: reset yes, replace no
DEBUG 2021-03-01 18:10:50,690 [shard 0] ms - [osd.0(client) v2:172.21.15.110:6800/33954@63960 >> mon.? v2:172.21.15.110:3300/0] TRIGGER CLOSING, was CONNECTING
WARN  2021-03-01 18:10:50,690 [shard 0] osd - ms_handle_reset
WARN  2021-03-01 18:10:50,690 [shard 0] monc - active conn reset v2:172.21.15.110:3300/0
INFO  2021-03-01 18:10:50,690 [shard 0] monc - reopen_session to mon.-1
WARN  2021-03-01 18:10:50,690 [shard 0] monc - mon.0 does not have an addr compatible with me
INFO  2021-03-01 18:10:50,690 [shard 0] monc - connecting to mon.1
INFO  2021-03-01 18:10:50,690 [shard 0] ms - [osd.0(client) v2:172.21.15.110:6800/33954 >> mon.? v2:172.21.15.110:3300/0] ProtocolV2::start_connect(): peer_addr=v2:172.21.15.110:3300/0, peer_name=mon.?, cc=14512795460730278364 policy(lossy=true, server=false, standby=false, resetcheck=false)
DEBUG 2021-03-01 18:10:50,690 [shard 0] ms - [osd.0(client) v2:172.21.15.110:6800/33954 >> mon.? v2:172.21.15.110:3300/0] TRIGGER CONNECTING, was NONE
DEBUG 2021-03-01 18:10:50,690 [shard 0] ms - [osd.0(client) v2:172.21.15.110:6800/33954 >> mon.? v2:172.21.15.110:3300/0] UPDATE: gs=3 for connect
INFO  2021-03-01 18:10:50,690 [shard 0] ms - [osd.0(client) v2:172.21.15.110:6800/33954 >> mon.? v2:172.21.15.110:3300/0] write_event: delay ...
INFO  2021-03-01 18:10:50,690 [shard 0] ms - [osd.0(client) v2:172.21.15.110:6800/33954@63960 >> mon.? v2:172.21.15.110:3300/0] write_event: dropped
INFO  2021-03-01 18:10:50,690 [shard 0] ms - [osd.0(client) v2:172.21.15.110:6800/33954@63960 >> mon.? v2:172.21.15.110:3300/0] execute_connecting(): protocol aborted at CLOSING -- std::system_error (error crimson::net:6, protocol aborted)
...
"
WARN  2021-03-01 18:10:50,690 [shard 0] seastar - Exceptional future ignored: seastar::broken_promise (broken promise), backtrace:    0x146f364
   0x146f6e1
   0x146fb01
   0x135c2fe
   0x135c481
   0x6ee079
   0x137db87
   0x137def2
   0x13ab085
   0x1347b27
   0x6619f5
   /lib64/libc.so.6+0x237b2
   0x6b217d
   --------
   N7seastar12continuationINS_8internal22promise_base_with_typeIvEENS_6futureIvE12finally_bodyIZNS_5asyncIZZ4mainENKUlvE_clEvEUlvE_JEEENS_8futurizeINSt9result_ofIFNSt5decayIT_E4typeEDpNSC_IT0_E4typeEEE4typeEE4typeENS_17thread_attributesEOSD_DpOSG_EUlvE1_Lb0EEEZNS5_17then_wrapped_nrvoIS5_SU_EENSA_ISD_E4typeEOT0_EUlOS3_RSU_ONS_12future_stateINS1_9monostateEEEE_vEE

```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-03-02 12:36:28 +00:00
Daniel Gryniewicz
8efaf76235 RGW Zipper - get_ctl() no longer needed
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2021-03-02 07:35:05 -05:00
Daniel Gryniewicz
200f71a90c RGW Zipper - user.empty()
Add an empty() method for user, and use it in admin code.

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2021-03-02 07:35:05 -05:00
Daniel Gryniewicz
ca61489782 RGW Zipper - Wrap zoneutils
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2021-03-02 07:35:05 -05:00
Daniel Gryniewicz
497c9dbdd6 RGW Zipper - Add zone abstraction
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2021-03-02 07:35:05 -05:00
Daniel Gryniewicz
f8aa45ffb7 RGW Zipper - random cleanups
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2021-03-02 07:35:05 -05:00
Daniel Gryniewicz
26670586c0 RGW Zipper - Meta list API
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2021-03-02 07:35:05 -05:00
Daniel Gryniewicz
69dc092bfe RGW Zipper - zipify RGWUserAdminOpState
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2021-03-02 07:35:05 -05:00
Daniel Gryniewicz
715a026d12 RGW Zipper - Clean up get_user* APIs.
The main get_user() function doesn't query the cluster, but the rest of
them do.  Rename the functions to match, and add comments to clarify.

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2021-03-02 07:35:05 -05:00
Daniel Gryniewicz
b67d5bca22 Zipper - zipperify the Auth code
This also removes the only user of s->sysobj_ctx, so that can be removed
as well.

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2021-03-02 07:35:05 -05:00
Daniel Gryniewicz
a3f1d9dae1 Zipper - remove duplicate get_user()
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2021-03-02 07:35:05 -05:00
Daniel Gryniewicz
72d1a36326 RGW - Zipper 10: Pull The Thread
This commit changes the RGWStoreManager to return a RGWStore* rather
than a RGWRadosStore*.  This is the thread that unravels the rest of the
Zipper work, removing hard-coded uses of the RGWRados* classes.

Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2021-03-02 07:35:05 -05:00
Kefu Chai
957653d1b2
Merge pull request #39779 from tchaikov/wip-crimson-monc-cleanup
crimson/mon: resend mon command when connected and cleanups

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
2021-03-02 20:32:25 +08:00
Kefu Chai
195c5bb962 crimson/os: return an errorator::future in an erroratorized chain
errorator does not convert a "void" continuation to a ready future at
the time of writing.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-03-02 19:55:50 +08:00
Kefu Chai
c951ec3eb2 crimson/os: capture structured binding labels with new variable
structured binding does not define variables. unlike GCC, Clang does
not allow this.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-03-02 19:54:14 +08:00
Kefu Chai
cec783344e crimson/os: mark unused variable with [[maybe_unused]]
`MAX_FLAT_BLOCK_SIZE` is only used in Debug builds.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-03-02 19:54:14 +08:00
Kefu Chai
50f29bf2b7 crimson/os: do not capture unused variables
Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-03-02 19:54:13 +08:00