Commit Graph

76364 Commits

Author SHA1 Message Date
Sage Weil
d62716b264 Merge pull request #16712 from gregsfortytwo/wip-20808
osd: pg: be more careful with locking around forced pg recovery

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2017-08-01 14:11:29 -05:00
Gregory Farnum
65e11540aa Merge pull request #16688 from amitkumar50/cov-1395347-1
os: Argument cannot be negative

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2017-08-01 11:25:20 -07:00
Jenkins Build Slave User
b661348f15 12.1.2 2017-08-01 17:55:40 +00:00
Casey Bodley
14aed80ac2 Merge pull request #15801 from zhangsw/feature-bucket-sync
rgw multisite: feature of bucket sync enable/disable

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2017-08-01 13:13:18 -04:00
Jason Dillaman
1d54951e47 common: avoid statically allocating configuration options
This was resulting in seg faults within rbd-fuse during shutdown. This also
fixes the "variable tracking size limit exceeded with -fvar-tracking-assignments,
retrying without" compiler warning".

Fixes: http://tracker.ceph.com/issues/20869
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-01 12:04:02 -04:00
Sage Weil
67e770e05b Merge pull request #16616 from tchaikov/wip-doc-cleanup
doc: remove docs on non-existant command
2017-08-01 11:01:09 -05:00
Jason Dillaman
dd4a912fa3 rbd-fuse: remove dependency on ceph-common
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2017-08-01 11:54:34 -04:00
Kefu Chai
69c6402bbd Merge pull request #16727 from jcsp/wip-doc-config-hel
doc/qa: cover `config help` command

Reviewed-by: Kefu Chai <kchai@redhat.com>
2017-08-01 23:38:28 +08:00
Kefu Chai
ffbf113fa0 Merge pull request #16707 from ivancich/wip-more-dmclock-docs
doc: Describe mClock's use within Ceph in great detail.

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2017-08-01 23:37:53 +08:00
Sage Weil
527a3f77db Merge pull request #16730 from liewegas/wip-more-doc-links
doc/release-notes: fix upmap and osd replacement links; add fixme

Reviewed-by: Kefu Chai <kchai@redhat.com>
2017-08-01 10:21:39 -05:00
Sage Weil
71307945bf doc/release-notes: fix a few doc links
Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-01 11:06:21 -04:00
Jos Collin
8669a70fcb Merge pull request #16653 from amitkumar50/Coverity-1409697
rgw: Use comparison instead of assignment

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2017-08-01 14:47:54 +00:00
amitkuma
1b62ee5cb4 os: Argument cannot be negative
Fixed:

** CID 1395347 (#1 of 1): Argument cannot be negative (NEGATIVE_RETURNS)
3. negative_returns: fd is passed to a parameter that cannot be negative

Signed-off-by: Amit Kumar amitkuma@redhat.com
2017-08-01 20:13:06 +05:30
Jason Dillaman
2589f57ecd Merge pull request #16656 from idryomov/wip-qa-newer-fio
qa/tasks/rbd_fio: bump default fio version to 2.21

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2017-08-01 10:14:46 -04:00
Sage Weil
c3aa866dca osd: initialize shardedwq osdmap references on startup
The _process methods assumes the shard osdmap refs are
non-null, but that leaves a window between startup and
the first call to prune_pg_waiters (via consume_map()),
which can lead to a seg fault.

Calling prune during startup, before we have any work,
will initialize those references.

Fixes: http://tracker.ceph.com/issues/20748
Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-01 09:58:28 -04:00
Kefu Chai
d12c51ca91 qa/suites: escape the parenthesis of the whitelist text
so we can avoid the warnings like

grep: Unmatched ( or \(

because we pass the whitelisted string to `egrep -v "$1"` directly.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-08-01 21:54:44 +08:00
Kefu Chai
d67d6c57ae qa/workunits/ceph-disk: fix the path to ceph-helpers-root.sh
partially reverts 841f3bd

Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-08-01 21:54:44 +08:00
Kefu Chai
4cac1e40b1 Merge pull request #16652 from shangzhong/wip-update-quick-guide
doc: update the pool names created by vstart.sh by default

Reviewed-by: Kefu Chai <kchai@redhat.com>
2017-08-01 21:50:52 +08:00
Sage Weil
4839485f53 Merge pull request #16637 from ceph/wip-doc-links
doc: upmap docs; various missing links for release notes

Reviewed-by: Kefu Chai <kchai@redhat.com>
2017-08-01 08:50:02 -05:00
Sage Weil
5e54676d99 doc/release-notes: add various links to docs
Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-01 09:49:39 -04:00
Sage Weil
aa5b930f60 doc/rados/operations/upmap: document new upmap feature
Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-01 09:49:39 -04:00
Sage Weil
6d7e4b444d Merge pull request #15838 from theanalyst/doc-pool-ns-update
doc: update the rados namespace docs

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2017-08-01 08:39:18 -05:00
Sage Weil
dbf14eb780 Merge pull request #16623 from xiexingguo/wip-weightset
crush: a couple of weight-set fixes

Reviewed-by: Sage Weil <sage@redhat.com>
2017-08-01 08:29:29 -05:00
Sage Weil
0afffa5c58 Merge pull request #16611 from liewegas/wip-doc-health
doc/rados/operations/health-checks: osd section

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: John Spray <john.spray@redhat.com>
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
2017-08-01 08:26:24 -05:00
Sage Weil
dbb1dd33e6 doc/rados/operations/health-checks: add PG health check commentary
Include a link to pg-repair.rst, although there is no
content there yet.

Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-01 09:25:42 -04:00
Sage Weil
cb34a63b32 mon/PGMap: include which pgs have unfound objects in detail
Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-01 09:25:42 -04:00
Sage Weil
6a4b83d646 mon/PGMap: put the _toofull states under DEGRADED_FULL
I think this was an oversight?

Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-01 09:25:42 -04:00
Sage Weil
3789f46ead mon/PGMap: 'incomplete' means data is unavailable
Well, data is certainly unavailable, and may also be
degraded in the sense that we can't peer.  I think
unavailable is the more severe of the two, though, so
let's put it there!

Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-01 09:25:42 -04:00
Sage Weil
6bac77e960 doc/rados/operations/health-checks: osd section
First paragraph: explain what the error means.

Second or later paragraph: describe steps to fix or mitigate.

Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-01 09:25:41 -04:00
Zhu Shangzhong
c91bb519e8 doc: change the default filesystem/pool names
- s/cephfs_data/cephfs_data_a
- s/cephfs_metadata/cephfs_metadata_a
- s#./rados df#bin/rados df
- update the 'bin/rados df' output
- remove the rbd pool, it isn't created by default anymore.

Signed-off-by: Zhu Shangzhong <zhu.shangzhong@zte.com.cn>
2017-08-01 20:40:58 +08:00
John Spray
ac2b9d63ca qa: include config help in admin socket test
Signed-off-by: John Spray <john.spray@redhat.com>
2017-08-01 13:38:40 +01:00
John Spray
fbf08b6868 doc: document config help command
Signed-off-by: John Spray <john.spray@redhat.com>
2017-08-01 13:38:27 +01:00
Jos Collin
beab3c5ef4 Merge pull request #16721 from joscollin/wip-config-rst-typo
doc: fix typo in config.rst

Reviewed-by: Xie Xingguo <xie.xingguo@zte.com.cn>
2017-08-01 11:21:59 +00:00
John Spray
4f2172cae1 Merge pull request #16723 from tchaikov/wip-doc-kill-warnings
doc: various fixes
2017-08-01 12:06:36 +01:00
Kefu Chai
5c374e7382 Merge pull request #16471 from jan--f/janf-mds-deactivate-doc
doc: reword mds deactivate docs; add optional fs_name argument

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2017-08-01 18:52:59 +08:00
Kefu Chai
a8c2b10439 Merge pull request #16620 from cfanz/master
common: use std::move() for better performance

Reviewed-by: Jos Collin <jcollin@redhat.com>
2017-08-01 17:45:06 +08:00
Kefu Chai
69607f8092 Merge pull request #16526 from TsaiJin/wip-fix-msg-typo
msg/async: fix the bug of inaccurate calculation of l_msgr_send_bytes

Reviewed-by: Pan Liu <wanjun.lp@alibaba-inc.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Haomai Wang <haomai@xsky.com>
2017-08-01 17:40:27 +08:00
Kefu Chai
24742cf3ef Merge pull request #16666 from scienceluo/wip-luo-auth-branch
auth: Remove unused function in AuthSessionHandler

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2017-08-01 17:38:08 +08:00
Kefu Chai
2670d244fd doc: various fixes
- radosgw/s3/bucketops.rst: fix Malformed table.
- operations/health-checks.rst: Title underline too short
- rbd/rados-rbd-cmds.rst: Title underline too short
- rados/operations/index.rst: include health-checks in toc

Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-08-01 17:31:36 +08:00
Jos Collin
eb1f53782a doc: fix typo in config.rst
Fixed the typo introduced by PR#16681

Signed-off-by: Jos Collin <jcollin@redhat.com>
2017-08-01 14:16:14 +05:30
Josh Durgin
61908ac890 Merge pull request #16622 from dillaman/wip-cmpext-dne
osd: cmpext operator should ignore -ENOENT on read

Reviewed-by: David Zafman <dzafman@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2017-07-31 23:52:43 -07:00
Greg Farnum
f19a3d96a3 osd: pg: be more careful with locking around forced pg recovery
This does several little things that add up to big concurrency and safety
improvements:
* Switch to passing around PGRefs instead of raw pointers, which is
  generally a good idea
* drop the pg_map_lock once we're done looking up the PGRefs, since
  we don't need it and holding the PG pointer alive was the only previous
  thing that might have made it necessary
* don't hold the recovery_lock since we don't need any OSD-level
  synchronization
* make sure the PG is not being deleted before we do a force-change of its
  state

Fixes: http://tracker.ceph.com/issues/20808

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
2017-07-31 23:41:08 -07:00
Kefu Chai
c4b25b114d Merge pull request #16677 from tchaikov/wip-20785
osd: do not send pg_created unless luminous

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2017-08-01 13:12:53 +08:00
Yanhu Cao
ce7fed2926 ceph-osd: fix auto detect which objectstore is currently running
Fixes: http://tracker.ceph.com/issues/20865

Signed-off-by: Yanhu Cao <gmayyyha@gmail.com>
2017-08-01 10:44:57 +08:00
Josh Durgin
886971b58b mon/OSDMonitor: make setting require-osd-release idempotent
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
2017-07-31 21:51:47 -04:00
Josh Durgin
966513908c osd: do not try to set device class before luminous
This avoids crashing when older monitors do not support it.

Fixes: http://tracker.ceph.com/issues/20850
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
2017-07-31 21:50:48 -04:00
David Zafman
901f14aa7c Merge pull request #16663 from dzafman/wip-ec-enoent
osd: EC read handling: don't grab an objectstore error to use as the read error

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2017-07-31 18:19:02 -07:00
Jos Collin
7e9d87fa2e Merge pull request #16681 from shun-s/wip-doc-config
doc: fix typos in config.rst

Reviewed-by: Jos Collin <jcollin@redhat.com>
2017-08-01 00:59:06 +00:00
Patrick Donnelly
8db2c43e79
qa: test export_pin is correct in dumped subtree
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2017-07-31 15:33:49 -07:00
Gregory Farnum
b16b973e39 Merge pull request #16695 from tchaikov/wip-cmake-disable-vta
cmake: disable -fvar-tracking-assignments for config.cc

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2017-07-31 15:05:23 -07:00