Commit Graph

120521 Commits

Author SHA1 Message Date
Patrick Donnelly
5faf0ee0f3
mds,qa: exit instead of respawn under valgrind
valgrind can't handle execve of /proc/self/exe:

    2021-02-27T05:52:37.813 INFO:tasks.ceph.mds.d.smithi073.stderr:==00:01:03:20.556 41218== execve(0x18546740(/proc/self/exe), 0x18546670, 0x133ef310) failed, errno 2
    2021-02-27T05:52:37.813 INFO:tasks.ceph.mds.d.smithi073.stderr:==00:01:03:20.556 41218== EXEC FAILED: I can't recover from execve() failing, so I'm dying.
    2021-02-27T05:52:37.813 INFO:tasks.ceph.mds.d.smithi073.stderr:==00:01:03:20.556 41218== Add more stringent tests in PRE(sys_execve), or work out how to recover.

So configure the MDS to just exit so it can be restarted by QA infra (the
daemon watchdog).

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2021-03-03 09:30:21 -08:00
Patrick Donnelly
3e5e03d4d2
qa: skip chdir for fuse_mount
The use of chdir will muck up the use of nsenter with valgrind:

    2021-03-03T02:13:49.897 DEBUG:teuthology.orchestra.run.smithi144:> sudo nsenter --net=/var/run/netns/ceph-ns--home-ubuntu-cephtest-mnt.0 cd /home/ubuntu/cephtest && sudo adjust-ulimits ceph-coverage /home/ubuntu/cephtest/archive/coverage daemon-helper term env 'OPENSSL_ia32cap=~0x1000000000000000' valgrind --trace-children=no --child-silent-after-fork=yes '--soname-synonyms=somalloc=*tcmalloc*' --num-callers=50 --suppressions=/home/ubuntu/cephtest/valgrind.supp --xml=yes --xml-file=/var/log/ceph/valgrind/client.0.log --time-stamp=yes --vgdb=yes --exit-on-first-error=yes --error-exitcode=42 --tool=memcheck --leak-check=full --show-reachable=yes ceph-fuse -f --admin-socket '/var/run/ceph/$cluster-$name.$pid.asok' --id 0 /home/ubuntu/cephtest/mnt.0
    2021-03-03T02:13:49.899 DEBUG:teuthology.orchestra.run.smithi144:> sudo modprobe fuse
    2021-03-03T02:13:49.914 INFO:teuthology.orchestra.run:Running command with timeout 30
    2021-03-03T02:13:49.914 DEBUG:teuthology.orchestra.run.smithi144:> sudo mount -t fusectl /sys/fs/fuse/connections /sys/fs/fuse/connections
    2021-03-03T02:13:49.919 INFO:tasks.cephfs.fuse_mount.ceph-fuse.0.smithi144.stderr:nsenter: failed to execute cd: No such file or directory

It's not necessary to chdir at all to do the mount, so don't.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2021-03-03 09:30:21 -08:00
Patrick Donnelly
1d85c9d535
qa: ignore all slow request warnings
Generalize the ignorelist for:

    2021-02-27T05:54:27.644 INFO:teuthology.orchestra.run.smithi002.stdout:2021-02-27T05:20:24.513041+0000 mds.d (mds.0) 1 : cluster [WRN] 1 slow requests, 1 included below; oldest blocked for > 183.680676 secs

From: /ceph/teuthology-archive/pdonnell-2021-02-26_23:40:39-fs-wip-pdonnell-testing-20210226.181017-distro-basic-smithi/5917580/teuthology.log

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2021-03-03 09:30:21 -08:00
Patrick Donnelly
dcac1dbe62
qa: add new mds beacon grace mon config
Otherwise the mons don't observe it.

Fixes: https://tracker.ceph.com/issues/49507
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2021-03-03 09:30:21 -08:00
Patrick Donnelly
911b9a55bb
qa: wait for MDS to join fsmap
When running under valgrind, MDS may be slow to be added to the FSMap
(especially if mons are in valgrind too). The file system creation that
follows will throw unnecessary warnings about insufficient standbys if
no MDS is available.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2021-03-03 09:30:21 -08:00
Patrick Donnelly
3681e3a1a8
qa: move get_valgrind_args to qa
This method is unused in the teuthology repo. The helper method better
belongs here where it is more easily modified.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2021-03-03 09:30:08 -08:00
Casey Bodley
38bb60b1e0
Merge pull request #39382 from gauravsitlani/master
rgw: added missing documentation on "pubsub" in rgw_enable_apis

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2021-03-03 12:13:16 -05:00
Nathan Cutler
4d47f8a928
Merge pull request #39762 from smithfarm/wip-support-leap-15.3
rpm/luarocks: simplify conditional and support Leap 15.3

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Reviewed-by: Kyr Shatskyy <kyrylo.shatskyy@suse.de>
2021-03-03 18:05:07 +01:00
Michael Fritch
d6323e3e01
cephadm: fixup alrady -> already
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:32 -07:00
Michael Fritch
55788a0bdb
cephadm: Change outer quotes to avoid escaping inner quotes (Q003)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:32 -07:00
Michael Fritch
3b8656d496
cephadm: Remove bad quotes from multiline string (Q001)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:32 -07:00
Michael Fritch
6ca31b99e1
cephadm: Remove bad quotes (Q000)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:32 -07:00
Michael Fritch
49f25f56ae
cephadm: introduce flake8-quotes
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:32 -07:00
Michael Fritch
7ac0479726
cephadm: line break after binary operator (W504)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:32 -07:00
Michael Fritch
06e02b73c7
cephadm: blank line contains whitespace (W293)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:32 -07:00
Michael Fritch
1870056fa5
cephadm: trailing whitespace (W291)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:31 -07:00
Michael Fritch
ec56db113f
cephadm: local variable 'e' is assigned to but never used (F841)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:31 -07:00
Michael Fritch
bb03318414
cephadm: 'select' imported but unused (F401)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:31 -07:00
Michael Fritch
c58701642d
cephadm: ambiguous variable name 'l' (E741)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:31 -07:00
Michael Fritch
8eb4c38f10
cephadm: do not use bare 'except' (E722)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:31 -07:00
Michael Fritch
6237df7527
cephadm: statement ends with a semicolon (E703)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:31 -07:00
Michael Fritch
9bbb35958c
cephadm: module level import not at top of file (E402)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:31 -07:00
Michael Fritch
6c8ea9fb65
cephadm: expected 1 blank line before a nested definition (E306)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:30 -07:00
Michael Fritch
cf9e974284
cephadm: expected 2 blank lines after end of function or class (E305)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:30 -07:00
Michael Fritch
f1af846c60
cephadm: too many blank lines (E303)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:30 -07:00
Michael Fritch
dea7798034
cephadm: expected 2 blank lines, found 1 (E302)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:30 -07:00
Michael Fritch
858b55c3ac
cephadm: expected 1 blank line, found 0 (E301)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:30 -07:00
Michael Fritch
3dcb56e3e3
cephadm: too many leading '#' for block comment (E266)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:30 -07:00
Michael Fritch
20c5f3d186
cephadm: block comment should start with '# ' (E265)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:30 -07:00
Michael Fritch
6d937393f8
cephadm: at least two spaces before inline comment (E261)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:29 -07:00
Michael Fritch
d47b26d792
cephadm: unexpected spaces around keyword / parameter equals (E251)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:29 -07:00
Michael Fritch
d2bb74a896
cephadm: multiple spaces after ',' (E241)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:29 -07:00
Michael Fritch
3e3ace6f31
cephadm: missing whitespace after ':' (E231)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:29 -07:00
Michael Fritch
549258b4c6
cephadm: missing whitespace around arithmetic operator (E226)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:29 -07:00
Michael Fritch
2af78e9358
cephadm: missing whitespace around operator (E225)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:29 -07:00
Michael Fritch
f2f76a2517
cephadm: whitespace before ':' (E203)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:29 -07:00
Michael Fritch
9e4fd38f32
cephadm: whitespace after '{' (E201)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:28 -07:00
Michael Fritch
5ba2b30f78
cephadm: continuation line unaligned for hanging indent (E131)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:28 -07:00
Michael Fritch
4611df9669
cephadm: continuation line under-indented for visual indent (E128)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:28 -07:00
Michael Fritch
460e6e84aa
cephadm: continuation line over-indented for visual indent (E127)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:28 -07:00
Michael Fritch
fa2b17c8ec
cephadm: continuation line over-indented for hanging indent (E126)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:28 -07:00
Michael Fritch
0d57f5496e
cephadm: continuation line with same indent as next logical line (E125)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:28 -07:00
Michael Fritch
91b54fcabc
cephadm: closing bracket does not match visual indentation (E124)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:28 -07:00
Michael Fritch
0b3943a87c
cephadm: ... does not match indentation of opening bracket's line (E123)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:27 -07:00
Michael Fritch
15e4b78abb
cephadm: continuation line missing indentation or outdented (E122)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:27 -07:00
Michael Fritch
75cf5fc676
cephadm: continuation line under-indented for hanging indent (E121)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:27 -07:00
Michael Fritch
8187eb97c7
cephadm: over-indented (E117)
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:27 -07:00
Michael Fritch
78916a499c
cephadm: introduce flake8
Signed-off-by: Michael Fritch <mfritch@suse.com>
2021-03-03 09:33:27 -07:00
Sebastian Wagner
86b25bc0be
Merge pull request #39789 from zdover23/wip-doc-cephadm-convert--bash-shells-2021-Mar-03
doc/cephadm: add prompts to adoption.rst

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-03-03 16:45:00 +01:00
Casey Bodley
fc03ae8f12
Merge pull request #39794 from cbodley/wip-qa-rgw-valgrind-supp-librados-delete
valgrind: suppress operator delete[] for tcmalloc

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2021-03-03 10:38:36 -05:00