Wire up the sighup_handler to reopen logs, like the other daemons.
Fixes: http://tracker.ceph.com/issues/19568
Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>
the "weights" parameter is an escaped serialized json dict, where double
quote is replaced with single quote.
Signed-off-by: Kefu Chai <kchai@redhat.com>
MonClient users should not be calling into MonClient
after calling shutdown(). However, MonClient should
assert out rather than proceeding to try and
follow a maybe-null pointer.
Related to http://tracker.ceph.com/issues/19566
Signed-off-by: John Spray <john.spray@redhat.com>
init-ceph kills all daemons that can be identified by get_name_list() by
default, so no need to list them explicitly. also, without this change,
mgr is not stopped when the test finishes.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Fix for:
[src/rgw/rgw_rest_s3.cc:1224]: (style) Array index 'chunk_offset'
is used before limits check.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Use assert to ensure Message *m is not NULL.
Fix for:
CID 1399578 (#4 of 4): Dereference after null check (FORWARD_NULL)
var_deref_model: Passing null pointer m to submit_message,
which dereferences it.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Fix for:
CID 1399581 (#1 of 1): Data race condition (MISSING_LOCK)
missing_lock: Accessing this->state.atime without holding lock
rgw::RGWFileHandle.mtx. Elsewhere, "_ZN3rgw13RGWFileHandle5StateE.atime"
is accessed with rgw::RGWFileHandle.mtx held 2 out of 3 times
(2 of these accesses strongly imply that it is necessary).
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Fix for:
CID 1395687 (#1 of 1): Resource leak (RESOURCE_LEAK)
CID 1395679 (#1 of 1): Resource leak (RESOURCE_LEAK)
leaked_storage: Variable c going out of scope leaks the storage it
points to.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Addressed issue:
CID 1219611 (#1 of 1): Resource leak (RESOURCE_LEAK)
leaked_storage: Variable saw_name going out of scope leaks
the storage it points to.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
* LogClient: move reset_session() into get_mon_log_message() and add a
"flush" param to the latter. so it can get_mon_log_message()
atomically. otherwise another call changing the log queue could sneak
in between reset_session() and get_mon_log_message().
* MonClient: add a "flush" param to do_send() so we can reset the
LogClient session once we are connected to a monitor.
Fixes: http://tracker.ceph.com/issues/19427
Signed-off-by: Kefu Chai <kchai@redhat.com>
The hot-standby become active as we expected but the mount piont broken strangely
when the active mds is down. The root reason is the new mds use last_cap_renews
decoded from ESesson::replay in find_idle_sessions and wrongly killed the session.
Maybe we should reset session->last_cap_renew to the current time when server send
OPEN to client in reconnect stage.
Fixes: http://tracker.ceph.com/issues/19437
Signed-off-by: Guan yunfei <yunfei.guan@xtaotech.com>
Remove mention of confusing reference to megabytes in opening paragraph of "quota management".
To remove further confusion, mention that setting a size for '--max-size' is in bytes by default.
Signed-off-by: Hans van den Bogert <hansbogert@gmail.com>
Pass specific information for RDMAConnTCP (and later for RDMAConnCM) in
the constructor.
This makes set_accept_fd() redundant.
Issue: 995322
Change-Id: I10b4a626f180858465a378e886a238fe187180d5
Signed-off-by: Amir Vadai <amir@vadai.me>
