Commit Graph

26083 Commits

Author SHA1 Message Date
John Wilkins
46f5f585de doc: Added latency comment.
Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2013-05-16 13:56:06 -07:00
Sage Weil
2df6e37641 Merge pull request #291 from dalgaaf/wip-da-CID-1019548
client/Client.cc: fix/silence "logically dead code" CID-Error

Even money that this satisfies the coverity gods...

Reviewed-by: Sage Weil <sage@inktank.com>
2013-05-16 13:10:50 -07:00
Danny Al-Gaaf
541396faae client/Client.cc: fix/silence "logically dead code" CID-Error
Fix handling of 'safe' and the conditions after calling file_flush().

CID 1019548 (#1 of 1): Logically dead code (DEADCODE)
  dead_error_begin: Execution cannot reach this statement "flock.Unlock();"

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-05-16 19:49:06 +02:00
Sage Weil
707ad738e6 Merge pull request #290 from dalgaaf/wip-da-SCA-cppcheck-v2
Reviewed-by: Sage Weil <sage@inktank.com>
rgw bits Reviewed-by: Yehuda Sadeh <yehuda@inktank.com>
2013-05-16 09:14:19 -07:00
Danny Al-Gaaf
49033b69e1 objclass/class_debug.cc: reduce scope of 'n' in cls_log()
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-05-16 14:20:10 +02:00
Danny Al-Gaaf
297b573d93 tools/ceph-filestore-dump.cc: reduce scope of 'r' in export_files()
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-05-16 14:20:10 +02:00
Danny Al-Gaaf
a634a13d46 test/system/systest_runnable.cc: reduce scope of 'ret' in join()
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-05-16 14:20:10 +02:00
Danny Al-Gaaf
6147df4868 test/system/st_rados_list_objects.cc: reduce scope of 'ret' in run()
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-05-16 14:20:10 +02:00
Danny Al-Gaaf
56f8c36474 test/system/st_rados_create_pool.cc_ reduce scope of 'ret' in run()
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-05-16 14:20:10 +02:00
Danny Al-Gaaf
d226d9c36c test/system/rados_list_parallel.cc: reduce scope of 'ret'
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-05-16 14:20:09 +02:00
Danny Al-Gaaf
8f486f0bd1 test/librbd/test_librbd.cc: reduce scope of several variables
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-05-16 14:20:09 +02:00
Danny Al-Gaaf
95bf066b66 rgw/rgw_tools.cc: reduce scope of 'ret' in rgw_get_obj()
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-05-16 14:20:09 +02:00
Danny Al-Gaaf
492553b3c6 rgw/rgw_common.cc: reduce scope of 'end' in two cases
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-05-16 14:20:09 +02:00
Danny Al-Gaaf
682f1076aa rgw/rgw_bucket.cc: reduce scope of 'max' in rgw_remove_bucket()
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-05-16 14:20:09 +02:00
Danny Al-Gaaf
9d6e086605 rgw/rgw_admin.cc: reduce scope of 'ret'
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-05-16 14:20:09 +02:00
Danny Al-Gaaf
a3eeb9f8d4 rgw/rgw_acl_s3.cc: remove local variable 'ret' from create_from_headers()
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-05-16 14:20:09 +02:00
Danny Al-Gaaf
b9fe22b33c rbd_fuse/rbd-fuse.c: reduce scope of some variables in open_rbd_image()
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-05-16 14:20:09 +02:00
Danny Al-Gaaf
393de3257f osdc/Objecter.cc: reduce scope of skipped_map
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-05-16 14:16:43 +02:00
Danny Al-Gaaf
84ce4e9b4e os/chain_xattr.cc: reduce scope of local variable
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-05-16 14:16:37 +02:00
Danny Al-Gaaf
829fdd4139 src/os/LFNIndex.cc: reduce scope of suffix_len
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-05-16 14:16:33 +02:00
Danny Al-Gaaf
8254072b91 os/HashIndex.cc: reduce scope of a local variable
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-05-16 14:16:24 +02:00
Danny Al-Gaaf
ea7d8a4df8 os/FileStore.cc: reduce scope of a local variable
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-05-16 14:16:21 +02:00
Danny Al-Gaaf
2c60bc1ea6 src/os/FlatIndex.cc: reduce scope of suffix_len
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-05-16 14:16:07 +02:00
Danny Al-Gaaf
442752828a src/os/DBObjectMap.cc: reduce scope of some variables
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-05-16 14:16:03 +02:00
Danny Al-Gaaf
14871d0566 mount/mount.ceph.c: reduce scope of 'skip' in parse_options()
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-05-16 14:15:51 +02:00
Danny Al-Gaaf
eb808cff39 src/mds/flock.cc: reduce scope of old_lock_to_end in two cases
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-05-16 14:15:47 +02:00
Danny Al-Gaaf
ce84a226d3 mds/Locker.cc: reduce scope of forced_change_max
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-05-16 14:15:40 +02:00
Danny Al-Gaaf
e7d47827f0 src/crush/mapper.c: reduce scope of some local variables
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-05-16 14:15:13 +02:00
Danny Al-Gaaf
e0f1084580 auth/Crypto.cc: reduce scope of local variable in_buf
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-05-16 14:11:08 +02:00
Danny Al-Gaaf
aa11c68fdd rgw/rgw_rados.cc: remove not needed code
Fix for cppcheck warning:
[src/rgw/rgw_rados.cc:2390]: (warning) Assignment of function
  parameter has no effect outside the function.

Assignment of if_nomatch_str.c_str() to if_nomatch has no
effect outside the function and the functions isn't used
inside the function after the assignment.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-05-16 14:11:02 +02:00
Danny Al-Gaaf
cd48f57039 rgw/rgw_gc.cc: fix possible NULL pointer dereference
Fix/silence cppcheck warning:
[src/rgw/rgw_gc.cc:185] -> [src/rgw/rgw_gc.cc:181]: (error) Possible
  null pointer dereference: ctx - otherwise it is redundant to check
  it against null.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-05-16 14:10:42 +02:00
Danny Al-Gaaf
403bfa43da osd/OSD.cc: remove unused variable
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-05-16 14:04:18 +02:00
Li Wang
17d8ee9df5 Fix some little/big endian issues
Ceph uses little endian, this patch fixes some endian issues
while Ceph running on big endian machine.

Signed-off-by: Yunchuan Wen <yunchuanwen@ubuntukylin.com>
Signed-off-by: Li Wang <liwang@ubuntukylin.com>
2013-05-15 23:02:13 -07:00
Sage Weil
769a16d667 Makefle: force char to be signed
On an armv7l build, we see errors like

 warning: rgw/rgw_common.cc:626:16: comparison is always false due to limited range of data type [-Wtype-limits]

from code

      char c1 = hex_to_num(*src++);
...
      if (c1 < 0)

Force char to be signed (regardless of any weird architecture's default)
to avoid risk of this leading to misbehavior.

Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Dan Mick <dan.mick@inktank.com>
2013-05-15 23:02:10 -07:00
David Zafman
1d6ed811ad Merge branch 'wip-4783'
Reviewed-by: Sam Just <sam.just@inktank.com>
2013-05-15 17:18:41 -07:00
David Zafman
3759daa9c4 OSD: After repairs finish a new deep-scrub should be avoided
When errors fixed, clear them so pg not inconsistent and no deep-scrub needed
In the rare case of incomplete repair, still do deep-scrub to get new error counts

fixes: #4783

Signed-off-by: David Zafman <david.zafman@inktank.com>
2013-05-15 17:18:01 -07:00
David Zafman
c0378b609e OSD: Repair with 0 fixed doesn't complete properly
Queue DoRecovery() event on any repair

Signed-off-by: David Zafman <david.zafman@inktank.com>
2013-05-15 17:18:01 -07:00
Sage Weil
e34a56f843 doc: fix mkcephfs production use, deprecated note
Signed-off-by: Sage Weil <sage@inktank.com>
2013-05-15 08:46:20 -07:00
Sage Weil
2a441aa28a Merge pull request #279 from ceph/wip-libcephfs-env
Reviewed-by: Greg Farnum <greg@inktank.com>
2013-05-14 17:06:53 -07:00
John Wilkins
8f3fb97256 Added OSD to glossary, removed parenthetical.
Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2013-05-14 17:06:12 -07:00
John Wilkins
f36ec02f93 doc: Updated architecture document.
fixes: #2968

Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2013-05-14 17:05:43 -07:00
David Zafman
624c8cc30f Merge branch 'wip-5049'
Reviewed-by: Sam Just <sam.just@inktank.com>
2013-05-14 16:38:50 -07:00
David Zafman
48e89b5171 OSD: scrub interval checking
Do arithmetic so large intervals don't wrap
Fix log messages to reflect the change and improve output
Add message when skipping scrub due to load

fixes: #5049

Signed-off-by: David Zafman <david.zafman@inktank.com>
2013-05-14 16:28:45 -07:00
David Zafman
1f4e7a5aaf OSD: Don't scrub newly created PGs until min interval
Set initial values for last_scrub_stamp, last_deep_scrub_stamp

fixes: #5050, #5051

Signed-off-by: David Zafman <david.zafman@inktank.com>
2013-05-14 16:28:40 -07:00
Sage Weil
7b93d28757 doc/release-notes: v0.62
Signed-off-by: Sage Weil <sage@inktank.com>
2013-05-14 16:02:20 -07:00
Gary Lowell
2ba167be0e Merge branch 'next' 2013-05-14 15:38:24 -07:00
athanatos
5ff703d60a Merge pull request #283 from dachary/wip-5058
internal documentation proofreading

Reviewed-by: Sam Just <sam.just@inktank.com>
2013-05-14 15:28:45 -07:00
Sage Weil
52b0438c66 doc/rados/configuration: fix [mon] osd min down report* config docs
Fix other osd -> mon section name, and note the old config value name prior
to v0.62.

Fixes: #5044.
Signed-off-by: Sage Weil <sage@inktank.com>
2013-05-14 14:02:27 -07:00
Loic Dachary
2a4425af0e reflect recent changes in the pg deletion logic
No need to wait on DeletingStateRef for flush d3dd99b725
Fix typos

http://tracker.ceph.com/issues/5058 refs #5058

Signed-off-by: Loic Dachary <loic@dachary.org>
2013-05-14 22:46:37 +02:00
Loic Dachary
1c53991e4c fix typos and add hyperlink to peering
s/;/:/
s/up_acting_affected/acting_up_affected/
Add relative link to ../../peering

http://tracker.ceph.com/issues/5058 refs #5058

Signed-off-by: Loic Dachary <loic@dachary.org>
2013-05-14 22:46:37 +02:00