Commit Graph

103894 Commits

Author SHA1 Message Date
Ernesto Puerta
ae6ab3047b
mgr/dashboard: fix LazyUUID4 not serializable
- Patch older versions of cherrypy (<11.1.0) to include `unique_id`
field in Request items.
- Add unit tests to verify Debug mode plugin
- Fix RGW Client test
- Fix Tools test

Fixes: https://tracker.ceph.com/issues/42565
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
2019-10-31 10:22:15 +01:00
Sage Weil
fc60989bf7 mgr/MgrClient: fix open condition
Do not open a mgr daemon session if we are a client using a non-client
key to authenticate.  This is a bit of a corner case, but it can
happen when using the mon. key do bootstrap functions.

This aligns the MgrClient condition with the mgr/DaemonServer.cc
handle_report condition, which rejects non-daemon client connections
based on the connection entity type, not the auth identity.

Fixes: https://tracker.ceph.com/issues/42566
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-30 21:23:45 -05:00
Abhishek Lekshmanan
f62c6e8cba mgr/telemetry: add rgw metadata
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-30 16:56:38 -05:00
Patrick Donnelly
35b0b52153
Merge PR #31231 into master
* refs/pull/31231/head:
	qa: add tests for CephFS admin commands
	mds/MDSRank: report state to mgr as mds id, not rank

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-10-30 12:22:48 -07:00
Sage Weil
57c6e51755 ceph-daemon: no extra newline needed in authorized_keys file
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-30 14:09:36 -05:00
Sage Weil
df40a49eb8 ceph-daemon: use client.admin keyring during bootstrap
It's usually okay to use the mon. key for CLI commands, except we had a
mgr but that prevented you from issuing mgr commands correctly.  We have
the new client.admin key available, so use that instead.

Update tests to not --skip-ssh (now that it doesn't hang).

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-30 14:07:52 -05:00
Sage Weil
d2c66f3879 Merge PR #31264 into master
* refs/pull/31264/head:
	ceph-daemon: deal with lack of TemporaryDirectory on py2
	ceph-daemon: make StringIO usage py2 compatible
	ceph-daemon: make ConfigParser py2 compatible

Reviewed-by: Alfredo Deza <adeza@redhat.com>
2019-10-30 14:04:07 -05:00
Ilya Dryomov
5011cc926c qa/suites/krbd: run unmap subsuite with msgr1 only
pre-single-major.yaml kernel doesn't have any of the monitor client
fixes that came in 4.6.  If the connection is closed, it closes the
session and retries only after 10 seconds.  On top of that, there is
nothing to prevent it from picking the same monitor when reconnecting.
This means that when given both v1 and v2 ports (which look like two
different monitors), it is susceptible to mount_timeout (60 seconds):

  $ sudo rbd map img
  rbd: sysfs write failed
  In some cases useful info is found in syslog - try "dmesg | tail".
  rbd: map failed: (5) Input/output error

  [  822.242313] libceph: mon0 172.21.15.132:3300 socket closed (con state CONNECTING)
  [  832.265494] libceph: mon0 172.21.15.132:3300 socket closed (con state CONNECTING)
  [  842.296175] libceph: mon0 172.21.15.132:3300 socket closed (con state CONNECTING)
  [  852.326924] libceph: mon0 172.21.15.132:3300 socket closed (con state CONNECTING)
  [  862.357611] libceph: mon0 172.21.15.132:3300 socket closed (con state CONNECTING)
  [  872.388373] libceph: mon0 172.21.15.132:3300 socket closed (con state CONNECTING)
  [  882.676136] libceph: mon0 172.21.15.132:3300 socket closed (con state CONNECTING)

Unlike newer kernels that return ETIMEDOUT, it returns EIO.

Newer kernels are much more aggressive about retries and will pick
a different monitor when reconnecting, hence they are always able to
establish the session in time.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2019-10-30 19:51:55 +01:00
Patrick Donnelly
9dc07d8096
qa: add tests for CephFS admin commands
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2019-10-30 11:44:26 -07:00
Sage Weil
9c9bb19d43 ceph-daemon: deal with lack of TemporaryDirectory on py2
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-30 13:29:49 -05:00
Sage Weil
749a0bdb61 ceph-daemon: make StringIO usage py2 compatible
Otherwise,

Traceback (most recent call last):
  File "../src/ceph-daemon", line 1698, in <module>
    r = args.func()
  File "../src/ceph-daemon", line 767, in command_bootstrap
    with StringIO() as f:
AttributeError: StringIO instance has no attribute '__exit__'

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-30 13:29:49 -05:00
Sage Weil
93570a501b ceph-daemon: make ConfigParser py2 compatible
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-30 13:29:49 -05:00
Tiago Melo
a7daa902a6 mgr/dashboard: Remove convertion to seconds
This is no longer need since the values are already in seconds.

Fixes: https://tracker.ceph.com/issues/42567

Signed-off-by: Tiago Melo <tmelo@suse.com>
2019-10-30 15:15:18 -01:00
Patrick Donnelly
25f4a0357c
Merge PR #31195 into master
* refs/pull/31195/head:
	vstart: Fix /dev/tty No such device or address

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-10-30 09:09:06 -07:00
Jason Dillaman
f4d99f796a
Merge pull request #31161 from trociny/wip-42488
rbd-mirror: mirrored clone should be same format 

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2019-10-30 12:07:30 -04:00
Jason Dillaman
5f823f8575
Merge pull request #31149 from wonderpow/master1
cls/rbd: add snapshot_add raise -ESTALE test case

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2019-10-30 12:07:12 -04:00
Jason Dillaman
922385c6c2
Merge pull request #31140 from Gangbiao/add-pybind-test-case
test/pybind: add create_snap rasie ImageExists test case

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2019-10-30 12:06:41 -04:00
Jason Dillaman
b50e6f5894
Merge pull request #30994 from JackSlateur/rbd_merged_du
rbd: add --merge to disk-usage

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2019-10-30 12:06:08 -04:00
Lenz Grimmer
5df7223985
mgr/dashboard: remove space in tox.ini deps (#31246)
mgr/dashboard: remove space in tox.ini deps

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2019-10-30 15:32:15 +00:00
Volker Theile
4385ce4805 vstart: Fix /dev/tty No such device or address
Running on Jenkins slave or as a daemon there will be no writable console.

Fixes: https://tracker.ceph.com/issues/42487

Signed-off-by: Volker Theile <vtheile@suse.com>
2019-10-30 15:52:28 +01:00
Nathan Cutler
49ab75109f backport-resolve-issue: prune duplicate URLs
I have seen PR descriptions with a single backport tracker URL mentioned twice.
When backport-resolve-issue hit one of these, it would say:

Found backport tracker: https://tracker.ceph.com/issues/39272
Found backport tracker: https://tracker.ceph.com/issues/39272
-----------------------------------------------------------------
INFO:root:Tracker https://tracker.ceph.com/issues/39272 links to PR https://github.com/ceph/ceph/pull/29153
INFO:root:Backport Tracker 39272 target version already populated with correct value v12.2.13
INFO:root:Backport Tracker 39272 status is already set to Resolved
-----------------------------------------------------------------
INFO:root:Tracker https://tracker.ceph.com/issues/39272 links to PR https://github.com/ceph/ceph/pull/29153
INFO:root:Backport Tracker 39272 target version already populated with correct value v12.2.13
INFO:root:Backport Tracker 39272 status is already set to Resolved
=================================================================

This commit fixes the issue.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
2019-10-30 14:30:08 +01:00
Lenz Grimmer
f61d002825
mgr/dashboard: Allow removal of single notification (#31048)
mgr/dashboard: Allow removal of single notification

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2019-10-30 12:32:37 +00:00
Lenz Grimmer
fb29d02330
mgr/dashboard: Use checkbox for multi selection (#30495)
mgr/dashboard: Use checkbox for multi selection

Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2019-10-30 11:58:15 +00:00
Alfonso Martínez
da72765d8e mgr/dashboard: edit/clone/copy rbd image after its data is received
Fixes: https://tracker.ceph.com/issues/42561
Signed-off-by: Alfonso Martínez <almartin@redhat.com>
2019-10-30 12:31:13 +01:00
Nathan Cutler
2566d95e31
Merge pull request #31193 from rhcs-dashboard/wip-42507-master
mgr/dashboard: update dashboard CODEOWNERShip

Reviewed-by: Lenz Grimmer <lgrimmer@suse.com>
Reviewed-by: Nathan Cutler <ncutler@suse.com>
2019-10-30 11:54:18 +01:00
Nathan Cutler
942e7385b6 backport-resolve-issue: recognize that Target version is populated
Due to a regression, the script stopped recognizing that a Backport tracker
issue's "Target version" field is populated.

Fixes: af43b3cc3b
Signed-off-by: Nathan Cutler <ncutler@suse.com>
2019-10-30 11:46:24 +01:00
Nathan Cutler
f28fbe6c54
Merge pull request #30988 from smithfarm/wip-bri-multi
backport-resolve-issue: resolve multiple backport issues
2019-10-30 11:31:21 +01:00
Sebastian Wagner
e463177d24 mgr/dashboard: remove space in tox.ini deps
Fixes: https://tracker.ceph.com/issues/42469
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-10-30 11:27:27 +01:00
Nathan Cutler
96cb16d5a6
Merge pull request #31163 from callithea/wip-issue-42489
doc: Small update of SubmittingPatches-backports

Reviewed-by: Nathan Cutler <ncutler@suse.com>
2019-10-30 11:02:30 +01:00
Nathan Cutler
147f386002
Merge pull request #30879 from smithfarm/wip-cbs-check-missing-milestone
ceph-backport.sh: implement --milestones feature and more-careful vetting

Reviewed-by: Jan Fajerski <jfajerski@suse.com>
Reviewed-by: Abhishek Lekshmanan <abhishek@suse.com>
2019-10-30 10:30:01 +01:00
Varsha Rao
45be766389 mds: Reorganize class members in MDSAuthCaps header
Fixes: https://tracker.ceph.com/issues/42311
Signed-off-by: Varsha Rao <varao@redhat.com>
2019-10-30 14:53:00 +05:30
Kefu Chai
32aaa44904 install-deps.sh: use sepia/lab-extra/8
some build dependencies are still missing in PowerTools and EPEL8, so we
built and pushed them to sepia so it can be used before they are ready
in these repos.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-10-30 12:55:52 +08:00
Jos Collin
8138cd5198
qa/tasks: Better handling of thrasher names and __init__ calls
Fixes: https://tracker.ceph.com/issues/42062
Fixes: https://tracker.ceph.com/issues/42478
Signed-off-by: Jos Collin <jcollin@redhat.com>
2019-10-30 10:21:25 +05:30
Kefu Chai
2210425a68
Merge pull request #29930 from IlsooByun/rocksdb_ver
cmake: require RocksDB 5.14 or higher

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-10-30 10:11:01 +08:00
Sage Weil
a1a220d137 mds/MDSRank: report state to mgr as mds id, not rank
Introduced by 625dffe65c, which added
periodic scrub stats reporting.

Fixes: https://tracker.ceph.com/issues/42494
Fixes: https://tracker.ceph.com/issues/41525
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-29 17:34:34 -05:00
Patrick Donnelly
b4f772d4f0
Merge PR #30369 into master
* refs/pull/30369/head:
	doc/cephfs: add doc for cephfs io path

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-10-29 15:32:18 -07:00
Sage Weil
2b7ac440ab mgr/telemetry: include fs size (files, bytes, snaps)
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-29 14:46:53 -05:00
Sage Weil
de5bfb67b4 mds: report r{files,bytes,snaps} via perfcounters
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-29 14:46:53 -05:00
Sage Weil
f4c7366994 mgr/telemetry: mds cache stats
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-29 14:46:53 -05:00
Sage Weil
a42dc0a3d0 mgr/telemetry: add some rbd metadata
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-29 14:46:53 -05:00
Patrick Donnelly
80e6cb7001
Merge PR #31201 into master
* refs/pull/31201/head:
	doc: document rank option for journal reset

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2019-10-29 12:39:06 -07:00
Sage Weil
702175f493 mgr/telemetry: note whether osd cluster_network is in use
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-29 14:25:00 -05:00
Sage Weil
9e6fbaaaa0 mgr/telemetry: add host counts
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-29 14:25:00 -05:00
Sage Weil
87670fdc3c mgr/telemetry: add more pool metadata
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-29 14:24:59 -05:00
Sage Weil
26b427356d mgr/telemetry: remove crush rule name
This is a user-specified string and could contain identifying info.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-29 14:24:22 -05:00
Sage Weil
3c0df4489c Merge PR #31181 into master
* refs/pull/31181/head:
	ceph-daemon: only pass podman -it if need an interactive shell

Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2019-10-29 13:39:40 -05:00
Sage Weil
3453930d43 mgr/telemetry: include min_mon_release and msgr v1 vs v2 addr count
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-29 13:38:44 -05:00
Sage Weil
7f6aad677b mgr/telemetry: add CephFS metadata
Signed-off-by: Sage Weil <sage@redhat.com>
2019-10-29 13:38:44 -05:00
Adam Kupczyk
f3f0989cb6 tools/rados: prevent 'put' operation from recreating object when --offset=0 is given
Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
2019-10-29 17:53:39 +01:00
Alfredo Deza
cfc1f71801
Merge pull request #31159 from alfredodeza/wip-rm42484
ceph-volume tests remove xenial from functional testing

Reviewed-by: Jan Fajerski <jfajerski@suse.com>
2019-10-29 12:05:11 -04:00