Just do what the error messages ask for.
Error from Clang:
```
In file included from /home/jenkins/workspace/ceph-master/src/cls/rbd/cls_rbd.cc:28:
In file included from /home/jenkins/workspace/ceph-master/src/objclass/../include/types.h:21:
In file included from /home/jenkins/workspace/ceph-master/src/include/uuid.h:9:
In file included from /home/jenkins/workspace/ceph-master/src/include/encoding.h:17:
In file included from /usr/include/c++/v1/set:426:
In file included from /usr/include/c++/v1/__tree:16:
/usr/include/c++/v1/memory:2241:41: error: call to implicitly-deleted default constructor of '__compressed_pair_elem<ceph::BitVector<'\x02'>::NoInitAllocator, 1>'
: _Base1(std::forward<_Tp>(__t)), _Base2() {}
^
/usr/include/c++/v1/vector:437:7: note: in instantiation of function template specialization 'std::__1::__compressed_pair<unsigned int *, ceph::BitVector<'\x02'>::NoInitAllocator>::__compressed_pair<nullptr_t, true>' requested here
__end_cap_(nullptr)
^
/usr/include/c++/v1/vector:496:5: note: in instantiation of member function 'std::__1::__vector_base<unsigned int, ceph::BitVector<'\x02'>::NoInitAllocator>::__vector_base' requested here
vector() _NOEXCEPT_(is_nothrow_default_constructible<allocator_type>::value)
^
/home/jenkins/workspace/ceph-master/src/common/bit_vector.hpp:163:3: note: in instantiation of member function 'std::__1::vector<unsigned int, ceph::BitVector<'\x02'>::NoInitAllocator>::vector' requested here
BitVector();
^
/home/jenkins/workspace/ceph-master/src/cls/rbd/cls_rbd.cc:3289:16: note: in instantiation of member function 'ceph::BitVector<'\x02'>::BitVector' requested here
BitVector<2> object_map;
^
/usr/include/c++/v1/memory:2179:39: note: explicitly defaulted function was implicitly deleted here
_LIBCPP_INLINE_VISIBILITY constexpr __compressed_pair_elem() = default;
^
/usr/include/c++/v1/memory:2172:50: note: default constructor of '__compressed_pair_elem<ceph::BitVector<'\x02'>::NoInitAllocator, 1, true>' is implicitly deleted because base class 'ceph::BitVector<'\x02'>::NoInitAllocator' has no default constructor
struct __compressed_pair_elem<_Tp, _Idx, true> : private _Tp {
^
1 error generated.
```
Fixes: http://tracker.ceph.com/issues/39561
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
So that both vi and emacs help to correctly format the source files,
add the directives to each of the source files. In addition, use
`#pragma once` in the header files instead of the macro work-around.
Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
* refs/pull/27875/head:
mgr/DaemonServer: Fix pgp_num throttling min
mgr/DaemonServer: allow pgp_num increases to be fast if pool is empty(ish)
mgr: fix pgp_num vs merge pacer
Reviewed-by: Kefu Chai <kchai@redhat.com>
Redmine issue names have a maximum length of 255 characters. When we prepend,
e.g., "nautilus: " to a very long issue name, we can end up with a string that
is over 255 characters long. Such a string will be refused by Redmine:
ValidationError: Subject is too long (maximum is 255 characters)
This patch avoids such an eventuality by truncating the post-prepend string to
255 characters.
Signed-off-by: Nathan Cutler <ncutler@suse.com>
We currently do not expose perf counters in the restful module but this
is a useful piece of information to be exposed by the restful module.
Since we already have a function to gather all the information about the
perf counters, we can make this easily accessible through the restful
API.
This also supports filtering by daemons through regexps.
Signed-off-by: Boris Ranto <branto@redhat.com>
Every time "show" is triggers now the notification gets queued before
sending it out. The notification service will make sure not to send out
duplicated notifications and to combine notifications that have the same
title. The combination of notification is useful for error messages.
For example if the mgr goes down you will get a view toasties notifying
about a 500 error. With the new implementation you get only one with the
different API paths it couldn't get.
Fixes: https://tracker.ceph.com/issues/39034
Signed-off-by: Stephan Müller <smueller@suse.com>
mgr/dashboard: RBD snapshot name suggestion with local time suffix
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Met the following bug when -DWITH_FIO=ON:
/home/src/test/fio/fio_ceph_messenger.cc:217:5: error: ‘require_authorizer’ was not declared in this scope
require_authorizer = false;
This bug introduce by f10660e84f which omit this.
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
Turn crashes from dict into list, and add a datestamp
(either from the report or from received time) to the
Elasticsearch document ID, remove hostname from crashdumps
Also add test code and requirements.txt for the tests for
ease of virtualenv creation
Signed-off-by: Dan Mick <dan.mick@redhat.com>
This condition should only kick in for pgp_num reductions, or else we'll
end up jump to the end instead of slowing down merges. (For splits, we
don't need to pace like this at all.)
Fixes 76503a1438
Signed-off-by: Sage Weil <sage@redhat.com>
On Linux, write() (and similar system calls) will transfer at most
0x7ffff000 (2,147,479,552) bytes, it will cap data if aio pwritev
more than 0x7ffff000, so we have the split the data to more aio submit.
Signed-off-by: kungf <yang.wang@easystack.cn>
* refs/pull/27804/head:
common, osd: remove erroneous 'section' in dump functions
dencoder: include some missed types
common: make utime_t dencoder-compatible
common: make uuid_d dencoder-compatible
osd: make watch_item_t dencoder-compatible
Reviewed-by: Sage Weil <sage@redhat.com>
The new suffix is still a time that follows the ISO standard as it can
be converted into any other time zone through the time zone prefix of
itself.
Fixes: https://tracker.ceph.com/issues/23858
Signed-off-by: Stephan Müller <smueller@suse.com>
Now it's possible to decrease the pg's of an existing pool. The decrease
will take place over time like the increase. As for both no notification
will be created when this is done (issue #39482).
Fixes: https://tracker.ceph.com/issues/35917
Signed-off-by: Stephan Müller <smueller@suse.com>
strictly speaking, time_t is an opaque time, and in this context, we
need a uint32_t, so it is not necessary and wrong. let's remove it.
Signed-off-by: Kefu Chai <kchai@redhat.com>
