Commit Graph

130324 Commits

Author SHA1 Message Date
Chunmei Liu
e0d18b7964 crimson: keep string alive during string_view lifetime
Signed-off-by: Chunmei Liu <chunmei.liu@intel.com>
2022-03-22 22:21:24 -07:00
Chunmei Liu
07756ec06e crimson:return read error code in MOSDOpReply
Signed-off-by: Chunmei Liu <chunmei.liu@intel.com>
2022-03-22 21:52:29 -07:00
wangxinyu
d75121c14b tools/cephfs-shell: fix typos in comments
fix typos in comments

Signed-off-by: wangxinyu <wangxinyu@inspur.com>
2022-03-23 10:15:15 +08:00
Josh Durgin
fe41f0bf7d
Merge pull request #45512 from zdover23/wip-doc-2022-03-18-master-to-main
ceph/admin: s/master/main

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2022-03-22 16:38:40 -07:00
Adam King
1568875a28 cephadm: verify config file exists when inferring it
Fixes: https://tracker.ceph.com/issues/54571

Signed-off-by: Adam King <adking@redhat.com>
2022-03-22 19:29:18 -04:00
Adam King
d97057f8d7 cephadm: respect --skip-firewalld flag
Fixes: https://tracker.ceph.com/issues/54137

Signed-off-by: Adam King <adking@redhat.com>
2022-03-22 19:09:26 -04:00
Adam King
9febc21c14 mgr/cephadm: Reschedule nfs daemons from offline hosts
In order to improve nfs availability, if there are other
hosts we can place an nfs daemon on or if there is a host
with a lower rank nfs daemon when a higher rank one is on
an offline host, we should reschedule the nfs daemons

Signed-off-by: Adam King <adking@redhat.com>
2022-03-22 18:57:21 -04:00
Adam King
73f8d0fdcd
Merge pull request #45286 from adk3798/ssh-offline
mgr/cephadm: add keep-alive requests to ssh connections

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2022-03-22 18:00:22 -04:00
Adam King
5301c3737c
Merge pull request #45333 from s0nea/config-fqdn
mgr/cephadm: try to get FQDN for configuration files

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Patrick Seidensal <pseidensal@suse.com>
Reviewed-by: Paul Cuzner <pcuzner@redhat.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2022-03-22 17:58:28 -04:00
Casey Bodley
bfe9bd3aac rgw: data sync uses yield_spawn_window()
restore concurrency to RGWDataSyncShardCR by replacing
drain_all_but_stack_cb() with yield_spawn_window()

Fixes: https://tracker.ceph.com/issues/55000

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2022-03-22 17:11:32 -04:00
Ilya Dryomov
f0ade57458 qa/suites/orch/cephadm: restrict test_iscsi_pids_limit to CentOS
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-03-22 21:42:41 +01:00
Teoman ONAY
de8b3c2676 cephadm: remove containers pids-limit
The default pids-limit (docker 4096/podman 2048) prevent some
customization from working (http threads on RGW) or limits the number
of luns per iscsi target.

Fixes: https://tracker.ceph.com/issues/52898
Signed-off-by: Teoman ONAY <tonay@redhat.com>
2022-03-22 21:41:26 +01:00
Ernesto Puerta
31699a99cf
Merge pull request #45269 from kalaspuffar/table_fix
mgr/dashboard: Table columns hiding fix

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: kalaspuffar <NOT@FOUND>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: sunilangadi2 <NOT@FOUND>
2022-03-22 19:35:43 +01:00
Ernesto Puerta
c90c92a776
Merge pull request #45510 from ceph/fix-github_workflow-master
.github: continue on error

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2022-03-22 18:35:50 +01:00
Kefu Chai
ebb577e778 compressor: s/boost::optional/std::optional/
prefer facilities provided by standard library over the ones in
3rd party libraries.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
2022-03-23 00:27:40 +08:00
Daniel Gryniewicz
115c8b2398
Merge pull request #44616 from dang/wip-dang-zipper-objctx
RGW - Zipper - remove RGWObjectCtx from SAL API

Reviewed-by: Soumya Koduri <skoduri@redhat.com>
2022-03-22 12:17:24 -04:00
Adam C. Emerson
854c919c15 test: Remove unused variable
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2022-03-22 23:27:52 +08:00
Adam C. Emerson
b91d80073d test: Pragma to silence infinite recursion warning for GCC
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2022-03-22 23:27:52 +08:00
Adam C. Emerson
2bb838093c test: Initialize possibly uninitialized buffer
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2022-03-22 23:27:47 +08:00
Ernesto Puerta
dc2384b23d
Merge pull request #45533 from rhcs-dashboard/update-grafana-version
mgr/dashboard/monitoring: update grafana version

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>
2022-03-22 16:27:25 +01:00
Casey Bodley
bbb1574eab mgr: use constexpr string_view as input to format()
resolves a c++20 compilation error with clang13:

ceph/src/mgr/Mgr.cc:602:42: error: call to consteval function 'fmt::basic_format_string<char, const std::basic_string<char> &>::basic_format_string<const char *, 0>' is not a constant expression
    monc->start_mon_command({fmt::format(cmd, name)}, {},
                                         ^
ceph/src/fmt/include/fmt/core.h:2839:56: note: read of non-constexpr variable 'cmd' is not allowed in a constant expression
  FMT_CONSTEVAL basic_format_string(const S& s) : str_(s) {
                                                       ^
ceph/src/mgr/Mgr.cc:602:42: note: in call to 'basic_format_string(cmd)'
    monc->start_mon_command({fmt::format(cmd, name)}, {},
                                         ^
ceph/src/mgr/Mgr.cc:601:17: note: declared here
    const char* cmd = R"({{"prefix": "mon metadata", "id": "{}"}})";
                ^

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2022-03-22 23:26:54 +08:00
Adam C. Emerson
fff72cd14c mon: Replace deprecated use of format_to
The non-deprecated version takes an explicit OutputIterator.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2022-03-22 23:26:54 +08:00
Adam C. Emerson
da789f40cb mon: Fix ranged-construct warning
In the case of an uint32_t there's no benefit to a reference so just
remove the const and make the copy.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2022-03-22 23:26:54 +08:00
Adam C. Emerson
0e1dc03fc5 mon: Replace deprecated spirit/include/phoneix.hpp with phoenix.hpp
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2022-03-22 23:26:54 +08:00
Redouane Kachach
b26c114c84
mgr/cephadm: checking service name before removal
Fixes: https://tracker.ceph.com/issues/54503

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2022-03-22 15:11:05 +01:00
Adam King
9671f179be
Merge pull request #45420 from mgfritch/cephadm-infer-image-pull
cephadm: infer the default container image during pull

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
2022-03-22 08:51:57 -04:00
Daniel Gryniewicz
db6104af8d
Merge pull request #45506 from dang/wip-dang-53614
RGW - Make admin bucket chown accept marker

reviewed-by: Casey Bodley <cbodley@redhat.com>
2022-03-22 08:36:20 -04:00
Nizamudeen A
4a34762330 mgr/dashboard: fix 01-hosts.e2e test error
Its a regression introduced by BDD testing
79f8545deb

Fixes: https://tracker.ceph.com/issues/54990
Signed-off-by: Nizamudeen A <nia@redhat.com>
2022-03-22 17:41:11 +05:30
Ernesto Puerta
c3127f3a13
Merge pull request #45360 from rhcs-dashboard/fix-54481-master
mgr/dashboard: fix wrong pg status processing

Reviewed-by: Sarthak0702 <NOT@FOUND>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: sunilangadi2 <NOT@FOUND>
2022-03-22 13:07:58 +01:00
Adam King
37019aad80 qa/suites/fs: stop looping in mds upgrade test if upgrade failed
Signed-off-by: Adam King <adking@redhat.com>
2022-03-22 08:05:31 -04:00
wangxinyu
1c326651d0 doc/mgr/prometheus.rst: fix spelling error
fix spelling error

Signed-off-by: wangxinyu <wangxinyu@inspur.com>
2022-03-22 18:51:57 +08:00
Ilya Dryomov
acf835db03
Merge pull request #45353 from PepperJo/readv_writev_overflow_v2
librbd: readv/writev fix iovecs length computation overflow

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2022-03-22 11:13:46 +01:00
Ilya Dryomov
7a6ddd5d1e
Merge pull request #45285 from chrisphoffman/wip-rbd-du-validate
test/librbd: add test to verify diff_iterate size

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2022-03-22 11:11:53 +01:00
Yuri Weinstein
622f197448
Merge pull request #45221 from rzarzynski/wip-core-drop-unused-aiocompletion-in-librados
core, test: fix compile-time warnings

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2022-03-21 14:12:39 -07:00
Samuel Just
155e739cae
Merge pull request #45415 from Matan-B/wip-matanb-watch-r-buffer
crimson/osd: fix osd crash due to buffer reference binding

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
2022-03-21 11:31:42 -07:00
Yuval Lifshitz
a3aae855a8 multisite/test: running the multisite test script with custom devices
following environment variables should be set to allow that:

DEV_LIST: comma separated list of devices that should be used by each
clusteri as bluestore block devices.
for example in: DEV_LIST=/dev/nvme7n1,/dev/nvme6n1
the device /dev/nvme7n1 to be used by cluster "c1, while /dev/nvme6n1
will be used by cluster "c2".

DB_DEV_LIST: similar mechanism for DB
WAL_DEV_LIST: similar mechanism for WAL

note that if any of these variables is missing, or has less values than
clusters, the default device would be used.

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2022-03-21 18:08:53 +02:00
Casey Bodley
217c328513
Merge pull request #45050 from hualongfeng/qatchange
common/compressor: fix the issue that cannot processed concurrently

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-03-21 09:40:55 -04:00
Venky Shankar
88ddf3350e
Merge pull request #44491 from nmshelke/fix-46075
ceph-fuse: ignore fuse mount failure if path is already mounted

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2022-03-21 18:39:35 +05:30
Gabriel BenHanokh
2969539d20 Fix a problem in store_test::BluestoreBrokenNoSharedBlobRepairTest where the check for active null-fm was wrong and so reporting bogus errors when null-fm was inactive
The check need to access dynamic value and not config setting (which can be overridden)
Signed-off-by: Gabriel BenHanokh <gbenhano@redhat.com>
2022-03-21 14:18:05 +02:00
Aashish Sharma
c306778889 mgr/dashboard/monitoring: update grafana version
Fixes: https://tracker.ceph.com/issues/54311

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2022-03-21 17:40:03 +05:30
Venky Shankar
1bc4cc5d44
Merge pull request #45406 from wxypro/fix-typos
docs,options: fix typos 

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2022-03-21 15:29:19 +05:30
Ilya Dryomov
df0506fd3d
Merge pull request #45525 from idryomov/wip-rbd-trash-purge-schedule-relax-assert
qa/workunits/rbd/cli_generic.sh: relax trash purge schedule status assert

Reviewed-by: Mykola Golub <mgolub@suse.com>
2022-03-21 10:22:53 +01:00
Liu-Chunmei
00b9fb6263
Merge pull request #45517 from liu-chunmei/crimson-fix-cmpxattr
crimson: let read operation return result in MOSDOpReply

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2022-03-20 22:40:28 -07:00
Adam King
f036bdaf5a python-common/drive_group: add extra_container_args to supported features
Should have been added when extending extra container args
to all the services but was missed

Signed-off-by: Adam King <adking@redhat.com>
2022-03-20 21:44:28 -04:00
Feng Hualong
aba2ac13fc common/compressor: fix the issue that cannot processed concurrently
Now, one session cannot support concurrent and it will lead to crash.
So there are mutil session using. At same time, it also can improve
the performance.

Fixes: https://tracker.ceph.com/issues/54361

Signed-off-by: Feng Hualong <hualong.feng@intel.com>
2022-03-21 09:22:57 +08:00
Ilya Dryomov
90a90ad47d qa/workunits/rbd/cli_generic.sh: relax trash purge schedule status assert
Commit 08df6e0fd0 ("qa/workunits/rbd: expand LevelSpec parsing
coverage") didn't account for images with a separate data pool.  This
was missed because of small-cache-pool.yaml breakage.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-03-19 14:54:00 +01:00
Chunmei Liu
3b5e838691 crimson: let read operation return result in MOSDOpReply
otherwise cmp_xattr will failed,
only check if return result for write operation.

Signed-off-by: Chunmei Liu <chunmei.liu@intel.com>
2022-03-18 19:58:43 -07:00
Liu-Chunmei
a43b68294c
Merge pull request #45518 from liu-chunmei/crimson-fix-read-length
crimson: set returned read length in op.extent.length not in rval

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2022-03-18 19:55:31 -07:00
Kefu Chai
ad0742365d
Merge pull request #45520 from rzarzynski/wip-crimson-rvalue-in-future-set_callback
crimson/common, seastar: bump up to a newer version. Fix a FTBFS

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2022-03-19 09:46:51 +08:00
Ernesto Puerta
7cad69fd93
Merge pull request #44835 from rhcs-dashboard/cypress-cucumber
mgr/dashboard: BDD approach for the dashboard cephadm e2e

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2022-03-18 18:12:16 +01:00