* refs/pull/32616/head:
cephadm: annotate call()
cephadm: podman inspect: image field was called `ImageID`:
Reviewed-by: Patrick Seidensal <pseidensal@suse.com>
Reviewed-by: Sage Weil <sage@redhat.com>
* refs/pull/32795/head:
cephadm: require fsid if name contains a daemon id
cephadm: infer the fsid by name
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Sage Weil <sage@redhat.com>
* refs/pull/32787/head:
qa/tasks/cephadm: work around .git suffix on ceph_repo
qa/tasks/cephadm: learn to pull cephadm from github
Reviewed-by: Jan Fajerski <jfajerski@suse.com>
$ cephadm shell --name mon.123
INFO:cephadm:Found fsids []
Traceback (most recent call last):
File "./cephadm", line 2805, in <module>
r = args.func()
File "./cephadm", line 646, in _infer_fsid
return func()
File "./cephadm", line 1992, in command_shell
no_config=True if args.config else False)
File "./cephadm", line 1009, in get_container_mounts
data_dir = get_data_dir(fsid, daemon_type, daemon_id)
File "./cephadm", line 670, in get_data_dir
return os.path.join(args.data_dir, fsid, '%s.%s' % (t, n))
File "/usr/lib64/python3.7/posixpath.py", line 94, in join
genericpath._check_arg_types('join', a, *p)
File "/usr/lib64/python3.7/genericpath.py", line 149, in _check_arg_types
(funcname, s.__class__.__name__)) from None
TypeError: join() argument must be str or bytes, not 'NoneType'
Signed-off-by: Michael Fritch <mfritch@suse.com>
* refs/pull/32794/head:
cephadm: normalize image_id in 'pull' output too
cephadm: fix image_id normalization
cephadm: pull: remove newline from ceph_version
mgr/cephadm: base upgrade check on return code, not stderr
mgr/cephadm: fix ok-to-stop
mgr/cephadm: some upgrade debug output
mgr/cephadm: remove dup check
mgr/cephadm: only need_upgrade_self if image_id doesn't match
mgr/cephadm: safe to restart mgr and other non-mon/osd/mds daemons
Reviewed-by: Michael Fritch <mfritch@suse.com>
this change is made to adapt
89e801b373
* always use the helpers from `futurize` instead of using
`::seastar::make_exception_future()` directly. as
`make_exception_future(future_state_base&& state)` is located in
`seastar::internal` namespace
* add `noexcept` specifier in both constructors. to match with the
helpers of `make_exception_future2()` which dispatch the call to
different constructor variants.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Can't call back() on an empty string. Causes unittest_rgw_kms
to fail when compiled with _GLIBCXX_ASSERTIONS.
Signed-off-by: Samuel Just <sjust@redhat.com>
This was relatively harmless as the pointer won't actually be
dereferenced, but it runs afoul of std::vector's bounds checks with
_GLIBCXX_ASSERTIONS enabled.
Signed-off-by: Samuel Just <sjust@redhat.com>
We already enable this by default in our rpm builds. Adding it here as
well increases the odds we'll catch things with make check and local
testing.
Signed-off-by: Samuel Just <sjust@redhat.com>
The dnsmasq package on centos 8.0 is broken, see
https://tracker.ceph.com/issues/43744
For now, run this test on ubuntu.
Signed-off-by: Sage Weil <sage@redhat.com>
