Commit Graph

51922 Commits

Author SHA1 Message Date
Samuel Just
3b54d5df28 test/rados/misc.cc: add long locator key and namespace tests
Signed-off-by: Samuel Just <sjust@redhat.com>
2016-04-08 15:39:13 -07:00
Samuel Just
cb03d4d3c2 LFNIndex: use chain_getxattr_buf
LFN attrs can be longer than these hard coded limits, let's just do
buffer doubling everywhere.

Signed-off-by: Samuel Just <sjust@redhat.com>
2016-04-08 15:39:13 -07:00
Samuel Just
c7db303028 chain_xattr: add chain_getxattr_buf
Otherwise callers need to implement buffer doubling in a lot of cases,
which is error prone.

Signed-off-by: Samuel Just <sjust@redhat.com>
2016-04-08 15:39:13 -07:00
Samuel Just
755c685f2d LFNIndex::lfn_parse_object_name: return int rather than bool
All current callers (except list_objects) already expect
ret < 0 for error.  Adjust list_objects to skip on EINVAL
instead of 0.

Signed-off-by: Samuel Just <sjust@redhat.com>
2016-04-08 15:38:17 -07:00
Samuel Just
e4916f68dd LFNIndex::list_objects: lfn_translate does not set errno
Signed-off-by: Samuel Just <sjust@redhat.com>
2016-04-08 14:57:16 -07:00
Samuel Just
25f937e364 FileStore::set_xattr_limits_via_conf: add warning if max xattr size smaller than max name
Signed-off-by: Samuel Just <sjust@redhat.com>
2016-04-08 14:57:16 -07:00
Samuel Just
18b9f95a4a test/objectstore/chain_xattr.cc: add test for ensure_single_attr
Signed-off-by: Samuel Just <sjust@redhat.com>
2016-04-08 14:57:13 -07:00
Samuel Just
73778f1eb9 LFNIndex: ensure that lfn and directory attrs are written atomically
We leave skip_chain_cleanup = false since the object may have been
written using code that split the lfn attr over multiple attrs.

Signed-off-by: Samuel Just <sjust@redhat.com>
2016-04-08 14:16:04 -07:00
Samuel Just
ac750cebc2 chain_[f]getxattr: always use size, no reaon to consider CHAIN_XATTR_MAX_BLOCK_LEN
Users of setxattr can now set attrs larger than that size.

Signed-off-by: Samuel Just <sjust@redhat.com>
2016-04-08 14:16:04 -07:00
Samuel Just
8dc033078f chain_xattr: s/onechunk/skip_chain_cleanup, add ensure_single_attr
onechunk was a deceptive name since it didn't actually ensure that
a single chunk would be used.  Rename to ensure_single_attr.  Also,
add a parameter to ensure that we use a single attribute.  We need
these to be distinct since we have LFN attrs which have been split
over 254 byte xattrs since after hammer which we need to correctly
clean up.  However, we need to ensure going forward that those attrs
are never split over more than one chunk -- it's not atomic.
Further, skip_chain_cleanup should imply ensure_single_attr, so make
them template params and add a static check to make sure we don't
mess this up in the future.

Signed-off-by: Samuel Just <sjust@redhat.com>
2016-04-08 14:16:04 -07:00
Samuel Just
21487fd0c2 os/,osd/: restructure the rados name length check
Enforce locator length vs the max name length and also
introduce a namespace length limit.

In addition to these checks, also pass the head object to the
ObjectStore implementation to validate.  This allows LFNIndex to account
for the idiosyncracies of its filename escaping and for different xattr
value max sizes.

Signed-off-by: Samuel Just <sjust@redhat.com>
2016-04-08 14:16:00 -07:00
Sage Weil
0f81ac5d87 Merge pull request #8378 from liewegas/wip-pgls-pgid
osdc/Objecter: use full pgid hash in PGNLS ops

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2016-04-04 16:53:51 -04:00
Samuel Just
72f18a26de Merge pull request #8069 from somnathr/wip-dyn-throttle-doc
Adding documentation on how to use new dynamic throttle scheme

Reviewed-by: Samuel Just <sjust@redhat.com>
2016-04-04 12:54:32 -07:00
Sage Weil
ec8318df70 Merge pull request #8429 from ErwanAliasr1/evelu-broken-cephtool-test-mon
tests: Fixing broken test/cephtool-test-mon.sh test

Reviewed-by: Loic Dachary <ldachary@redhat.com>
2016-04-04 15:48:10 -04:00
Orit Wasserman
9eca65f328 Merge pull request #8411 from theanalyst/rgw/unused-var
rgw_admin: remove unused parent_period arg
Reviewed-by: Orit Wasserman <owasserm@redhat.com>
2016-04-04 20:22:43 +02:00
Josh Durgin
cce88dfdc5 Merge pull request #8426 from dillaman/wip-striper-logs
Striper: reduce assemble_result log level

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2016-04-04 10:01:52 -07:00
Kefu Chai
24b9762355 Merge pull request #8421 from tchaikov/wip-noexcept
os/ObjectStore: add noexcept to ensure move ctor is used

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2016-04-04 23:44:43 +08:00
Erwan Velu
f47e06b907 tests: Fixing broken test/cephtool-test-mon.sh test
Since the merge of pr #7693, 'ceph command' to get the help is invalid.
As a result, 'test/cephtool-test-mon.sh' test was broken

This patch simply change the 'ceph command' by a 'ceph --help command'

Since this change the test is passing again.

Signed-off-by: Erwan Velu <erwan@redhat.com>
2016-04-04 16:58:58 +02:00
Casey Bodley
77ccd20d90 Merge pull request #8422 from ceph/wip-fix-cmake
CMake: For CMake version <= 2.8.11, use LINK_PRIVATE
2016-04-04 10:35:20 -04:00
Casey Bodley
969d62827c Merge pull request #8410 from theanalyst/rgw/help-args
rgw: add a few more help options in admin interface
2016-04-04 10:28:38 -04:00
Sage Weil
77aee99835 Merge pull request #8393 from jcsp/wip-15309-2
qa: update rest test cephfs calls (part 2)

Reviewed-by: Sage Weil <sage@redhat.com>
2016-04-04 09:42:57 -04:00
Sage Weil
5aedc215e7 Merge pull request #8402 from ilc/master
configure: Add -D_LARGEFILE64_SOURCE to Linux build.
2016-04-04 09:32:12 -04:00
Sage Weil
6d5855814b Merge pull request #8420 from dzafman/wip-15347
test: Fix test to run with btrfs which has snap_### dirs

Reviewed-by: Sage Weil <sage@redhat.com>
2016-04-04 08:56:23 -04:00
Sage Weil
79582b04f6 Merge pull request #8423 from wjin/fix
osdmap: rm nonused variable

Reviewed-by: Sage Weil <sage@redhat.com>
2016-04-04 08:55:53 -04:00
Sage Weil
f203d56cd1 qa/workunits/rbd: qemu tests need to wait for image to be createdReviewe
qa/workunits/rbd: qemu tests need to wait for image to be created

Reviewed-by: Sage Weil <sage@redhat.com>
2016-04-04 08:55:14 -04:00
Sage Weil
01a56dc81c Merge pull request #8427 from ghxandsky/master
set 128MB tcmalloc cache size by bytes
2016-04-04 08:54:11 -04:00
Star Guo
9565a50c58 set 128MB tcmalloc cache size by bytes
Signed-off-by: Star Guo <star.guo@mevoco.com>
2016-04-04 13:41:52 +08:00
Sage Weil
548fb8b2d4 Merge pull request #8314 from dx9/wip-unittest-erasure-code-plugin
unittest_erasure_code_plugin: fix deadlock (Alpine)
2016-04-03 18:13:28 -04:00
Sage Weil
dac9ad338d Merge pull request #7693 from aclamk/auto_complete_python
ceph: bash auto complete for CLI based on mon command descriptions

Reviewed-by: Kefu Chai <kchai@redhat.com>
2016-04-03 18:12:03 -04:00
Sage Weil
773d5ec167 Merge pull request #8366 from yangdongsheng/trival
build: fix compiling warnings

Reviewed-by: Kefu Chai <kchai@redhat.com>
2016-04-03 18:11:18 -04:00
Sage Weil
370e4f773a Merge remote-tracking branch 'gh/jewel' 2016-04-03 14:28:23 -04:00
Jason Dillaman
ff9843bb34 Striper: reduce assemble_result log level
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2016-04-03 10:52:10 -04:00
Jason Dillaman
f812199f72 qa/workunits/rbd: qemu tests need to wait for image to be created
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2016-04-03 10:29:38 -04:00
Sage Weil
f7137661a2 ceph_test_rados_api_tier: parse env
Signed-off-by: Sage Weil <sage@redhat.com>
2016-04-03 09:49:07 -04:00
Sage Weil
769c0affc4 ceph_test_rados_api_list: parse env
Signed-off-by: Sage Weil <sage@redhat.com>
2016-04-03 09:45:56 -04:00
Sage Weil
b9b07c13e4 osd/ReplicatedPG: tolerate pgls commands with full hash
Signed-off-by: Sage Weil <sage@redhat.com>
2016-04-03 09:45:56 -04:00
Sage Weil
5c612e82bb osd/ReplicatedPG: discard pgnls op that is outside pg bounds
This should only happen with a buggy client, but we should avoid crashing,
and send a polite error message back.

Signed-off-by: Sage Weil <sage@redhat.com>
2016-04-03 09:45:56 -04:00
Sage Weil
f16187f68d osdc/Objecter: use full hash value for pg[n]ls ops
Normal ops do this so they can behave when racing with split; pgnls ops
are no different.

In particular, this fixes a bug where we have an old OSDMap that doesn't
reflect a split, and the OSD replies with a 'next' value of the PG's new
max.  If we resend the same value to that PG, it'll be out of bounds,
and BlueStore will notice.

Signed-off-by: Sage Weil <sage@redhat.com>
2016-04-03 09:45:56 -04:00
Sage Weil
9196a75459 osd/ReplicatedPG: fix typo
Signed-off-by: Sage Weil <sage@redhat.com>
2016-04-03 09:45:56 -04:00
Sage Weil
bf38318070 Merge pull request #8380 from dillaman/wip-cls-fadvise
cls_rbd: pass WILLNEED fadvise flags during object map update

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
2016-04-03 09:13:31 -04:00
Wei Jin
a92fa830bd osdmap: rm nonused variable
Signed-off-by: Wei Jin <wjin.cn@gmail.com>
2016-04-03 14:20:16 +08:00
Haomai Wang
4eb8f7753c CMake: For CMake version <= 2.8.11, use LINK_PRIVATE
Signed-off-by: Haomai Wang <haomai@xsky.com>
2016-04-03 13:31:07 +08:00
Kefu Chai
c432691a3b os/ObjectStore: add noexcept to ensure move ctor is used
otherwise vector::push_back() will use the copy ctor if it resizes,
to enforce its strong exception guarantee.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2016-04-03 03:37:13 +08:00
Josh Durgin
fdef226cc9 Merge branch 'wip-cycles'
common/Cycles: Do not initialize Cycles globally

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Haomai Wang <haomai@xsky.com>
2016-04-02 12:35:43 -07:00
Richard W.M. Jones
1c2831a2c1 common/Cycles: Do not initialize Cycles globally.
Move initialization to the few tests that actually use it.

Fixes: http://tracker.ceph.com/issues/15225
Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
2016-04-02 12:34:10 -07:00
John Coyle
ec79b64f85 unittest_erasure_code_plugin: fix deadlock caused by locked mutex in cancelled thread
Added unlock when thread is cancelled.

Signed-off-by: John Coyle <dx9err@gmail.com>
2016-04-02 00:10:12 -04:00
Sage Weil
9470969da1 Merge pull request #8193 from liewegas/wip-bluestore
os/bluestore: a few fixes
2016-04-01 17:52:47 -04:00
David Zafman
aedc529b4c test: Fix test to run with btrfs which has snap_### dirs
Fixes: http://tracker.ceph.com/issues/15347

Signed-off-by: David Zafman <dzafman@redhat.com>
2016-04-01 14:35:50 -07:00
Orit Wasserman
f53cb1289a Merge pull request #8404 from cbodley/wip-rgw-realm-pull-fix
radosgw-admin: fix for 'realm pull'
Reviewed-by: Orit Wasserman <owasserm@redhat.com>
2016-04-01 20:22:51 +02:00
Josh Durgin
b71cc17f1c Merge pull request #8417 from dillaman/wip-librbd-mirroring-unsupported
librbd: avoid throwing error if mirroring is unsupported

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2016-04-01 10:54:02 -07:00