Commit Graph

140860 Commits

Author SHA1 Message Date
John Mulligan
de6ccf0be4 cephadm: move extract_uid_gid_monitoring to Monitoring class
Make it a method of the class handling monitoring, such as other classes
already are.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-05 17:05:33 -04:00
John Mulligan
abf39a669f cephadm: convert iscsi type to a ContainerDaemonForm
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-05 17:05:33 -04:00
John Mulligan
1fcacd6b20 cephadm: convert nvmeof type to a ContainerDaemonForm
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-05 17:05:33 -04:00
John Mulligan
04b2f4cddd cephadm: convert tracing type to a ContainerDaemonForm
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-05 17:05:33 -04:00
John Mulligan
aaffe62c0b cephadm: convert haproxy type to a ContainerDaemonForm
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-05 17:05:33 -04:00
John Mulligan
1e531f4854 cephadm: convert keepalived type to a ContainerDaemonForm
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-05 17:05:33 -04:00
John Mulligan
14664264e5 cephadm: remove gateways property from Ceph type
The gateways list property of the Ceph type was used in exactly one
place. In order to provide a clearer structure to the classes in
cephadm, remove this property and simply list the daemon types
specifically where they are needed.

In the future, I hope to see these handled in a class/object based
manner but this is still better for now.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-05 17:05:33 -04:00
John Mulligan
89dd3719a0 cephadm: add unit test coverage for deploying ceph-exporter
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-05 17:05:33 -04:00
John Mulligan
04e2ac04b6 cephadm: add unit test coverage for deploying ceph container
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-05 17:05:33 -04:00
John Mulligan
8f82ef32c8 cephadm: add unit test coverage for deploying tracing
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-05 17:05:33 -04:00
John Mulligan
5c49070a05 cephadm: add unit test coverage for deploying monitoring
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-05 17:05:33 -04:00
John Mulligan
785e4a623d cephadm: add unit test coverage for deploying nvmeof
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-05 17:05:33 -04:00
John Mulligan
9aecda0f94 cephadm: add unit test coverage for deploying iscsi
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-05 17:05:33 -04:00
John Mulligan
42991a1dc6 cephadm: add unit test coverage for deploying haproxy
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-05 17:05:33 -04:00
John Mulligan
d365d605bd cephadm: move some common mocks to a function
Reduce frequently repeated mocks in these new deployment test functions.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-05 17:05:33 -04:00
John Mulligan
dd8f59a1e8 cephadm: add unit test coverage for deploying keepalived
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-05 17:05:32 -04:00
Casey Bodley
36622e19c7 rgw: fix http error checks in keystone/barbican/vault clients
when RGWHTTPManager encounters an http error, it uses
rgw_http_error_to_errno() to map that to a negative posix error code.
RGWHTTPClient::process() returns that mapped error code, and exposes the
original http error via get_http_status()

the http client code for keystone, barbican, and vault were returning
early on the errors from process(), so weren't getting to the http error
checks

these clients now check for specific http errors before testing the
result of process()

Fixes: https://tracker.ceph.com/issues/62989

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-10-05 11:59:56 -04:00
Adam King
6c4ed58ab1
Merge pull request #52296 from asm0deuz/bz2153448_ipv6
mgr/cephadm: ceph orch add fails when ipv6 address is surrounded by square brackets.

Reviewed-by: Adam King <adking@redhat.com>
2023-10-05 11:43:53 -04:00
Adam King
ab07057e18
Merge pull request #53621 from phlogistonjohn/jjm-cephadm-dtypes-common
cephadm: introduce Daemon Forms

Reviewed-by: Adam King <adking@redhat.com>
2023-10-05 11:41:47 -04:00
Venky Shankar
3844ff224e Merge PR #53836 into main
* refs/pull/53836/head:
	PendingReleaseNotes: add a note about disallowing delegating inodes
	qa: start testing mds_client_delegate_inos_pct config
	mds: disable delegating inode ranges to clients

Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
2023-10-05 20:58:33 +05:30
Dhairya Parmar
1f78a32a18 doc: remove egg fragment from dev/developer_guide/running-tests-locally
DEPRECATION: git+https://github.com/ceph/teuthology#egg=teuthology
[test] contains an egg fragment with a non-PEP 508 name pip 25.0 will enforce
this behaviour change. A possible replacement is to use the req @ url syntax,
and remove the egg fragment. Discussion can be found at
https://github.com/pypa/pip/issues/11617

Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
2023-10-05 20:17:14 +05:30
Rishabh Dave
84f1280991 src/MDSMonitor: make use of imported namespace symbols
Symbols imported into current namespace should be used directly; there
is no need to mention their parent namespace while using them. IOW, to use
"std::string" after it has been imported, just write "string" instead of
"std::string".

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-10-05 19:56:32 +05:30
Rishabh Dave
7c864711e5 mon/MDSMonitor: remove unused namespace imports
Remove symbols imported into the current namespace since they are not being
used.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-10-05 19:54:30 +05:30
Rishabh Dave
3cbe4e2321 mon/FSCommands: import std::ostream into current namespace
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-10-05 19:54:03 +05:30
Yuval Lifshitz
c217fba493 rgw/lua: install lua packages in temp directory
and switch to it only once installation is done.
this is needed for cases where installation can happen
while RGW is running

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
2023-10-05 17:21:32 +03:00
Yuval Lifshitz
84944ab680 rgw/lua/doc: fix luajson example
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
2023-10-05 17:21:32 +03:00
Rishabh Dave
c3a2e678c9 mon/FSCommands: make use of imported namespace symbols
There's no need to mention the "home" namespace of a symbol while using
it after it has been imported into the current namespace. IOW, no need to
write, for example, "std::string" after it has been imported from its
namespace; instead simply writing "string" will suffice.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-10-05 19:50:11 +05:30
Rishabh Dave
ee940855be mon/FSCommands: remove unused namespace imports
When symbols imported into the current namespace won't be used, don't
import them.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-10-05 19:48:21 +05:30
Rishabh Dave
8545784a98 mon/AuthMonitor: make use of imported namespace symbols
Once a symbol has been imported into the current namespace, no need to
mention the original namespace while using it. IOW, no need to write
"std::string" after it has been imported from the namespace "std" into the
current namespace.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-10-05 19:47:09 +05:30
Rishabh Dave
3126533d26 mon/AuthMonitor: remove unused namespace imports
Don't import items into current namespace when they'll be never used.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-10-05 19:43:39 +05:30
Nizamudeen A
7f32bce6c5
Merge pull request #53700 from cloudbehl/cephfs-snapshot
mgr/dashboard: Fixed cephfs snapshot listing in directories

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2023-10-05 19:40:32 +05:30
Adam King
a44dd1fd70
Merge pull request #53782 from sachinpunadikar/vstart-fix
vstart: exclude default route during cluster setup

Reviewed-by: Adam King <adking@redhat.com>
2023-10-05 08:37:56 -04:00
cloudbehl
a40fd8ca92 mgr/dashboard: Filter active alerts
- List alerts which are not suppressed

fixes: https://tracker.ceph.com/issues/62990

Signed-off-by: cloudbehl <cloudbehl@gmail.com>
2023-10-05 17:33:35 +05:30
zdover23
ce1bf5ae25
Merge pull request #53819 from zdover23/wip-doc-2023-10-04-rados-troubleshooting-index
doc/rados: edit troubleshooting.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-10-05 22:43:02 +11:00
Venky Shankar
689b3d5ae1 PendingReleaseNotes: add a note about disallowing delegating inodes
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2023-10-05 16:54:32 +05:30
Venky Shankar
4c6660842f qa: start testing mds_client_delegate_inos_pct config
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2023-10-05 15:09:15 +05:30
Venky Shankar
8d57584ff8 mds: disable delegating inode ranges to clients
Fixes: http://tracker.ceph.com/issues/63103
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2023-10-05 15:09:15 +05:30
Yuval Lifshitz
5fede37615
Merge pull request #52735 from vedanshbhartia/coverity_minlong
rgw: Add coverity annotation for warning about tautological comparison

reviewed-by: thotz, yuvalif
2023-10-05 10:50:21 +03:00
Ali Masarwa
8cf2e2d089
Merge pull request #53788 from AliMasarweh/wip-alimasa-topic-stats-help
RGW: add the missing help print for command 'topic stats'

Reviewed-by: thotz <thottanjiffin@gmail.com>, Daniel Gryniewicz <dang@redhat.com>
2023-10-05 10:46:37 +03:00
Nizamudeen A
296044d181
Merge pull request #53789 from rhcs-dashboard/rgw-overview-fix
mgr/dashboard: fix rgw inventory card and broken shadows

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
2023-10-05 12:25:11 +05:30
Sachin Punadikar
8b328dd979 vstart: exclude default route during cluster setup
"ip route list" may list default route, and that needs to be excluded
while doing cluster setup
Typical o/p of ip route list:
$ ip route list
default via 10.8.159.254 dev eno1 proto dhcp src 10.8.152.13 metric 100
10.8.152.0/21 dev eno1 proto kernel scope link src 10.8.152.13 metric 100

Signed-off-by: Sachin Punadikar <sachin.punadikar@ibm.com>
2023-10-05 02:22:08 -04:00
Nizamudeen A
54afd7b36e
Merge pull request #52313 from linuxbox2/wip-fix-disable-dashboard
dashboard: regression, make install fails w/dashboard disabled

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2023-10-05 09:12:25 +05:30
John Mulligan
ed1bdff776 cephadm: convert cephadm agent to a daemon form
The cephadm agent is a bit special in that it will not be converted
to a ContainerDaemonForm (it is not containerized) but we still want
to have it registered as a DeamonForm so that the deamon_type can be
passed to create and have it resolve correctly.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
e82baf51be cephadm: convert SNMPGateway to a ContainerDaemonForm
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
be3e552717 cephadm: convert CustomContainer to a ContainerDaemonForm
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
0c702d530e cephadm: convert NFSGanesha to a ContainerDaemonForm
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
3d75f99119 cephadm: add func to deploy any generic ContainerDaemonForm
While there are no ContainerDaemonForms implemented yet, add a function
that uses the ContainerDaemonForm methods to construct a deployment
for the container based daemons.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
81566c3a3f cephadm: add ContainerDaemonForm
Add a supplemental DaemonForm subclass that helps deploy container
based daemons in a standard fashion. Most of these methods are
optional and should have sensible defaults.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
0e58e0a170 cephadm: move DeploymentType to deploy.py
The DeploymentType is used by a number of other classes and functions
and has no dependencies beyond enum and is safe to move.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00
John Mulligan
33f2606935 cephadm: move firewalld related items to firewalld.py
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-10-04 15:17:57 -04:00