1
0
mirror of https://github.com/ceph/ceph synced 2024-12-29 15:03:33 +00:00
Commit Graph

143 Commits

Author SHA1 Message Date
Ernesto Puerta
3a386d52a4
create-backport-trackers: Python >= 3.12 deprecated distutils
See https://docs.python.org/3.10/whatsnew/3.10.html#distutils-deprecated.

Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
2023-10-30 12:42:19 +01:00
Anthony D'Atri
1ca356a916 .github: Clarify checklist details
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2023-10-19 11:30:28 -04:00
Nizamudeen A
3441b89ad4 .github: fix add to dashboard failing
```
Error: Request failed due to following response errors:
 - Could not resolve to a ProjectV2 with the number 2.
```

On further investigation, it looks like it could be a permission issue.
I followed the recommendation in their documentation to fix it: https://github.com/actions/add-to-project#creating-a-pat-and-adding-it-to-your-repository

Signed-off-by: Nizamudeen A <nia@redhat.com>
2023-08-14 23:23:11 +05:30
Nizamudeen A
38ee272419 .github: pr-triage broken link fix
The link I put was broken so replacing it with the correct one:

Fixes: https://github.com/ceph/ceph/pull/52455

Signed-off-by: Nizamudeen A <nia@redhat.com>
2023-08-08 10:34:59 +05:30
Nizamudeen A
a0ccdd411a
Merge pull request from ceph/gh-add-to-project-fix
.github: pr-triage fix

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
2023-08-08 10:09:54 +05:30
Nizamudeen A
a54af94f6a .github: pr-triage fix
Signed-off-by: Nizamudeen A <nia@redhat.com>
2023-08-07 21:17:43 +05:30
Laura Flores
f32988e0c3 .github/workflows: pin the stale bot to the latest version
Signed-off-by: Laura Flores <lflores@redhat.com>
2023-08-01 15:03:30 -05:00
Neha Ojha
573d0ff5d5 .github/milestone.yml: add reef
Signed-off-by: Neha Ojha <nojha@redhat.com>
2023-03-10 22:13:17 +00:00
Ernesto Puerta
c9a7e7158e
.github: update add-to-project action
Signed-off-by: Ernesto Puerta <37327689+epuertat@users.noreply.github.com>
2023-02-27 16:01:33 +01:00
Ilya Dryomov
38898dfeb8 CODEOWNERS: assign qa/workunits/windows to RBD
Assume ownership of qa/workunits/windows.  Despite the generic name,
currently it has just rbd-wnbd tests.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2023-02-26 17:55:13 +01:00
Ernesto Puerta
2d11e4770a
.github/workflows: update failing action
[Example](https://github.com/ceph/ceph/actions/runs/4222995073/jobs/7360873373) of failing run.

Signed-off-by: Ernesto Puerta <37327689+epuertat@users.noreply.github.com>
2023-02-21 20:47:31 +01:00
Casey Bodley
36747b08ff examples: move rgw examples under subdirectory
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-02-13 17:20:26 -05:00
Ilya Dryomov
1aeae0aebd CODEOWNERS: don't override doc-writers by core and rbd for some files
This happens because core and rbd ownership is defined after
doc-writers: a later match takes precedence.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2023-02-13 19:05:03 +01:00
Casey Bodley
78c3839d89 github: add /examples to CODEOWNERS
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-02-12 11:00:59 -05:00
Casey Bodley
41c3975c9f github: add rgw team to CODEOWNERS
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-02-10 13:17:21 -05:00
Laura Flores
960aec07bd .github: automatically add telemetry label to relevant files
Signed-off-by: Laura Flores <ljflores@redhat.com>
2022-12-14 16:20:45 +00:00
Laura Flores
e75eb834e7
.github: add core label to files under src/test/librados
In response to https://tracker.ceph.com/issues/58173, it would have helped to have the PR label librados test files with core, so the PR would have been tagged for rados qa.

Signed-off-by: Laura Flores <lflores@redhat.com>
2022-12-05 15:07:42 -06:00
Laura Flores
2f8b6d6cb6
.github/workflows: update days-before-pr-close
Currently, the stale bot closes PRs 90 days after they are marked stale since it counts "marking a PR stale" as activity. 

We really want the PRs to close after a total of 90 days, or 30 days after they are marked stale. Changing `days-before-prs-close` to 30 will fix this.

Signed-off-by: Laura Flores <lflores@redhat.com>
2022-10-28 13:24:33 -05:00
Ernesto Puerta
d6a2266fbb
.github/pr-triage: update node.js to v16
[Warning](https://github.com/ceph/ceph/actions/runs/3273201887):
```
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
Please update the following actions to use Node.js 16: actions/labeler, iyu/actions-milestone
```

Signed-off-by: Ernesto Puerta <37327689+epuertat@users.noreply.github.com>
2022-10-18 14:50:39 +02:00
Ernesto Puerta
f846400652
.github/pr-triage: switch from old to new project
The old (classic) Dashboard project (https://github.com/ceph/ceph/projects/6) has been migrated to a new-style one (https://github.com/orgs/ceph/projects/2/views/1).

This also requires updating the GH Action that automatically assigned `dashboard`-labeled PRs to the Dashboard project.

Signed-off-by: Ernesto Puerta <37327689+epuertat@users.noreply.github.com>
2022-10-17 17:50:41 +02:00
David Galloway
41fcdd9a5b .github: Give folks 30 seconds to fill out the checklist
Otherwise GitHub sends an annoying e-mail right away when you file a PR that doesn't have the checklist filled out.  It's easier IMO to create the PR, then check the boxes instead of putting Xes in brackets while filling out the PR comment.

Signed-off-by: David Galloway <dgallowa@redhat.com>
2022-08-31 14:21:16 -04:00
Ernesto Puerta
ee1e163b1e
Merge pull request from ceph/wip-backportbot_script-main
.github/workflows: add create-backport action

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: David Galloway <dgallowa@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
2022-08-10 14:40:18 +02:00
Ernesto Puerta
a92bf26f05
.github/workflows: add create-backport action
Currently there's a cron job in a teuthology VM running a script to find all trackers in needs-backports and to create their corresponding backport trackers. This is done through the [Backport Bot](https://tracker.ceph.com/users/12172) Redmine account.

This PR intends to run this cron job task as a periodic Github Action.

Signed-off-by: Ernesto Puerta <37327689+epuertat@users.noreply.github.com>
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
2022-08-10 13:09:52 +02:00
Laura Flores
0f31bf10f8 .github/workflows: increase operations-per-run to 100 in stale bot
The stale bot's `operations-per-run`
(https://github.com/actions/stale#operations-per-run) corresponds to the max
number of API calls it is allowed to make per hour. Currently,
`operations-per-run` is set to 30, which means that the stale bot
can make up to 30 API calls per hour.

With this limit in place, the stale bot is only able to process 400 PRs at a time.
Since there are 900+ PRs in the Ceph repository, we should increase the number of
operations to cover them all. This needs to be done with care though, since GitHub
has a rate limit
(https://docs.github.com/en/rest/overview/resources-in-the-rest-api#rate-limiting)
depending on business plan.

According to GitHub's documentation on GitHub action requests
(https://docs.github.com/en/rest/overview/resources-in-the-rest-api#requests-from-github-actions),
the rate limit is 1,000 requests per hour per repository when using `GITHUB_TOKEN` (which we are).
For enterprise accounts, GitHub Enterprise Cloud's rate limit applies, and the limit is 15,000
requests per hour per repository.

Based on this information, we should be fine to increase the max `operations-per-run`
to 100. This would cover a little over 1000 PRs, which should be enough
to process the 900-some-odd PRs in the Ceph repository.

Signed-off-by: Laura Flores <lflores@redhat.com>
2022-08-05 11:34:20 -05:00
Neha Ojha
7fd52c0669 .github/labeler.yml: add core label to some tools
Signed-off-by: Neha Ojha <nojha@redhat.com>
2022-07-11 19:11:50 +00:00
Laura Flores
49284d6358 .github/workflows: run the stale bot every hour
Currently, the stale bot runs once a day at 1:30 UTC.
This will only process a few PRs per day, which is not
enough to handle the volume of PRs that come into the
Ceph repository. Running the bot once every hour with
a limit of 30 operations will keep within the rate
limit, but it will also process more PRs per day.

Followup to 1a8d201037.

Signed-off-by: Laura Flores <lflores@redhat.com>
2022-07-07 12:19:08 -05:00
Sébastien Han
1a8d201037 .github/workflows: process PRs in ascending order
The Ceph repo has many PRs and we cannot process all the PRs with the
default "operations-per-run" value (30). At the time of writting the bot
processes 408 every day and there are around 938 PRs.
Even the job informs us that not enough PRs might have been processed
and encouraged us to increase "operations-per-run" if possible. However
it might expose us to Github's API rate limit.
So let's operate with the oldest PRs first, this should close a bunch of
PRs already. If not enough we can try to increase "operations-per-run".

Signed-off-by: Sébastien Han <seb@redhat.com>
2022-07-06 17:21:07 +02:00
David Galloway
f8357dd6d0 Revert ".github: Label doc/releases PRs so tibdex/backport@v2 can backport"
This reverts commit 24e3822435.

Signed-off-by: David Galloway <dgallowa@redhat.com>
2022-06-30 17:20:05 -04:00
David Galloway
928d935b74 Revert ".github: Support for automatically creating backport PRs when labeled"
This reverts commit f5f9459fb2.

Signed-off-by: David Galloway <dgallowa@redhat.com>
2022-06-30 17:19:58 -04:00
David Galloway
3e238b83ec Revert ".github: Add labels while PR is open"
This reverts commit 605b457c98.

Signed-off-by: David Galloway <dgallowa@redhat.com>
2022-06-30 17:19:36 -04:00
David Galloway
605b457c98 .github: Add labels while PR is open
I think https://github.com/tibdex/backport will only create backport PRs if our doc/releases PRs are labelled *and then* closed.  This action currently labels after the PR is closed.

Signed-off-by: David Galloway <dgallowa@redhat.com>
2022-06-24 12:27:43 -04:00
David Galloway
f5f9459fb2 .github: Support for automatically creating backport PRs when labeled
e.g., add a 'backport quincy' label to a PR and this workflow will automatically create a backport PR

Signed-off-by: David Galloway <dgallowa@redhat.com>
2022-06-23 15:33:54 -04:00
David Galloway
24e3822435 .github: Label doc/releases PRs so tibdex/backport@v2 can backport
Signed-off-by: David Galloway <dgallowa@redhat.com>
2022-06-23 15:31:48 -04:00
Huber-ming
a892525c71 SubmittingPatches.rst: PRs should target "main"
Signed-off-by: Huber-ming <zhangsm01@inspur.com>
2022-06-13 09:38:40 +08:00
Ernesto Puerta
9bfde20d57
Merge pull request from ceph/fix-codeowners_api-master
codeowners: remove api team

Reviewed-by: Sarthak Gupta <sarthak.dev.0702@gmail.com>
Reviewed-by: nSedrickm <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2022-06-06 17:40:09 +02:00
Ilya Dryomov
00a44f1c6b CODEOWNERS: add RBD team
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2022-06-01 13:37:21 +02:00
Ernesto Puerta
19ed43f114
codeowners: remove api team
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
2022-05-31 15:01:49 +02:00
Neha Ojha
8303c6b911 .github/CODEOWNERS: tag core devs on core PRs
Start with everything that is present under core in .github/labeler.yml.

Signed-off-by: Neha Ojha <nojha@redhat.com>
2022-05-27 20:30:47 +00:00
John Mulligan
4904b02f9f .github: ensure object_format.py is labeled the same as mgr_util.py
Signed-off-by: John Mulligan <jmulligan@redhat.com>
2022-05-13 10:42:00 -04:00
Laura Flores
246c21d7f9 .github: remove "Submitting Patches to Ceph" comment
Ideally, this should not be in comment form so users
can click on the link.

Signed-off-by: Laura Flores <lflores@redhat.com>
2022-04-26 13:17:06 -05:00
Laura Flores
23d6db4a56 .github: add a "Contribution Guidelines" to the pull request template
These guidelines refer contributors to the "Submitting Patches to Ceph" doc
and the "Submitting Patches to Ceph - Backports" doc. Even though there are
already tips for titling/signing commits in the PR template, these tips
are commented out and easy to gloss over once the contributor creates the
PR. These existing tips do not include any pointers about staging backports.

Fixes: https://tracker.ceph.com/issues/55418
Signed-off-by: Laura Flores <lflores@redhat.com>
2022-04-22 23:11:58 +00:00
Ernesto Puerta
d8c0229b90
.github/pr-triage: reorder milestone step
In `master` the milestone step exits and causes remaining tasks not to be run. I previously tried with the `continue-on-error` flag, but it didn't work, so let's try putting that steps at the end.

Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
2022-04-18 18:50:52 +02:00
Laura Flores
ea290a4025
Merge pull request from ljflores/wip-github-actions-stale
.github/workflows: replace probot-stale with equivalent github action
2022-03-23 11:37:38 -05:00
Ernesto Puerta
b6791ee09a
.github: continue on error
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
2022-03-17 20:53:31 +01:00
Kamoltat
7c464a0eeb .github/pull_request_template.md: added test windows command
Added `jenkins test windows` to the

Show available Jenkins Commands section

Signed-off-by: Kamoltat <ksirivad@redhat.com>
2022-03-04 19:01:21 +00:00
Laura Flores
265f727481 .github: update dependabot.yml to keep github action versions up to date
Config based on this recommendation: https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/keeping-your-actions-up-to-date-with-dependabot#example-dependabotyml-file-for-github-actions

Signed-off-by: Laura Flores <lflores@redhat.com>
2022-03-02 20:11:32 +00:00
Laura Flores
97ba9ccf8e .github/workflows: replace probot-stale with equivalent github action
We currently use probot-stale (https://github.com/probot/stale) to mark stale PRs. According to several issues reported for this repository, there is a widespread problem of probot-state not working properly in github projects (i.e. https://github.com/probot/stale/issues/349). Some users recommend using https://github.com/actions/stale instead.

Fixes: https://tracker.ceph.com/issues/54443
Signed-off-by: Laura Flores <lflores@redhat.com>
2022-03-02 20:03:56 +00:00
Ernesto Puerta
662f46dcbe
mgr/dashboard: configure dependabot
https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/configuration-options-for-dependency-updates

Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
2021-12-02 14:17:06 +01:00
Sage Weil
37ed8b6427 .github/pull_request_template: drop teuthology reference
It is not clear what role this has relative to the needs-qa label.

Signed-off-by: Sage Weil <sage@newdream.net>
2021-11-20 08:56:06 -06:00
Sage Weil
c68b9c0d1e .github/pull_request_template: add cleanup option
Signed-off-by: Sage Weil <sage@newdream.net>
2021-11-20 08:56:06 -06:00