Commit Graph

67467 Commits

Author SHA1 Message Date
Brad Hubbard
9c48cad021 test/librados/tier.cc: Fix valgrind errors
Rectify memory leak and invalid reads.

Fixes: http://tracker.ceph.com/issues/18360
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
2016-12-29 13:07:30 +10:00
runsisi
9ede01affd osd/OpRequest: dump both name and addr for the client op
Signed-off-by: runsisi <runsisi@zte.com.cn>
2016-12-29 10:23:31 +08:00
huangjun
891c0992c5 osd/PrimaryLogPG: optimize pick_newest_available
we can get pg_missing_item from is_missing(), no need to find it again.

  Signed-off-by: huangjun <hjwsm1989@gmail.com>
2016-12-29 09:13:46 +08:00
Sage Weil
380dbb4ae5 osdc/Objecter: remove internal oncommit_sync
We can use onfinish for the linger completions.

Signed-off-by: Sage Weil <sage@redhat.com>
2016-12-28 17:08:42 -05:00
Sage Weil
540601c2b7 osdc/Objecter: onack + oncommit -> onfinish etc
And num_unack + num_unsafe -> num_in_flight.
l_osdc_op_ack + l_osdc_op_commit -> l_osdc_op_reply

Signed-off-by: Sage Weil <sage@redhat.com>
2016-12-28 17:08:42 -05:00
Sage Weil
bb7c7735c7 osdc/Objecter: remove onack from remaining mutate methods
Signed-off-by: Sage Weil <sage@redhat.com>
2016-12-28 17:08:42 -05:00
Sage Weil
7ea438cadc osdc/Objecter: drop onack from _modify
Signed-off-by: Sage Weil <sage@redhat.com>
2016-12-28 17:06:03 -05:00
Sage Weil
a023af6e7a osdc/Filer: go to single ack for update methods
Signed-off-by: Sage Weil <sage@redhat.com>
2016-12-28 17:06:03 -05:00
Sage Weil
16d0c85ff4 osdc/Objecter: go to single callback for mutate()
...and prepare_mutate_op().

Signed-off-by: Sage Weil <sage@redhat.com>
2016-12-28 17:04:30 -05:00
Sage Weil
af01db76f6 librados: eliminiate ack vs commit distinction
- paper over the distinction in the public interface
- consolidate internal completions and flags

Signed-off-by: Sage Weil <sage@redhat.com>
2016-12-28 17:01:26 -05:00
Sage Weil
d4c837da5a client: remove special ack vs commit behavior
1) Do not submit a separate ack callback; just the
blocking cond one.

2) Do the sync write completion synchronously--much
simpler now!

Signed-off-by: Sage Weil <sage@redhat.com>
2016-12-28 17:01:26 -05:00
Sage Weil
c2535c1363 mon/OSDMonitor: remove workaround for dumpling-era bug
We will definitely have published (and stored) a new osdmap since then.

Signed-off-by: Sage Weil <sage@redhat.com>
2016-12-28 14:10:08 -05:00
Sage Weil
1611090173 Merge pull request #12703 from kylinstorage/wip-remove-unused-variable
os/bluestore/BlueStore.cc: remove unused variable

Reviewed-by: Igor Fedotov <ifedotov@mirantis.com>
2016-12-28 11:56:55 -06:00
Sage Weil
eff4c1c5f3 Merge pull request #12594 from wjwithagen/wip-wjw-freebsd-rebind-timing
common/config_opts.h: FreeBSD timing changed due to no SO_REUSEADDR

Reviewed-by: Sage Weil <sage@redhat.com>
2016-12-28 11:54:53 -06:00
Li Wang
2590b97b4d os/bluestore/BlueStore.cc: remove unused variable
Signed-off-by: Li Wang <li.wang@kylin-cloud.com>
2016-12-28 15:23:51 +00:00
Willem Jan Withagen
4b9b562465 qa/test_rados_tool.sh: POSIX dd only accepts 'k' as multiplier
FreeBSD does not want KB as 1k multiplier.
see also: http://www.unix.com/man-page/posix/1posix/dd/

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
2016-12-28 12:13:29 +01:00
Haomai Wang
8ca15b1a4e test_userspace_event: fix missing std
Signed-off-by: Haomai Wang <haomai@xsky.com>
2016-12-28 17:56:32 +08:00
Haomai Wang
410002de5a msg/dpdk/TCP: remove unneeded CephContext argument
Signed-off-by: Haomai Wang <haomai@xsky.com>
2016-12-28 17:55:45 +08:00
Yunchuan Wen
9d725523a8 rbd: limit --io-threads to avoid wait forever in do_bench
Signed-off-by: Yunchuan Wen <yunchuan.wen@kylin-cloud.com>
2016-12-28 17:33:31 +08:00
Yunchuan Wen
08fafce9b7 rbd: limit --io-size to avoid divide by zero in do_bench
Signed-off-by: Yunchuan Wen <yunchuan.wen@kylin-cloud.com>
2016-12-28 17:33:22 +08:00
Xinze Chi
59fdcc1990 os/bluestore: _txc_release_alloc when do wal cleaning
Signed-off-by: Xinze Chi <xinze@xsky.com>
2016-12-28 12:08:23 +08:00
Haomai Wang
b486adb692 Merge pull request #12688 from Adirl/clean_line_end
msg/async/rdma: clean line endings

Reviewed-by: Haomai Wang <haomai@xsky.com>
2016-12-28 10:50:15 +08:00
xie xingguo
1d97862f71 os/bluestore: fix OnodeSizeTracking testing
[  FAILED  ] 1 test, listed below:
[  FAILED  ] ObjectStore/StoreTest.OnodeSizeTracking/2, where GetParam() = "bluestore"

 1 FAILED TEST

The above test failure happens as the bluestore mount() process
will try to load all collections and put them into the coll_map,
which will be also tracked as mempool::bluestore_meta_other.
So total_bytes from mempool won't be equal to zero.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2016-12-28 09:56:04 +08:00
Dave Chen
091547d10c common/ceph_context: Show clear message if all features are enabled
It's saying the following dangerous and experimental featuresare enabled
while the value is "*", it's not quite clear what's "*" stands for.

The patch updates the message so that it's more clear when "*" is used
in place.

Signed-off-by: Dave Chen <wei.d.chen@intel.com>
2016-12-28 09:54:17 +08:00
Sage Weil
075325c3a4 Merge pull request #12336 from kylinstorage/wip-cleanup-use-string-ref
osd: cleanup: use string & to avoid unnecessary copy

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2016-12-27 16:38:17 -06:00
Sage Weil
c67a23592d Merge pull request #12569 from liewegas/wip-bluestore-raw-unused
os/bluestore/bluestore_types: drop std::bitset for blob unused

Reviewed-by: Igor Fedotov <ifedotov@mirantis.com>
Reviewed-by: Varada Kari <varada.kari@sandisk.com>
2016-12-27 16:37:15 -06:00
Sage Weil
bb281925f7 Merge pull request #12612 from fangyuxiangGL/master
osd/ReplicatedBackend: do not set omap header if it is empty

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Haomai Wang <haomai@xsky.com>
2016-12-27 16:36:44 -06:00
Sage Weil
56b04966f6 Merge pull request #12668 from hjwsm1989/pg-unfound
osd/PG: add new have_unfound() function in MissingLoc

Reviewed-by: Sage Weil <sage@redhat.com>
2016-12-27 16:36:18 -06:00
Sage Weil
2e1a096a82 Merge pull request #12674 from Liuchang0812/tools-rados-offset-support
tools/rados: add a parameter "--offset" to rados put command

Reviewed-by: Kefu Chai <kchai@redhat.com>
2016-12-27 16:35:50 -06:00
Sage Weil
c467d7fb23 Merge pull request #12675 from Liuchang0812/fix-test-case-in-rados
test: replace hard-code binary names with varibles

Reviewed-by: Kefu Chai <kchai@redhat.com>
2016-12-27 16:35:29 -06:00
Sage Weil
88ae4bb067 mon/OSDMonitor: ceph osd pool get/set crush_rule by name
This means users don't have to manually translate a rule
they just created to a ruleset ID in order to map a pool
to it.

Signed-off-by: Sage Weil <sage@redhat.com>
2016-12-27 11:02:19 -05:00
Sage Weil
88d85ad726 mon/PGMap: remove CATEGORY column from 'df detail'
Signed-off-by: Sage Weil <sage@redhat.com>
2016-12-27 11:02:19 -05:00
Sage Weil
f198ba81cc mon/PGMap: fix alignment of 'cache io' in ceph -s output
Currently it looks like

  client io 3508 B/s wr, 0 op/s rd, 5 op/s wr
  cache io 0 op/s promote

but should be

  client io 3508 B/s wr, 0 op/s rd, 5 op/s wr
   cache io 0 op/s promote

Signed-off-by: Sage Weil <sage@redhat.com>
2016-12-27 11:02:19 -05:00
Sage Weil
52bd5bbb36 mon: 'fs set-default' not 'fs set_default'
The convention is to use - for command names and
_ for variable names.

Signed-off-by: Sage Weil <sage@redhat.com>
2016-12-27 11:02:19 -05:00
Sage Weil
b1811e3d55 Merge pull request #12655 from ceph/wip-fix-fio
test/fio_ceph_objectstore: fix fio plugin build failure caused by rec…

Reviewed-by: Sage Weil <sage@redhat.com>
2016-12-27 09:34:59 -06:00
Sage Weil
3323230d51 Merge pull request #12682 from renhwztetecs/renhw-wip-mon-osdmonitor-sortbitwise
mon/OSDMonitor: fixup sortbitwise flag warning

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2016-12-27 09:30:59 -06:00
Sage Weil
22adda23ec Merge pull request #12654 from yuyuyu101/wip-fix-async-subop
messages/MOSDSubOp: Make encode_payload can be reentrant

Reviewed-by: Sage Weil <sage@redhat.com>
2016-12-27 09:26:00 -06:00
Kefu Chai
f3d453d872 Merge pull request #12662 from Liuchang0812/doc-fix
doc: fix document about rados mon

Reviewed-by: Kefu Chai <kchai@redhat.com>
2016-12-27 21:09:06 +08:00
Kefu Chai
d0a2651a3b Merge pull request #12198 from tchaikov/wip-pybind-freebsd
pybind: conditional compile the linux specific constant

Reviewed-by: Willem Jan Withagen <wjw@digiware.nl>
2016-12-27 20:52:07 +08:00
Nathan Cutler
76b31c1309 doc: clarify "ceph quorum" syntax
The man page did not prepare the user for the fact that "ceph quorum exit" will
cause a random monitor to leave quorum, nor did it say explicitly how to make
the command work on a specific monitor.

Fixes: http://tracker.ceph.com/issues/17802
Signed-off-by: Nathan Cutler <ncutler@suse.com>
2016-12-27 12:11:04 +01:00
huanwen ren
c25ee187e2 mon/OSDMonitor: fixup sortbitwise flag warning
"ceph -s" does not report warning when using
command "ceph osd unset sortbitwise" to drop
sortbitwise flag.
we should use "osdmap.get_up_osd_features() &
CEPH_FEATURE_OSD_BITWISE_HOBJ_SORT"
instead of "(osdmap.get_features(CEPH_ENTITY_TYPE_OSD, NULL) &
CEPH_FEATURE_OSD_BITWISE_HOBJ_SORT)",
because osdmap.get_features only get local "features"

Signed-off-by: huanwen ren <ren.huanwen@zte.com.cn>
2016-12-27 11:07:54 +00:00
Brad Hubbard
766d328ed4 ceph_test_rados_api_misc: Fix trivial memory leak
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
2016-12-27 20:37:27 +10:00
fangyuxiang
c0ddd399ef ReplicatedBackend: do not set omap header if it is empty
In replicatedpg backfill, objects have no omap header or keys previously, but an empty omap header will be inserted when they are pushed to replica, which leads leveldb performance degrade seriously when cluster has huge number of objects.
so my opinion is that we does't insert omap header if is size is zero when handle PushOp in recovery.

Signed-off-by: fang yuxiang <fang.yuxiang@eisoo.com>
2016-12-27 16:53:44 +08:00
liuchang0812
fe3d3821cb tools/rados: add parameter offset for put cmd and test case for it
add a parameter "--offset" for put command
add a test case for rados put command

Signed-off-by: liuchang0812 <liuchang0812@gmail.com>
2016-12-27 16:06:41 +08:00
liuchang0812
52db747f32 doc: fix document about rados mon
Signed-off-by: liuchang0812 <liuchang0812@gmail.com>
2016-12-27 14:59:04 +08:00
Kefu Chai
b5acc288d7 Merge pull request #12663 from badone/wip-ceph_test_rados_api_c_write_operations-valgrind-fixes
c_write_operations.cc: Fix trivial memory leak

Reviewed-by: Kefu Chai <kchai@redhat.com>
2016-12-27 14:44:35 +08:00
liuchang0812
14de3a1ee1 test: replace hard-code binary names with varibles
This test case couldn't run under customize env CEPH_BIN.

Signed-off-by: liuchang0812 <liuchang0812@gmail.com>
2016-12-27 14:18:29 +08:00
Haomai Wang
610a97abf8 Merge pull request #12672 from liupan1111/wip-fix-nvme-driver-compile-issue
bluestore: fixed compilation error when enable spdk

Reviewed-by: Haomai Wang <haomai@xsky.com>
2016-12-27 14:07:07 +08:00
Pan Liu
1ed6a37611 bluestore: fixed compilation error when enable spdk
Signed-off-by: Pan Liu <pan.liu@istuary.com>
2016-12-27 12:42:44 +08:00
Adir Lev
131062f70e msg/async/rdma: clean line endings
Change-Id: I59359ae585b66018fe54d5e841a6506c077c606f
Signed-off-by: Adir Lev <adirl@mellanox.com>
2016-12-27 01:53:49 +02:00