Commit Graph

121327 Commits

Author SHA1 Message Date
Ronen Friedman
437456ecf9 osd: remove a ceph_assert() from a legitimate path
on_replica_init() might be legitimately called twice,
if the replica was waiting for updates to complete
before servicing the request.

Fixes: https://tracker.ceph.com/issues/49867

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2021-03-18 17:13:42 +02:00
Patrick Donnelly
25bc7023f0
Merge PR #40207 into master
* refs/pull/40207/head:
	doc: max_maps -> max_caps

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-03-18 06:46:03 -07:00
Avan Thakkar
9456884c29 mgr/dashboard: Display users current quota usage
Fixes: https://tracker.ceph.com/issues/45965

Signed-off-by: Avan Thakkar <athakkar@redhat.com>
2021-03-18 18:48:37 +05:30
Jos Collin
22baa700f2
mds: fix latency spelling
Signed-off-by: Jos Collin <jcollin@redhat.com>
2021-03-18 18:46:43 +05:30
zdover23
f79a9d438e
Merge pull request #40187 from ideepika/wip-tracing-intial-doc
dev/developer_guide: add jaegertracing intial developer documentation

Reviewed-by: Zac Dover <zac.dover@gmail.com>
2021-03-18 21:45:39 +10:00
Deepika Upadhyay
6fd0165610 doc/dev/developer_guide: add jaegertracing intial developer documentation
Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
2021-03-18 16:59:44 +05:30
Sridhar Seshasayee
88df47230b qa/tasks: Add additional wait_for_clean() check in lost_unfound tasks.
At the end of the lost_unfound tests add an additional wait_for_clean()
check to ensure that recoveries get enough time to complete before
proceeding and avoid failures down the line. For e.g. failure like
"Scrubbing terminated -- not all pgs were active and clean." is because
recoveries on the PGs did not get sufficient time to complete even though
they were bound to eventually complete.

Fixes: https://tracker.ceph.com/issues/49844
Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
2021-03-18 13:03:41 +05:30
Dan van der Ster
8d5608f695 doc: max_maps -> max_caps
Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>
2021-03-18 08:05:49 +01:00
Casey Bodley
29f4bbb5ee qa/rgw: notifications suite runs single job
pin to the beast frontend, default bluestore, replicated pools, and run
against a random distro

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2021-03-18 11:06:40 +05:30
Kefu Chai
01a7ecaba2
Merge pull request #40163 from ktdreyer/resource-agents-noarch
rpm: ceph-resource-agents package is noarch

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-03-18 11:02:22 +08:00
Patrick Donnelly
822789547e
Merge PR #40058 into master
* refs/pull/40058/head:
	doc: mds cap acquisition readdir throttle documentation

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-03-17 19:41:09 -07:00
Patrick Donnelly
14a2501f4b
Merge PR #40193 into master
* refs/pull/40193/head:
	ceph-debug-docker: podman build doesn't accept input via stdin

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-03-17 19:31:43 -07:00
Brad Hubbard
cba65e6ea4
Merge pull request #31514 from simon-rock/simon_work_fou
osd:modify conf, timeout & suicide timeout, of workqueue at runtime to av…

Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
2021-03-18 12:30:26 +10:00
Sage Weil
a2b7587e04 mgr/cephadm: stop conflicting daemon when deploying to a specific port
If we are deploying a daemon to bind to a specific port and there is
an existing daemon we are removing that also binds to that port, stop
it first.  Unless we are both binding to different IPs.

This resolves the case where daemons bind to * and we redeploy with a
subnet to bind to.  It would eventually converge before, but would
throw a bind error in the process and take longer.

Signed-off-by: Sage Weil <sage@newdream.net>
2021-03-17 17:45:41 -04:00
Sage Weil
98fa727cad mgr/cephadm: make DaemonPlacement print nicer
'host(ip:port)' or 'host(*:port)' so we can show it to a user.

Signed-off-by: Sage Weil <sage@newdream.net>
2021-03-17 17:45:41 -04:00
Samuel Just
1af1a7cf69
Merge pull request #39911 from cyx1231st/wip-seastore-onode-tree-fix-cache
crimson/onode-staged-tree: fix tree_cursor_t::Cursor to be aware of extent duplication

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2021-03-17 13:43:32 -07:00
Andrew Schoen
1347243242 ceph-volume: show devices with GPT headers as not available
This patch ensures that if a device has GPT headers it will
not show up in `ceph-volume inventory` as available.

Fixes: https://tracker.ceph.com/issues/48697
Resolves: rhbz#1908065

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
2021-03-17 15:19:08 -05:00
Ali Maredia
91e720d37c rgw: add latency to the request summary of an op
Latency of a request added at the end of request
summary rgw log line. This summary line also contains
information about the request like the op, bucket,
object, http status.

Signed-off-by: Ali Maredia <amaredia@redhat.com>
2021-03-17 16:02:34 -04:00
Sage Weil
f45f6ee4f6 Merge PR #40160 into master
* refs/pull/40160/head:
	qa/suites/rados/cephadm/orchestrator_cli: random-distro$ -> 0-random-distro$
	qa/suites/rados/cephadm/smoke-roleless: distro -> 0-distro
	qa/distros/podman: install kubic once per host, in parallel
	qa/suites/fs/multiclient: use clients: not all: for pexec

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2021-03-17 15:50:50 -04:00
Sage Weil
f8c32b0fcc mgr/cephadm: clean up misc messages
- join list with ' '
- key, not keyring
- -ing, not ': '

Signed-off-by: Sage Weil <sage@newdream.net>
2021-03-17 15:49:47 -04:00
Sage Weil
b828e627d6 mgr/cephadm/configcheck: do not spam info every minute
It doesn't make to spam INF every minute.  Reducing this to DBG means
it'll never be seen.  Just remove it.

Signed-off-by: Sage Weil <sage@newdream.net>
2021-03-17 15:44:08 -04:00
Jason Dillaman
92522c624b
Merge pull request #39915 from CongMinYin/fix-vm-io-hang
librbd/cache/pwl: set max size of continuous data

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Jianpeng Ma <jianpeng.ma@intel.com>
2021-03-17 15:35:58 -04:00
Jason Dillaman
bdc1178bd8 test: ignore failures to force-enable lockdep
PR #40062 tweaked the behavior of lockdep to compile it out
of the code entirely for release builds. This fixes several
gtests where lockdep was force-enabled.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2021-03-17 15:29:37 -04:00
Josh Durgin
c3e7acb3ac common/options: turn off bluestore_fsck_quick_fix_on_mount by default
This option enables 3 conversions:

1) pool stats, added in nautilus
2) per-pool omap, added in octopus
3) per-pg omap (replacing (2)) in pacific

Upgrading the long running cluster in sepia from octopus to pacific
resulted in conversion (3). This conversion isn't particularly useful
yet since the follow-on optimization of pg removal aren't in pacific
yet.

This took 25 minutes for the SSD-based osds with <10GB of omap. That's
a lot of disruption, and some clusters have 10x that much omap data.

Upgrades going from nautilus to pacific will miss the finer-grained
stats granularity, but isn't such an important feature it's worth
causing potential availability problems.

In the future we can orchestrate these format changes via cephadm/rook
to minimize the impact on the whole cluster, e.g. going an osd at a
time or doing it during an off-peak period, and not necessarily at the
same time as an upgrade.

Fixes: https://tracker.ceph.com/issues/45265
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
2021-03-17 15:12:25 -04:00
Ilya Dryomov
8d5b3b0dc2
Merge pull request #40175 from idryomov/wip-krbd-blkroset-5.12
qa: krbd_blkroset.t: update for separate hw and user read-only flags

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2021-03-17 19:44:14 +01:00
Sage Weil
a40c96d793 mgr/cephadm: fix --force remove comment
Signed-off-by: Sage Weil <sage@newdream.net>
2021-03-17 14:42:34 -04:00
Jason Dillaman
625244f999 test/pybind/rbd: fixed functional change in encryption API
The encryption format API now also implicitly loads the encryption
layer. This tweaks the tests to account for this functional
difference.

Fixes: https://tracker.ceph.com/issues/49848
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2021-03-17 14:14:48 -04:00
Jeff Layton
84ae9432a1 ceph-debug-docker: podman build doesn't accept input via stdin
podman on centos 8 at least doesn't accept the Dockerfile being fed to
it via stdin. Change that branch of the script to use the same method
that the ubuntu side does.

This gets the script working on senta03 for me.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
2021-03-17 13:55:35 -04:00
Sebastian Wagner
3fb62b1a4c
Merge pull request #40051 from strenuous-life/wip-cephadm-osd-exact-match-size
mgr/cephadm: When device size contains the decimal, it can not match size exactly

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-03-17 18:22:05 +01:00
Sebastian Wagner
b8bcfd4cc3
Merge pull request #39880 from adk3798/upgrade-status
mgr/cephadm: add info to 'ceph orch upgrade status' in cephadm

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-03-17 18:08:23 +01:00
Jeff Layton
5aec283a1c test: reduce number of threads to 32 in LibCephFS.ShutdownRace
We're still occasionally hitting file descriptor limits when running
this test. Reduce the thread count to 32 for now, since it was possible
to reproduce the original problem with 10 or so threads.

Fixes: https://tracker.ceph.com/issues/49559
Signed-off-by: Jeff Layton <jlayton@redhat.com>
2021-03-17 13:08:08 -04:00
Patrick Donnelly
28b5137da7
Merge PR #40177 into master
* refs/pull/40177/head:
	doc: update Windows MSI link

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2021-03-17 09:00:56 -07:00
Ilya Dryomov
1ddca6b563
Merge pull request #40178 from idryomov/wip-rbd-map-sanity-check-fixup
krbd: check device node accessibility only if we actually mapped

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2021-03-17 16:43:26 +01:00
Casey Bodley
9b58f62c98
Merge pull request #39678 from yehudasa/wip-rgw-aws4-client
rgw: awsv4 client support

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2021-03-17 11:42:08 -04:00
Kefu Chai
5d10b6995c
Merge pull request #36549 from markhpc/wip-bl-dynamic_alen
common/buffer.cc: Implement dynamic alen in refill_append_space

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-03-17 22:43:07 +08:00
Kefu Chai
181dc1a43f
Merge pull request #39757 from aclamk/wip-qa-test-bluestore-reshard
qa: Add bluestore resharding test

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2021-03-17 22:41:34 +08:00
Sage Weil
476422a6e3 qa/suites/rados/cephadm/orchestrator_cli: random-distro$ -> 0-random-distro$
Signed-off-by: Sage Weil <sage@newdream.net>
2021-03-17 10:40:32 -04:00
Kefu Chai
0c4a1bc5e9
Merge pull request #40032 from aclamk/wip-bdev-remove-reap
blk/BlockDevice: Remove reap_ioc logic

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
2021-03-17 22:40:21 +08:00
Sebastian Wagner
59af5fc555
Merge pull request #40118 from jtlayton/wip-49806
doc: fixes for cephadm documentation

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2021-03-17 15:19:33 +01:00
Xiubo Li
e0e5eb4c93 qa/vstart_runner: fix the admin_socket args parsing
Fixes: https://tracker.ceph.com/issues/49621
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2021-03-17 21:54:50 +08:00
Kefu Chai
e7ff5b97be
Merge pull request #40179 from tchaikov/wip-cmake-permissive-for-cxx
cmake: do not pass -fpermissive when compiling C code

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2021-03-17 21:49:12 +08:00
Kefu Chai
4846e97415
Merge pull request #40136 from kshtsk/wip-fix-ninja-leap
ceph.spec.in: use ninja instead of ninja-build for openSUSE

Reviewed-by: Nathan Cutler <ncutler@suse.com>
2021-03-17 21:23:45 +08:00
Jeff Layton
bf69cdc689 doc: fixes for cephadm documentation
Be sure to note that python 3 is a prerequisite. Minimal centos 8
installs don't have it, for instance.

Also, we probably don't want to hardcode an octopus URL into the
suggested curl command. Change it to fill that in with
"|stable-release|", which should always point to the latest released
version name.

Fixes: https://tracker.ceph.com/issues/49806
Signed-off-by: Jeff Layton <jlayton@redhat.com>
2021-03-17 20:58:56 +08:00
Jason Dillaman
94f550a87f
Merge pull request #39290 from lxbsz/service
mgr: enhance the rados service map

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-03-17 08:16:49 -04:00
Kefu Chai
93d22b6795 cmake: do not pass -fpermissive when compiling C code
silences warnings like

[2/768] /usr/bin/x86_64-w64-mingw32-gcc-posix -DBOOST_ASIO_DISABLE_THREAD_KEYWORD_EXTENSION -DHAVE_CONFIG_H -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2 -D_POSIX=1 -D_POSIX_=1 -D_POSIX_C_SOURCE=1
-D_POSIX_THREADS=1 -D_REENTRANT -D_THREAD_SAFE -D_WIN32_WINNT=0x0A00 -D__CEPH__ -D__STDC_FORMAT_MACROS -Isrc/include -I../src -I../src/include/win32 -isystem ../build.deps/mingw/boost/include -isystem
include -isystem ../src/xxHash -isystem ../src/rapidjson/include -isystem ../src/fmt/include -O3 -DNDEBUG   -include winsock_wrapper.h -include win32_errno.h -U_FORTIFY_SOURCE -Wall
-fno-strict-aliasing -fsigned-char -Wtype-limits -Wignored-qualifiers -Wpointer-arith -Werror=format-security -Winit-self -Wno-unknown-pragmas -fpermissive -fdiagnostics-color=auto -std=gnu99 -MD -MT
src/CMakeFiles/common-objs.dir/xxHash/xxhash.c.obj -MF src/CMakeFiles/common-objs.dir/xxHash/xxhash.c.obj.d -o src/CMakeFiles/common-objs.dir/xxHash/xxhash.c.obj   -c ../src/xxHash/xxhash.c
cc1: warning: command line option '-fpermissive' is valid for C++/ObjC++ but not for C

see also
https://gcc.gnu.org/onlinedocs/gcc-4.0.4/gcc/C_002b_002b-Dialect-Options.html

Signed-off-by: Kefu Chai <kchai@redhat.com>
2021-03-17 20:04:47 +08:00
Ilya Dryomov
8330c9fa4e krbd: check device node accessibility only if we actually mapped
Fix a braino that came with commit f6854ac65d ("krbd: make sure the
device node is accessible after the mapping").

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2021-03-17 12:11:25 +01:00
Lucian Petrut
8e4fe67100 doc: update Windows MSI link
Instead of having a direct download link, we'll point to the
download page, which will eventually contain other MSI versions as
well (e.g. Quincy).

While at it, we're simplifying the document a bit, dropping
information that's also included in the manual install guide.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
2021-03-17 10:49:11 +00:00
Ilya Dryomov
485bedd312
Merge pull request #40169 from petrutlucian94/test_fixes
win32*.sh: use the right target when building the tests

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2021-03-17 11:16:24 +01:00
Ilya Dryomov
d72fca26ed qa: krbd_blkroset.t: update for separate hw and user read-only flags
Since kernel 5.12, hardware read-only state and user read-only
policy (BLKROGET/SET ioctls) are tracked separately in the block
layer.  As the purpose of our ->set_read_only() method was exactly
that, it was removed.

As a side effect, BLKROSET no longer returns EROFS on an attempt
to make a read-only mapping read-write with "blockdev --setrw".
The policy gets updated, but the device remains read-only as before
because the hardware (== mapping) state is controlled by the driver.

Fixes: https://tracker.ceph.com/issues/49858
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2021-03-17 11:00:33 +01:00
Lucian Petrut
c2896329ce win32*.sh: use the right target when building the tests
We switched from make to ninja but we're using the wrong target
when building the tests.

"ninja test" tries to actually run the tests. We'll have to use
"ninja tests" when targeting Windows.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
2021-03-17 07:03:19 +00:00