If `store->get_devname()` returns an empty device name, it means it couldn't
determine the device that backs the monitor DB store directory.
This can happen if `ceph-mon` runs with `PrivateDevices=yes` in systemd, or
within a container where the host `/dev` isn't exposed.
This commit makes sure we abort trying to get the device health at that point,
and return an appropriate error.
Signed-off-by: Benoît Knecht <bknecht@protonmail.ch>
build(deps): bump swagger-ui from 4.1.2 to 4.1.3 in /src/pybind/mgr/dashboard/frontend
Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Server::handle_client_request() ignores unknown client operation
by returning -ENOTSUPP, however, Server::perf_gather_op_latency()
aborts on unknown client op, thereby causing -ENOTSUPP to never
reach the client. ceph_abort() seems unnecessary here.
Note, we could have invoked Server::perf_gather_op_latency()
when the return value to client is not -ENOTSUPP, however,
a valid client operation *might* just return -ENOTSUPP in
some cases.
@mchangir ran into this with his getvxattr op changes (PR #42001).
Signed-off-by: Venky Shankar <vshankar@redhat.com>
IO waited state variables including waited_lanes, waited_entries,
waited_buffers are only used to print logs and have no practical
effect.no_space = true is enough to indicate state.
Signed-off-by: Yin Congmin <congmin.yin@intel.com>
The full name of PWL is persistent write log, and the full name of
RWL is replica write log. Change the title to make it consistent
with the name of the feature and better reflect its design.
Signed-off-by: Yin Congmin <congmin.yin@intel.com>
some comments are outdated, some are no longger needed, update them.
remove redundant ";". remove redundant log. remove redundant "".
Signed-off-by: Yin Congmin <congmin.yin@intel.com>
I removed the `02-hosts-inventory.e2e` file because it is a duplicate
test of one of the test in the `01-hosts.e2e` file and fixed the error
from that file.
Also, in the inventory Identify test, we test for an element to be not
visible. According to the latest cypress docs, this should be not.exist
instead of not.visible since the cd-modal will not even be present in
the DOM
Fixes: https://tracker.ceph.com/issues/53499
Signed-off-by: Nizamudeen A <nia@redhat.com>
After create/open pmem device, add pmemobj_close() during error handle.
Merge the same error handle to the end of function.
Signed-off-by: Yin Congmin <congmin.yin@intel.com>
To enable fine-grain logger control for easier bug triage.
See common/subsys.h for the new classifications.
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Ensure async queue_transactions of remove op on cloned
object happens before KV range scan, otherwise assertion
on the number of shared blob may failed.
Signed-off-by: Tongliang Deng <dengtongliang@sensetime.com>
When testing the upgration, for the old version the *_op_timeouts
options' type is TYPE_FLOAT, but when parsing them by strict_strtod
it will failed with error:
strict_strtod: garbage at end of string. got: '15m'
This commit will remove the 'm' suffix by switch the time to 900,
thus the old version still could parse it successfully.
Introduced-by: d060c9a768https://tracker.ceph.com/issues/51705
Signed-off-by: Xiubo Li <xiubli@redhat.com>
The TSO feature of some NICs(mlx5,iavf,sfc,hns3) is abnormal in DPDK-20.11.
The TSO feature is fiexed in DPDK-21.11. Therefore, a configure is added
for compatibility.
Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
Reviewed-by: luo rixin <luorixin@huawei.com>
Reviewed-by: Han Fengzhe <hanfengzhe@hisilicon.com>
Commands are added to obtain the network adapter status and statistics
for debugging network adapter packet loss and mbuf insufficiency issues.
Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
Reviewed-by: luo rixin <luorixin@huawei.com>
Reviewed-by: Han Fengzhe <hanfengzhe@hisilicon.com>
Adds documentation how to change default rbd object size. With the
previous option `--order` it was easy to guess the config name for the
default value, with the current option name `--object-size` thats hard
to guess.
Also extends the documentation for rbd_default_order to include
* how object-size is derived from the configured value
* allowed range of the value
In the first version of this commit I also added min and max for this
parameter (12/25, matching the object size range in `man 8
rbd`/Striping/object-size), but this made some tests fail, since some
seem to set values outside this range (and probably are fine since
included for some time already). To have this a doc-change only, I
removed the range.
Signed-off-by: Mara Sophie Grosch <littlefox@lf-net.org>
* refs/pull/44342/head:
mds: trigger stray reintegration when loading dentry
qa: test that scrub causes reintegration
Reviewed-by: Xiubo Li <xiubli@redhat.com>
this allow changing rgw conf when sratting the test scrip. e.g.
MON=1 OSD=1 MDS=0 MGR=1 ../src/test/rgw/test-rgw-multisite.sh 2
--rgw_max_objs_per_shard=50
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
The CPU affinity of the DPDK thread has been set during DPDK initialization.
Do not modify the DPDK affinity when setting NUMA affinity.
Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
Reviewed-by: luo rixin <luorixin@huawei.com>
Reviewed-by: Han Fengzhe <hanfengzhe@hisilicon.com>
The thread_name of the DPDK thread has been set during DPDK initialization.
Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
Reviewed-by: luo rixin <luorixin@huawei.com>
Reviewed-by: Han Fengzhe <hanfengzhe@hisilicon.com>
