Commit Graph

10496 Commits

Author SHA1 Message Date
Samuel Just
070fa43328 qa/.../crimson-rados/.../thrashers/default.yaml: disable reset_purged_snaps for crimson
Signed-off-by: Samuel Just <sjust@redhat.com>
2023-12-11 04:10:17 +00:00
Samuel Just
41f930ae26 qa/.../crimson-rados/perf/.../fixed-2.yaml: fix ignorelist
It's common during cluster setup for there to be periods with
degraded/recovering PGs.  Ignore those errors.

Signed-off-by: Samuel Just <sjust@redhat.com>
2023-12-11 04:10:17 +00:00
Samuel Just
6397b1cae9 qa/.../crimson-rados/.../thrashers/default.yaml: enable wait-for-scrub
Signed-off-by: Samuel Just <sjust@redhat.com>
2023-12-11 04:10:17 +00:00
Casey Bodley
5df7b44727 qa/rgw/crypt: disable failing kmip testing
kmip tests have been failing all year and are not being maintained:

https://tracker.ceph.com/issues/58751
https://tracker.ceph.com/issues/58523

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-12-08 13:07:41 -05:00
Jos Collin
1c241e49e5
qa: drop mon_host check from test_cephfs_mirror_peer_bootstrap
Fixes: https://tracker.ceph.com/issues/63614
Signed-off-by: Jos Collin <jcollin@redhat.com>
2023-12-08 15:18:24 +05:30
Adam Emerson
8a07fdb2eb qa/rados: Add neorados tests to run
Signed-off-by: Adam Emerson <aemerson@redhat.com>
2023-12-07 16:26:58 -05:00
Ilya Dryomov
2b135a2eb6 qa: make sure "rados cppool" requires --yes-i-really-mean-it for RBD
Safeguards in rados CLI tool isn't really the subject of this test, but
it fits nicely.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2023-12-04 18:55:24 +01:00
Ilya Dryomov
d9147a14c4
Merge pull request #54205 from VallariAg/wip-nvmeof-test
qa: add rbd/nvmeof integration test

Reviewed-by: Zack Cerza <zack@redhat.com>
Reviewed-by: Aviv Caro <Aviv.Caro@ibm.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2023-12-04 18:14:38 +01:00
Radoslaw Zarzynski
7fc77efe2b qa: qa/suites/rados/upgrade/parallel points to reef
```
$ git rm qa/suites/rados/upgrade/parallel
$ ln -s ../../upgrade/reef-x/parallel qa/suites/rados/upgrade/parallel
$ git add qa/suites/rados/upgrade/parallel
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2023-12-04 16:27:51 +01:00
Radosław Zarzyński
def898c5a2 qa: drop filestore-remove-check from upgrade/reef-x
FileStore is removed in Reef.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
2023-12-04 16:27:51 +01:00
Radoslaw Zarzynski
7af05d0944 qa: bring qa/suites/upgrade/reef-x
Bases on quincy-x.

```
$ cp -R qa/suites/upgrade/quincy-x/ qa/suites/upgrade/reef-x
$ git add qa/suites/upgrade/reef-x
$ git mv qa/suites/upgrade/reef-x/filestore-remove-check/1-ceph-install/quincy.yaml qa/suites/upgrade/reef-x/filestore-remove-check/1-ceph-install/reef.yaml
$ find qa/suites/upgrade/reef-x/ -type f -exec sed -i 's/quincy/reef/g' {} +
```

A note from rebase: changes from 05e24270a2efe85bcdceade87b0e91efcfca3001
have been pulled in.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2023-12-04 16:27:51 +01:00
Radosław Zarzyński
b35871b920 qa: bring test_telemetry_reef.sh for squid
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
2023-12-04 16:27:51 +01:00
Radoslaw Zarzynski
6d25c05312 qa: bring test_telemetry_reef_x.sh for squid
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2023-12-04 16:27:51 +01:00
Radoslaw Zarzynski
081177f6a4 qa: stubs and clean up for reef
- remove upgrades from octopus
- stubs for completing upgrade to reef

Still missing the quincy-x upgrade tests.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2023-12-04 16:27:51 +01:00
Radoslaw Zarzynski
dea8aa67c2 common, mon, qa: Mon-related updates for squid
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2023-12-04 16:27:51 +01:00
Radoslaw Zarzynski
da25e58dc1 doc, qa/standalone/mon/misc: verify that len(monmap.features.persistent) == 11
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2023-12-04 16:27:50 +01:00
Vallari Agrawal
42e121a42a
qa: add rbd/nvmeof test
A basic test for ceph-nvmeof[1] where
nvmeof initiator is created.
It requires use of a new task "nvmeof_gateway_cfg"
under cephadm which shares config information
between two remote hosts.

[1] https://github.com/ceph/ceph-nvmeof/

Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
2023-12-04 19:27:54 +05:30
Ronen Friedman
8ec47bba09
Merge pull request #54482 from ronen-fr/wip-rf-repl-hp
osd/scrub: decouple being reserved from handling scrub requests

Reviewed-by: Samuel Just <sjust@redhat.com>
2023-12-03 09:45:18 +02:00
Ronen Friedman
6f1e0e6825 tests/scrub: deactivate osd-scrub-dump stand-alone test
as the scrub reservation changes had made it obsolete.
Note - it is not an issue of fixing the test, but rather
that the tested functionality is no longer there.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2023-12-01 08:48:49 -06:00
Ilya Dryomov
cb16d96e83
Merge pull request #54724 from ajarr/wip-63673
qa/workunits/rbd/cli_generic.sh: narrow race window

... when checking that rbd_support module command fails after blocklisting the module's client.

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2023-12-01 10:33:10 +01:00
Venky Shankar
6b1f123866 Merge PR #53431 into main
* refs/pull/53431/head:
	qa: add test cases to verify error reporting works as expected
	mgr: fix some doc strings in object_format.py
	mgr/tests: test returning error status works as expected
	mgr: make object_format's Responder class capable of responding err status
	mgr/nfs: report proper errno with err status

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-11-30 11:28:10 +05:30
Rishabh Dave
533ed43609
Merge pull request #54631 from rishabh-d-dave/mgr-vol-tests
qa/cephfs: improvements for name generators in test_volumes.py

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-11-30 10:47:42 +05:30
Patrick Donnelly
215d96c1d1
qa: test fs:shell on all distros
This is a simple sub-suite that has one job. Always schedule on all supported distros.

Fixes: https://tracker.ceph.com/issues/43393
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2023-11-29 20:23:03 -05:00
Patrick Donnelly
b12bdfeee3
qa: add cephfs-shell to installed rpm packages
For CephFS QA.

Fixes: https://tracker.ceph.com/issues/43393
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2023-11-29 20:23:00 -05:00
Rishabh Dave
5d471c2712
Merge pull request #54308 from rishabh-d-dave/mgr-vol-flake-warnings
mgr/vol: fix flake8 warnings

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
2023-11-30 00:49:28 +05:30
Ramana Raja
ea033fe860 qa/workunits/rbd/cli_generic.sh: narrow race window
... when checking whether a rbd_support module command fails after
blocklisting the module's client.

In tests that check the recovery of the rbd_support module after its
client is blocklisted, the rbd_support module's client is
blocklisted using the `osd blocklist add` command. Next,
`osd blocklist ls` command is issued to confirm that the client is
blocklisted. A rbd_support module command is then issued and expected
to fail in order to verify that the blocklisting has affected the
rbd_support module's operations. Sometimes it was observed that before
this rbd_support module command reached the ceph-mgr, the rbd_support
module detected the blocklisting, recovered from it, and was able to
serve the command. To reduce the race window that occurs when trying to
verify that the rbd_support module's operation is affected by client
blocklisting, get rid of the `osd blocklist ls` command.

Fixes: https://tracker.ceph.com/issues/63673
Signed-off-by: Ramana Raja <rraja@redhat.com>
2023-11-29 13:49:06 -05:00
Rishabh Dave
ad96e91ee4 qa/cephfs: improvements for name generators in test_volumes.py
Generate a name that is shorter and easier to remember.

Also, write a simpler, faster & better helper method for generating
unique names. This method will also have shorter and more concise name,
so this will be easier to type and easier to read.

Fixes: https://tracker.ceph.com/issues/63680
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-11-29 21:15:29 +05:30
Casey Bodley
67ffb05d71
Merge pull request #54618 from alimaredia/wip-remove-vstart-runner-radosgw-admin-task
qa: remove vstart runner from radosgw_admin task

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2023-11-29 15:18:57 +00:00
Neeraj Pratap Singh
7f0cf0b7a2 qa: test cases for checking the health status after scrub repair
Fixes: https://tracker.ceph.com/issues/54557
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
2023-11-29 16:09:01 +05:30
Vallari Agrawal
b896bebf38
Merge pull request #54209 from VallariAg/wip-xml-scanner
qa: use Remote.run_unit_test and ValgrindScanner
2023-11-29 12:21:02 +05:30
Venky Shankar
e5e1d6254a qa: don't fail on gather_mount_info() failure
kernel 5.4 (Ubuntu 20.04) has the following missing commits:

- 5a9e2f5d5590 ceph: add ceph.{cluster_fsid/client_id} vxattrs
- 247b1f19dbeb ceph: add status debugfs file

fs suite relies on these debugfs entries to gather mount information
(client-id, addr/inst) which are required by some tests. In fs suite,
the disto kernel gets overridden by the testing kernel and therefore
even if Ubuntu 20.04 is chosen as the distro, the testing kernel is
installed. However, with smoke suite, the distro kernel is used and
the missing patches causes certain essential information gathering to
fail early on (client-id, etc..) causing the test to not even start
execution. PR #54515 fixes a bug in the client-id fetching path but
isn't complete due to the missing patches - details here:

        https://tracker.ceph.com/issues/63488#note-8

But its essential to have the smoke tests running since those tests
have lately uncovered bugs in the MDS (w/ distro kernels). In order
to benefit from those tests, this change ignores failures when
gathering mount information (which aren't used by the fs relevant
smoke tests). The test (in fs suite) that rely on this piece of
information would fail when run with 20.04 distro kernel (but the
fs suite overrides it with the testing kernel).

Signed-off-by: Venky Shankar <vshankar@redhat.com>
2023-11-29 11:47:14 +05:30
Ali Maredia
a44fd94b96 qa: remove vstart runner from radosgw_admin task
Fixes: https://tracker.ceph.com/issues/63583

Signed-off-by: Ali Maredia <amaredia@redhat.com>
2023-11-28 02:58:49 -05:00
Josh Soref
ed70d843df rgw: fix spelling errors
* access
* acquire
* across
* algorithm
* alternatively
* ambiguous
* attributes
* authenticated
* automatically
* based
* between
* beware
* bootstrap
* bucket
* cache
* character
* check
* cleanup
* combinations
* committed
* comparison
* compatibility
* concurrent
* conditions
* conjunction
* connections
* considered
* contains
* correct
* creates
* crypto
* dependencies
* dequeued
* dequeuing
* derivative
* described
* determine
* deterministic
* detritus
* discrepancy
* display
* either way
* elements
* entirely
* entries
* error
* everything
* expected
* explicitly
* extend
* false
* fclose
* feature
* following
* foreign
* format
* forward
* functionality
* functions
* generated
* getting
* gracefully
* happened
* hashicorp
* healthcheck
* hierarchy
* however
* http
* identify
* idleness
* ignored
* incremental
* information
* initialization
* length
* locally
* macros
* malformed
* means
* mechanism
* multipart
* multiple
* must
* namespace
* necessary
* nonexistent
* notifications
* occurred
* official
* outputs
* outputted
* overridden
* ownership
* parallelism
* partition
* passthrough
* pause
* penguin
* perform
* permission
* populated
* position
* preferably
* prefixes
* presumably
* previous
* print
* quadruple
* reference
* regardless
* registry
* renewed
* request
* requires
* reshard
* resource
* result to
* satisfy
* secret
* separate
* separator
* setting
* shouldn't
* skipping
* some
* somehow
* something
* specific
* struct
* succeeded
* success
* successful
* successfully
* syntax
* testing
* truncated
* unambiguously
* unittest
* unmodified
* unnecessary
* valid_action
* verifying
* versioning
* visible
* whatever
* whenever

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-11-27 10:27:32 -05:00
Yuval Lifshitz
213923165c
Merge pull request #52931 from yuvalif/wip-yuval-lua-teuthology
rgw/test/lua: add lua integration tests suite

reviewed-by: TRYTOBE8TME, cbodley
2023-11-24 11:38:51 +02:00
Jane Zhu
96ca98a169 rgw/swift: preserve dashes/underscores in swift user metadata names
Signed-off-by: Juan Zhu <jzhu116@bloomberg.net>
2023-11-23 17:40:04 -05:00
Rishabh Dave
974c4f93b3 qa/cephfs: don't write guest keyring to file "keyring"
Writing guest keyring to CWD's file named "keyring" will over-write
build/keyring on developer's machine which will make the cluster
inoperatable and also fail the test.

Fixes: https://tracker.ceph.com/issues/63506
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-11-24 00:14:23 +05:30
Yuval Lifshitz
46500cace6 rgw/test/lua: add lua integration tests suite
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>

Fixes: https://tracker.ceph.com/issues/63616
2023-11-23 16:36:28 +00:00
Xiubo Li
21a1e1cd95 qa/fscrypt: enable debug log for bluestore
We need to get more debug logs from bluestore to know what exactly
has happened for the extent map.

URL: https://tracker.ceph.com/issues/63586
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2023-11-23 15:22:53 +08:00
Casey Bodley
b0b050d31c
Merge pull request #52813 from cbodley/wip-59424
qa/rgw: run s3tests against keystone ec2

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2023-11-21 13:33:58 +00:00
Venky Shankar
ebea0f8935
Update qa/tasks/cephfs/test_data_scan.py
Co-authored-by: Dhairya Parmar <87528150+dparmar18@users.noreply.github.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2023-11-21 14:59:23 +05:30
Venky Shankar
2958a7cd12 qa: set mds config with config set for a particular test
The config setting is persisted in ceph.conf after the MDSs are started.
However, the test case fails the file system causing the active MDS to
restart and pick up the new config. When the file system is marked joinable,
then, if the MDS which was standby before the file system was marked failed
takes over as the rank, the updated setting are not used by this MDS.

In the failed test, merging directory fragment is disabled, but since
the config is set in ceph.conf, the (earlier standby) MDS which acquires
a rank uses the default merge size causing the dirfrag to merge and
thereby tripping the test.

Fixes: http://tracker.ceph.com/issues/57087
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2023-11-21 12:11:53 +05:30
Milind Changire
aca254a3ed
Merge PR #54414 into main
* refs/pull/54414/head:
	qa: run kernel_untar_build with newer tarball

Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-11-19 08:58:14 +05:30
Ronen Friedman
116c72bf1b osd/scrub: maintain a set of remote reservations
... instead of a simple counter.

This - as a preparation for the next commit, which will decouple
the "being reserved" state from the handling of scrub requests.
The planned changes to the scrub state machine will make
it harder to know when to clear the "being reserved" state.
The changes here would allow us to err on the side of caution,
i.e. trying to "un-count" a remote reservation even if it was not
actually reserved or was already deleted.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2023-11-18 11:44:32 -06:00
Samuel Just
6adc03ac37
Merge pull request #52151 from myoungwon/wip-ceph-dedup-tool-memory
tools/ceph-dedup-tool: set memory threshold not to cause excessive  memory usage

Reviewed-by: Samuel Just <sjust@redhat.com>
2023-11-17 10:40:11 -08:00
Ronen Friedman
d9a4752cd8
Merge pull request #54363 from ronen-fr/wip-rf-force-scrub
osd/scrub: modify "scrub" & "deep_scrub" ASOK commands

Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2023-11-15 18:12:22 +02:00
Ilya Dryomov
e0584935f9
Merge pull request #54489 from Suyashd999/main
qa/suites/rbd: Cleanup of MIRROR_IMAGE_MODE

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2023-11-15 16:49:57 +01:00
Ronen Friedman
fbb7d73e6f tests/standalone: fix scrub-related tests following command changes
Using
ceph tell $pgid [deep]-scrub
to initiate an 'operator initiated' scrub, and
ceph tell $pgid schedule[-deep]-scrub
for causing a 'periodic scrub' to be scheduled.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2023-11-15 03:14:15 -06:00
Xiubo Li
540f396203 test/libcephfs: move the snapdiff to a dedicated binary
The snapdiff test cases will take too much time, sometimes for hours.
It's very inconvenient to run some general tests locally.

Just move it to a dedicated binary.

Signed-off-by: Xiubo Li <xiubli@redhat.com>
2023-11-15 15:42:10 +08:00
Suyashd999
9b773eec4a qa/suites/rbd: Cleanup of MIRROR_IMAGE_MODE
Fixes: https://tracker.ceph.com/issues/63431
Signed-off-by: Suyash Dongre <suyashd999@gmail.com>
2023-11-14 18:28:02 +05:30
Milind Changire
b150e935e8
qa: run kernel_untar_build with newer tarball
Replace old tarball link with a url link to linux-6.5.11.tar.xz.

Fixes: https://tracker.ceph.com/issues/57655
Signed-off-by: Milind Changire <mchangir@redhat.com>
2023-11-14 15:35:50 +05:30
Milind Changire
994ae0d633
qa: use correct imports to resolve fuse_mount and kernel_mount
Fixes: https://tracker.ceph.com/issues/62706
Signed-off-by: Milind Changire <mchangir@redhat.com>
2023-11-13 12:56:50 +05:30
Adam King
9e2d5c4972
Merge pull request #49914 from adk3798/monitoring-teuth-test
qa/cephadm: basic test for monitoring stack

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2023-11-10 17:09:12 -05:00
Adam King
b4db5e4ffc qa/cephadm: adjust host drain test to handle explicit placement warning
Since we're adding a warning if any host is listed explicitly
in the placement of any service when removing the host,
we need to adjust the host drain test that removes a host
without the --force flag to not have the explicit hostname
in the placement for the mon service.

Signed-off-by: Adam King <adking@redhat.com>
2023-11-09 14:31:48 -05:00
Rishabh Dave
50aab7dadb
Merge pull request #50212 from rishabh-d-dave/fs-swap-subcmd
cephfs: add command "ceph fs swap"

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2023-11-08 21:18:27 +05:30
Venky Shankar
d5834c9af6 qa: enable debug mds/client for fs/nfs suite
Fixes: http://tracker.ceph.com/issues/63482
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2023-11-08 11:51:30 +05:30
Rishabh Dave
df7717c8a1
Merge pull request #53912 from joscollin/wip-B63099-fix-prev-snapshot-none
client: avoid getvxattr op for ceph.mirror* attrs

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
2023-11-07 23:28:23 +05:30
Rishabh Dave
380ac6c792
Merge pull request #53899 from rishabh-d-dave/before-fs-rename-fail-fs
cephfs,mon: fs rename must require FS to be offline and refuse_client_session to be set

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2023-11-07 23:22:42 +05:30
Patrick Donnelly
c6b8328603
Merge PR #53568 into main
* refs/pull/53568/head:
	common: resolve config proxy deadlock using refcounted pointers
	common: add missing locks in config_proxy methods
	common/ceph_mutex: note whether mutex debug methods are usable
	qa: add reproducer for obs removal deadlock
	qa: narrow search to debug_asok

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-11-06 14:57:17 -05:00
Adam King
7870538dc1 qa/cephadm: test --rm-crush-entry host rm flag in host drain test
Signed-off-by: Adam King <adking@redhat.com>
2023-11-03 13:23:15 -04:00
Adam King
13f16e8d7b qa/cephadm: add teuthology test for host draining
This was a gap in our testing in general, but I'm
adding it here right now specifically to use it
to test the "--rm-crush-entry" flag in a follow
up commit

Signed-off-by: Adam King <adking@redhat.com>
2023-11-03 13:23:15 -04:00
Rishabh Dave
7532011aba
Merge pull request #53129 from rishabh-d-dave/xfstests-dev-deps
qa/cephfs: update dependencies for xfstests-dev

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-11-03 18:09:52 +05:30
Ilya Dryomov
c93a53aa66
Merge pull request #48508 from pkalever/rbd-tests
qa/workunits/rbd: merge journal and snapshot test scripts

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2023-11-03 12:55:02 +01:00
Rishabh Dave
9c547ad2a5 qa/cephfs: allow finer control on test runs
When working with large group tests (18 in this case), it gets very
tedious to debug and fix tests when all 18 have to be run again for
every mistake. Cheap fix for this to split these 18 tests into several
classes.

But when modification are made to the feature, all these 18 tests needs
to exercised and previous solution forces developer to intitiate all
these test classes to run one by one.

Best of both worlds can be achieved if we split tests into group but
move all these related group to a new file.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-11-03 15:25:54 +05:30
Rishabh Dave
7170314542 cephfs: add command "ceph fs swap"
Add a FS command that enables users to swap names of two file systems in
a single PAXOS transaction. Add an option to this command that swaps
FSCIDS along with FS names. This commands also updates the application
pool tags and fails when mirroring is enabled on either or both FSs.

Fixes: https://tracker.ceph.com/issues/58129
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-11-03 13:05:14 +05:30
Gabriel Benhanokh
a666cb4a08
Merge pull request #53132 from benhanokh/maintain_prefix_itr_2
osd/SnapMapper:maintain the prefix_itr between calls to SnapMapper::get_next_objects_to_trim()
2023-11-03 08:21:22 +02:00
myoungwon oh
c4275c9842 tools/ceph_dedup_tool: add a test to check the memory limit works correctly
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2023-11-03 04:18:39 +00:00
Gabriel BenHanokh
abba1a8b2c osd/SnapMapper: maintain the prefix_itr between calls to SnapMapper::get_next_objects_to_trim()
Maintain the prefix_itr between calls to SnapMapper::get_next_objects_to_trim() to prevent searching depleted prefixes.
We got 8 distinct hash prefixes used for searching objects owned by a given PG.
On each call to SnapMapper::get_next_objects_to_trim() we start from the first prefix even after all objects mapped to it were depleted.
This means that we will be searching for 1 non-existing prefix after the first prefix was depleted, 2 after the first two prefixes were depleted... and so on until we will search 7 non-existing prefixes after the first 7 prefixes were depleted.

This is a performance improvement PR only!
It maintains the existing behavior and does not try to fix/change any of the TRIM logic.
I added an extra step after the last object is trimmed doing a full scan of the DB and only if no object was found it will return ENOENT.
This should make the new code no-worse than existing code which returns ENOENT after a full scan found no object.
It should not impact performance in real life snaps as it should only happen once per-snap.

added snap-mapper tests to rados-test-suite
disabled osd_debug_trim_objects when running (SnapMapperTest, prefix_itr) to prevent asserts(as this code does illegal inserts into DELETED snaps)
Code beautifing

Disabled the assert as there is a corner case when we retrieve the last valid object/s in a snap
The prefix_itr is advanced past the last valid value (as we completed a full scan)
If the OSD will call get_next_objects_to_trim() before the retrieved object/s was processed and removed from the SnapMapper DB it won't be found by the next call (as the prefix_itr is invalid).
The object will be found in the second-pass which will seems as if it was added after the trim was started (which is illegal) and will trigger an ASSERT

Signed-off-by: Gabriel BenHanokh <gbenhano@redhat.com>
2023-11-02 19:25:16 +00:00
Rishabh Dave
3f93d74067 cephfs: allow FS fail only if client_refuse_session is set
client_refuse_session must be set for a CephFS before an attempt to
rename a CephFS can be made. Add a new test for this, and update current
tests (test_admin.py and test_volumes.py) accordingly.

Fixes: https://tracker.ceph.com/issues/63154
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-11-02 22:12:49 +05:30
Rishabh Dave
e268908a5a qa/cephfs: create new class for "volume fs volume rename" tests
Move tests for "ceph fs volume rename" command to a new class. This
makes it possible to run this group of tests in a single command.

This provides a convenient way to execute these tests which is necessary
after the changes has been made to the code for the "ceph fs volume
rename" command.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-11-02 22:11:53 +05:30
Rishabh Dave
fe3a4b9683 cephfs,mon: allow FS rename only if FS is offline
Reject the attempt to rename the CephFS is the CephFS is not offline.
Add new tests for this and update current tests (test_admin.py and
test_volumes.py) accordingly.

Fixes: https://tracker.ceph.com/issues/63154
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-11-02 22:11:51 +05:30
Prasanna Kumar Kalever
3fd8a03887 qa/workunits/rbd: merge journal and snapshot test scripts
The idea is to avoid the maintenance of duplicate code in both the journal
and snapshot test scripts.

Usage:
   RBD_MIRROR_MODE=journal rbd_mirror.sh

Use environment variable RBD_MIRROR_MODE to set the mode
Available modes: snapshot | journal

Fixes: https://tracker.ceph.com/issues/54312
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
2023-11-02 18:11:55 +05:30
Samuel Just
4801e812bc
Merge pull request #52261 from myoungwon/wip-ceph-dedup-tool-snap-add
tool/ceph-dedup-tool: perform dedup on snapshotted object during sample dedup

Reviewed-by: Samuel Just <sjust@redhat.com>
2023-11-01 18:53:28 -07:00
Yuri Weinstein
ddd2c61077
Merge pull request #52545 from Matan-B/wip-matanb-trim-61962
osd/OSD: fix trim_maps() - possible leak on `skip_maps`

Reviewed-by: Samuel Just <sjust@redhat.com>
2023-11-01 12:09:44 -07:00
Yuri Weinstein
2cb99f8866
Merge pull request #50081 from NitzanMordhai/wip-nitzan-subscription-manager-rocksdb-librados
qa/*/test_envlibrados_for_rocksdb.sh: subscribe repo

Reviewed-by: Laura Flores <lflores@redhat.com>
2023-11-01 12:08:42 -07:00
Ilya Dryomov
c5eb0ce432
Merge pull request #53535 from ajarr/wip-62891
qa/suites/rbd: add test to check rbd_support module recovery

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
2023-11-01 10:45:59 +01:00
Rishabh Dave
b1bf543127
Merge pull request #54210 from rishabh-d-dave/progress-submodule-update
add --progress flag to git submodule update commands

Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2023-11-01 10:59:59 +05:30
Rishabh Dave
eb6995436f cmake: add --progress flag to git submodule update commands
Ceph has lots of submodules that needs to be cloned before building
binaries from the repository. Seeing the progress when these submodules
are being cloned is useful, especially when developers/users have a
network issue or a slow network.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-10-31 23:14:49 +05:30
neeraj pratap singh
4af9f8eb6c qa: fix rank_asok() to handle errors from asok commands
Fixes: https://tracker.ceph.com/issues/63176
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
2023-10-31 14:14:14 +05:30
Aishwarya Mathuria
b88cecdc7c DaemonServer.cc: fix config show command for RGW daemons
RGW daemons register in the servicemap by gid which allows multiple radosgw instances to share an auth key/identity. The daemon name is sent as part of the metadata.  (84c265238b).
All other daemons register by the daemon name and the manager stores all daemon state information with daemon name as key. The 'config show' command looks up the daemon_state map with the daemon name the user mentions as key (for example: 'osd.0', 'client.rgw', 'mon.a').
Due to the change in RGW daemon registration, the key used for storing daemon state has become rgw.gid and 'config show client.rgw' no longer works.

This change will take care of going through the daemon metadata to look for the RGW daemon name when a user enters the config show command for a RGW daemon. Once the correct daemon is found, we retrieve the corresponding daemon key (rgw.gid) and use that to query the daemon_state map.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2011756
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
2023-10-30 17:28:05 +00:00
Ilya Dryomov
bf82a7bd34
Merge pull request #50593 from pkalever/fix-feature-disable
rbd-nbd: fix stuck with disable request

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2023-10-30 08:55:09 +01:00
Jos Collin
be551a6c68
qa: tests set/get ceph.mirror.dirty_snap_id attribute succeeds in a remote filesystem
Fixes: https://tracker.ceph.com/issues/63099
Signed-off-by: Jos Collin <jcollin@redhat.com>
2023-10-30 11:09:42 +05:30
Yuri Weinstein
d6f6dd1fbf
Merge pull request #54082 from pdvian/wip-qa-suites-fix
qa/smoke,orch,perf-basic: add POOL_APP_NOT_ENABLED to ignorelist

Reviewed-by: Laura Flores <lflores@redhat.com>
2023-10-27 11:42:52 -07:00
Casey Bodley
a57765022a
Merge pull request #53003 from alimaredia/wip-rgw-perf-counters-cache
Perf counters cache + Labeled RGW Op counters

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2023-10-27 14:40:19 +01:00
Rishabh Dave
94a287d8fd qa/cephfs: update dependencies for xfstests-dev
Dependencies listed in xfstests_dev.py for xfstests-dev project are
outdated. This leads the xfstests_dev.py based integration tests to
fail. Update this dependency list using README of xfstests-dev project.

Also, remove code which is not relevant anymore (specifically, if-block
that checks and deals for 'python' and 'btrfs-progs-devel').

Fixes: https://tracker.ceph.com/issues/62556
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-10-26 16:07:58 +05:30
Vallari Agrawal
397e85a5f8
qa: rewrite "valgrind_post" to use ValgrindScanner
previously, valgrind_post() func used grep to find error
from valgrind logs.
now, it uses ValgrindScanner to log better exceptions with
traceback and exception kind, along with creating a more detailed
summary in valgrind.yaml in archive.

Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
2023-10-26 14:08:46 +05:30
Vallari Agrawal
ccf2bba418
qa: use Remote.run_unit_test when "unit_test_scan" config is used
"unit_test_scan" optional config uses Remote.run_unit_test()
to scan xml files generated by unit tests to throw better failure
messages (for s3tests and gtests run by workunit)
It also creates "unit_test_summary.yaml" for more exception details
from xml files.

Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
2023-10-26 12:13:37 +05:30
Yuval Lifshitz
75bd7e3e20
Merge pull request #54025 from yuvalif/wip-yuval-fix-63205
rgw/notifications/test: fix rabbitmq and kafka issues in centos9

reviewed-by: cbodley
2023-10-22 18:26:30 +03:00
Yuval Lifshitz
2ab7c16737 rgw/notifications/test: install java for kafka build
also use kafka binaries insted of building from source

Fixes: https://tracker.ceph.com/issues/63205

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2023-10-22 09:58:37 +00:00
Yuri Weinstein
f0804064d6
Merge pull request #54109 from ceph/wip-yuri-crontab-main
qa/tests: enabled smoke tests on main, quincy and reef

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
2023-10-20 07:29:47 -07:00
Venky Shankar
76e6fb0d77 Merge PR #53839 into main
* refs/pull/53839/head:
	qa: enhance test cases
	mds: erase clients getting evicted from laggy_clients
	mds: report clients laggy due laggy OSDs only after checking any OSD is laggy

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-10-20 14:44:27 +05:30
Venky Shankar
677b5226b6 Merge PR #53651 into main
* refs/pull/53651/head:
	qa: add test_subvolume_group_rm_when_its_not_empty
	mgr/volumes: fix `subvolume group rm` error message

Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-10-20 10:43:19 +05:30
Yuri Weinstein
060e1239dd qa/tests: enabled smoke tests on main, quincy and reef
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
2023-10-19 10:26:55 -07:00
Yuval Lifshitz
1ffe4aca2a rgw/notifications/test: use dnf and systemctl to setup rabbitmq
Fixes: https://tracker.ceph.com/issues/63205

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2023-10-19 14:22:53 +00:00
Dhairya Parmar
9005451882 qa: enhance test cases
Fixes: https://tracker.ceph.com/issues/63105
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
2023-10-19 17:41:45 +05:30
Prashant D
4ecec7a777 qa/smoke,orch,perf-basic: add POOL_APP_NOT_ENABLED to ignorelist
Some of the smoke, orch and perf-basic tests are failing due
to POOL_APP_NOT_ENABLED health check failure. Add
POOL_APP_NOT_ENABLED to ignorelist for these tests.

Signed-off-by: Prashant D <pdhange@redhat.com>
2023-10-18 16:07:47 -04:00
Dhairya Parmar
76755dad4c qa: fix error reporting string in assert_cluster_log
Fixes: https://tracker.ceph.com/issues/63217
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
2023-10-16 19:16:04 +05:30
myoungwon oh
0da2318e70 qa/workunits/test_dedup_tool.sh: add snapshot test during sample dedup
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
2023-10-15 03:26:05 +00:00
Ali Maredia
56c7cc8c59 rgw: misc labeled op counters work
Highlights of this commit include:
- splitting the rgw perf counters cache int two
caches for bucket labeled and user labeled op counters
- add config overrides to verify suite for CI
- add tenant label for op counters
- misc cleanup cleanup
- add docs for rgw metrics

Signed-off-by: Ali Maredia <amaredia@redhat.com>
2023-10-12 15:46:08 -04:00
Ilya Dryomov
4e051e66a3
Merge pull request #53914 from idryomov/wip-63149
qa/suites/rbd: drop cache tiering workload tests

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
2023-10-12 21:29:05 +02:00
Dhairya Parmar
9a92242e99 qa: add test cases to verify error reporting works as expected
Fixes: https://tracker.ceph.com/issues/62641
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
2023-10-12 17:10:34 +05:30