This amends the code to follow our C++ style guidelines with the goal of
increasing header readability.
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
rgw: Anonymous users shouldn't be able to access requester pays buckets.
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
This reverts commit bc23e0f7fa.
We're doing that because the reverted commit was a makeshift
solution to not fail Ceph compilation on platforms lacking
Boost modern enough to ship the container/static_vector.hpp.
As we got the in-tree Boost the commit isn't necessary anymore.
Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
Latest master includes
- CMakeLists.txt: FreeBSD has jemalloc as default malloc
- cmake: drop "-march=native" from CXX_FLAGS (#1429)
Signed-off-by: Kefu Chai <kchai@redhat.com>
It's possible mds's state is RESOLVE and mds's want_state is
RECONNCT or STATE_REJOIN. MDCache::resolve_done is null in that
case.
Signed-off-by: Yan, Zheng <zyan@redhat.com>
The TENTH_TIMEOUT was not delcared as an int and failed to be set with
the correct number. The test of the function did not catch this.
Implement computing of the increasingly large sleep delays in a separate
function so that it can be tested more easily. Give up on sub-second
sleep because a the function will not sleep at all if the cluster is
already clean. And if it is not already clean, it is very unlikely to
become clean within less than a second. The downside of having very
short sleep time is that it needlessly stress the machine and also
possibly spam the logs.
Refs: http://tracker.ceph.com/issues/17830
Signed-off-by: Loic Dachary <loic@dachary.org>
... as 'allow r' (the minimum mon caps required to access a share)
when:
* authorizing the auth ID to access a volume.
* deauthorizing the auth ID to access a volume, but the auth ID is
authorized to access other volumes.
In both the above cases, the ceph_volume_client previously tried to
set the mon caps of the auth ID to an invalid value, None.
Fixes: http://tracker.ceph.com/issues/17800
Signed-off-by: Ramana Raja <rraja@redhat.com>
this silences the warning of:
yasm: warning: can open only one input file, only the last file will be
processed
as yasm does not understand -isystem, but gcc does.
Signed-off-by: Kefu Chai <kchai@redhat.com>
close() was never called for the passed in IoCtx which
could probably result in an IoCtx leak if the original
IoCtx was a valid pool context allocated earlier.
Its kind of better to do it here rather than to leave
the destruction on the caller for better (or cleaner)
common case handling.
Signed-off-by: Venky Shankar <vshankar@redhat.com>
A new CDentry will not have a parent until its projected parent is
flushed to journal. During path construction a given dentry may have no
parent yet which will cause fallbacks to be used (the inode number).
This can cause access checks to fail:
2016-11-17 19:50:43.830207 7eff9977a700 20 Session check_access path #10000000002/3
compare to an earlier check:
2016-11-17 19:50:43.824223 7eff9977a700 20 Session check_access path /test/1/2
This commit refactors path construction to optionally use projected
parents for the entire chain of directories. Existing use of real stable
parents is unchanged. For example, this line is the same before and
after the patch:
2016-11-18 23:17:15.611680 7f153f97a700 12 mds.0.cache.dir(10000000002) add_null_dentry [dentry #10000000002/3 [2,head] auth NULL (dversion lock) pv=0 v=1 inode=0 0x55e0f771f5f0]
Here inode "#10000000002" has no stable parent yet. So the path is
constructed as "#10000000002/3".
One notable change in this commit is the removal of
make_path_string_projected which was only used in debugging code. Here's
an example difference:
2016-11-17 19:50:43.827915 7eff9977a700 10 mds.0.server traverse_to_auth_dir [dir 10000000003 {#10000000003 #10000000002/3}/ [2,head] auth v=1 cv=0/0 state=1073741826|complete f() n() hs=0+0,ss=0+0 0x55f5d35e2ee0]
to:
2016-11-18 23:17:15.617757 7f153f97a700 10 mds.0.server traverse_to_auth_dir [dir 10000000003 /test/1/2/3/ [2,head] auth v=1 cv=0/0 state=1073741826|complete f() n() hs=0+0,ss=0+0 0x55e0f7706ee0]
Fixes: http://tracker.ceph.com/issues/17858
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
