Commit Graph

42311 Commits

Author SHA1 Message Date
Loic Dachary
864e2007d9 tests: add --{show_,}path to ceph_erasure_code_non_regression
The directory in which the payload is stored is created from the plugin
parameters. The --show-path shows the directory and exits. This
directory can then be used with --path to override the path created from
the plugin parameters. This is useful to verifying that the jerasure
variant optimized with AVX, SSE4 etc. instructions can be used on the
same payload and show no difference at all. In this case the directory
used by the default jerasure variant is used for each variant and the
parameter that sets the variant to use ( --parameters jerasure-variant )
must not be taken into account to figure out the location of the
payload.

http://tracker.ceph.com/issues/9720 Refs: #9720

Signed-off-by: Loic Dachary <ldachary@redhat.com>
2015-06-07 00:15:05 +02:00
Loic Dachary
1d60786c39 Merge pull request #4811 from dachary/wip-11346-isa
ceph-erasure-code-corpus: isa: add k=10 m=4

Reviewed-by: Yuan Zhou <yuan.zhou@intel.com>
2015-06-07 00:12:11 +02:00
Loic Dachary
3ec41030cc erasure-code: add sanity check to guard against k=1
Add a call to ErasureCode::sanity_check_k for the isa and jerasure
plugins, with associated tests.

http://tracker.ceph.com/issues/10358 Fixes: #10358

Signed-off-by: Loic Dachary <ldachary@redhat.com>
2015-06-06 23:51:57 +02:00
Sage Weil
efededa010 Merge pull request #4882 from SUSE/wip-submitting-patches-clarification
SubmittingPatches: clarify how Reviewed-by lines are added

Reviewed-by: Sage Weil <sage@redhat.com>
2015-06-06 06:24:17 -07:00
Nathan Cutler
85b327f85a SubmittingPatches: clarify how Reviewed-by lines are added
Signed-off-by: Nathan Cutler <ncutler@suse.com>
2015-06-06 15:16:16 +02:00
Loic Dachary
eefdeb6b79 Merge pull request #4878 from dachary/wip-11901-spec
ceph.spec.in: add missing BuildRequires from SUSE block

Reviewed-by: Nathan Cutler <ncutler@suse.cz>
2015-06-06 14:37:23 +02:00
Nathan Cutler
e1cb7e5104 ceph.spec.in: move specific BuildRequires to where they belong
Move distro-specific BuildRequires out of "common" section and
into the appropriate %if statement in the "specific" section.
Also remove a duplicated "Requires: gdisk".

Signed-off-by: Nathan Cutler <ncutler@suse.com>
Reviewed-by: Loic Dachary <ldachary@redhat.com>
2015-06-06 14:14:50 +02:00
Loic Dachary
739ef0f9a3 install-deps.sh: detect yum-builddep errors
yum-builddep does not exit on error when an error happens: grep the
output for the error: string instead.

Signed-off-by: Loic Dachary <ldachary@redhat.com>
2015-06-06 12:31:56 +02:00
Loic Dachary
34e4dd9c8a ceph.spec.in: add missing BuildRequires from SUSE block
The %endif removed by f94f23297c is restored.
The %else removed by 75e87a20da is restored.
The stray %endif added by d8abde3338 is removed.

May 29th, in d8abde3338 Owen added a stray
%endif after

   BuildRequires: gperftools-devel

around line 133. June 3rd, in f94f23297c
Ken correctly attributed the error

     "error: /srv/autobuild-ceph/gitbuilder.git/build/ceph.spec:140: Got a
      %endif with no %if"

to a stray %endif but did not remove the one causing problem and in
doing so created another problem. June 4th, in
75e87a20da Owen incorrectly fixed
this new problem by removing the %else that is near

   BuildRequires: gperftools-devel

around line 116, instead of reverting
f94f23297c. As a consequence the
ceph.spec.in became syntactically correct but implemented an if/else
logic different from what was intended originally and a number of
BuildRequires became exclusive to SUSE and were not installed for CentOS
7 etc.

http://tracker.ceph.com/issues/11901 Fixes: #11901

Signed-off-by: Loic Dachary <ldachary@redhat.com>
2015-06-06 12:05:19 +02:00
Loic Dachary
37f7360760 erasure-code: implement ErasureCode::sanity_check_k
Implement the ErasureCode::sanity_check_k helper for plugins
that need to verify k >= 2.

http://tracker.ceph.com/issues/10358 Fixes: #10358

Signed-off-by: Loic Dachary <ldachary@redhat.com>
2015-06-06 09:43:49 +02:00
Noah Watkins
a8500ce981 Merge pull request #4834 from liewegas/wip-11461
fix build on arm w/ old kernels

Signed-off-by: Noah Watkins <nwatkins@redhat.com>
2015-06-05 12:12:13 -07:00
Greg Farnum
905a867043 Merge remote-tracking branch 'origin/wip-client-fsync'
Conflicts:
	src/client/Client.cc

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2015-06-05 11:25:21 -07:00
Gregory Farnum
3f4dfb80e3 Merge pull request #4831 from ceph/wip-11807
qa: fix multiple_rsync.sh to avoid using /usr/ directly

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
2015-06-05 11:22:53 -07:00
Gregory Farnum
7dc602aff7 Merge pull request #4743 from ceph/wip-client-oldest-tid
Wip client oldest tid

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2015-06-05 11:21:20 -07:00
Gregory Farnum
3673c8be10 Merge pull request #4723 from ceph/wip-snap-misc
Wip snap misc

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2015-06-05 11:16:50 -07:00
Gregory Farnum
5e99022fc6 Merge pull request #4702 from tchaikov/wip-fix-11590
mon: always reply mdsbeacon

Reviewed-by: Joao Eduardo Luis <joao@suse.de>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2015-06-05 11:15:25 -07:00
Gregory Farnum
5a3da7b891 Merge pull request #4602 from ceph/wip-11504
mon: refine check_remove_tier checks

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2015-06-05 11:13:42 -07:00
Jenkins
997b3f998d 9.0.1 2015-06-05 10:59:02 -07:00
Jason Dillaman
d9dd5c5890 librbd: don't cancel request lock early
It's possible that a stale notice is received and will
be discarded after the request lock has been canceled.
This will stale the client.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-06-05 12:33:44 -04:00
Jason Dillaman
f97ce46ea4 tests: new test for transitioning exclusive lock
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-06-05 12:33:44 -04:00
Jason Dillaman
d2a1c226ab tests: verify that librbd will periodically resend lock request
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-06-05 12:33:43 -04:00
Jason Dillaman
879b8a73e2 common: Mutex shouldn't register w/ lockdep if disabled
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-06-05 12:29:32 -04:00
Jason Dillaman
b951a7398e librbd: improve debugging output for ImageWatcher
Include the instance pointer so that different images
can be differentiated in the logs.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-06-05 12:29:32 -04:00
Jason Dillaman
3e1e561cc2 librados_test_stub: watcher id should be the instance id (gid)
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-06-05 12:29:32 -04:00
Jason Dillaman
37c74e6e52 librbd: retry lock requests periodically until acquired
If the exclusive lock owner acks the lock release request but crashes
before it actually releases the lock, the requestor will wait forever.
Therefore, after a certain timeout, retry the request again until it
succeeds.

Fixes: #11537
Backport: hammer
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-06-05 12:29:32 -04:00
Jason Dillaman
2b6d0633d5 librbd: don't hold owner_lock for write during flush
The various IO callback codepaths will attempt to take
the lock, which will result in deadlock since the flush
cannot complete.

Backport: hammer
Fixes: #11537
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Conflicts:
	src/librbd/ImageWatcher.cc
2015-06-05 12:29:32 -04:00
Jason Dillaman
1e0f128356 librbd: CoR should copyup empty object to prevent future CoR attempts
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-06-05 12:24:27 -04:00
Jason Dillaman
0766734a24 librbd: don't attempt to (re-)update the object map for CoW
The AbstractWrite state machine has already taken care of updating
the object map to the correct state.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-06-05 12:24:27 -04:00
Jason Dillaman
9055eb6c0a librbd: hide ENOENT errors during copyup operations
It's possible for this to occur when shrinking an image with
snapshots and a zeroed data block.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-06-05 12:24:27 -04:00
Jason Dillaman
43e0e3cd63 librbd: avoid infinite loop if copyup fails
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-06-05 12:24:27 -04:00
Jason Dillaman
cd0fd833ad librbd: whole-object discards should copyup when snapshots exist
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-06-05 12:24:19 -04:00
Josh Durgin
788542cc05 Merge pull request #4781 from ceph/wip-librbd-perf-counters
librbd: re-add missing discard perf counters

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2015-06-05 08:59:15 -07:00
Jason Dillaman
d345061a8a tests: verify copyup behavior during object discard
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-06-05 11:54:41 -04:00
Jason Dillaman
f8c831e6dd librbd: trim operation should issue object copyups for overlap extent
Now that child images can be disassociated from their parents even
when snapshots exist, trim operations need to copyup parent objects
before deleting the object from the child.

Fixes: #11579
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-06-05 11:54:40 -04:00
Jason Dillaman
64f84182b5 librbd: new AioTrim operation to force copyup on object removal
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-06-05 11:46:30 -04:00
Jason Dillaman
325a066c09 librbd: default to data_ctx for post-copyup operations
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-06-05 11:46:30 -04:00
Jason Dillaman
1525ecbd04 librados_test_stub: truncate should honor op snapshot context
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-06-05 11:46:30 -04:00
Jason Dillaman
62f1306690 librbd: always use current parent overlap
With deep-copyup, there is no longer a reason to shrink the
parent overlap for IO operations.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-06-05 11:46:30 -04:00
Jason Dillaman
773438804c tests: verify that copyup properly handle image shrinking
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-06-05 11:46:30 -04:00
Jason Dillaman
da5b565f9f librbd: add new copyup helper method
ImageCtx::get_copyup_snap_id returns the oldest snapshot
to be used when calculating parent image overlaps.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Conflicts:
	src/librbd/AioRequest.cc
2015-06-05 11:46:30 -04:00
Jason Dillaman
336c3bfb00 librbd: include actual write op type in AbstractWrite debug output
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

Conflicts:
	src/librbd/AioRequest.cc
2015-06-05 11:46:30 -04:00
Jason Dillaman
712b2da419 librbd: removed unused ImageCtx::parent_io_len method
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-06-05 11:45:28 -04:00
Loic Dachary
f2897886b0 Merge pull request #4870 from joaquimrocha/extra_doc_info_for_debug_option
build: Add info about tests to --with-debug option

Reviewed-by: Loic Dachary <ldachary@redhat.com>
2015-06-05 15:22:48 +02:00
Joaquim Rocha
63aa2e6a95 build: Add info about tests to --with-debug option
The configure's --with-debug option builds also some of the tests
so this should be mentioned in its doc string in order to let users
know how to build all the tests.

Signed-off-by: Joaquim Rocha <joaquim.rocha@cern.ch>
2015-06-05 15:17:42 +02:00
Loic Dachary
3a562b44f9 Merge pull request #4866 from ddiss/fix_test_ceph_disk_dmcrypt_uuid_only
tests: fix test_activate_dmcrypt uuid usage

Reviewed-by: Loic Dachary <ldachary@redhat.com>
2015-06-05 11:56:37 +02:00
David Disseldorp
7bef2d8897 tests: fix test_activate_dmcrypt uuid usage
4601e10800 introduced a regression in that
an empty (uninitialised) OSD uuid is passed to test_pool_read_write for
IO. As a result, the "rados put" request times out causing test failure.

This change ensures that a correct OSD uuid is passed to
test_pool_read_write.

Signed-off-by: David Disseldorp <ddiss@suse.de>
2015-06-05 11:39:31 +02:00
Josh Durgin
792e94822f Merge pull request #4528 from ceph/wip-librbd-helgrind
librbd: correct issues discovered via lockdep / helgrind

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2015-06-04 18:55:43 -07:00
Jason Dillaman
c1b2783bc0 Merge pull request #4857 from jdurgin/wip-rbd-features-constants
update rbd features constants for python usage

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2015-06-04 20:37:39 -04:00
Jason Dillaman
3d5cef38c3 librbd: flush pending ops while not holding lock
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-06-04 16:52:05 -04:00
Jason Dillaman
742a85d667 tests: fix possible deadlock in librbd ImageWatcher tests
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2015-06-04 16:52:05 -04:00