This is more convenient, and also faster than initializing it in
buffer_anon and the immediately moving it elsewhere.
Drop the optionality of the alignment argument.
No users yet.
Signed-off-by: Sage Weil <sage@redhat.com>
This buys us fixes for a few memory errors and asserts and also
improves the CMake build script so it doesn't mostly ignore the
CXXFLAGS we pass in.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Even though extending the lifetime of this temporary delays execution
of its destructor, the compiler does not consider the reference to
have a side-effecting constructor.
The compiler is wrong, but we can silence its complaints.
This will cease to be an issue once we adopt C++17, since mandatory
RVO will solve the inability to bind a variable to a returned
move-only object and the need to extend a temporary.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Clang4 does not recognize a constructor with all arguments defaulted
as a default constructor in some circumstances.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Without cython_rbd, there are import errors
in the mgr log and the ceph-mgr dashboard cannot be
viewed by building just the vstart target.
Signed-off-by: Ali Maredia <amaredia@redhat.com>
This makes it easier for consumers to detect a path, or a device that
might be mounted or might have more than one mount, including tmpfs and
devtmpfs support, which was just not possible before.
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Fixes the coverity issues:
** 1402628 Uninitialized scalar field
CID 1402628 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member epoch is not initialized
in this constructor nor in any functions that it calls.
** 1409841 Uninitialized scalar field
CID 1409841 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member len is not initialized
in this constructor nor in any functions that it calls.
** 1416594 Uninitialized scalar field
CID 1416594 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member field fh.fh_hk is not
initialized in this constructor nor in any functions that it calls.
Signed-off-by: Amit Kumar <amitkuma@redhat.com>
some times, we only want scrub at out permitted time, avoid
scrub mainly deep scrub affecting business io. this patch
make no scrub deadline when osd_scrub_max_interval == 0, then
we can make sure scrub can only do in expect time.
Signed-off-by: kungf <yang.wang@easystack.cn>
os/bluestore: allow reconstruction of osd data dir from bluestore bdev label
Reviewed-By: Alfredo Deza <adeza@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
to include the change of https://github.com/ceph/dmclock/pull/41
Merge commit '060a7777cb6fe3f052259e1324490cdbf7b49980'
Signed-off-by: Kefu Chai <kchai@redhat.com>
1bbd42b8fe Merge pull request #41 from tchaikov/wip-client-info-ptr
cb7901e99a ClientRec: instead of a copy of ClientInfo, keep a pointer of it
git-subtree-dir: src/dmclock
git-subtree-split: 1bbd42b8fe212dbff68c2b470813e936859705d6
This guarantees replayed unsafe requests (on other mds) and mksnap/setlayout
get processed in proper order.
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
Auth mds may take xlock on the lock and change the object when replaying
unsafe requests. To guarantee new requests and replayed unsafe requests
(on auth mds) get processed in proper order, we shouldn't rdlock locks in
replica object while auth mds of the object is recovering
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
This reverts commit c11485e1b3.
The original sort order was compliant with amazon. Failures observed
in s3tests turned out to be a bug in boto2 - boto3 and other s3 clients
produce the correct sort order.
Fixes: http://tracker.ceph.com/issues/21832
Signed-off-by: Casey Bodley <cbodley@redhat.com>
a. upstream motivating behavior no longer reproduces
b. incorrect stat behavior observed, traced to exact match enforcement
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
Introduce new rgw_readdir2(...), which in which continues
from an arbitrary dirent name, which presumably has been
seen in a prior partial enumeration.
Add single-file unit test for READDIR cases, librgw_file_marker.cc.
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
