Commit Graph

4 Commits

Author SHA1 Message Date
Laura Flores
0f31bf10f8 .github/workflows: increase operations-per-run to 100 in stale bot
The stale bot's `operations-per-run`
(https://github.com/actions/stale#operations-per-run) corresponds to the max
number of API calls it is allowed to make per hour. Currently,
`operations-per-run` is set to 30, which means that the stale bot
can make up to 30 API calls per hour.

With this limit in place, the stale bot is only able to process 400 PRs at a time.
Since there are 900+ PRs in the Ceph repository, we should increase the number of
operations to cover them all. This needs to be done with care though, since GitHub
has a rate limit
(https://docs.github.com/en/rest/overview/resources-in-the-rest-api#rate-limiting)
depending on business plan.

According to GitHub's documentation on GitHub action requests
(https://docs.github.com/en/rest/overview/resources-in-the-rest-api#requests-from-github-actions),
the rate limit is 1,000 requests per hour per repository when using `GITHUB_TOKEN` (which we are).
For enterprise accounts, GitHub Enterprise Cloud's rate limit applies, and the limit is 15,000
requests per hour per repository.

Based on this information, we should be fine to increase the max `operations-per-run`
to 100. This would cover a little over 1000 PRs, which should be enough
to process the 900-some-odd PRs in the Ceph repository.

Signed-off-by: Laura Flores <lflores@redhat.com>
2022-08-05 11:34:20 -05:00
Laura Flores
49284d6358 .github/workflows: run the stale bot every hour
Currently, the stale bot runs once a day at 1:30 UTC.
This will only process a few PRs per day, which is not
enough to handle the volume of PRs that come into the
Ceph repository. Running the bot once every hour with
a limit of 30 operations will keep within the rate
limit, but it will also process more PRs per day.

Followup to 1a8d201037.

Signed-off-by: Laura Flores <lflores@redhat.com>
2022-07-07 12:19:08 -05:00
Sébastien Han
1a8d201037 .github/workflows: process PRs in ascending order
The Ceph repo has many PRs and we cannot process all the PRs with the
default "operations-per-run" value (30). At the time of writting the bot
processes 408 every day and there are around 938 PRs.
Even the job informs us that not enough PRs might have been processed
and encouraged us to increase "operations-per-run" if possible. However
it might expose us to Github's API rate limit.
So let's operate with the oldest PRs first, this should close a bunch of
PRs already. If not enough we can try to increase "operations-per-run".

Signed-off-by: Sébastien Han <seb@redhat.com>
2022-07-06 17:21:07 +02:00
Laura Flores
97ba9ccf8e .github/workflows: replace probot-stale with equivalent github action
We currently use probot-stale (https://github.com/probot/stale) to mark stale PRs. According to several issues reported for this repository, there is a widespread problem of probot-state not working properly in github projects (i.e. https://github.com/probot/stale/issues/349). Some users recommend using https://github.com/actions/stale instead.

Fixes: https://tracker.ceph.com/issues/54443
Signed-off-by: Laura Flores <lflores@redhat.com>
2022-03-02 20:03:56 +00:00