Commit Graph

126838 Commits

Author SHA1 Message Date
Sebastian Wagner
293e2dcede
Merge pull request #43321 from adk3798/remove-exporter
mgr/cephadm: remove cephadm exporter code

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
2021-09-29 12:36:06 +02:00
Yuval Lifshitz
c69e45c0e0
Merge pull request #43226 from TRYTOBE8TME/wip-rgw-amqp-minor-nit
src/test: Minor nit from PR #43025
2021-09-29 12:32:55 +03:00
Samuel Just
7c64d92fef
Merge pull request #43327 from cyx1231st/wip-seastore-ool-metrics
crimson/os/seastore: introduce ool related metrics with misc improvements

Reviewed-by: Samuel Just <sjust@redhat.com>
2021-09-28 17:38:13 -07:00
Neha Ojha
84379239c0
Merge pull request #43302 from ronen-fr/wip-rf-osd-psik
osd: add a missing comma in a list of strings

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Sridhar Seshasayee <sseshasa@redhat.com>
2021-09-28 10:01:28 -07:00
Neha Ojha
5c077586d9
Merge pull request #43303 from ronen-fr/wip-rf-osd-modulu
osd: fix the truncation of an int by int division

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2021-09-28 10:00:02 -07:00
Ernesto Puerta
ba9e17d2d2
Merge pull request #43132 from p-se/monitoring-grafana-piechart-update
monitoring: update grafana-piechart-panel plugin

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: p-se <NOT@FOUND>
2021-09-28 18:37:45 +02:00
Sage Weil
5ee3d38f78 Merge PR #43177 into master
* refs/pull/43177/head:
	osd/PrimaryLogPG: drop ops when pool has EIO flag
	osdc/Objecter: set SUPPORTSPOOLEIO flag on all ops
	ceph_test_rados_api_aio: test pool EIO flag
	osdc/Objecter: return EIO for new linger ops
	osdc/Objecter: return EIO for existing ops and linger ops
	osdc/Objecter: return EIO for new ops
	osd,mon: add EIO pool flag

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2021-09-28 10:58:24 -04:00
Kefu Chai
e310b1e847
Merge pull request #43320 from pdvian/wip-doc-cephx-fixtypo
doc/dev/cephx: fix typo

Reviewed-by: Varsha Rao <varao@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2021-09-28 22:56:57 +08:00
Kefu Chai
69897926b2
Merge pull request #43316 from smithfarm/wip-spdk-tw
rpm: enable system_pmdk bcond for SUSE builds

Reviewed-by: Tim Serong <tserong@suse.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2021-09-28 22:49:58 +08:00
Sebastian Wagner
a24b3fa949
Merge pull request #43150 from sebastian-philipp/doc-cephadm-serves-sub-tree
doc/cephadm: move services under doc/cephadm/services ?

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2021-09-28 11:20:47 +02:00
Deepika Upadhyay
85635f3066
Merge pull request #43221 from badone/wip-install-deps-new-pip-resolver
install-deps.sh: Use legacy pip resolver

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
 Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
2021-09-28 14:15:41 +05:30
Yingxin Cheng
c1fdb0ab48 crimson/os/seastore: introduce ool related metrics with misc improvements
* The number of ool records written;
* Write overhead from journal/ool records;
* Wasted writes from invalided ool records;
* Wasted writes from erased inline extents;
* Distinguish ool and inline extents from metrics;

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-09-28 16:31:08 +08:00
Yingxin Cheng
2b1402b3d5 crimson/os/seastore/transaction: count fresh blocks separately
Correct get_num_fresh_blocks() to be accurate under the effect of
delayed allocations.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-09-28 16:31:08 +08:00
Yingxin Cheng
529f1a81c7 crimson/os/seastore/transaction: cleanup comments
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-09-28 16:31:08 +08:00
Yingxin Cheng
33b5947a86 crimson/os/seastore/cache: misc cleanup
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-09-28 16:31:08 +08:00
Yingxin Cheng
336fe386c7 crimson/os/seastore: cleanup, consolidate metrics about transactional efforts
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-09-28 16:31:08 +08:00
Yingxin Cheng
5fd3a781c2 crimson/os/seastore: cleanup, reset cache metrics as a whole
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-09-28 16:31:08 +08:00
Sage Weil
5ac9f523ea osd/PrimaryLogPG: drop ops when pool has EIO flag
If the op doesn't have the SUPPORTSPOOLEIO flag (i.e., it is an old client),
return with an explicit EIO.

Signed-off-by: Sage Weil <sage@newdream.net>
2021-09-27 13:20:31 -04:00
Sage Weil
6992a1cd74 osdc/Objecter: set SUPPORTSPOOLEIO flag on all ops
This tells us the client understands the pool EIO flag, without having to
burn a feature bit.

Signed-off-by: Sage Weil <sage@newdream.net>
2021-09-27 13:20:31 -04:00
Sage Weil
c2f753c57e ceph_test_rados_api_aio: test pool EIO flag
Signed-off-by: Sage Weil <sage@newdream.net>
2021-09-27 13:20:31 -04:00
Adam King
35f895aa45 mgr/cephadm: remove cephadm exporter code
It's functionality has been effectively replaced by the cephadm agent

Signed-off-by: Adam King <adking@redhat.com>
2021-09-27 12:11:55 -04:00
Prashant D
0b05924769 doc/dev/cephx: fix typo
Signed-off-by: Prashant D <pdhange@redhat.com>
2021-09-27 13:37:31 +01:00
Ernesto Puerta
99f1f0f4c0
Merge pull request #43285 from rhcs-dashboard/api-endpoint-version-compatibility
mgr/dashboard: make modified API endpoints backward compatible

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2021-09-27 14:13:07 +02:00
Sebastian Wagner
8c70398949
doc/cephadm: move services into services/
This is going to clean up the toctree a bit.

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
2021-09-27 12:21:54 +02:00
Sebastian Wagner
5e25b19cc7
doc/cephadm: move service-management to services/index.rst
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
2021-09-27 12:20:02 +02:00
Sebastian Wagner
10012acb3e
Merge pull request #43160 from sebastian-philipp/doc-spec-networks
doc/cephadm: Add networks to spec documentation 

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2021-09-27 12:19:17 +02:00
Nathan Cutler
1a3a1b0958 rpm: enable system_pmdk bcond for SUSE builds
ecb8d2cae2 disabled the system_pmdk bcond for all
build targets based on the fact that pmdk 1.10 was not available on any of them.

Now that openSUSE Tumbleweed ships pmdk 1.11, we re-enable the system_pmdk bcond
to fix the master build for openSUSE Tumbleweed.

Since openSUSE Tumbleweed is the *only* SUSE build target master supports, there
is no need for greater granularity in the distro conditional here.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
2021-09-27 12:05:45 +02:00
Venky Shankar
e425e083d6
Merge pull request #43276 from lxbsz/fix_typo
mds: fix typo in the comments and log when setting new loner

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2021-09-27 12:00:11 +05:30
Samuel Just
a35d1eff1d
Merge pull request #43301 from athanatos/sjust/wip-seastore-fixes-2021-09-24
crimson/os/seastore/.../btree_range_pin: fix is_parent_of

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2021-09-26 22:04:18 -07:00
Brad Hubbard
e7a8d094bc
Merge pull request #43291 from badone/wip-missing-hostname-dependency
rpm, debian: We depend on 'hostname'

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-09-27 14:21:14 +10:00
Brad Hubbard
cf932436c8 rpm, debian: Add hostname as a "make check" dependency
test_hostname.cc depends on the hostname binary.

Fixes: https://tracker.ceph.com/issues/52695

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
2021-09-27 11:03:55 +10:00
Ronen Friedman
1a2329c46b
Merge pull request #43191 from ronen-fr/wip-rf-scrub-locations
osd/scrub: collecting scrub-related files into a separate directory

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2021-09-26 20:33:49 +03:00
Kefu Chai
48c044b618
Merge pull request #43304 from inspur-wyq/wip-doc-3
doc/rbd/rbd-windows.rst: fix typos

Reviewed-by: Deepika Upadhyay <dupadhya@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-09-26 21:55:57 +08:00
Ronen Friedman
7248f12768 osd/scrub: collecting scrub-related files into a separate directory
Cleaning src/osd from scrub implementation files. Triggered by:
- the matching Crimson scrub structure;
- the proliferation of scrub related code files (inc. in coming PRs);

scrubber_common.h, which defines the scrubber's interface, remains
in src/osd.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2021-09-26 13:42:54 +00:00
Ronen Friedman
c98b0bced3
Merge pull request #40984 from ronen-fr/wip-ronenf-scrub-sched
osd/scrub: extracting scrub scheduling code from OSD.cc

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2021-09-26 14:59:49 +03:00
Ilya Dryomov
6de678890b
Merge pull request #43220 from idryomov/wip-keyring-resolve-error
auth,mon: don't log "unable to find a keyring" error when key is given

Reviewed-by: Kefu Chai <kchai@redhat.com>
2021-09-26 12:09:43 +02:00
Ilya Dryomov
60e5539976
Merge pull request #43207 from idryomov/wip-full-try-regressions
librados,neorados,librbd: fix FULL_TRY handling regressions

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2021-09-26 12:07:06 +02:00
Ernesto Puerta
357f79ff2e
mgr/dashboard: replace string version with class
* APIVersion:
  * Moved to a separate file
  * Added doctests
  * Added sentinel values:
    * DEFAULT = 1.0
    * EXPERIMENTAL = 0.1
    * NONE = 0.0
  * Added to_mime_type() helper method
* Controllers.__init__:
  * Added type hints
  * Replaced string versions with APIVersions
* Feedback controller:
  * Replaced with EXPERIMENTAL (probably it should be NONE)

Fixes: https://tracker.ceph.com/issues/52480
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
2021-09-25 13:47:06 +02:00
Ronen Friedman
6f2b4d3dd2 osd: fix the truncation of an int by int division
The 'r' coeff calculated in OSD::tick() was always 0.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2021-09-25 11:42:56 +00:00
Ronen Friedman
11f94b3dd7 osd: add a missing comma in a list of strings
One of OSD::get_tracked_conf_keys() keys was missing
a terminating ','

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2021-09-25 09:13:09 +00:00
Ilya Dryomov
75824a113b
Merge pull request #43228 from idryomov/wip-rbd-mirror-snapshot-rx-only
rbd-mirror: unbreak one-way snapshot-based mirroring

Reviewed-by: Mykola Golub <mgolub@suse.com>
2021-09-25 10:58:17 +02:00
Xiubo Li
2724043bae mds: fix the set loner log
Once here the current loner has already been dropped if there has,
and the get_wanted_loner() is the new loner it trying to set to.

Signed-off-by: Xiubo Li <xiubli@redhat.com>
2021-09-25 16:57:18 +08:00
Xiubo Li
3a98cce6ca mds: fix typo in the comments
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2021-09-25 16:54:03 +08:00
Samuel Just
49affebfa5 crimson/os/seastore/.../btree_range_pin: fix is_parent_of
The LBA tree implementation only requires that the start addr of
a logical extent be contained within the leaf range.  It's entirely
possible for the end of a logical extent to extend past the end addr
of the containing leaf node.

Fixes: https://tracker.ceph.com/issues/52709
Signed-off-by: Samuel Just <sjust@redhat.com>
2021-09-24 18:26:09 -07:00
Samuel Just
ac7e44de95 crimson/os/seastore/transaction_manager: whitespace cleanup submit_transaction_direct
Signed-off-by: Samuel Just <sjust@redhat.com>
2021-09-24 17:11:10 -07:00
Sage Weil
14367571fc osdc/Objecter: return EIO for new linger ops
Signed-off-by: Sage Weil <sage@newdream.net>
2021-09-24 12:25:13 -04:00
Sage Weil
f1c495b7a2 osdc/Objecter: return EIO for existing ops and linger ops
Signed-off-by: Sage Weil <sage@newdream.net>
2021-09-24 12:25:13 -04:00
Sage Weil
45ffdda221 osdc/Objecter: return EIO for new ops
Signed-off-by: Sage Weil <sage@newdream.net>
2021-09-24 12:25:13 -04:00
Sage Weil
2756dacc74 osd,mon: add EIO pool flag
Signed-off-by: Sage Weil <sage@newdream.net>
2021-09-24 12:25:13 -04:00
Ilya Dryomov
803e03d629
Merge pull request #43282 from Madhu-1/csi-ceph-conf
doc/rbd/rbd-kubernetes: add ceph.conf configmap

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2021-09-24 18:04:20 +02:00