If CEPH_CLI_TEST_DUP_COMMAND is set when ceph osd create is called, it
will create two osd. They must be cleaned up afterwards instead of
assuming only one is going to be created.
http://tracker.ceph.com/issues/10083Fixes: #10083
Signed-off-by: Loic Dachary <ldachary@redhat.com>
simplify ObjectStore interface
sage-2014-11-11_08:26:01-rados-wip-sage-testing-distro-basic-multi
Reviewed-by: Haomai Wang <haomaiwang@gmail.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
msgr: make mark_down not block on fast dispatch
sage-2014-11-11_08:26:01-rados-wip-sage-testing-distro-basic-multi
Reviewed-by: Greg Farnum <greg@inktank.com>
The "fqdn" (fully-qualified domain name) was misspelled in a couple
places as fgdn". Use the correct spelling.
Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
The local filesytem may behave slightly differently. This isn't
foolproof, but seems to be reliable enough on rhel7 rootfs, where
exact comparison was failing.
Fixes: #10002
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
This reverts commit 10b68b2e1a.
The check for 'nextkey < last_disk_key' makes not much sense since
last_disk_key is an empty string and not set before. Comparing a
decoded string to be less than an empty string will be never true.
Since this if() isn't part of a loop last_disk_key is only set
once and there is no other consumer: revert this dead code.
Conflicts:
src/osd/ReplicatedPG.cc
Fix potential deref after null check. Move check for max_snaps in
rbd_snap_list up to fail early before call any functions.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Fix for:
[src/osd/ReplicatedPG.cc:2171]: (style) Redundant checking of STL
container element existence before removing it.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
In the checks to build only_in_b up the wrong const_iterator x is
build up. it should compare rhs->xattrs with xattrs entries and
not twice rhs->xattrs.
Fix for:
CID 716957 (#1 of 1): Invalid iterator comparison (MISMATCHED_ITERATOR)
mismatched_comparison: Comparing x from rhs->xattrs to this->xattrs.end()
from this->xattrs.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Fix for:
CID 717177 (#2-1 of 3): Uncaught exception (UNCAUGHT_EXCEPT)
root_function: In function main(int, char const **) an exception of
type ceph::FailedAssertion is thrown and never caught.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
RBD python unit tests no longer utilize the 'rbd' pool for
test cases. Instead, a new temporary pool is created and
deleted. Additionally, each unit test now uses a unique
image name to reduce the possibility of test case failures
affecting subsequent tests.
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Constrain the number of in-flight RADOS read requests to the
cache size. This reduces the chance of the cache memory
ballooning during certain scenarios like copy-up which can
invoke many concurrent read requests.
Fixes: #9854
Backport: giant, firefly, dumpling
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Readahead was using the incorrect lock with the pending condition,
resulting in a failed assertion. It now uses the lock associated
with pending ops.
Fixes: #10045
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
