Commit Graph

24719 Commits

Author SHA1 Message Date
Danny Al-Gaaf
f6b4f3e000 crushtool.cc: prefer prefix ++operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-13 19:07:45 +01:00
Danny Al-Gaaf
c4810a5b8b libcephfs_jni.cc: fix indention
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-13 19:06:56 +01:00
John Wilkins
6802f2793b doc: Added libvirt config comments for discard granularity.
fixes: #4395

Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2013-03-13 10:57:23 -07:00
Yehuda Sadeh
88725316dd rgw: set up curl with CURL_NOSIGNAL
Fixes: #4425
Backport: bobtail
Apparently, libcurl needs that in order to be thread safe. Side
effect is that if libcurl is not compiled with c-ares support,
domain name lookups are not going to time out.
Issue affected keystone.

Signed-off-by: Yehuda Sadeh <yehuda@inktank.com>
Reviewed-by: Greg Farnum <greg@inktank.com>
2013-03-13 10:45:07 -07:00
Danny Al-Gaaf
4056552c90 src/crush/CrushTester.{cc,h}: prefer prefix ++operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-13 18:40:44 +01:00
Danny Al-Gaaf
acac2be0c3 common/pick_address.cc: prefer prefix ++operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-13 18:40:06 +01:00
Danny Al-Gaaf
1fc0b4d2d7 common/buffer.cc: prefer prefix ++operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-13 18:39:26 +01:00
Danny Al-Gaaf
7feec80318 common/WorkQueue.cc: prefer prefix ++operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-13 18:09:30 +01:00
Danny Al-Gaaf
ae9fdfd1ee LogEntry.h: prefer prefix ++operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-13 18:09:00 +01:00
Danny Al-Gaaf
74198cc400 common/LogClient.cc: : prefer prefix ++operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-13 18:08:31 +01:00
Danny Al-Gaaf
5c7b603b2f client/SyntheticClient.cc: prefer prefix ++operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-13 18:07:51 +01:00
Danny Al-Gaaf
20dbd1306c osd/osd_types.h: prefer prefix --/++operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-13 17:56:30 +01:00
Danny Al-Gaaf
e04726084c osd/PG.h: prefer prefix ++operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-13 17:56:06 +01:00
Danny Al-Gaaf
f59f644809 osd/OSD.h: prefer prefix ++operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-13 17:55:42 +01:00
Danny Al-Gaaf
5e016d9a8f client/Client.cc: prefer prefix ++operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-13 17:55:04 +01:00
Danny Al-Gaaf
8998c9f1f3 ceph_syn.cc: prefer prefix ++operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-13 17:54:39 +01:00
Danny Al-Gaaf
b94f4b3e94 mon/Session.h: prefer prefix --operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-13 17:20:17 +01:00
Danny Al-Gaaf
1e89f74cee mon/Session.h: prefer prefix ++operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-13 17:19:23 +01:00
Danny Al-Gaaf
69d1eab69c mds/SnapRealm.h: prefer prefix ++operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-13 17:18:56 +01:00
Danny Al-Gaaf
62d33e9692 mds/SessionMap.h: prefer prefix ++operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-13 17:18:31 +01:00
Danny Al-Gaaf
d3f9673783 mds/MDSMap.h: prefer prefix ++operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-13 17:18:05 +01:00
Danny Al-Gaaf
89ffc64043 mds/CInode.h: prefer prefix ++operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-13 17:17:28 +01:00
Danny Al-Gaaf
bd4f1a3705 msg/Messenger.h: prefer prefix ++operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-13 16:59:40 +01:00
Danny Al-Gaaf
95749b3821 MonMap.h: prefer prefix ++operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-13 16:58:40 +01:00
Danny Al-Gaaf
6ae03459ee buffer.h: prefer prefix ++operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-13 16:58:05 +01:00
Danny Al-Gaaf
5d401b0a9e types.h: prefer prefix ++operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-13 16:47:32 +01:00
Danny Al-Gaaf
81e00c14e9 auth/Crypto.cc prefer prefix ++operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-13 16:40:44 +01:00
John Wilkins
af3b16349a doc: Fixed syntax error.
Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2013-03-12 17:50:26 -07:00
John Wilkins
be6f7ce68f doc: Added tcp and bind settings and cleaned up syntax a bit.
Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2013-03-12 17:44:10 -07:00
John Wilkins
77ecdc7260 doc: Setting should use network not single IP.
Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2013-03-12 15:43:33 -07:00
John Wilkins
669d2ba552 doc: Fixed usage and added note for copying keyring to client. Added hyperlinks.
fixes: #4373

Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2013-03-12 14:39:46 -07:00
John Wilkins
7f66ebe9a5 doc: Addressed confusion with version numbering.
fixes: #4411

Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2013-03-12 14:25:44 -07:00
John Wilkins
4df44bb1bb doc: Added troubleshooting entry for single OSD and single replica.
fixes: #3327

Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2013-03-12 14:15:51 -07:00
David Zafman
9464b5e965 Merge remote-tracking branch 'origin/wip-fix-librados-headers' 2013-03-12 12:03:43 -07:00
Gary Lowell
a5156fb74c Merge pull request #97 from Elbandi/master
Fix FTBFS

Reviewed-by: Gary Lowell <gary.lowell@inktank.com>
2013-03-12 11:15:00 -07:00
David Zafman
36c672dcb2 Fix typo in ceph usage output
Signed-off-by: David Zafman <david.zafman@inktank.com>
2013-03-12 11:07:54 -07:00
Sage Weil
6e2b33b460 Merge pull request #103 from dalgaaf/wip-da-fix-c_str
mon/Monitor.h: return string instead of 'char *' from get_state_name()

Reviewed-by: Sage Weil <sage@inktank.com>
2013-03-12 11:00:08 -07:00
Danny Al-Gaaf
60639ab67e mon/Monitor.h: return string instead of 'char *' from get_state_name()
Return a string instead of 'char *' to avoid usage of std::string:c_str()
to return a 'char *' from get_state_name().

Returning result of c_str() from a function is dangerous since the
result gets (may) invalid after the related string object gets
destroyed or out of scope (which is the case with return). So you may
end up with garbage in this case.

Related warning from cppcheck:
 [src/mon/Monitor.h:172]: (error) Dangerous usage of c_str(). The value
 returned by c_str() is invalid after this call.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-12 18:21:40 +01:00
Sage Weil
34f198487f Merge pull request #102 from dalgaaf/wip-da-sca-style-4-v2
Fixes for more cppcheck issues (v2 of #101)

Reviewed-by: Sage Weil <sage@inktank.com>
2013-03-12 09:57:44 -07:00
Danny Al-Gaaf
72c62269f0 client/hadoop/CephFSInterface.cc: prefer prefix ++operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-12 16:59:45 +01:00
Danny Al-Gaaf
5ad24601ff cls/rgw/cls_rgw.cc: prefer prefix --operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-12 16:59:44 +01:00
Danny Al-Gaaf
7a310854f2 client/Inode.cc: prefer prefix ++operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-12 16:59:44 +01:00
Danny Al-Gaaf
822c67ef84 SyntheticClient.h: prefer prefix ++operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-12 16:59:44 +01:00
Danny Al-Gaaf
0f48638ee4 CephxKeyServer.h: prefer prefix ++operator for iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-12 16:59:44 +01:00
Danny Al-Gaaf
b1437a8bf9 auth/Auth.h: prefer prefix ++operator for non-primitive types
Prefer prefix ++operator for non-primitive types like iterators for
performance reasons. Prefix ++/-- operators avoid creating a temporary
copy.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-12 16:59:44 +01:00
Danny Al-Gaaf
64dca11e4a tools/rest_bench.cc: remove unused variable
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-12 16:59:44 +01:00
Danny Al-Gaaf
9b51c25fa9 test/test_filejournal.cc: use %u to format unsigned in sprintf()
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-12 16:59:44 +01:00
Danny Al-Gaaf
5e882db521 test/system/st_rados_list_objects.cc: remove not needed statement
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-12 16:59:44 +01:00
Danny Al-Gaaf
ae15b2fcaa test/osd/RadosModel.h: remove unused variables
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-12 16:59:44 +01:00
Danny Al-Gaaf
faab0e849a test/osd/Object.cc: catch exception by reference
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2013-03-12 16:59:43 +01:00