as per https://www.json.org/json-en.html, JSON encodes bool as
"true" or "false", without the quotes. before this change, the quotes
are always added when encoding boolean values.
but this change is not backward compatible.
encode_json()'s bool overload is used by rgw. it uses JSONObj
defined in common/ceph_json.h to decode JSON-encoded structs.
and it does not differentiate bool from str when decoding a boolean
value despite that it could have check the "quoted" member variable
of JSONObj for validating the type of value. so we should be fine.
Fixes: https://tracker.ceph.com/issues/55189
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
I'm changing "3" to "three" for two reasons:
1. It's correct.
2. This allows me to test backports into Octopus, Pacific, and Quincy.
I am particularly interested to see what happens when I attempt
the backport into Octopus, because backports into Octopus have
failed. This will provide me with another unit of data.
Signed-off-by: Zac Dover <zac.dover@gmail.com>
This is one in a set of PRs meant to keep the Basic
Workflow in the Developer guide current. It refines
the English in the "Integration Tests AKA ceph-qa-suite"
section of "Basic Workflow".
Several other small updates like this are expected. I
intend to avoid refining half of the page in one commit,
as I did last month when I refined the first half of the
basic workflow.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@gmail.com>
before lua script is being executed, we keep the tracer runtime configuration value, and then decides whether to trace or not the request based on the value that maybe changed during lua exeuction, so we can disable/enable tracing for request even if the tracer is in the opposite state at the same time
Signed-off-by: Omri Zeneva <ozeneva@redhat.com>
This PR updates the basic-workflow.rst file
to serve the needs of people in 2022 who were not
present at jump street.
The text has been refined up to the section called
"Integration Tests" (non-inclusive).
Signed-off-by: Zac Dover <zac.dover@gmail.com>
mgr/nfs: clarify in the output message
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Convert all command arguments to str from list, update checks and
adjustments performed on command arguments accordingly and update
documentation to include warnings about some critical parts of
vstart_runner.py and update tasks.cephfs.mount.MountCephFS.run_shell().
Fixes: https://tracker.ceph.com/issues/47849
Signed-off-by: Rishabh Dave <ridave@redhat.com>
The pgcalc tool has moved to the "old" ceph site so update
the link to avoid a 404.
Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
The pgcalc tool has moved to the "old" ceph site so update
the link to avoid a 404.
Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
Fix invalid syntax where "linenos:" was printed in the
final rendered documentation instead of being used as
formatting syntax.
There is no need to use sudo for editing a source file
so run vim without sudo.
Change the whole block to use bash prompt since it is
a command.
Also modify the preceding text to hopefully not bold it.
Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
because bucket object is created only after authentication,
if bucket object is null upon accessing Request.Bucket.Name, we return req_state->init_state.url_bucket
Signed-off-by: Omri Zeneva <ozeneva@redhat.com>
In cephadm service management documentation several of the
ceph orch commands are missing the ceph part, mostly in
ceph orch apply commands but not all of them.
Add ceph in the front of the command to make them consistent
with all other commands.
Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
When we set the proxy mode to remove a writeback cache according to
the ceph official documentation an error occurred:
[root@controller-1 root]# ceph osd tier cache-mode cachepool proxy
Invalid command: proxy not in writeback|readproxy|readonly|none
osd tier cache-mode writeback|readproxy|readonly|none [--yes-i-really-mean-it]:
specify the caching mode for cache tier
According to the description of the official website document: since
a writeback cache may have modified data, you must take steps to ensure
that you do not lose any recent changes to objects in the cache before
you disable and remove it. Change the cache mode to proxy so that new and
modified objects will flush to the backing storage pool.
Fixes: https://tracker.ceph.com/issues/54576
Signed-off-by: tan changzhi <544463199@qq.com>
.. of NFS and ingress services after creating/deleting a NFS cluster.
The `nfs cluster info` command is not sufficient to show that the
NFS cluster is created/deleted as expected.
Signed-off-by: Ramana Raja <rraja@redhat.com>
Description: `!` - Exclamation mark can be used to interact with local
file system apart from Ceph File System too. This PR intends
to document it.
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
