there is no encode/decode funtions for type 'size_t'. We get following
error on OSX:
os/PageSet.h:207:5: error: call to 'encode' is ambiguous
os/MemStore.h:144:7: error: call to 'encode' is ambiguous
Signed-off-by: Yan, Zheng <zyan@redhat.com>
if the size of a bufferlist is page aligned we allocate page aligned
memory chunk for it when rebuild() is called. otherwise we just call
the plain new() to allocate new memory chunk for holding the continuous
buffer. but we should not expect that `new` allocator always returns
unaligned memory chunks. instead, it *could* return page aligned
memory chunk as long as the allocator feels appropriate. so, the
`EXPECT_FALSE(bl.is_page_aligned())` after the `rebuild()` call is
removed.
Signed-off-by: Kefu Chai <kchai@redhat.com>
* implement bufferlist::iterator using bufferlist::iterator_impl
* unlike its cousin, `bufferlist::const_iterator` is not exported using
CEPH_BUFFER_API. will do it once we think it will have external users.
Signed-off-by: Kefu Chai <kchai@redhat.com>
Remove unused variable is_next_available and while loop. These
are leftovers from commit #a69a989f.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Delete mdsmap in descructor. Remove not needed checks for
mds_rank and objecter before call delete since the C++ standard
allows the deletion of pointer with NULL-value. The check is
redundant.
Fix for:
CID 1316224 (#1 of 1): Resource leak in object (CTOR_DTOR_LEAK)
1. alloc_new: Allocating memory by calling new MDSMap.
2. var_assign: Assigning: this->mdsmap = new MDSMap.
3. ctor_dtor_leak: The constructor allocates field mdsmap of MDSDaemon
but the destructor and whatever functions it calls do not free it.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Fix for:
[src/client/Client.cc:4555]: (style) The scope of the variable
'initial_group_count' can be reduced.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Fix for:
[src/mon/ConfigKeyService.cc:94] -> [src/mon/ConfigKeyService.cc:100]:
(warning) Possible null pointer dereference: m - otherwise it is redundant
to check it against null.
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
The RGW error responses must contain a RequestId to be compliant with
the Amazon S3 errors. This RequestId is the ID of the request associated
with the error.
Fixes: #13020
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
It is supposed to be used as a last resort to fix a cluster that has
PGs in 'incomplete' state, using the following procedure:
1) stop the osd that is primary for the incomplete PG;
2) run:
ceph-objectstore-tool --data-path ... --journal-path ... --pgid $PGID --op mark-complete
3) start the osd.
Fixes: #10098
Signed-off-by: Mykola Golub <mgolub@mirantis.com>
Fixes: #13015
Intra zone copy requires that all objects' attributes are preserved.
This was broken at commit: e41d97c8e3
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
