Ronen Friedman
5970ff6637
osd/scrub: add required sub-states to handle queued reservation requests
...
The scrub async reserver is not yet used. All requests are treated as
'legacy' requests, i.e. requests that expect an immediate grant/deny
reply.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2024-01-28 09:40:02 -06:00
Ronen Friedman
c61bca6d6b
osd/scrub: add "queue my request" flag to replica reservation messages
...
Up-to-date primaries will set this flag when sending a reservation
request. The replica OSD, if too busy to handle the request immediately, will queue
it until such time that the number of concurrent reservations is below the
configured limit. The queued requests are honored in FIFO order.
Old primaries will not set this flag, and will receive the expected
grant or deny reply immediately.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2024-01-28 09:40:02 -06:00
Ronen Friedman
c6c05ab639
osd/scrub: add synchronous request to AsyncReserver API
...
To be used when handling replica reservation requests from "old"
primaries, that expect an immediate grant/deny reply.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2024-01-28 09:40:02 -06:00
Matan Breizman
7eb9e33f53
Merge pull request #55281 from Matan-B/wip-matanb-crimson-cyanstore-rmcoll
...
crimson/os/cyanstore: support OP_RMCOLL
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: chunmei-liu <chunmei.liu@intel.com>
2024-01-28 11:22:39 +02:00
zdover23
d55f4b4a8d
Merge pull request #55333 from zdover23/wip-doc-2024-01-27-radosgw-index-verb-disagreement
...
doc/radosgw: fix verb disagreement - index.html
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2024-01-28 18:17:52 +10:00
Zac Dover
9f271093f4
doc/radosgw: fix verb disagreement - index.html
...
Fix a tricky verb disagreement and rewrite a few sentences for what I
hope is greater clarity.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2024-01-28 18:04:57 +10:00
Guillaume Abrioux
327ec975e9
Merge pull request #54423 from guits/dmcrypt-optim
...
ceph-volume: use 'no workqueue' options with dmcrypt
2024-01-27 12:27:42 +01:00
Guillaume Abrioux
f72100bbd1
ceph-volume: fix partitions support in disk.get_devices()
...
The following:
```
is_part = get_file_contents(os.path.join(_sys_dev_block_path, item, 'partition')) == "1"
```
assumes any `/sys/dev/block/x:y/partition` contains '1' which is wrong.
This file actually contains the corresponding partition number.
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2024-01-27 01:29:19 +01:00
Laura Flores
906bf69521
Merge pull request #55323 from ceph/dependabot-github_actions-gregsdennis-dependencies-action-1.3.2
...
.github: Bump gregsdennis/dependencies-action from 1.2.3 to 1.3.2
2024-01-26 16:46:36 -06:00
Laura Flores
15bd38eece
mgr: add CephReleases class to sustainably compare releases
...
Changes how the upmap balancer compares min_mon_release
to account for release names eventually wrapping around the alphabet.
Signed-off-by: Laura Flores <lflores@ibm.com>
2024-01-26 22:41:23 +00:00
Laura Flores
702cb64e87
Merge pull request #55331 from ceph/revert-55096-sjust/for-review/wip-crush-msr
...
Revert "crush: add multistep retry rules"
2024-01-26 16:15:46 -06:00
Guillaume Abrioux
0985e20134
ceph-volume: use 'no workqueue' options with dmcrypt
...
CloudFlare engineers made some testing and realized that using
workqueues with encryption on flash devices has a bad effect.
See [1] for details.
With this patch it will make ceph-volume call crypsetup with
`--perf-no_read_workqueue` and `--perf-no_write_workqueue` options
when the device is not a rotational.
[1] https://blog.cloudflare.com/speeding-up-linux-disk-encryption/
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
Co-Authored-by: Stefan Kooman <stefan@kooman.org>
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
2024-01-26 22:05:30 +01:00
Samuel Just
a5ce9c3863
Revert "crush: add multistep retry rules"
...
This PR was merged by accident before it was ready.
Let's revert for now and open a new PR.
Signed-off-by: Samuel Just <sjust@redhat.com>
2024-01-26 20:32:05 +00:00
Yuri Weinstein
37d5d931b0
Merge pull request #55096 from athanatos/sjust/for-review/wip-crush-msr
...
crush: add multistep retry rules
Reviewed-by: Laura Flores <lflores@redhat.com>
2024-01-26 11:57:53 -08:00
Laura Flores
b5ad8cb325
.github/workflows: update comment to reflect version change
...
Signed-off-by: Laura Flores <lflores@ibm.com>
2024-01-26 09:59:56 -06:00
Casey Bodley
4bdc5d18dd
rgw/rest: fix url decode of post params for iam/sts/sns
...
add the `in_query=true` argument to `url_decode()` to replace '+' with ' '
Fixes: https://tracker.ceph.com/issues/64189
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2024-01-26 09:53:33 -05:00
Casey Bodley
1112689da4
Merge pull request #55303 from cbodley/wip-63130-debug
...
cmake/arrow: don't treat warnings as errors
Reviewed-by: Leonid Usov <leonid.usov@ibm.com>
2024-01-26 14:18:48 +00:00
Ilya Dryomov
2b11aa38ea
Merge pull request #55234 from ajarr/wip-64063
...
rbd-nbd: use netlink interface by default
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2024-01-26 12:37:52 +01:00
Kefu Chai
d813ce1923
Merge pull request #55121 from zhscn/fix-ambiguous-error
...
common: fix ambiguous error when using gcc 13
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2024-01-26 14:42:06 +08:00
Yingxin
3e190e5614
Merge pull request #54896 from cyx1231st/wip-crimson-save-conn-foreign-copy
...
crimson/osd: drop a foreign-copy to shard-0 for every pg operation
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2024-01-26 13:47:37 +08:00
Casey Bodley
ecb4eb14e5
Merge pull request #52496 from adamemerson/wip-rgw-surface-neorados
...
rgw: Surface neorados
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2024-01-26 02:43:44 +00:00
dependabot[bot]
e03f8a8c16
.github: Bump actions/labeler from 4.0.2 to 5.0.0
...
Bumps [actions/labeler](https://github.com/actions/labeler ) from 4.0.2 to 5.0.0.
- [Release notes](https://github.com/actions/labeler/releases )
- [Commits](5c7539237e...8558fd7429
2024-01-25 23:57:22 +00:00
dependabot[bot]
5ae5925a92
.github: Bump gregsdennis/dependencies-action from 1.2.3 to 1.3.2
...
Bumps [gregsdennis/dependencies-action](https://github.com/gregsdennis/dependencies-action ) from 1.2.3 to 1.3.2.
- [Release notes](https://github.com/gregsdennis/dependencies-action/releases )
- [Commits](80b5ffec56...f98d55eee1
2024-01-25 23:57:13 +00:00
Laura Flores
fc4ff1796e
Merge pull request #55308 from ljflores/wip-dependabot
2024-01-25 17:56:29 -06:00
zdover23
77fbe9ead3
Merge pull request #55307 from zdover23/wip-doc-2024-01-25-radosgw-admin-usage
...
doc/radosgw: edit "Usage" admin.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2024-01-26 09:24:13 +10:00
Zac Dover
d8df6f61e8
doc/radosgw: edit "Usage" admin.rst
...
Edit "Usage" in doc/radosgw/admin.rst.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2024-01-26 09:12:59 +10:00
Casey Bodley
93d158711e
Merge pull request #55315 from cbodley/wip-moncommand-dencoder
...
mon: zero-initialize MonCommand::flags
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2024-01-25 17:12:07 +00:00
Ramana Raja
fcbf7367d2
rbd-nbd: map using netlink interface by default
...
Mapping rbd images to nbd devices using ioctl interface is not
robust. It was discovered that the device size or the md5 checksum
of the nbd device was incorrect immediately after mapping using
ioctl method. When using the nbd netlink interface to map RBD images
the issue was not encountered. Switch to using nbd netlink interface
for mapping.
Fixes: https://tracker.ceph.com/issues/64063
Signed-off-by: Ramana Raja <rraja@redhat.com>
2024-01-25 11:00:59 -05:00
Matan Breizman
6a130a7007
crimson/os/cyanstore: support OP_RMCOLL
...
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2024-01-25 15:33:45 +00:00
Casey Bodley
12b7352047
mon: zero-initialize MonCommand::flags
...
causing failures in check-generated.sh:
2 MonCommand
/tmp/typ-qmnDZ1ahR /tmp/typ-lIgJTZiUe differ: byte 100, line 6
**** MonCommand test 1 dump_json check failed ****
ceph-dencoder type MonCommand select_test 1 dump_json > /tmp/typ-qmnDZ1ahR
ceph-dencoder type MonCommand select_test 1 encode decode dump_json > /tmp/typ-lIgJTZiUe
6c6
< "flags": 94661933599904
---
> "flags": 94342467308704
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2024-01-25 09:45:10 -05:00
Ilya Dryomov
f7b52fc712
Merge pull request #55287 from ajarr/wip-64139
...
rbd-nbd: fix resize of images mapped using netlink
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2024-01-25 13:04:26 +01:00
Afreen
946a26c41e
mgr/dashboard: Code refactor rgw migrate component for using correctly the MIGRATE action verb
...
fixes https://tracker.ceph.com/issues/64152
this.MIGRATE = $localize`Migrate to Multi-Site`;
Just like other action verbs we should set this.Migrate = "MIGRATE" only.
This will require rephrasing in the following places as well:
1. d3256c4841/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-multisite-details/rgw-multisite-details.component.ts (L223-L228)d3256c4841/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-multisite-migrate/rgw-multisite-migrate.component.ts (L180-L18)
2024-01-25 17:20:35 +05:30
Nizamudeen A
a70dc48d48
Merge pull request #55270 from afreen23/fix-cap-inconsistency-multisite
...
mgr/dashboard: Fix inconsistency in capitalisation of "Multi-site"
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: rosinL <NOT@FOUND>
2024-01-25 15:40:43 +05:30
Redouane Kachach
463716e64d
Merge pull request #55182 from rkachach/fix_issue_64029
...
mgr/rook: adding some basic rook e2e testing
2024-01-25 10:23:43 +01:00
Venky Shankar
2a6c1dc36d
qa: fs volume rename requires fs fail and refuse_client_session set
...
Introduced-by: fe3a4b9683http://tracker.ceph.com/issues/64174
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2024-01-25 12:08:50 +05:30
Samuel Just
000188f2ba
Merge pull request #55266 from athanatos/sjust/wip-63996
...
crimson: retain map references in OSDSingletonState::store_maps
Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2024-01-24 21:05:09 -08:00
Samuel Just
db3addf01c
crimson/osd/shard_services: retain map references in OSDSingletonState::store_maps
...
Introduced: 3f11cd94https://tracker.ceph.com/issues/63996
Signed-off-by: Samuel Just <sjust@redhat.com>
2024-01-25 03:02:06 +00:00
Samuel Just
cb02911686
crimson/osd/shard_service.cc: convert to newer logging machinery
...
Signed-off-by: Samuel Just <sjust@redhat.com>
2024-01-25 03:02:06 +00:00
Samuel Just
6ad175f0b9
crimson/osd/osd.cc: migrate logging to new style
...
Signed-off-by: Samuel Just <sjust@redhat.com>
2024-01-25 03:02:04 +00:00
Samuel Just
3eebce4aab
Merge pull request #55288 from athanatos/sjust/wip-64140
...
Revert "crimson/os/alienstore/alien_log: _flush concurrently"
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2024-01-24 17:23:47 -08:00
Adam Emerson
0e584be902
rgw: Thread site config into RADOS driver
...
Make this available so multisite sync doesn't have to rely on the zone
service.
Signed-off-by: Adam Emerson <aemerson@redhat.com>
2024-01-24 16:59:58 -05:00
Adam C. Emerson
dc262061fe
rgw: Asio frontend shares io_context with the rest of RGW
...
Pull the `io_context` and threads out of `AsioFrontend`, pass in a
reference to `io_context_pool` so it can be shut down at `AsioFrontend::join`
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2024-01-24 16:59:56 -05:00
Yuri Weinstein
5ddd51e819
Merge pull request #54987 from batrick/i63822
...
pybind/mgr/devicehealth: skip legacy objects that cannot be loaded
Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
Reviewed-by: Yaarit Hatuka <yaarithatuka@gmail.com>
2024-01-24 13:31:31 -08:00
Yuri Weinstein
e538587e18
Merge pull request #54491 from jianwei1216/fix_osd_pg_stat_report_interval_max_cmain
...
fix: resolve inconsistent judgment of osd_pg_stat_report_interval_max
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <Matan.Brz@gmail.com>
2024-01-24 13:30:50 -08:00
Yuri Weinstein
6bba2bc173
Merge pull request #53250 from YiteGu/add-perfcount-for-allocator
...
os/bluestore: add perfcount for bluestore/bluefs allocator
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
2024-01-24 13:30:07 -08:00
Yuri Weinstein
2fac6737f8
Merge pull request #52530 from amathuria/wip-amat-fix-59531
...
osd: Add memstore to unsupported objstores for QoS
Reviewed-by: Sridhar Seshasayee <sseshasa@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2024-01-24 13:28:16 -08:00
Adam C. Emerson
7c4eee61c4
rgw: SAL drivers take boost::asio::io_context
...
`RadosDriver` needs it, and since SAL generally uses `optional_yield`,
other stores are going to need it to implement that sensibly.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2024-01-24 15:51:46 -05:00
Adam C. Emerson
82a40dc151
ceph/async: io_context_pool constructor/start takes init function
...
Add overloads of the constructor and `start` that take an init
function, for setting up the thread before dropping into
`io_context::run`.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2024-01-24 15:51:46 -05:00
Adam C. Emerson
c7789f10fe
common/async: io_context_pool constructor takes int64_t
...
Just because this is what Ceph's config uses and it saves a narrowing
conversion. If we want to set a max value on the thread count, we
should do it in config.
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2024-01-24 15:51:46 -05:00
Adam Emerson
809e1304b0
include/inline_memory.h: Add missing includes to fix build
...
Signed-off-by: Adam Emerson <aemerson@redhat.com>
2024-01-24 15:51:46 -05:00
