os/bluestore: move aio_callback{,_priv} to base class BlockDevice
Reviewed-by: Pan Liu <liupan1111@gmail.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
In case this is the last crush rule which is still referencing
a specific device class. Otherwise the device class might stay
hanging.
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Drop the unnecessary polling_stop() in the ~RDMAStack(). The RDMADispatcher object contained in
RDMAStack will get distroyed when RDMAStack gets distroyed. Thus ~RDMADispatcher() will be
called automatically and executes the polling_stop().
Fixes:
The below coverity scan reports.
1. CID 1416590: Memory - corruptions
2. CID 1416593: Memory - illegal accesses
3. CID 1416595: Memory - corruptions
4. CID 1416597: Memory - illegal accesses
Signed-off-by: Jos Collin <jcollin@redhat.com>
rbd-mirror: Set the data pool correctly when creating images
Reviewed-by: Mykola Golub <mgolub@mirantis.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Return osd_min_pg_log_entries to its original values, which matches
osd_pg_log_dups_tracked, so the extended dup log is not used in the
general case.
This helps address: http://tracker.ceph.com/issues/21026
Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
Previously the data-pool option was ignored by rbd-mirror, so when using
erasure coding data for the image on the secondary site would end up in
the metadata pool.
Configure the data-pool using the data-pool's name from the primary site
when creating images on the secondary site.
Fixes: http://tracker.ceph.com/issues/20567
Signed-off-by: Adam Wolfe Gordon <awg@digitalocean.com>
(cherry picked from commit dffaac83d1)
rpm expands all macros in a .spec file, even those in comments. Drop the
percent signs so rpm will not expand these.
This change silences rpmlint's warning about macros in comments.
Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
Fixes the coverity issue:
** 717332 Uninitialized pointer field
2. uninit_member: Non-static class member field iocb.data is not
initialized in this constructor nor in any functions that it calls.
4. uninit_member: Non-static class member field iocb.key is not
initialized in this constructor nor in any functions that it calls.
6. uninit_member: Non-static class member field iocb.__pad2 is not
initialized in this constructor nor in any functions that it calls.
8. uninit_member: Non-static class member field iocb.aio_lio_opcode
is not initialized in this constructor nor in any functions that it calls.
10. uninit_member: Non-static class member field iocb.aio_reqprio
is not initialized in this constructor nor in any functions that it calls.
CID 717332 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
12. uninit_member: Non-static class member field iocb.aio_fildes is not
initialized in this constructor nor in any functions that it calls.
Signed-off-by: Amit Kumar amitkuma@redhat.com
if init fails to connect to a monitor, we just exit(1), there is no need
to set the `r` or lock the grand osd_lock for this. this change also
silences the warning of clang analyzer:
Value stored to 'r' is never read
Signed-off-by: Kefu Chai <kchai@redhat.com>
Support Filter tag in Lifecycle XML similar to AWS S3, while S3 docs
mention that this tag is mandatory, older clients still default to
Prefix, and S3 itself seems to relaxed in enforcing the rule, this
implementation also follows a similar pattern. Filter optionally
supports filtering via (multiple) Object Tags, this is still a TODO. The
current implementation of object tags is still as an object xattr, and
since the LC processing still iterates over the bucket index which
currently doesn't have any info. on tags, this requires some thought
into for implementing without a larger performance penalty
Fixes: http://tracker.ceph.com/issues/20872
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
do not enable lz4 compressor plugin unless HAVE_LZ4 is ON. so, for
example, when the compressor type is "random", the compressor factory
won't complain with:
load failed dlopen(): "/usr/lib64/ceph/compressor/libceph_lz4.so: cannot
open shared object file: No such file or directory"
anymore.
Signed-off-by: Kefu Chai <kchai@redhat.com>
This command returns all crush rules that are currently
referencing the device class specified by user.
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Fixes te coveity issue:
** 1316251 Uninitialized pointer field
CID 1316251 (#1 of 1): Uninitialized pointer field (UNINIT_CTOR)
2. uninit_member: Non-static class member mon_client is not initialized
in this constructor nor in any functions that it calls.
Signed-off-by: Amit Kumar amitkuma@redhat.com
* refs/remotes/upstream/pull/16891/head:
mds/MDSDaemon: add 'is_valid=false' when failed to parse caps
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
libfuse already does not set FUSE_SET_ATTR_UID if the chown uid is -1. However,
another libcephfs client could call setattr directly with -1 as the uid/gid so we
should handle that potential case.
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
