Commit Graph

77457 Commits

Author SHA1 Message Date
Kefu Chai
953a8caaa5 mon/OSDMonitor: check creating_pgs.last_scan_epoch instead when sending creates
we cannot be sure that the creating_pgs_by_osd_epoch is in sync with
creating_pgs.pgs even if mapping.get_epoch() is less or equal to
creating_pgs_epoch. because, 1) the access to mapping.epoch is not
protected by lock, 2) even worse, the mapping might be not finished yet
when we are trying to send pg-creates to subscribers.

so instead of comparing creating_pgs_epoch with mapping's epoch, we
should compare it with creating_pgs.last_scan_epoch. the former is
updated once the creating_pgs_by_osd_epoch is updated with the latest
mapping's epoch and creating_pgs.pgs; the latter is updated with current
osdmap's epoch when creating_pgs is being updated with the inc osd map.
if we are using a creating_pgs_epoch in sync, creating_pgs_epoch should
be creating_pgs.last_scan_epoch + 1.

Fixes: http://tracker.ceph.com/issues/20785
Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-08-25 14:34:35 +08:00
Josh Durgin
4c8fd99783 Revert "osd: adjust osd_min_pg_log_entries"
This reverts commit 1c4df03394.

Signed-off-by: Josh Durgin <jdurgin@redhat.com>
2017-08-25 01:02:59 -04:00
Josh Durgin
75af72f758 osd/PGLog: write only changed dup entries
Writing all of the dup entries whenever one is changed causes a large
regression in performance.

Instead, keep track of ranges that need to be cleared and written
after log merging (dirty_{to,from}_dups) and the earliest dup entry we
haven't written yet during normal operation (write_from_dups). This
parallels the way we track unpersisted log entries.

Check that the correct set of dups is persisted by adding a roundtrip
through memstore to each merge_log unit test.

Fixes: http://tracker.ceph.com/issues/21026
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
2017-08-25 01:02:58 -04:00
Kefu Chai
80a5556fac Merge pull request #16960 from jcsp/wip-20692
mgr/dashboard: fix FS status on old MDS daemons

Reviewed-by: Kefu Chai <kchai@redhat.com>
2017-08-25 13:02:46 +08:00
Kefu Chai
d2d941dd19 osd/PGBackend: release a msg using msg->put() not delete
fix the regression introduced by 1c18b5cb

Fixes: http://tracker.ceph.com/issues/20913
Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-08-25 10:41:58 +08:00
Sage Weil
13577a4f35 os/bluestore: print leaked extents to debug output
Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-24 22:31:39 -04:00
Yuri Weinstein
1f8cfd6dc5 Merge pull request #17142 from Songweibin/wip-unused-variable
osd/PG: drop unused variable "oldest_update" in PG.h

Reviewed-by: Kefu Chai <kchai@redhat.com>
2017-08-24 13:13:42 -07:00
Yuri Weinstein
4d058844a4 Merge pull request #17171 from xiexingguo/wip-dedup-ec-want-acting
osd/PG: two cleanups

Reviewed-by: Kefu Chai <kchai@redhat.com>
2017-08-24 13:13:15 -07:00
Sage Weil
8d265ca2f6 Merge pull request #17243 from liewegas/wip-min-size-stuck
qa/overrides/2-size-2-min-size: whitelist REQUEST_STUCK
2017-08-24 14:51:21 -05:00
Sage Weil
805455274e qa/overrides/2-size-2-min-size: whitelist REQUEST_STUCK
With min_size == size things can get stuck a very long time.

Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-24 15:50:45 -04:00
Neha Ojha
834ab275b7 mon: warn about using osd new instead of osd create
Signed-off-by: Neha Ojha <nojha@redhat.com>
2017-08-24 12:46:41 -07:00
Sage Weil
3e7ac52a58 Merge pull request #17224 from liewegas/wip-ceph-deploy-mgr
qa/tasks/ceph_deploy: gatherkeys before mgr deploy

Reviewed-by: Vasu Kulkarni <vasu@redhat.com>
2017-08-24 12:41:31 -05:00
Kefu Chai
457c145aef Merge pull request #17083 from xiexingguo/wip-swap-bucket
crush: force rebuilding shadow hierarchy after swapping buckets

Reviewed-by: Sage Weil <sage@redhat.com>
2017-08-24 23:15:38 +08:00
Kefu Chai
8ed5fe0f32 Merge pull request #17033 from mychoxin/yuanxin_put_assert_to_base
os/bluestore: move assert of read/write to base class

Reviewed-by: Jianpeng Ma <jianpeng.ma@intel.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2017-08-24 23:09:03 +08:00
Kefu Chai
46de2caa18 Merge pull request #17058 from xiexingguo/wip-crush-compiler
crush: fix CrushCompiler won't compile maps with empty shadow tree

Reviewed-by: Sage Weil <sage@redhat.com>
2017-08-24 23:05:58 +08:00
Kefu Chai
b5f64dd5df Merge pull request #17034 from xiexingguo/wip-class-ls-osd
mon/OSDMonitor: add plain output for "crush class ls-osd" command

Reviewed-by: Sage Weil <sage@redhat.com>
2017-08-24 23:05:12 +08:00
Kefu Chai
2df0815e51 Merge pull request #17179 from xiexingguo/wip-crush-smoke-test
mon/OSDMonitor: fix improper input/testing range of crush somke testing

Reviewed-by: Kefu Chai <kchai@redhat.com>
2017-08-24 23:04:21 +08:00
Kefu Chai
6d271abb32 Merge pull request #17183 from tchaikov/wip-20913
osd/PGBackend: delete reply if fails to complete delete request

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2017-08-24 22:33:31 +08:00
Sage Weil
893b3ac6fa Merge pull request #17227 from liewegas/wip-jewel-x
qa/suites/upgrade/jewel-x/parallel: tolerate laggy mgr
2017-08-24 09:30:31 -05:00
Sage Weil
bf296018ff qa/suites/upgrade/jewel-x/parallel: tolerate laggy mgr
Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-24 10:30:01 -04:00
Sage Weil
d3632fd2f9 Merge pull request #17226 from liewegas/wip-jewel-x
qa/suites/upgrade/jewel-x/stress-split: tolerate sloppy past_intervals
2017-08-24 09:27:44 -05:00
Sage Weil
d5d5d7d1d2 qa/suites/upgrade/jewel-x/stress-split: tolerate sloppy past_intervals
This is harmless in general, esp during upgrade.

Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-24 10:23:22 -04:00
Sage Weil
800fdd9953 qa/tasks/ceph_deploy: gatherkeys before mgr deploy
Otherwise we may be missing the bootstrap-mgr key.

Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-24 09:52:17 -04:00
Sage Weil
511f71c10d Merge pull request #17190 from amitkumar50/cov-test-1
test: Checking fd for negative before closing

Reviewed-by: Sage Weil <sage@redhat.com>
2017-08-24 08:41:07 -05:00
amitkuma
1666d9aa81 test: Checking fd for negative before closing
Fixes the coverity issue:

** 1395317 Argument cannot be negative
161. negative_return_fn: Function open("bufferlist", 0) returns a
negative number.
162. var_assign: Assigning: signed variable fd = open.

Signed-off-by: Amit Kumar amitkuma@redhat.com
2017-08-24 22:48:02 +05:30
Kefu Chai
3704fe283b common/options: use user-defined literals for default intervals
for better readablility

Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-08-24 17:24:02 +08:00
Kefu Chai
d9b38a1d61 common/options: use user-defined literals for default sizes
for better readablity.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2017-08-24 17:24:02 +08:00
xie xingguo
05666c3af2 osd/PrimaryLogPG: do_osd_ops - propagate EAGAIN/EINPROGRESS on failok
These are not really errors and ignoring these error codes can
cause potential problems.

Propagating these errors to high-level callers such as execute_ctx()
where they can be taken good care of should instead be the preferred
option.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2017-08-24 16:56:29 +08:00
xie xingguo
4ad25c3462 osd/PrimaryLogPG: fix sparse read won't trigger repair correctly
Normal reads instead of hole-reads should trigger auto-repair.
Also we shall quit on successfully triggering a repair, or else
we are at risk of doing the op multiple times.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2017-08-24 16:03:44 +08:00
Yan Jun
759b753e99 test/librbd: fix mock method macro of set_journal_policy
Signed-off-by: Yan Jun <yan.jun8@zte.com.cn>
2017-08-24 15:02:46 +08:00
Patrick Donnelly
270f1edaae
Merge PR #17205 into master
* refs/remotes/upstream/pull/17205/head:
	client: fix locking in Client::getcwd

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2017-08-23 20:48:22 -07:00
Patrick Donnelly
7a317809b3
Merge PR #17204 into master
* refs/remotes/upstream/pull/17204/head:
	fuse: use c++ allocations for group list

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2017-08-23 20:48:20 -07:00
Patrick Donnelly
7952d66db2
Merge PR #17199 into master
* refs/remotes/upstream/pull/17199/head:
	client: fix compat version on MStatfs

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Douglas Fuller <dfuller@redhat.com>
2017-08-23 20:48:13 -07:00
Kefu Chai
49c65c73f2 Merge pull request #17121 from zmedico/PGPool-update-optimize-with-interval_set-swap
PGPool::update: optimize with interval_set.swap

Reviewed-by: Kefu Chai <kchai@redhat.com>
2017-08-24 09:22:53 +08:00
Xie Xingguo
bedec98a90 Merge pull request #17014 from xiexingguo/wip-various-weight-set-fix
crush: various weight-set fixes

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
2017-08-24 08:29:50 +08:00
Xie Xingguo
e0ff2b38f8 Merge pull request #17099 from xiexingguo/wip-stuck-op-count
mon/PGMap: fix "0 stuck requests are blocked > 4096 sec" warn

Reviewed-by: Kefu Chai <kchai@redhat.com>
2017-08-24 08:21:36 +08:00
Sage Weil
4f1fca0483 Merge pull request #17203 from liewegas/wip-jewel-x
qa/suites/upgarde/jewel-x/parallel: tolerate mgr warning
2017-08-23 17:21:37 -05:00
Alfredo Deza
6bf848c6ce Merge pull request #17207 from ceph/wip-bz1484002
ceph-volume: use unique logical volumes

Reviewed-by: Andrew Schoen <aschoen@redhat.com>
2017-08-23 17:43:19 -04:00
Yehuda Sadeh
0c23c42678 Merge pull request #12429 from yehudasa/wip-meta-stream
rgw: stream metadata full sync init

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2017-08-23 12:59:19 -07:00
Matt Benjamin
25ffe9c30d Merge pull request #16926 from fangyuxiangGL/infinitely-send-data-log-list
rgw: break sending data-log list infinitely
2017-08-23 15:57:41 -04:00
Matt Benjamin
1e1731e663 Merge pull request #16612 from cbodley/wip-20668
rgw: fixes for multisite replication of encrypted objects
2017-08-23 15:57:02 -04:00
Alfredo Deza
fbce7ad593 ceph-volume tests centos7 use the new ansible syntax for lvm
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-08-23 15:37:42 -04:00
Alfredo Deza
8f0f202ec4 ceph-volume tests use the new ansible syntax for lvm
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-08-23 15:37:42 -04:00
Alfredo Deza
7584d64c0f ceph-volume tests create tests for the get_lv helper method
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-08-23 15:37:42 -04:00
Alfredo Deza
d5eb9640aa ceph-volume tests create tests for the new arg validator
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-08-23 15:37:42 -04:00
Alfredo Deza
0ce77806bd ceph-volume util create a validator module for argparse
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-08-23 15:37:42 -04:00
Alfredo Deza
192fe4e1dd ceph-volume lvm.prepare enforce usage of vg/lv when preparing lvm devices
Signed-off-by: Alfredo Deza <adeza@redhat.com>
2017-08-23 15:37:41 -04:00
Sage Weil
5455f599b3 qa/suites/upgrade/jewel-x/parallel: tolerate OBJECT_MISPLACED
Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-23 14:24:00 -04:00
Sage Weil
2504ab1675 qa/suites/upgarde/jewel-x/parallel: tolerate mgr warning
Signed-off-by: Sage Weil <sage@redhat.com>
2017-08-23 14:22:34 -04:00
Patrick Donnelly
2084b96de4
Merge PR #17175 into master
* refs/remotes/upstream/pull/17175/head:
	client: add blank space between function name and inode number for log

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2017-08-23 10:56:09 -07:00