Commit Graph

20921 Commits

Author SHA1 Message Date
Sage Weil
2214e83851 omap_bench: fix uninit var
Coverity cid 717386
Signed-off-by: Sage Weil <sage@inktank.com>
2012-08-31 13:11:04 -07:00
Sage Weil
20372126d9 test/osd/RadosModel: uninit value
Coverity cid 717388 717387
Signed-off-by: Sage Weil <sage@inktank.com>
2012-08-31 13:11:04 -07:00
Sage Weil
26a822bc7d test/osd/RadosModel: fix uninit value
Coverity cid 717389
Signed-off-by: Sage Weil <sage@inktank.com>
2012-08-31 13:11:04 -07:00
Sage Weil
7c10bdc3a5 test/osd/RadosModel: fix uninit values
Coverity cid 717390
Signed-off-by: Sage Weil <sage@inktank.com>
2012-08-31 13:11:04 -07:00
Sage Weil
8d9d4f6154 test/osd/RadosModel: fix uninit ptr
Coverity cid 717391
Signed-off-by: Sage Weil <sage@inktank.com>
2012-08-31 13:11:04 -07:00
Sage Weil
1247d4d557 test/rados-api/aio: fix uninit ptr
Coverity cid #717392
Signed-off-by: Sage Weil <sage@inktank.com>
2012-08-31 13:11:04 -07:00
Sage Weil
220980c9b6 cephtool: fix uninitialized scalar in constructor
Signed-off-by: Sage Weil <sage@inktank.com>
2012-08-31 13:11:03 -07:00
Sage Weil
998e207913 test/Object: comment out dead code
Coverity cid #717397
Signed-off-by: Sage Weil <sage@inktank.com>
2012-08-31 13:11:03 -07:00
Sage Weil
97bd084853 mds: fix unused value
This value was never used before it was clobbered.

Coverity cid #717398
Signed-off-by: Sage Weil <sage@inktank.com>
2012-08-31 13:11:03 -07:00
Sage Weil
b9adc27b3a mds: drop unused value
Coverity cid #717400
Signed-off-by: Sage Weil <sage@inktank.com>
2012-08-31 13:11:03 -07:00
Sage Weil
1355a676f6 filer: add missing return
Coverity cid 717404
Signed-off-by: Sage Weil <sage@inktank.com>
2012-08-31 13:11:03 -07:00
Sage Weil
a6dfa3e5b1 rgw: fix use-after-free
Coverity cid 717405
Signed-off-by: Sage Weil <sage@inktank.com>
2012-08-31 13:11:03 -07:00
Sage Weil
ec0a266245 test_librbd: add missing va_end()
Coverity cid 717407
Signed-off-by: Sage Weil <sage@inktank.com>
2012-08-31 13:11:03 -07:00
Josh Durgin
82999c0e49 Merge branch 'wip-rbd-children' 2012-08-30 16:06:49 -07:00
Josh Durgin
649bdc15d3 doc: clarify rbd man page (esp. layering)
* a clone's size can't be overridden
* note which commands require format 2
* clarify details of copy
* add examples for cloning
* add pool to map example for consistency
* fix a couple warnings and re-sync man page with rst

Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
2012-08-30 14:34:49 -07:00
Josh Durgin
dcbb87cc0c rbd: add --format option
This chooses whether to use the original (supported by krbd)
or the new (supports layering) format.

Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
2012-08-30 14:34:49 -07:00
Sage Weil
1b27a7cd4d client: renew/submit subs on startup
This fixes a delay in getting the initial MDSMap during startup (we wait
for the MonClient tick()).

Reported-by: Noah Watkins <jayhawk@cs.ucsc.edu>
Signed-off-by: Sage Weil <sage@inktank.com>
2012-08-30 14:03:11 -07:00
John Wilkins
a23351efda :doc: Added constraints and revised a description per joshd.
Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2012-08-30 11:48:47 -07:00
Tommi Virtanen
f2c4510848 upstart, ceph-create-keys: Make client.admin key generation automatic.
This should help simplify Chef etc deployments. Now (when using the
Upstart jobs), when a ceph-mon is started, ceph-create-admin-key is
triggered. If /etc/ceph/$cluster.client.admin.keyring already exists,
it does nothing; otherwise, it waits for ceph-mon to reach quorum, and
then does a "ceph auth get-or-create" to create the key, and writes it
atomically to disk.

The equivalent code can be removed from the Chef cookbook once this is
in.
2012-08-30 13:41:20 -04:00
Tommi Virtanen
0de719567f upstart: Make instance jobs export their cluster and id variables.
This allows other jobs listening to Upstart "started ceph-mon" events
to see what instance started.

Signed-off-by: Tommi Virtanen <tv@inktank.com>
2012-08-30 10:25:07 -04:00
Tommi Virtanen
3b0e2a2d98 config: Add a per-name default keyring to front of keyring search path.
This lets us have e.g. /etc/ceph/ceph.client.admin.keyring that is
owned by root:admin and mode u=rw,g=r,o= without making every non-root
run of the command line tools complain and fail.

This is what the Chef cookbook has been doing for a while already.
2012-08-30 10:25:07 -04:00
John Wilkins
8b4a9ade32 doc: Modified index page with table. Pools and Auth will go to Ops.
Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2012-08-30 00:38:01 -07:00
John Wilkins
b961a660be doc: Some improvements. This still needs review.
Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2012-08-30 00:37:02 -07:00
John Wilkins
c41fa39460 doc: Added additional note to mount data disk to data path.
Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2012-08-30 00:35:31 -07:00
John Wilkins
b80a1b73ed doc: Added a document for general config settings.
Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2012-08-30 00:33:58 -07:00
John Wilkins
2407b0cdef doc: Added a doc for filestore settings.
Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2012-08-30 00:29:14 -07:00
John Wilkins
17dee291e8 doc: Added a document for RBD cache settings.
Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2012-08-30 00:28:29 -07:00
John Wilkins
69e10167f4 doc: Added substantial detail to OSD setting descriptions.
Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2012-08-30 00:26:38 -07:00
John Wilkins
c0c9fe5400 doc: minor edit to use # for comments.
Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2012-08-30 00:25:17 -07:00
John Wilkins
98eaaccd13 doc: Restructured ceph config. Added network and OSD config details.
Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2012-08-30 00:24:26 -07:00
Josh Durgin
3c9bc47a4d librbd: prevent racing clone and snap unprotect
If the following sequence of events occured,
a clone could be created of an unprotected snapshot:

1. A: begin clone - check that snap foo is protected
2. B: rbd unprotect snap foo
3. B: check that all pools have no clones of foo
4. B: unprotect snap foo
5. A: finish creating clone of foo, add it as a child

To stop this from happening, check at the beginning and end of
cloning that the parent snapshot is protected. If it is not,
or checking protection status fails (possibly because the parent
snapshot was removed), remove the clone and return an error.

Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
2012-08-29 17:35:28 -07:00
Dan Mick
465fcca1fe rbd: add "children" command, update cli test files
Fixes: #2720
Signed-off-by: Dan Mick <dan.mick@inktank.com>
Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
2012-08-29 17:35:27 -07:00
Dan Mick
78f69752a4 librbd: add {rbd_}list_children() methods
These iterate over all pools and check for children of a
particular snapshot.

Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
Reviewed-by: Dan Mick <dan.mick@inktank.com>
2012-08-29 17:35:27 -07:00
Yehuda Sadeh
4d9802c414 rgw: remove unused block of code
We were reading bucket info, but that wasn't necessary.

Signed-off-by: Yehuda Sadeh <yehuda@inktank.com>
2012-08-29 14:20:38 -07:00
caleb miles
e3834f023b rgw_admin.cc: Prevent clobbering the index when linking a bucket.
Prevent the 'bucket link' command from overwriting the index of an
existing bucket. Corrects bug 2935:

http://tracker.newdream.net/issues/2935

Signed-off-by: caleb miles <caleb.miles@inktank.com>
2012-08-29 12:45:13 -07:00
Yehuda Sadeh
82c62bd977 rgw: clear usage map before reading usage
Fixes: #3057
Since we read usage in chunks we need to clear the
usage map before reading the next chunk, otherwise
we're going to aggregate the old data as well.

Backport: argonaut
Signed-off-by: Yehuda Sadeh <yehuda@inktank.com>
2012-08-28 16:47:41 -07:00
Sage Weil
0052a78726 Merge branch 'next' 2012-08-28 15:15:08 -07:00
Sage Weil
5f36b8d784 osd: fix waiting_for_disk assertion
If requeue is false, we won't have cleared out waiting_for_ondisk; adjust
assert placement as appropriate.  Also, make sur we handle the requeue
and !op case properly (although I'm not sure offhand if/when it would
come up).

Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Samuel Just <sam.just@inktank.com>
2012-08-28 15:14:41 -07:00
Mike Ryan
745a3c9ba0 rados_bench: wait for completion callbacks before returning
If we don't wait for the callback, the finisher may cleanup the callback
context before the callback is actually invoked, causing a
use-after-free error.

This fixes #3048.

Signed-off-by: Mike Ryan <mike.ryan@inktank.com>
2012-08-28 14:21:13 -07:00
Yehuda Sadeh
dfb7f80409 Makefile.am: add missing .h
Was missing rgw_html_errors.h

Signed-off-by: Yehuda Sadeh <yehuda@inktank.com>
2012-08-28 14:13:53 -07:00
Yehuda Sadeh
0ab6232503 Merge remote-tracking branch 'origin/wip-multi-delete'
Conflicts:
	src/Makefile.am

Signed-off-by: Yehuda Sadeh <yehuda@inktank.com>
2012-08-28 13:36:35 -07:00
Mike Ryan
2d79a62a11 rados_bench: wait for completion callbacks before returning
If we don't wait for the callback, the finisher may cleanup the callback
context before the callback is actually invoked, causing a
use-after-free error.

This fixes #3048.

Signed-off-by: Mike Ryan <mike.ryan@inktank.com>
2012-08-28 13:28:52 -07:00
John Wilkins
a7867c27cb doc: Completed and reviewed RGW config reference.
Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2012-08-28 13:25:44 -07:00
John Wilkins
8d7912cba0 doc: added admonishment. Updated header syntax, copy semantics and x-ref.
Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2012-08-28 13:24:29 -07:00
Yehuda Sadeh
5507665a58 rgw: fix usage log read
The usage log read got broken in a recent cleanup work.

Signed-off-by: Yehuda Sadeh <yehuda@inktank.com>
2012-08-28 12:51:55 -07:00
John Wilkins
3eea9104af doc: Added internal references. Clarified language in disk prepare.
Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2012-08-28 11:41:59 -07:00
John Wilkins
a466dfff2d doc: added sudo for hdparm command.
Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2012-08-28 11:02:13 -07:00
John Wilkins
080e5722b3 doc: added internal hyperlink targets.
Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2012-08-28 10:55:04 -07:00
John Wilkins
dd011aba90 doc: Clean up quick start to ensure nobody uses "localhost".
Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2012-08-28 10:01:20 -07:00
John Wilkins
9755466619 doc: Cleaned up syntax errors, and converted table to list.
Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2012-08-28 09:24:22 -07:00