Commit Graph

35851 Commits

Author SHA1 Message Date
Danny Al-Gaaf
f29e5b3382 mount.ceph.c: free memory before return
CID 1219610 (#1 of 1): Resource leak (RESOURCE_LEAK)
 leaked_storage: Variable buf going out of scope leaks the
  storage it points to.
 leaked_storage: Variable mount_path going out of scope leaks
  the storage it points to.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-09-04 13:57:58 +02:00
Danny Al-Gaaf
903af9c4ac st_rados_create_pool.cc: cleanup before return from run()
CID 739605 (#1 of 1): Resource leak (RESOURCE_LEAK)
 leaked_storage: Variable io_ctx going out of scope leaks the
 storage it points to.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-09-04 13:01:11 +02:00
Danny Al-Gaaf
ece990dc04 rados_list_parallel.cc: cleanup before return from run()
Fix for:

CID 717112 (#1 of 1): Resource leak (RESOURCE_LEAK)
 leaked_storage: Variable io_ctx going out of scope leaks
 the storage it points to.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-09-04 12:20:11 +02:00
Loic Dachary
135ccad117 erasure-code: warning fix
Signed-off-by: Loic Dachary <loic-201408@dachary.org>
2014-09-04 10:14:03 +02:00
Loic Dachary
36554f90eb Merge pull request #2392 from majianpeng/fix1
FileStore: Remove unused code.

Reviewed-by: Loic Dachary <loic@dachary.org>
2014-09-04 10:04:28 +02:00
Ma Jianpeng
7de8d17d2f FileStore: Remove unused code.
Signed-off-by: Ma Jianpeng <jianpeng.ma@intel.com>
2014-09-04 14:01:20 +08:00
Gregory Farnum
1bcf40459c Merge pull request #2373 from ceph/wip-9026
client: vxattr support for stat

Reviewed-by: Greg Farnum <greg@inktank.com>
2014-09-03 21:08:15 -07:00
Yan, Zheng
41df414bfb mds: don't take mds_lock when doing journal operations
Now journaler and objecter have internal locks to protect themself, there is
no need to take the mds_lock before using journaler and objecter.

Signed-off-by: Yan, Zheng <zyan@redhat.com>
2014-09-04 11:31:01 +08:00
Danny Al-Gaaf
7ccabbf91f librbd.cc: add check to prevent null deref in rbd_list()
Fix for :

CID 1192467 (2 of 2): Explicit null dereferenced (FORWARD_NULL)
 var_deref_model: Passing null pointer ibuf to rbd_list,
 which dereferences it.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-09-03 22:59:30 +02:00
Jason Dillaman
4f35714f12 Parallelize RBD import/export
Use librbd aio_read/_write calls where possible to improve speed.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2014-09-03 13:27:32 -04:00
Danny Al-Gaaf
f53bf5320c PendingIO.cc: use static_cast instead of c-style cast
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-09-03 17:52:00 +02:00
Danny Al-Gaaf
cbd324da59 FileStore.cc: use static_cast instead of c-style cast
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-09-03 17:51:04 +02:00
John Spray
eadc352d45 Merge remote-tracking branch 'origin/next' 2014-09-03 13:52:32 +01:00
John Spray
0f92657d59 Merge pull request #2377 from ceph/wip-session-stats
mds: cap and lease count in `session ls` asok

Reviewed-by: Yan, Zheng <ukernel@gmail.com>
2014-09-03 13:39:25 +01:00
John Spray
ebd1152944 Merge pull request #2376 from ceph/wip-request-count
mds: Fix Session::get_request_count

Reviewed-by: Yan, Zheng <ukernel@gmail.com>
2014-09-03 13:39:19 +01:00
Yan, Zheng
ca6eb61285 client: vxattr support for rstat
copy the kernel client code (which uses table to present vxattrs)

Signed-off-by: Yan, Zheng <zyan@redhat.com>
2014-09-03 06:30:24 +08:00
Samuel Just
299f28b0eb Merge pull request #2363 from ceph/wip-9285
osd/ReplicatedPG: do not evict blocked objects

Reviewed-by: Samuel Just <sam.just@inktank.com>
2014-09-02 14:09:55 -07:00
John Spray
8657022cc8 Merge pull request #2343 from ceph/wip-9151
Wip 9151 + 9152

Reviewed-by: Sage Weil <sage@redhat.com>
2014-09-02 22:02:59 +01:00
Samuel Just
d0e0eb47e9 Merge pull request #2362 from ceph/wip-9294
osd/ReplicatedPG: avoid dereferencing iterator at end()

Reviewed-by: Samuel Just <sam.just@inktank.com>
2014-09-02 12:47:51 -07:00
John Wilkins
ed62ae58cd Merge pull request #2322 from ceph/wip-doc-authentication
doc: Refactored authentication docs.

Reviewed-by: John Wilkins <john.wilkins@inktank.com>
2014-09-02 11:40:22 -07:00
John Wilkins
c2443b9584 doc: Provided additional detail on daemon-specific caps syntax.
Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2014-09-02 11:38:16 -07:00
John Wilkins
8569b93cba doc: Updated Keyring settings from comments and ceph-deploy defaults.
Signed-off-by: John Wilkins <john.wilkins@inktank.com>
2014-09-02 11:37:33 -07:00
Loic Dachary
9c98d555c4 Merge pull request #2372 from dachary/wip-disk-thread-ioprio
documentation: document disk thread ioprio options

Reviewed-by: Volker Voigt <volker.voigt@1und1.de>
2014-09-02 19:18:35 +02:00
Loic Dachary
b6a97d83da documentation: disk thread ioprio options
Signed-off-by: Loic Dachary <loic-201408@dachary.org>
2014-09-02 19:08:00 +02:00
Danny Al-Gaaf
6ec08e06bc client/Client.cc: fix null pointer checks for 'in'
Cleanup checks for null pointer dereference of 'in' use a
wider code block the cover 'in'.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-09-02 15:15:04 +02:00
John Spray
c8d2388060 mon: add MDS metric metadata to health detail
This is a bit wonky because the mon health structure expects
a string, and we have a key-val structure, but it's better
to output this somehow than to have it rot as a purely internal
thing.

Signed-off-by: John Spray <john.spray@redhat.com>
2014-09-02 14:06:25 +01:00
John Spray
9ee801524f mds: add thread to progress queues outside dispatch
This speeds up processing of queued waiters.

Fixes: #9252

Signed-off-by: John Spray <john.spray@redhat.com>
2014-09-02 14:06:25 +01:00
John Spray
1058a9e18a mon: handle beacon health metrics in MDSMonitor
Fixes: #9151

Signed-off-by: John Spray <john.spray@redhat.com>
2014-09-02 14:06:25 +01:00
John Spray
0fc8a0da1a mds: populate health metrics in beacon
Signed-off-by: John Spray <john.spray@redhat.com>
2014-09-02 14:06:25 +01:00
John Spray
12ab937a71 messages: add health fields to MMDSBeacon
Signed-off-by: John Spray <john.spray@redhat.com>
2014-09-02 14:06:25 +01:00
John Spray
f5e7a4be4a mds: use HeartbeatMap to control beacons
...so that if something hogs mds_lock without
pinging the heartbeat map, we will stop sending
beacons to the mon and it will have the chance
to recognise that we are laggy.

Signed-off-by: John Spray <john.spray@redhat.com>
2014-09-02 14:06:25 +01:00
John Spray
681f4f8bd1 mds: const getters in MDLog
Signed-off-by: John Spray <john.spray@redhat.com>
2014-09-02 14:06:24 +01:00
John Spray
124856ab58 include/CompatSet: more const-ness
Signed-off-by: John Spray <john.spray@redhat.com>
2014-09-02 14:06:24 +01:00
John Spray
232757f45e mds: promote Beacon to be a Dispatcher
This allows it to handle its own MSG_MDS_BEACON
messages from the mon, outside of mds_lock.

This is less important than the sending of beacons
being outside the lock, but still nice to have and
gets all the beacon messaging in one place.

Signed-off-by: John Spray <john.spray@redhat.com>
2014-09-02 14:06:24 +01:00
John Spray
17d547ed3e mds: extract beacon state from MDS lock
For clarity, give it its own class for the
state protected by the separate lock too.

Fixes: #9152

Signed-off-by: John Spray <john.spray@redhat.com>
2014-09-02 14:06:24 +01:00
John Spray
e69f3214d1 include/CompatSet: make merge const()
With usual shenanigans to deal with [] on map
not being const-safe.

Signed-off-by: John Spray <john.spray@redhat.com>
2014-09-02 14:06:24 +01:00
Danny Al-Gaaf
46c94e9561 mds/CInode.h: prefer ++operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-09-02 14:56:47 +02:00
Danny Al-Gaaf
a5468abe44 ceph_objectstore_tool.cc: prefer ++operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-09-02 14:56:10 +02:00
John Spray
4d9927e048 mds: cap and lease count in session ls asok
Signed-off-by: John Spray <john.spray@redhat.com>
2014-09-02 13:18:39 +01:00
John Spray
ea2a8d0415 mds: Fix Session::get_request_count
Signed-off-by: John Spray <john.spray@redhat.com>
2014-09-02 13:18:19 +01:00
Danny Al-Gaaf
15df8ac4f3 rbd_replay/Replayer.cc: pass const string parameter by reference
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-09-02 14:15:21 +02:00
Danny Al-Gaaf
9d926f1eea ReplicatedPG.cc: prefer ++operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-09-02 14:03:51 +02:00
Danny Al-Gaaf
dae0593839 IndexManager.cc: prefer ++operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-09-02 14:03:03 +02:00
Danny Al-Gaaf
40189a2891 PGMonitor.cc: prefer empty() over size() for emptiness check
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-09-02 13:57:23 +02:00
Danny Al-Gaaf
99fc33f9df ErasureCodeLrc.cc: prefer ++operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-09-02 13:53:52 +02:00
Danny Al-Gaaf
2dcfe0fec3 ErasureCodePlugin.cc: prefer ++operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-09-02 13:49:32 +02:00
Danny Al-Gaaf
a754ce517b ErasureCodeLrc.cc: fix -Wmaybe-uninitialized compiler warning
Init 'n' with 0 to prevent uninitialized integer.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-09-02 13:42:49 +02:00
Danny Al-Gaaf
0d27bcc534 osd/ReplicatedPG.cc: fix resource leak
CID 1204294 (#1 of 1): Resource leak (RESOURCE_LEAK)
 leaked_storage: Variable filter going out of scope leaks the
 storage it points to.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-09-02 13:22:08 +02:00
Danny Al-Gaaf
38e6c64aee test_rgw_admin_log.cc: remove unused variables
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-09-02 13:22:08 +02:00
Danny Al-Gaaf
473b33b0c9 osdc/ObjectCacher.cc: refer ++operator for non-primitive iterators
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
2014-09-02 13:22:07 +02:00