Commit Graph

149831 Commits

Author SHA1 Message Date
Ilya Dryomov
1f71671dc6 rbd: drop --pool option from "rbd group image {add,rm}"
It stopped working with removal of get_special_pool_group_names() in
commit 3e8624f157 ("rbd: add support for namespaces") over six years
ago.  Given how much time has passed, stop accepting this option.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2024-12-20 13:29:46 +01:00
Ilya Dryomov
f35e3a6e9d rbd: handle --{group,image}-namespace in "rbd group image {add,rm}"
Currently only passing the namespace as part of the group or image spec
works.  If --group-namespace or --image-namespace options are used, the
namespace isn't picked up.

Fixes: https://tracker.ceph.com/issues/69324
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2024-12-20 11:51:18 +01:00
leonidc
862ed6e9cd
Merge pull request #61113 from leonidc/wip-leonidc_no_listener_fix
nvmeofgw*: fix no-listeners
2024-12-19 17:57:25 +02:00
Casey Bodley
8c4f592eec
Merge pull request #61107 from cbodley/wip-69241
rgw/posix: std::ignore return value of write()

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2024-12-19 10:19:51 -05:00
afreen23
34dea65e0d
Merge pull request #59703 from rhcs-dashboard/usermanagement-form
mgr/dashboard: carbonize user management form

Reviewed-by: Afreen Misbah <afreen@ibm.com>
2024-12-19 20:46:59 +05:30
baum
34f0475205
Merge pull request #61130 from baum/wip-baum-20241218-00
src/nvmeof/NVMeofGwMonitorClient: remove MDS client, not needed
2024-12-19 16:57:14 +02:00
Zac Dover
3d072b5e0d
Merge pull request #61128 from zdover23/wip-doc-2024-12-18-radosgw-uadk-accel
doc/radosgw: edit uadk-accel.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2024-12-19 23:13:14 +10:00
Yuval Lifshitz
93498236e5
Merge pull request #60788 from oshrey16/tests-rgw-ps-list-topics-op
tests/rgw/notifications: Add tests for RGWPSListTopicsOp::execute()
2024-12-19 08:18:42 +02:00
Vallari Agrawal
ed261a083c
Merge pull request #60431 from VallariAg/fix-nvmeof-ns-test
qa: fix nvmeof scalability and namespace test
2024-12-19 09:19:31 +05:30
Patrick Donnelly
672d7a1715
Merge PR #61018 into main
* refs/pull/61018/head:
	msg/async/Event: make the pipe byte static

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2024-12-18 09:33:50 -05:00
Oshrey Avraham
65614c4ca4 rgw/notifications: Add tests for RGWPSListTopicsOp::execute()
Tests:
Add comprehensive test cases to verify the behavior of `RGWPSListTopicsOp::execute()` under various scenarios:

    Migration case: Validate correct handling when `support_all_zones` is enabled, with v1 in a new state after migration and v2 topics present.
    v2 notification case: Ensure proper retrieval when v2 notifications are supported.
    v1 notification case: Verify fallback behavior when v2 notifications are unavailable.

Enhancements:
    Update `delete_all_topics` to handle v1 responses with the `result` key.

fixes: https://tracker.ceph.com/issues/68756
Signed-off-by: Oshrey Avraham <oshrey16@gmail.com>
2024-12-18 16:23:40 +02:00
Casey Bodley
9c1bf9bd84
Merge pull request #60771 from YaZasnyal/fix/complete-abort-mp
rgw/abortmp: Race condition on AbortMultipartUpload

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2024-12-18 09:05:50 -05:00
J. Eric Ivancich
e84c7fcc57
Merge pull request #60676 from awojno-bloomberg/rgw-admin-json
rgw-admin: Add --format option for bucket sync status

Reviewed-by: Adam Emerson <aemerson@redhat.com>
2024-12-18 08:56:33 -05:00
J. Eric Ivancich
954ca4589b
Merge pull request #60970 from clwluvw/redirect-qs
rgw: append query string to redirect URL if present

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2024-12-18 08:56:08 -05:00
J. Eric Ivancich
ec81d4a454
Merge pull request #60579 from clwluvw/empty-multidelete
rgw: return MalformedXML for empty objects list in DeleteObjects

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2024-12-18 08:55:45 -05:00
Patrick Donnelly
b7f1f8c8bd
Merge PR #60217 into main
* refs/pull/60217/head:
	CMakeLists.txt: do not compile {Objecter,Striper}.cc twice

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
2024-12-18 08:33:56 -05:00
leonidc
790be2d63b
Merge pull request #61091 from leonidc/wip-leonidc_publish_rebalance_index
nvmeofgw* : fix publishing rebalance index
2024-12-18 14:08:11 +02:00
Alexander Indenbaum
f80687256d src/nvmeof/NVMeofGwMonitorClient: remove MDS client, not needed
Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
2024-12-18 10:10:05 +00:00
Zac Dover
4d4e1b54d9 doc/radosgw: edit uadk-accel.rst
Incorporate Anthony D'Atri's suggested changes from
https://github.com/ceph/ceph/pull/60953 into doc/radosgw/uadk-accel.rst.

Two questions from that PR remain unclear to me: one is about whether
IOMMU should be disabled for performance on AMD EPYC systems, and the
other is about UADK. The note about UADK will be rewritten in improved
English in a near-future PR and any remaining technical questions that
involve it can be discussed in that PR.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2024-12-18 19:25:00 +10:00
Zac Dover
4b6a1eb17c
Merge pull request #60953 from zdover23/wip-doc-2024-12-04-radosgw-uadk-accel
doc/radosgw: edit uadk-accel.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2024-12-18 19:19:17 +10:00
Pedro Gonzalez Gomez
ffde19a7d9
Merge pull request #60976 from rhcs-dashboard/fix-69144-main
mgr/dashboard: Fix Latency chart data units in rgw overview page

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2024-12-18 09:20:40 +01:00
Ronen Friedman
2ce9ed615c
Merge pull request #61115 from ronen-fr/wip-rf-tst-p-replicated
qa/standalone/scrub: fix TEST_periodic_scrub_replicated

Reviewed-by: Laura Flores <lflores@redhat.com>
2024-12-18 08:42:57 +02:00
Ronen Friedman
1966e5923a
Merge pull request #60863 from ronen-fr/wip-rf-deeperrors
osd/scrub: remove the 'has_deep_errors' scheduling flag

Reviewed-by: Samuel Just <sjust@redhat.com>
2024-12-18 08:39:10 +02:00
J. Eric Ivancich
1fd1a361e2
Merge pull request #61122 from ceph/revert-61024-wip_ops-replayer_jfw-signedness-warning
Revert "ops_replayer: fix signed/unsigned warning and add parameter range checking."

Reviewed-by: Laura Flores <lflores@redhat.com>
2024-12-17 19:30:44 -05:00
Casey Bodley
7c656491fc
Merge pull request #56583 from pritha-srivastava/wip-rgw-del-bucket-tag
rgw: fix to correctly store updated attrs in backend store after erasing an attr/attrs for delete ops on a bucket.

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2024-12-17 16:33:46 -05:00
Pedro Gonzalez Gomez
8234253124
Merge pull request #60940 from rhcs-dashboard/rgw-user-accounts-api
mgr/dashboard: RGW user accounts CRUD api's 

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2024-12-17 22:22:00 +01:00
Casey Bodley
8f931cff65 Revert "ops_replayer: fix signed/unsigned warning and add parameter range checking."
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2024-12-17 14:00:52 -05:00
Jesse Williamson
90a5d4efe2
Merge pull request #61024 from chardan/wip_ops-replayer_jfw-signedness-warning
ops_replayer: fix signed/unsigned warning and add parameter range checking.
2024-12-17 10:17:09 -08:00
Ali Masarwa
a508216657
Merge pull request #60942 from AliMasarweh/wip-alimasa-bucket-logging-filter
RGW/logging: add filtering for bucket logging 

Reviewed-by: yuvalif<ylifshit@redhat.com>
2024-12-17 20:06:51 +02:00
Ali Masarwa
856b47fe50
Merge pull request #60697 from AliMasarweh/wip-alimasa-bucket-logging-flush
RGW/logging: add rest API to flush logging bucket

Reviewed-by: yuvalif<ylifshit@redhat.com>
2024-12-17 17:08:22 +02:00
Ronen Friedman
ca189fb511 qa/standalone/scrub: fix TEST_periodic_scrub_replicated
A bogus change introduced as part of PR#54363 (commit
fbb7d73) changed multiple 'scrub' commands to 'scheduled-scrub'.
In this one instance - that was wrong.

Fixes: https://tracker.ceph.com/issues/69276

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2024-12-17 15:51:48 +02:00
Milind Changire
2060e186cb
Merge pull request #59936 from anoopcs9/client-chown-statx-fixes
client: Handle empty pathnames for `ceph_chownat()` and `ceph_statxat()`
2024-12-17 16:48:24 +05:30
Ali Masarwa
e03f5ca25f RGW\logging: convert s3_filter to key_filter
Signed-off-by: Ali Masarwa <amasarwa@redhat.com>
2024-12-17 13:06:11 +02:00
Ali Masarwa
ca9e0f4061 RGW/logging: add filtering for bucket logging
Signed-off-by: Ali Masarwa <amasarwa@redhat.com>
2024-12-17 13:06:04 +02:00
Ali Masarwa
9a9e14db35 RGW/logging: add rest API to flush logging bucket
Signed-off-by: Ali Masarwa <amasarwa@redhat.com>
2024-12-17 12:55:39 +02:00
Leonid Chernin
ee66dc51cc nvmeofgw*: fix no-listeners
Signed-off-by: Leonid Chernin <leonidc@il.ibm.com>
2024-12-17 10:46:25 +00:00
Leonid Chernin
ceb62c0c80 nvmeofgw* : fix publishing rebalance index
Signed-off-by: Leonid Chernin <leonidc@il.ibm.com>
2024-12-17 08:25:47 +00:00
afreen23
744eb5cdb3
Merge pull request #60798 from rhcs-dashboard/edit-configuration-at-runtime
mgr/dashboard: Administration > Configuration > rgw_dns_name and rgw_dns_s3website_name not updatable via dashboard

Reviewed-by: Afreen Misbah <afreen@ibm.com>
2024-12-17 13:39:04 +05:30
Aashish Sharma
d9aa164cd3 mgr/dashboard: Fix Latency chart data units in rgw overview page
Issue: The Latency chart in the rgw overview page shows incorrect data
unit as the unit that we are passing as an input to the dashboard-area
chart component is `ms` whereas the data that we get from the metrics is
in seconds. Due to this if we pass a value like 0.725s to
the dashboard chart component it will show the value in the chart as
0.725ms whereas it should be 725ms.

Fix: Pass the value in ms as expected to the dashboard area chart
component

Fixes: https://tracker.ceph.com/issues/69144

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2024-12-17 12:14:46 +05:30
baum
7c0f6eb1d1
Merge pull request #60807 from baum/nvmeof_service_ports
🧹cephadm/nvmeof: fix ports when default values are overridden
2024-12-17 08:26:55 +02:00
Naman Munet
0fc5aecd55 mgr/dashboard: RGW user accounts CRUD api's
Fixes: https://tracker.ceph.com/issues/69110

PR Changes:
Added CRUD & managing quota endpoints for RGW user accounts management with the unit-tests

Signed-off-by: Naman Munet <namanmunet@li-ff83bccc-26af-11b2-a85c-a4b04bfb1003.ibm.com>
2024-12-17 10:53:51 +05:30
J. Eric Ivancich
c1882678e7
Merge pull request #61106 from ivancich/wip-fix-hadoop-java
qa/rgw: force Hadoop to run under Java 1.8

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2024-12-17 00:00:06 -05:00
Venky Shankar
97555e0931 Merge PR #59736 into main
* refs/pull/59736/head:
	deb: Add cephfs.pc to libcephfs-dev
	rpm: Add cephfs.pc to libcephfs-devel
	cephfs: Add a pkgconfig file for libcephfs

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dan Mick <dmick@redhat.com>
2024-12-17 09:48:34 +05:30
Alexander Indenbaum
e717a925ae cephadm/nvmeof: fix ports when default values are overridden
Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
2024-12-17 03:35:07 +00:00
baum
b192a7e36d
Merge pull request #60806 from baum/nvmeof_addr_map
cephadm/nvmeof: support per-node gateway addresses
2024-12-17 05:32:14 +02:00
Casey Bodley
a2ebc00a56 rgw/posix: std::ignore return value of write()
/ceph/src/rgw/driver/posix/notify.h: In member function 'void file::listing::Inotify::signal_shutdown()':
/ceph/src/rgw/driver/posix/notify.h:215:19: error: ignoring return value of 'ssize_t write(int, const void*, size_t)' declared with attribute 'warn_unused_result' [-Werror=unused-result]
  215 |       (void) write(efd, &msg, sizeof(uint64_t));
      |              ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors

Fixes: https://tracker.ceph.com/issues/69241

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2024-12-16 17:10:10 -05:00
Casey Bodley
1241834039
Merge pull request #61031 from phlogistonjohn/jjm-rm-assigned-only
test/fio: remove assign-only variable

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2024-12-16 14:10:07 -05:00
Casey Bodley
cdbe0a2e94
Merge pull request #61030 from phlogistonjohn/jjm-remove-unused-var
test/cls_log: remove unused variable

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2024-12-16 14:09:54 -05:00
Jesse F. Williamson
06a56b7efb Fix signed/unsigned warning and add parameter range checking.
Signed-off-by: Jesse F. Williamson <1643380+chardan@users.noreply.github.com>
2024-12-16 10:43:25 -08:00
J. Eric Ivancich
c5503187af qa/rgw: force Hadoop to run under Java 1.8
The Hadoop test installs Java 1.8 but then just runs the default
version. This makes sure it will run the version it installed.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
2024-12-16 13:21:35 -05:00