Commit Graph

100687 Commits

Author SHA1 Message Date
Rafael Quintero
19a0593087 mgr/dashboard: Verify fields on ISCSI page
Fixes: https://tracker.ceph.com/issues/41207

Signed-off-by: Adam King <adking@redhat.com>
Signed-off-by: Rafael Quintero <rquinter@redhat.com>
2019-08-12 09:44:05 -04:00
Casey Bodley
13f1595335
Merge pull request #29558 from theanalyst/rgw-cache-lock
rgw: fix unlock of shared lock in RGWCache

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-08-09 13:03:35 -04:00
Abhishek Lekshmanan
2b6dbe31c8 rgw: fix unlock of shared lock in RGWCache
similar to https://github.com/ceph/ceph/pull/29538/ we unlock a shared_lock with
unlock causing a crash. Also scope the single line if statements to make the
code more concise

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
2019-08-09 17:54:22 +02:00
Sage Weil
f011c13547 Merge PR #29292 into master
* refs/pull/29292/head:
	os/bluestore: warn on no per-pool omap
	os/bluestore: fsck: warning (not error) by default on no per-pool omap
	os/bluestore: fsck: int64_t for error count
	os/bluestore: default size of 1 TB for testing
	os/bluestore: behave if we *do* set PGMETA and PERPOOL flags
	os/bluestore: do not set both PGMETA_OMAP and PERPOOL_OMAP
	os/bluestore: fsck: only generate 1 error per omap_head
	os/bluestore: make fsck repair convert to per-pool omap
	os/bluestore: teach fsck to tolerate per-pool omap
	os/bluestore: ondisk format change to 3 for per-pool omap
	mon/PGMap: add data/omap breakouts for 'df detail' view
	osd/osd_types: separate get_{user,allocated}_bytes() into data and omap variants
	mon/PGMap: fix stored_raw calculation
	mon/PGMap: add in actual omap usage into per-pool stats
	osd: report per-pool omap support via store_statfs_t
	os/bluestore: set per_pool_omap key on mkfs
	osd/osd_types: count per-pool omap capable OSDs
	os/bluestore: report omap_allocated per-pool
	os/bluestore: add pool prefix to omap keys
	kv/KeyValueDB: take key_prefix for estimate_prefix_size()
	os/bluestore: fix manual omap key manipulation to use Onode::get_omap_key()
	os/bluestore: make omap key helpers Onode methods
	os/bluestore: add Onode::get_omap_prefix() helper
	os/bluestore: change _do_omap_clear() args

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2019-08-09 10:40:45 -05:00
Alfredo Deza
8363d89a4d
Merge pull request #29528 from tchaikov/wip-build-doc-with-python3
admin/build-doc: use python3

Reviewed-by: Alfredo Deza <adeza@redhat.com>
2019-08-09 11:17:19 -04:00
Matt Benjamin
a7b29647fd
Merge pull request #29560 from linuxbox2/wip-rgwf-advance
rgw_file: dont deadlock in advance_mtime()
2019-08-09 10:01:03 -04:00
Sage Weil
b8501164ef os/bluestore: warn on no per-pool omap
Signed-off-by: Sage Weil <sage@redhat.com>
2019-08-09 08:21:18 -05:00
Kefu Chai
2db496017a
Merge pull request #29400 from wjwithagen/wjw-fix-do_freeBSD.sh
do_freebsd.sh: update build scripts to resemble Jenkins scripts

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-08-09 14:09:42 +08:00
Kefu Chai
ed8ff905fc
Merge pull request #29495 from ifed01/wip-ifed-finisher-improve
common/Finisher: remove some lock acquisitions.

Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Jianpeng Ma <jianpeng.ma@intel.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-08-09 12:24:28 +08:00
Kefu Chai
e5165db985
Merge pull request #29477 from tchaikov/wip-osd-pg-as-mutex
osd: pg as a mutex

Reviewed-by: Greg Farnum gfarnum@redhat.com
Reviewed-by: Samuel Just <sjust@redhat.com>
2019-08-09 12:22:26 +08:00
Kefu Chai
abce85bbd2
Merge pull request #29486 from runsisi/wip-fix-verbose
ceph.in: fix verbose print

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-08-09 12:21:29 +08:00
Kefu Chai
32b33d3258
Merge pull request #29465 from penglaiyxy/wip_bluestore_caculated_revert
os/bluestore: no need to add tail length (revert PR#29185)

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
2019-08-09 12:20:46 +08:00
Kefu Chai
88c6c039d1
Merge pull request #29488 from majianpeng/bluestore-remove-lock
os/bluestore: no need protected by OpSequencer::qlock.

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
2019-08-09 12:19:27 +08:00
Kefu Chai
3efc51fa1d
Merge pull request #29385 from kamoltat/wip-qa-tasks-mgr-test-progress-bug-fix
qa/tasks/mgr/test_progress.py: fix bug in 9b4dbf0

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2019-08-09 12:18:40 +08:00
Dan Mick
8096d69f9a
Merge pull request #29365 from liewegas/wip-telemetry-post
telemetry/server: misc fixes
2019-08-08 16:32:15 -07:00
Matt Benjamin
0d3338c2d2 rgw_file: dont deadlock in advance_mtime()
Fixes: https://tracker.ceph.com/issues/41173

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
2019-08-08 18:57:15 -04:00
Sage Weil
6c690ae285 os/bluestore: fsck: warning (not error) by default on no per-pool omap
Unconditionally error if the global per_pool_omap was set, though!

Signed-off-by: Sage Weil <sage@redhat.com>
2019-08-08 17:26:37 -05:00
Sage Weil
dee8f8cb7e os/bluestore: fsck: int64_t for error count
Just to be on the safe side.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-08-08 17:26:24 -05:00
Sage Weil
dbdd1d9b6e os/bluestore: default size of 1 TB for testing
Less ENOSPC from vstart.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-08-08 17:26:24 -05:00
Sage Weil
52a2d4b24d os/bluestore: behave if we *do* set PGMETA and PERPOOL flags
pgmeta trumps perpool.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-08-08 17:26:24 -05:00
Sage Weil
9bbe8d04c7 os/bluestore: do not set both PGMETA_OMAP and PERPOOL_OMAP
Signed-off-by: Sage Weil <sage@redhat.com>
2019-08-08 17:26:24 -05:00
Sage Weil
1eb10f3233 os/bluestore: fsck: only generate 1 error per omap_head
Signed-off-by: Sage Weil <sage@redhat.com>
2019-08-08 17:26:24 -05:00
Sage Weil
b1e44c3298 os/bluestore: make fsck repair convert to per-pool omap
- error if objects not per-pool
- error if per_pool_omap not set
- convert as we go, and set the flag at the end

Signed-off-by: Sage Weil <sage@redhat.com>
2019-08-08 17:26:24 -05:00
Yuri Weinstein
690385362c
Merge pull request #29541 from yuriw/wip-yuriw-upgrade-rbd-master
qa/tests: added rbd task on ec
2019-08-08 15:22:48 -07:00
Sage Weil
0d9410036a Merge PR #27542 into master
* refs/pull/27542/head:
	qa/tasks: Fix ambiguous store_thrash, thrash_store

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-08-08 15:52:58 -05:00
Sage Weil
8827bc1022 Merge PR #29493 into master
* refs/pull/29493/head:
	qa/tasks/mgr/mgr_test_case: get mgrmap from 'mgr dump', not status
	qa/tasks/ceph_manager: no newlines in 'ceph -s' output
	mon: make mon summary more concise in 'ceph -s'
	mon/MgrStatMonitor: set initial service_map 'modified' to cluster mkfs
	mon: remove double-nesting of "osdmap" for ceph status
	mon/MgrMap: make print_summary (used by 'ceph -s') more concise

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-08-08 15:52:45 -05:00
Sage Weil
a0fca4eaf6 Merge PR #29511 into master
* refs/pull/29511/head:
	common/config: respect POD_MEMORY_REQUEST *and* POD_MEMORY_LIMIT env vars
	common/config: let diff show non-build defaults
	common/config: do no include multiple 'default' values

Reviewed-by: Mark Nelson <mnelson@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
2019-08-08 15:49:29 -05:00
Sage Weil
01fcf0e401 Merge PR #29517 into master
* refs/pull/29517/head:
	osd: include PastInterals in pg_notify_t

Reviewed-by: Samuel Just <sjust@redhat.com>
2019-08-08 15:49:17 -05:00
Adam C. Emerson
ad88d4dced Merge pull request #29559 from adamemerson/wip-putobj-crash
rgw: Move upload_info declaration out of conditional

Reviewed-By: Casey Bodley <cbodley@redhat.com>
2019-08-08 15:14:03 -04:00
Adam C. Emerson
a63881eaf7 rgw: Move upload_info declaration out of conditional
That way we don't deconstruct it right after assigning a reference to
part of it.

Fixes: https://tracker.ceph.com/issues/41172
Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
2019-08-08 13:12:46 -04:00
Casey Bodley
24a3056171
Merge pull request #29449 from cbodley/wip-vstart-client-rgw
vstart: move common rgw config to [client.rgw]

Reviewed-By: Abhishek Lekshmanan <abhishek@suse.com>
2019-08-08 11:33:52 -04:00
Yuri Weinstein
644ed83e24 qa/tests: added rbd task on ec
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
2019-08-08 08:10:37 -07:00
Sage Weil
72d6426025 osd: include PastInterals in pg_notify_t
We use a pair<pg_notify_t,PastIntervals> everywhere a pg_notify_t is used.
This is silly; just make it a member instead.

Include some minor compat cruft so we can speak to pre-octopus OSDs.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-08-08 09:14:03 -05:00
Casey Bodley
6e976c5aa7
Merge pull request #29538 from cbodley/wip-rgw-data-changes-shared-unlock
rgw: fix unlock of shared lock in RGWDataChangesLog

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-08-08 10:11:29 -04:00
Mykola Golub
82a45573d5
Merge pull request #29468 from dillaman/wip-41032
pybind/mgr/rbd_support: use image ids to detect duplicate tasks

Reviewed-by: Mykola Golub <mgolub@suse.com>
2019-08-08 16:32:33 +03:00
Sage Weil
0b719c4382 Merge PR #29514 into master
* refs/pull/29514/head:
	mgr/hello: typos
	mgr/hello: a better command example
	mgr/hello: boilerplate for handling config options
	mgr/hello: fully document our options

Reviewed-by: Tim Serong <tserong@suse.com>
2019-08-08 08:24:33 -05:00
Sage Weil
390f76d525 qa/tasks/mgr/mgr_test_case: get mgrmap from 'mgr dump', not status
Signed-off-by: Sage Weil <sage@redhat.com>
2019-08-08 08:17:04 -05:00
Sage Weil
0527d9c8cd Merge PR #29546 into master
* refs/pull/29546/head:
	mgr/telemetry: clear the event after being awaken by it

Reviewed-by: Sage Weil <sage@redhat.com>
2019-08-08 08:12:53 -05:00
Lenz Grimmer
6d5939f8d1
mgr/dashboard: Prevent clone when layering not enabled on pare… (#29317)
mgr/dashboard: Prevent clone when layering not enabled on parent image

Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
2019-08-08 14:38:58 +02:00
Lenz Grimmer
ee66b6be91
mgr/dashboard: fix RBD snapshot protected label (#29534)
mgr/dashboard: fix RBD snapshot protected label

Reviewed-by: Tiago Melo <tmelo@suse.com>
2019-08-08 14:34:17 +02:00
Lenz Grimmer
95ec11a080
mgr/dashboard: Verify fields on Crush map page (#29452)
mgr/dashboard: Verify fields on Crush map page

Reviewed-by: Tiago Melo <tmelo@suse.com>
2019-08-08 14:01:49 +02:00
Lenz Grimmer
f22fc76453
mgr/dashboard: Verify fields on Monitors page (#29450)
mgr/dashboard: Verify fields on Monitors page

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2019-08-08 14:00:52 +02:00
Lenz Grimmer
e56e3d78fb
mgr/dashboard: E2E Dashboard Page Test Suite (#29432)
mgr/dashboard: E2E Dashboard Page Test Suite

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2019-08-08 13:59:42 +02:00
Lenz Grimmer
c2caec2ebe
mgr/dashboard: Verify manager modules have editing functionali… (#29407)
mgr/dashboard: Verify manager modules have editing functionality

Reviewed-by: Tiago Melo <tmelo@suse.com>
2019-08-08 13:58:51 +02:00
Kefu Chai
0dddb20685 mgr/telemetry: clear the event after being awaken by it
otherwise telemetry will have a busy-loop once it's signaled.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-08-08 12:24:56 +08:00
David Zafman
b1c14b7f6e
Merge pull request #29494 from dzafman/wip-scrub-test
test: Bump sleep time for slower machines

Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-08-07 18:30:31 -07:00
Casey Bodley
17fc695047
Merge pull request #28813 from smanjara/wip-user-rename-working
rgw : Bucket mv, bucket chown and user rename utilities

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
2019-08-07 16:05:07 -04:00
Neha Ojha
c9d2833b25
Merge pull request #29425 from aclamk/wip-bluestore-monitor-allocations
[bluestore][tools] Inspect allocations in bluestore

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-08-07 11:37:34 -07:00
Casey Bodley
553d97ca95 rgw: fix unlock of shared lock in RGWDataChangesLog
std::shared_mutex expects a call to unlock_shared() after lock_shared().
use the std::shared_lock guard to make it more obviously correct

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2019-08-07 14:02:49 -04:00
Adam Kupczyk
713f9b4d09 doc/rados/operations/health-checks: document BlueStore fragmentation and BlueFS space available features
Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
2019-08-07 19:18:21 +02:00