Commit Graph

112977 Commits

Author SHA1 Message Date
Kefu Chai
d3355c6b07
Merge pull request #35943 from tchaikov/wip-mgr-balancer
pybind/mgr/balancer: use "==" and "!=" for comparing str

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
2020-07-08 20:03:57 +08:00
Lenz Grimmer
6d9ff66101
Merge pull request #35948 from tspmelo/wip-clean-jest
mgr/dashboard: Clean unit tests configuration and output

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
2020-07-08 13:28:49 +02:00
Lenz Grimmer
e63fa9d1c8
Merge pull request #35922 from tspmelo/wip-clean-lint
mgr/dashboard: Clean the output of lint and fix scripts

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
2020-07-08 13:27:10 +02:00
myoungwon oh
942c73bf07
Merge pull request #35338 from myoungwon/wip-doc-manifet-snap
doc/dev/osd_internals/manifest.rst: add information about clone snap refcounting

Reviewed-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2020-07-08 18:57:13 +09:00
Ricardo Marques
df6163e136 mgr/dashboard: Allow to edit iSCSI target with active session
Fixes: https://tracker.ceph.com/issues/46383

Signed-off-by: Ricardo Marques <rimarques@suse.com>
2020-07-08 10:41:29 +01:00
Lenz Grimmer
191f070ab9
Merge pull request #35874 from tspmelo/wip-fix-pwd-notification
mgr/dashboard: Hide password notification when expiration date is far

Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
2020-07-08 11:27:22 +02:00
Lenz Grimmer
8ab14ab685
Merge pull request #35501 from SchoolGuy/streamline-bootstrap-usage
mgr/dashboard: Introduce SASS modules

Reviewed-by: Sebastian Krah <skrah@suse.com>
Reviewed-by: Tiago Melo <tmelo@suse.com>
2020-07-08 10:50:41 +02:00
Kefu Chai
f7f3044219
Merge pull request #34960 from majianpeng/vstart-spdk
vstart: specify the NVME PCI BUS ID when enable spdk.

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-07-08 12:42:22 +08:00
Kefu Chai
65dc464977 pybind/mgr/balancer: use "==" and "!=" for comparing str
we cannot assume that two values with the same value share the same
identity in Python.

also silences warnings like:

balancer/module.py:473: SyntaxWarning: "is" with a literal. Did you mean "=="?
  if pool_ids is '':

Fixes: https://tracker.ceph.com/issues/46406
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-07-08 12:04:52 +08:00
Jianpeng Ma
5640390f66 vstart: specify the NVME PCI BUS ID when enable spdk.
Currently we use vendor::device to specify the nvme name when using
spdk. But it have some problems:
a)it can't use different vendor or different device with the same
device.
b)if machine has same vendor&device, we don't choose specific
device.

So we diretly specify the PCI BUS ID for NVME device.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
2020-07-08 10:25:09 +08:00
Patrick Donnelly
02fc51deb7
Merge PR #35725 into master
* refs/pull/35725/head:
	client: Fix setxattr with 0 size specified

Reviewed-by: Zheng Yan <zyan@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
2020-07-07 15:22:39 -07:00
Tiago Melo
c05b7cbbfc mgr/dashboard: Update Cypress
Signed-off-by: Tiago Melo <tmelo@suse.com>
2020-07-07 22:05:15 +00:00
Tiago Melo
b13dd050f8 mgr/dashboard: Add E2E for navigation
Fixes: https://tracker.ceph.com/issues/45376

Signed-off-by: Tiago Melo <tmelo@suse.com>
2020-07-07 22:05:15 +00:00
J. Eric Ivancich
6d9d548096 rgw: rgw-orphan-list -- fix interaction, quoting, and percentage calc
The interactive mode wasn't working due to prompts going to stdout
instead of stderr. If a space should appear in temporary file, it will
generate a shell error, so quoting was added. Furthermore if there are
no objects found in a pool, a divide by zero error will be
generated. This commit addresses these issues.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
2020-07-07 15:59:13 -04:00
Tiago Melo
294c37b343 mgr/dashboard: Add E2E for languages
Fixes: https://tracker.ceph.com/issues/45376

Signed-off-by: Tiago Melo <tmelo@suse.com>
2020-07-07 18:28:30 +00:00
Tiago Melo
1ef00a83b1 mgr/dashboard: Add E2E for login
Fixes: https://tracker.ceph.com/issues/45376

Signed-off-by: Tiago Melo <tmelo@suse.com>
2020-07-07 18:28:30 +00:00
Tiago Melo
1c06642a72 mgr/dashboard: Clean the output of lint and fix scripts
Increase deprecation tslint rule from warning to error and
remove no-use-before-declare.

Fixes: https://tracker.ceph.com/issues/46339

Signed-off-by: Tiago Melo <tmelo@suse.com>
2020-07-07 18:11:32 +00:00
Mykola Golub
03dbeebab3
Merge pull request #35861 from dillaman/wip-write-zeroes-tweaks
librbd: allow thick-zeroing of an image extent

Reviewed-by: Mykola Golub <mgolub@suse.com>
2020-07-07 17:44:50 +03:00
Patrick Donnelly
1dbad702b6
Merge PR #35743 into master
* refs/pull/35743/head:
	qa/tasks/test_nfs: Add test for cluster info
	mgr/volumes/nfs: Add cluster show info command

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-07-07 06:59:41 -07:00
Casey Bodley
1fa1fc1914
Merge pull request #35834 from yuvalif/add-amqp-topic-doc
rgw: add a doc hint that the topic-name is used as AMQP routing-key

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2020-07-07 09:56:08 -04:00
Laura Paduano
f937df79a0
Merge pull request #35923 from votdev/fix_various_issues
mgr/dashboard: Fix bugs in a unit test and i18n translation

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
2020-07-07 15:21:08 +02:00
Casey Bodley
fc2b872868
Merge pull request #35886 from yuvalif/wip-yuval-fix-46316
rgw: make RGWToken string ctor explicit

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2020-07-07 09:08:36 -04:00
Laura Paduano
3375389e14
Merge pull request #35707 from Devp00l/wip-45650
mgr/dashboard: Fixes ICU selection regression

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
2020-07-07 14:29:06 +02:00
Kefu Chai
ff17d0b13e
Merge pull request #35764 from rzarzynski/wip-bl-cache-in-release
common/bl: document and slightly optimize ptr::release().

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-07-07 18:49:39 +08:00
Enno Gotthold
e8d80f285c
mgr/dashboard: Introduces SASS modules
Fixes: https://tracker.ceph.com/issues/45934

Signed-off-by: Enno Gotthold <egotthold@suse.de>
2020-07-07 12:03:35 +02:00
Radoslaw Zarzynski
d427acf4a5 common/bl: document and slightly optimize ptr::release().
Before the patch GCC was generating:
```
  10f9910:   mov    (%rdi),%rax
  10f9913:   test   %rax,%rax
  10f9916:   je     10f9951 <ceph::buffer::v15_2_0::ptr::release()+0x41>
  10f9918:   mov    0x2c(%rax),%eax
  10f991b:   cmp    $0x1,%eax
  10f991e:   jne    10f9940 <ceph::buffer::v15_2_0::ptr::release()+0x30>
  10f9920:   mov    (%rdi),%rax
  10f9923:   movq   $0x0,(%rdi)
  10f992a:   test   %rax,%rax
  10f992d:   je     10f9958 <ceph::buffer::v15_2_0::ptr::release()+0x48>
  10f992f:   mov    (%rax),%rdx
  10f9932:   mov    %rax,%rdi
  10f9935:   mov    0x8(%rdx),%rdx
  10f9939:   jmpq   *%rdx
  10f993b:   nopl   0x0(%rax,%rax,1)
  10f9940:   mov    (%rdi),%rax
  10f9943:   lock subl $0x1,0x2c(%rax)
  10f9948:   je     10f9920 <ceph::buffer::v15_2_0::ptr::release()+0x10>
  10f994a:   movq   $0x0,(%rdi)
  10f9951:   retq
  10f9952:   nopw   0x0(%rax,%rax,1)
  10f9958:   retq
  10f9959:   nop
  10f995a:   nopw   0x0(%rax,%rax,1)
```

after:
```
  11209b0:   mov    (%rdi),%rax
  11209b3:   movq   $0x0,(%rdi)
  11209ba:   test   %rax,%rax
  11209bd:   je     11209e6 <ceph::buffer::v15_2_0::ptr::release()+0x36>
  11209bf:   mov    0x2c(%rax),%edx
  11209c2:   lea    0x2c(%rax),%rcx
  11209c6:   cmp    $0x1,%edx
  11209c9:   jne    11209e0 <ceph::buffer::v15_2_0::ptr::release()+0x30>
  11209cb:   mov    (%rax),%rdx
  11209ce:   mov    %rax,%rdi
  11209d1:   mov    0x8(%rdx),%rdx
  11209d5:   jmpq   *%rdx
  11209d7:   nopw   0x0(%rax,%rax,1)
  11209de:
  11209e0:   lock subl $0x1,(%rcx)
  11209e4:   je     11209cb <ceph::buffer::v15_2_0::ptr::release()+0x1b>
  11209e6:   retq
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2020-07-07 11:16:37 +02:00
Andreas Unterkircher
41f26bffe2 rgw: add a doc hint that the topic-name is used as AMQP routing-key
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2020-07-07 11:23:41 +03:00
Varsha Rao
93aa5e4012 qa/tasks/test_nfs: Add test for cluster info
Signed-off-by: Varsha Rao <varao@redhat.com>
2020-07-07 10:50:22 +05:30
Varsha Rao
1faed4b1aa mgr/volumes/nfs: Add cluster show info command
Fixes: https://tracker.ceph.com/issues/45743
Signed-off-by: Varsha Rao <varao@redhat.com>
2020-07-07 10:50:22 +05:30
Kefu Chai
8664843083
Merge pull request #35940 from tchaikov/wip-ceph-dencoder-struct-ver
tools/ceph-dencoder: add get_struct_v,get_struct_compat commands

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2020-07-07 10:09:54 +08:00
Kefu Chai
e7227e3d56
Merge pull request #35914 from tchaikov/wip-crimson-clang
crimson: clang related cleanups

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2020-07-07 10:04:06 +08:00
Kefu Chai
4d94935262
Merge pull request #35933 from tchaikov/wip-interval-set
include/interval_set: use template as the 2nd template parameter

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-07-07 10:01:53 +08:00
Yan, Zheng
c4a335d7c6 mon: add 'ceph fs required_client_feature <fs_name> add/rm' command
Fixes: https://tracker.ceph.com/issues/43817
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
2020-07-07 09:05:56 +08:00
Patrick Donnelly
9b913a1135
Merge PR #35496 into master
* refs/pull/35496/head:
	client: introduce timeout for client shutdown

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-07-06 16:50:30 -07:00
Jason Dillaman
2148f22db6 neorados: build new RADOS client using legacy librados::Rados
Client libraries like librbd cannot force the adaptation to neorados
and it would not be ideal to have two effective RADOS cluster
connections for librados and neorados.

The new neorados::RADOS::make_with_librados helper method will
allow neorados to re-use the existing thread pool, MGR, MON, and
objecter already created for librados::Rados.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2020-07-06 17:11:07 -04:00
Zac Dover
9dbc7c715d doc/devel: repair sentences in "Essentials" page
This commit fixes a few sentences in the "Essentials" page
that aren't as well-formed as they might have been. This commit
fixes the issue detailed in the tracker link, as well as a couple
of other improvements that I couldn't resist in the heat of the
moment.

Fixes: https://tracker.ceph.com/issues/46362
Signed-off-by: Zac Dover <zac.dover@gmail.com>
2020-07-07 07:10:55 +10:00
Jason Dillaman
83b82bc3d6 neorados: use a lightweight proxy object to abstract RADOS backend
Both neorados and (legacy) librados create MON, MGR, and OSD
(objecter) clients. Let the neorados frontend API directly access
these clients through a generic class that can be swapped out.
This will allow the neorados API to re-use a (legacy) librados
RadosClient in a future commit.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2020-07-06 16:12:35 -04:00
Tiago Melo
dcc6685c16 mgr/dashboard: Hide password notification when expiration date is far
Fixes: https://tracker.ceph.com/issues/46306

Signed-off-by: Tiago Melo <tmelo@suse.com>
2020-07-06 20:01:21 +00:00
Tiago Melo
02f151a1f0 mgr/dashboard: Clean unit tests configuration and output
Remove outdated configurations and moment warning.
Update Jest related packages.

Fixes: https://tracker.ceph.com/issues/46341

Signed-off-by: Tiago Melo <tmelo@suse.com>
2020-07-06 19:48:33 +00:00
Jason Dillaman
32e2e907e5 neorados: fixed valgrind memory leaks and errors
Keep the CephContext wrapped in an intrusive pointer to keep the
reference counting functional. Ensure all the messenger clients
(mon, mgr, and objecter) are shut down prior to destruction.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2020-07-06 14:57:33 -04:00
Kefu Chai
faab304e9d
Merge pull request #35942 from tchaikov/wip-build-rtd
admin: move python-common deps out of doc-requirements.txt

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2020-07-06 23:25:23 +08:00
Lenz Grimmer
35a68ebb33
Merge pull request #35354 from ishanrai05/rfs
mgr/dashboard: use relative font sizes

Reviewed-by: Tiago Melo <tmelo@suse.com>
Reviewed-by: Volker Theile <vtheile@suse.com>
2020-07-06 17:19:15 +02:00
Kefu Chai
8149c9302d tools/ceph-dencoder: add get_struct_v,get_struct_compat commands
for understanding the current encoding version and the lower bound of
supported decoders.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-07-06 22:58:05 +08:00
Kefu Chai
a5441010ed
Merge pull request #35913 from ideepika/wip-container-tag-change
docker/podman: tag crimson flavor container as 'sha-1-flavor'

Reviewed-by: Dimitri Savineau <dsavinea@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-07-06 21:01:06 +08:00
Kefu Chai
b9e0ae1a2e
Merge pull request #35920 from uweigand/entity-addrvec-fix
msg/msg_types: entity_addrvec_t: fix decode on big-endian hosts

Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-07-06 20:51:25 +08:00
Kefu Chai
1f8ec1e49c
Merge pull request #35890 from matthewoliver/cephadm_ipv6_list_networks
cephadm: Make list_networks ipv6 enabled

Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2020-07-06 20:50:41 +08:00
Kefu Chai
527e55d485
Merge pull request #35546 from agayev/zoned-fm
os/bluestore: Introduce zoned freelist manager.

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
2020-07-06 20:42:48 +08:00
Kefu Chai
b83be6f33b admin: move python-common deps out of doc-requirements.txt
to address the build failure of

python -m pip install --exists-action=w --no-cache-dir -r admin/doc-requirements.txt
ERROR: ../src/python-common is not a valid editable requirement. It should either be a path to a local project or a VCS URL (beginning with svn+, git+, hg+, or bzr+).

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-07-06 19:19:22 +08:00
Deepika Upadhyay
b0a14d6e1e docker/podman: tag crimson flavor container as 'sha-1-flavor'
see also: ceph/ceph-container#1704

Signed-off-by: Deepika Upadhyay <dupadhya@redhat.com>
2020-07-06 16:19:28 +05:30
Volker Theile
656727a315 mgr/dashboard: Fix bugs in a unit test and i18n translation
* SKIP: Unknown argument type: 'BinaryExpression' NodeObject { ... text: 'You can activate the module on the Telemetry configuration '
* WARNING: /ceph/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-bucket-list/rgw-bucket-list.component.spec.ts:39:32 - get is deprecated: from v9.0.0 use TestBed.inject

Fixes: https://tracker.ceph.com/issues/46371

Signed-off-by: Volker Theile <vtheile@suse.com>
2020-07-06 11:50:47 +02:00