Yingxin Cheng
f4b40cddc1
crimson/net: isolate exceptions from dispatcher implementations
...
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2020-11-27 13:13:29 +08:00
Yingxin Cheng
bc140cf5d7
crimson: add a missing header to admin_socket.cc
...
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2020-11-27 11:16:22 +08:00
Brad Hubbard
a5bcca7f41
qa/suites/rados/monthrash: Exercise mon scrub error injectors
...
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
2020-11-27 12:59:59 +10:00
Brad Hubbard
f85001e5d5
qa/config/rados.yaml: Test mon scrub
...
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
2020-11-27 12:58:06 +10:00
Willem Jan Withagen
e4e4995440
librbd: remove unwanted std::move
...
Clang argues:
```
/home/jenkins/workspace/ceph-master-compile/src/librbd/migration/HttpClient.cc:463:16: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
response = std::move(m_parser->release());
^
/home/jenkins/workspace/ceph-master-compile/src/librbd/migration/HttpClient.cc:463:16: note: remove std::move call here
response = std::move(m_parser->release());
^~~~~~~~~~ ~
1 warning generated.
```
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
2020-11-27 01:17:32 +01:00
Willem Jan Withagen
461ff5a3bf
librbd: remove double declaration
...
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
2020-11-27 01:15:45 +01:00
Volker Theile
5cf222b6d2
mgr/dashboard: Disable TLS 1.0 and 1.1
...
Disable these TLS versions because of security issues.
Fixes: https://tracker.ceph.com/issues/48360
Signed-off-by: Volker Theile <vtheile@suse.com>
2020-11-26 15:40:15 +01:00
Kefu Chai
db2767cc6d
Merge pull request #38297 from badone/wip-make-sure--e-actually-works
...
run-make-check.sh: Make sure a build failure will exit
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-11-26 21:34:46 +08:00
Willem Jan Withagen
ac9dfa3f82
blk: fix parameters for non native uring
...
The parameterlist used when uring is availble needs
to be equal to the case where no uring is available.
fixes: https://github.com/ceph/ceph/pull/38257
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
2020-11-26 14:04:22 +01:00
Kefu Chai
cbbd74558b
crimson/osd: wait for min_epoch instead of map_epoch
...
osdmap_epoch is the latest osdmap of the client, it is not the minimum
osdmap epoch required to serve the request from the client with this
osdmap.
as a matter of fact, `MOSDOp` inherits from `MOSDFastDispatchOp`.
the `MOSDFastDispatchOp::get_min_epoch()` returns `get_map_epoch()`, and
`MOSDOp` does not override `get_min_epoch()`.
`ClientRequest` is designed to handle `MOSDOp`. so, there is no need
to wait for `m->get_map_epoch()` osdmap before moving further, and more
importantly, we should wait until PG is updated with min_epoch osdmap.
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-11-26 20:13:48 +08:00
Kefu Chai
48515e9b8d
Merge pull request #38265 from Rethan/doc-prometheus-config-key
...
doc/mgr/prometheus: update 'config-key set' to 'config set' for consistency
Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-11-26 19:52:10 +08:00
Kefu Chai
17c9827ad8
crimson/osd: errororize PG::with_*_obc methods()
...
they all use `seastar::with_lock()` to ensure the obc lock is released
in the error handling path. but we cannot assume that
`seastar::with_lock()` always return `seastar::future<>`, so propogate
the error returned by the function passed to `with_lock()` using
errorator.
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-11-26 18:44:25 +08:00
Samuel Just
c820d40aca
crimson/common/errorator: fix finally
...
We need to specify the return type here to ensure we don't lose
the errorator properties.
Signed-off-by: Samuel Just <sjust@redhat.com>
2020-11-26 18:44:25 +08:00
Kefu Chai
cc16516fd8
Merge pull request #38257 from lnsyyj/wip-iouring-poll
...
blk/kernel: expose IORING_SETUP_{IOPOLL,SQPOLL} as options
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-11-26 18:19:45 +08:00
Kefu Chai
6c4dbb2e48
Merge pull request #38263 from tchaikov/wip-boost-1.74-asio
...
src,cmake: define BOOST_ASIO_USE_TS_EXECUTOR_AS_DEFAULT for Boost.Asio users and cleanups
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2020-11-26 18:18:22 +08:00
Sebastian Wagner
0cc58de5c7
mgr/cephadm: add docstring describing the HostCache
...
Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
2020-11-26 11:03:00 +01:00
Adam Kupczyk
58f94cc98b
os/bluestore: Fixed memory leak in test
...
This is only unittest issue. This (potential) problems do not appear is BlueStore itself.
Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
2020-11-26 04:53:34 -05:00
Yingxin Cheng
f2b81287e6
crimson/net: add comments to Messenger bind methods
...
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2020-11-26 16:33:47 +08:00
Yingxin Cheng
13f656d91b
crimson/net: remove unused add_dispatcher()
...
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
2020-11-26 16:30:36 +08:00
Jan Fajerski
59c6ba580c
Merge PR #38149 into master
...
* refs/pull/38149/head:
ceph-volume inventory: make libstoragemgmt data retrieval optional
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Dan Mick <dmick@redhat.com>
2020-11-26 08:14:25 +01:00
haoyixing
f5fd172559
doc/mgr/prometheus: update 'config-key set' to 'config set' for consistency
...
Elsewere in mgr/prometheus use the 'config set' way, so update the only 'config-key set'
to make it consistent.
Signed-off-by: haoyixing <haoyixing@kuaishou.com>
2020-11-26 14:23:56 +08:00
Brad Hubbard
e70483133d
run-make-check.sh: Make sure a build failure will exit
...
We 'set -e' but that is ignored because 'build tests' is executed in a
'&&' list (see 'man set') so move the echo to the following line.
Follow-up to 03ff2146f9
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
2020-11-26 15:32:35 +10:00
Brad Hubbard
7f533f5ecd
Merge pull request #38292 from badone/wip-dont-run-tests-if-build-fails
...
run-make-check.sh: Don't run tests if build fails
Reviewed-by: Kefu Chai <kchai@redhat.com>
2020-11-26 13:33:46 +10:00
Brad Hubbard
03ff2146f9
run-make-check.sh: Don't run tests if build fails
...
When run-make was taken out we lost the 'set -e' call and therefore
continue after an error.
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
2020-11-26 11:20:06 +10:00
Patrick Donnelly
ba055a743c
Merge PR #38121 into master
...
* refs/pull/38121/head:
client: do not unset the client_debug_inject_tick_delay
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-11-25 13:30:04 -08:00
Patrick Donnelly
f5909c2078
Merge PR #38109 into master
...
* refs/pull/38109/head:
mds: dir->mark_new() should together with dir->mark_dirty()
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-11-25 13:29:16 -08:00
Patrick Donnelly
f7c9ce50ae
Merge PR #38031 into master
...
* refs/pull/38031/head:
client: check rdonly file handle on truncate
test/libcephfs: test truncate on rdonly fd
Reviewed-by: Jeff Layton <jlayton@redhat.com>
2020-11-25 13:28:25 -08:00
Patrick Donnelly
f7c056020e
Merge PR #38104 into master
...
* refs/pull/38104/head:
client: dump which fs is used by client for multiple-fs
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2020-11-25 13:27:19 -08:00
Jan Fajerski
b29a54d21e
ceph-volume inventory: make libstoragemgmt data retrieval optional
...
Default to not retrieving libstoragemgmt data since it seems this can
cause serious issues on older hardware. Safest way is to only retrieve
lsm data when the user opts in..
Fixes: https://tracker.ceph.com/issues/48270
Signed-off-by: Jan Fajerski <jfajerski@suse.com>
2020-11-25 22:19:00 +01:00
Boris Ranto
dd5886c3c0
mgr/prometheus: use threading.Event instead of sleep
...
This allows us to avoid waiting for the sleep to finish when waiting for
the thread to finish.
Signed-off-by: Boris Ranto <branto@redhat.com>
2020-11-25 20:49:50 +01:00
Boris Ranto
28a5c13bf9
mgr/prometheus: Log collection issues
...
Log any issues encountered during the data collection and continue to
collect the data anyway (after a sleep).
Signed-off-by: Boris Ranto <branto@redhat.com>
2020-11-25 16:32:16 +01:00
Mykola Golub
8dbb87cf5f
Merge pull request #38068 from dillaman/wip-librbd-migration-4
...
librbd: S3-based migration source
Reviewed-by: Mykola Golub <mgolub@suse.com>
2020-11-25 17:30:54 +02:00
Boris Ranto
aa0650092d
mgr/prometheus: Use mgr.release_name for always on modules
...
The host_version is not populated properly in the early stages of ceph
mgr start up process. We can use mgr.release_name instead. It is more
stable and it provides the data even if mgr_map does not contain the
versions, yet.
Signed-off-by: Boris Ranto <branto@redhat.com>
meh
2020-11-25 16:30:31 +01:00
Kefu Chai
70e99e76b5
mgr: do not migrate conf from config-key store to new-style conf
...
since all module options are using the new-style config framework.
the migration is offered for the use case of upgrade from luminous to mimic,
since pacific can only be upgraded from octopus. the mimic monitors are alreay
able to populate the configurations to mgr, not to mention the octopus
monitors, so there is no need to migrate the options stored in config-key
store anymore.
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-11-25 23:30:15 +08:00
zdover23
6497da98d7
Merge pull request #38195 from anthonyeleven/anthonyeleven/docs-14730
...
doc/rados/troubleshooting: description of upgrade procedure - stopping/starting OSDs
Reviewed-by: Zac Dover <zac.dover@gmail.com>
2020-11-26 01:27:06 +10:00
Kefu Chai
7924528b8c
Merge pull request #38276 from tchaikov/wip-labeler
...
github/labeler: add "rgw" label to rgw related changes
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2020-11-25 23:03:02 +08:00
Mykola Golub
2578b4ef4e
librbd: reserve async request id globally
...
We don't want it to be reset after an image is reopen as it may
cause requests being treated as duplicate.
Signed-off-by: Mykola Golub <mgolub@suse.com>
2020-11-25 14:35:23 +00:00
zdover23
2d25182893
Merge pull request #38091 from anthonyeleven/anthonyeleven/docs-46367
...
doc/dev/developer_guide: verb disagreement on "Testing: Unit Tests" page
Reviewed-by: Zac Dover <zac.dover@gmail.com>
2020-11-26 00:19:38 +10:00
zdover23
ea57d5d7ee
Merge pull request #38143 from anthonyeleven/anthonyeleven/docs-46364
...
doc/dev/developer_guide: What Is Merged and When?" could be less colloquial
Reviewed-by: Zac Dover <zac.dover@gmail.com>
2020-11-26 00:16:51 +10:00
Volker Theile
d3e09b6e04
mgr: Fix various typos
...
Signed-off-by: Volker Theile <vtheile@suse.com>
2020-11-25 15:16:00 +01:00
zdover23
3cea1e5a2a
Merge pull request #38079 from anthonyeleven/anthonyeleven/docs-24143
...
doc/rados/configuration/common.rst: enhance the running multiple clusters section
Reviewed-by: Zac Dover <zac.dover@gmail.com>
2020-11-26 00:14:51 +10:00
Boris Ranto
03fcaccafc
mgr/prometheus: Clean up collection thread
...
We need to clean up the metrics collection thread.
Signed-off-by: Boris Ranto <branto@redhat.com>
2020-11-25 15:13:07 +01:00
Augustinas
0d73909779
doc: Remove duplicate sentence in sync module documentation
...
Signed-off-by: Augustinas Šimelionis <augustinas.simelionis@gmail.com>
2020-11-25 15:39:01 +02:00
zdover23
eefa5e33ff
Merge pull request #38088 from anthonyeleven/anthonyeleven/docs-47627
...
doc/mgr: document dashboard configuration unsetting
Reviewed-by: Zac Dover <zac.dover@gmail.com>
2020-11-25 22:10:41 +10:00
Jan Fajerski
72c9cc7c6d
Merge PR #38156 into master
...
* refs/pull/38156/head:
ceph-volume batch: reject partitions in argparser
Reviewed-by: Dimitri Savineau <dsavinea@redhat.com>
Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>
2020-11-25 11:41:19 +01:00
Volker Theile
24a2495ba3
mgr/dashboard: Use pipe instead of calling function within template wherever possible
...
https://tracker.ceph.com/issues/48181
Signed-off-by: Volker Theile <vtheile@suse.com>
2020-11-25 11:28:00 +01:00
Kefu Chai
3c0ab38aba
github/labeler: label src/test/** with "tests"
...
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-11-25 18:14:42 +08:00
Kefu Chai
daee16839a
github/labeler: add "rgw" label to rgw related changes
...
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-11-25 18:14:42 +08:00
Mykola Golub
8b08c7bad6
librbd: make sure we are not loosing exclusive lock
...
when starting a serialized maintenance operation
Signed-off-by: Mykola Golub <mgolub@suse.com>
2020-11-25 10:13:35 +00:00
Mykola Golub
2cdbfa868c
librbd: serialize maintenance operations by type
...
Signed-off-by: Mykola Golub <mgolub@suse.com>
2020-11-25 10:13:35 +00:00