Commit Graph

94050 Commits

Author SHA1 Message Date
Patrick Donnelly
8ef68663d3
MDSMonitor: add missing OSDMonitor writeable check
Fixes: http://tracker.ceph.com/issues/37929

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2019-01-15 14:26:22 -08:00
Patrick Donnelly
1a3457be4e
MDSMonitor: codify constraint for writeable OSDMap
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2019-01-15 14:24:34 -08:00
Patrick Donnelly
4c49f165ec
MDSMonitor: add fs fail command
This command sets the fs as not joinable and fails all ranks. This is a simpler
command than the typical sequence: (a) set fs not joinable; (b) iterate through
and fail ranks. It also does this in a single FSMap update.

Fixes: http://tracker.ceph.com/issues/37085

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2019-01-15 14:22:48 -08:00
Noah Watkins
adc08c1f99 doc: sort releases by date and version
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
2019-01-15 13:15:29 -08:00
Jeff Layton
90b4c5157f mgr/rook: populate rados_config_location field
The dashboard ganesha management code requires the rados:// config
URL for the nfs-ganesha daemons. Ensure that we populate that.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
2019-01-15 14:14:35 -05:00
Jeff Layton
5df34eeb11 mgr/rook: lowercase the "RADOS" dict label
rook is lowercasing this tag in the CRD in response to review comments.
Change the orchestrator accordingly.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
2019-01-15 12:41:19 -05:00
Nathan Cutler
0a46fb0f45 doc: add mimic 13.2.3 and 13.2.4 to releases chart
Signed-off-by: Nathan Cutler <ncutler@suse.com>
2019-01-15 18:40:16 +01:00
Juan Miguel Olmo Martínez
77f20e725c
mgr/ansible: Replace deprecated <get_config> calls
Changes needed to replace the obsolete get_config by the new get_module_option manager module method

Signed-off-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
2019-01-15 18:04:06 +01:00
Sage Weil
b7273450df mon: make bootstrap rank check more robust
If we search for myaddrs, then we will detect our rank properly if we were
[a,b] and the a addr got removed.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-01-15 10:54:56 -06:00
Sage Weil
0c2f792aa7 mon: clean up probe debug output a bit
Signed-off-by: Sage Weil <sage@redhat.com>
2019-01-15 10:42:29 -06:00
Sage Weil
cb5ada1970 msg/async: use v1 for v1 <-> [v2,v1] peers
If *peers* are communicating, i.e. there may be bidirectional connection
attempts, we must use the same protocol version from both ends or else
we will get very confused.

Fix this by forcing the use of v1 when we

- are bound to a v1 endpoint only (people can't connect to us via v2)
- we are connecting to a *peer*

If it is a non-peer, then connections are uni-directional.  If we both
have v2, we will both use v2.

If we ever switch to [v2,v1], it will be as part of a restart.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-01-15 10:42:29 -06:00
Sage Weil
9459c6118a msg/async/AsyncMessenger: drop single-use _send_to
Signed-off-by: Sage Weil <sage@redhat.com>
2019-01-15 10:42:29 -06:00
Sage Weil
6ba8db68cd mon/HealthMonitor: raise MON_MSGR2_NOT_ENABLED if mons not bound to msgr2
If the ms_bind_msgr2 option is enabled, and all mons are nautilus,
raise a health alert if any mons aren't bound to msgr2 addresses.

Whitelist tests that mon_bind_addrvec=false or mon_bind_msgr2=false.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-01-15 10:42:29 -06:00
Sage Weil
57c4795c00 doc/rados/operations/health-checks: document MON_* health warnings
Signed-off-by: Sage Weil <sage@redhat.com>
2019-01-15 10:42:29 -06:00
Sage Weil
10a4a7fbda mon/MonMapMonitor: add 'mon enable-msgr2' command
This switches any monitor listening on v1:...:6789 only to v2 (on
3300) + v1 (on 6789).  It should be run after upgrading all monitors
to nautilus.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-01-15 10:42:29 -06:00
Sage Weil
2986a1b70e mon: respawn if rank addr changes
If the address for our rank change, then respawn!

Signed-off-by: Sage Weil <sage@redhat.com>
2019-01-15 10:42:29 -06:00
Sage Weil
38a99f04f4 Merge PR #25947 into master
* refs/pull/25947/head:
	msg/Messenger: remove get_connection() and send_message()
	ceph_test_msgr: remove final get_connection() user

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-01-15 09:42:40 -06:00
Patrick Donnelly
d0355acb36
common: restore constructor fmtflags on clear
This is to prevent fmtflags changes from a previous use (e.g. debug message)
leaking into the the next (i.e. the next debug message).

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2019-01-15 06:41:39 -08:00
Patrick Donnelly
cb1e7e5fd0
common: use better name reset for clear method
Reset is more analogous to re-initilization which is the intent.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2019-01-15 06:41:39 -08:00
Sage Weil
469f02d6c1 msg/msg_types: make set_sockaddr() work with AF_UNSPEC (i.e., zeroed)
Signed-off-by: Sage Weil <sage@redhat.com>
2019-01-15 08:24:48 -06:00
Sebastian Wagner
db677babac
Merge pull request #25649 from SUSE/wip-orchestrator-service-op
mgr/orchestrator: Add service_action method

Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Ricardo Dias <rdias@suse.com>
2019-01-15 14:37:35 +01:00
Sebastian Wagner
18a7863657
Merge pull request #25669 from sebastian-philipp/orchestrator-type-hinting
mgr/orchestrator: Improve docstrings, add type hinting

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Tim Serong <tserong@suse.com>
2019-01-15 14:36:40 +01:00
Patrick Nawracay
d207abf8d0 ceph_argparse: fix --verbose
Fixes traceback when issuing `ceph --verbose osd purge <id>`.

Signed-off-by: Patrick Nawracay <pnawracay@suse.com>
2019-01-15 13:55:18 +01:00
Lenz Grimmer
80945c8b95
Merge pull request #25543 from rjfd/wip-mgr-cli-commands
mgr: modules CLI commands declaration using @CLICommand decorator

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
2019-01-15 11:59:54 +01:00
Lenz Grimmer
4ac642c56a
Merge pull request #25426 from Tinatinak/fix_bug25094_2
mgr/dashboard: Filter out tasks depending on permissions

Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Sebastian Wagner <swagner@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
2019-01-15 10:59:10 +01:00
xie xingguo
c18d377c9f crush: fix memory leak
If we remove the last item of bucket, there should still be
one final entry in the __weights__ field of __weight_set__.
Free the corresponding memory before we __null__ the pointer.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2019-01-15 16:23:26 +08:00
Tim Serong
fa6cd8ae65 mgr/orchestrator_cli: Add service and service-instance start/stop/reload
Signed-off-by: Tim Serong <tserong@suse.com>
2019-01-15 17:11:06 +11:00
Tim Serong
cf2570bae7 mgr/orchestrator: Add service_action method
This is to facilitate service start/stop/reload (for example,
after altering NFS Ganesha configuration, we need to trigger
a service reload).

Signed-off-by: Tim Serong <tserong@suse.com>
2019-01-15 17:09:30 +11:00
Xie Xingguo
c55dc78903
Merge pull request #25953 from falcon78921/wip-doc-24924
doc: fixed typo in CRUSH map docs

Reviewed-by: xie xingguo <xie.xingguo@zte.com.cn>
2019-01-15 14:05:34 +08:00
Yingxin Cheng
e56277fbbb crimson/net: fix potential parallel write in SocketConnection
All the write/flush in SocketConnection should be serialized, or nasty
segment-fault could happen in seastar which is hard to diagnose.

This fix serializes the writes in `handle_keepalive2()` with other
writes in the open state.

Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>
2019-01-15 13:17:48 +08:00
Kefu Chai
1d0fcd847d common/pick_address: #include "ceph_context.h"
pick_address.cc reference cct->_conf, so it should include the
definition of of CephContext explicitly instead of relying on the fact
that some headers it includes include its definition.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-01-15 13:17:27 +08:00
Kefu Chai
af23895dba common/ip_addr: do not support numa preference if WITH_SEASTAR
in pick_address.cc, set_val_or_die() is called to set the "public_addr"
and/or "cluster_addr". but since the sharded ConfigProxy cannot
set_val_or_die() synchronously, we cannot do it this way.

we need to fix pick_addresses() so it works with seastar later. either
by making the involved function return future<>, or making the set_val()
call non-blocking or synchronous if we can go with 1:1 mapping
threading model.

but at this moment, let's just disable this feature in crimson-osd.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-01-15 12:05:47 +08:00
Kefu Chai
eb683a3a2a test/crimson: enable unittest_seastar_messenger
so we can at least compile it, even it fails sometimes.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-01-15 12:04:54 +08:00
Yingxin Cheng
39d778b681 crimson/net: fix unittest_seastar_messenger failure
unittest_seastar_messenger is failed since updated the seastar repo.
std::system_error (error system:22, Invalid argument) will be raised
from `listener->accept()`, which will be re-raised and not be captured.

This fix is to print error logs for the unexpected exceptions in
`SocketMessenger::start()` and not raise them again.

Signed-off-by: Yingxin Cheng <yingxincheng@gmail.com>
2019-01-15 12:02:33 +08:00
James McClune
c44d31167a doc: fixed typo in CRUSH map docs
Fixes: https://tracker.ceph.com/issues/24924
Signed-off-by: James McClune <jmcclune@mcclunetechnologies.net>
2019-01-14 22:16:20 -05:00
Sage Weil
0334cc19fa Merge PR #22612 into master
* refs/pull/22612/head:
	kv/RocksDBStore: Don't use sync mode when disableWAL is set.

Reviewed-by: Sage Weil <sage@redhat.com>
2019-01-14 20:49:51 -06:00
Sage Weil
f1505a081a Merge PR #25915 into master
* refs/pull/25915/head:
	mon/ConfigMonitor: add 'config generate-minimal-conf' command
	common/options: add FLAG_MINIMAL_CONF

Reviewed-by: Neha Ojha <nojha@redhat.com>
2019-01-14 20:49:34 -06:00
Sage Weil
02f6b7b623 msg/msg_types: make set_sockaddr() a bit more robust
We should keep the unused parts of u zeroed.

Signed-off-by: Sage Weil <sage@redhat.com>
2019-01-14 20:48:36 -06:00
Sage Weil
817baec24c msg/async: fix IP inference
socket_addr is *our* socket address; target_addr is the remote peer's
socket address.  We are inferring the remote's IP address here.

Fixes: http://tracker.ceph.com/issues/37882
Signed-off-by: Sage Weil <sage@redhat.com>
2019-01-14 20:45:28 -06:00
Patrick Donnelly
f0eb0e350b
Merge PR #25879 into master
* refs/pull/25879/head:
	client: define template to declare ref
	client: use message smart ptr instead of raw ptr
	client: make map lookup optimizations
	client: do not clear message payload
	client: clean up variable name
	*: use std::string_view instead of char ptr

Reviewed-by: Sage Weil <sage@redhat.com>
2019-01-14 15:40:30 -08:00
Patrick Donnelly
43415424d1
Merge PR #25921 into master
* refs/pull/25921/head:
	mds: convert const char ptr to string_view
	common/TrackedOp: use string_view interface

Reviewed-by: Sage Weil <sage@redhat.com>
2019-01-14 15:38:30 -08:00
Jason Dillaman
cdbc9ebad1
Merge pull request #25948 from liewegas/wip-fix-locker-addr
cls/lock: always store v1 addr in locker_info_t

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2019-01-14 17:24:46 -05:00
Ali Maredia
b5bd434598
Merge pull request #25881 from cbodley/wip-rgw-sanitize-v4
rgw: sanitize customer encryption keys from log output in v4 auth
2019-01-14 16:30:47 -05:00
Greg Farnum
498f17bb8b .githubmap: remove erroneous jlayton entry
He's jtlayton on github!

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
2019-01-14 13:29:08 -08:00
Greg Farnum
dc284249de .githubmap: switch Gregory Farnum to Greg
Signed-off-by: Greg Farnum <gfarnum@redhat.com>
2019-01-14 13:29:02 -08:00
Sage Weil
4372688e28 cls/lock: always store v1 addr in locker_info_t
Signed-off-by: Sage Weil <sage@redhat.com>
2019-01-14 14:50:58 -06:00
Jason Dillaman
0d18c2864d
Merge pull request #24446 from vico-research-and-consulting/master
common: fix for broken rbdmap parameter parsing

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2019-01-14 15:42:57 -05:00
Sage Weil
aa3d6f6667 msg/Messenger: remove get_connection() and send_message()
Signed-off-by: Sage Weil <sage@redhat.com>
2019-01-14 14:17:47 -06:00
Sage Weil
9284680f89 ceph_test_msgr: remove final get_connection() user
Signed-off-by: Sage Weil <sage@redhat.com>
2019-01-14 14:17:29 -06:00
Sage Weil
5478320ae7 Merge PR #25754 into master
* refs/pull/25754/head:
	msg/async/Protocol: send keepalive on connection race winner

Reviewed-by: Gregory Farnum <gfarnum@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
2019-01-14 14:11:14 -06:00