Commit Graph

131187 Commits

Author SHA1 Message Date
Samuel Just
83e9db3a8b crimson: retain reference to WaitForObjectRecovery until blocker resolves
PGRecovery::on_global_recover destroys the map entry without waiting for
the future returned from

    seastar::future<> wait_for_recovered(BlockingEvent::TriggerI& trigger) {

This commit changes WaitForObjectRecovery to be refcounted and retains a
reference until the future resolves.

Fixes: https://tracker.ceph.com/issues/55565
Signed-off-by: Samuel Just <sjust@redhat.com>
2022-05-06 23:21:54 +00:00
Rishabh Dave
02f0a3f136 qa/cephfs: omit_sudo must be passed to underlying method...
so that it can have it's intended effect.

Fixes: https://tracker.ceph.com/issues/55572
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2022-05-06 22:04:18 +05:30
Anthony D'Atri
74e57a6ab2
Merge pull request #46170 from elacunza/patch-1
doc/rados/operations: Add missing required parameters to stretch-mode CRUSH rule example
2022-05-06 08:42:41 -07:00
Prashant D
9b40fdad5a examples: Add rgw script to access admin APIs using curl
The rgw_admin_curl.sh script will allow end-user/developers to
access RGW admin APIs through curl command.

Signed-off-by: Prashant D <pdhange@redhat.com>
2022-05-06 11:14:12 -04:00
Jos Collin
0e66107c89
qa: drop get_blocklisted_instances in TestMirroring
drop get_blocklisted_instances in TestMirroring and use
is_addr_blocklisted instead.

Signed-off-by: Jos Collin <jcollin@redhat.com>
2022-05-06 18:16:12 +05:30
Ernesto Puerta
a7e57518a2
Merge pull request #46108 from rhcs-dashboard/fix-ingress-ssl-cert-validation
mgr/dashboard: fix ssl cert validation for ingress service creation

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: sunilangadi2 <NOT@FOUND>
2022-05-06 13:52:13 +02:00
Soumya Koduri
2e2eb69b7c rgw/dbstore: Add options to configure dbstore db file path & name_prefix
DBStore will use the below options when creating .db file for rgw server
to use.

'dbstore_db_dir':
    - path for the directory to store db backend store files
    - default: /var/run/ceph
'dbstore_db_name_prefix':
    - prefix to be used for the files created by db backend store
    - defauult: dbstore

For eg., by default the full path of the file shall be
eg., /var/run/ceph/dbstore-default_ns.db

Signed-off-by: Soumya Koduri <skoduri@redhat.com>
2022-05-06 15:51:45 +05:30
Jos Collin
47de5d79b8
qa: fix is_addr_blocklisted() to get blocklisted clients from 'osd dump'
By the introduction of range blocklist, the 'blocklist ls' command outputs
two lists. It's also straightforward to get the blocklisted clients directly
from 'osd dump' to avoid regression.

Fixes: https://tracker.ceph.com/issues/55516
Signed-off-by: Jos Collin <jcollin@redhat.com>
2022-05-06 13:50:32 +05:30
Aashish Sharma
334f4e141c mgr/cephadm: Disable external snapshots in grafana
This PR intends to disable the external snapshots in grafana to reduce security threats

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2022-05-06 13:30:51 +05:30
Eneko Lacunza
42c3018cfb doc/rados/operations: Add missing required parameters to stretch-mode CRUSH rule example
Rule example is missing min_size and max_size, both are required.

Signed-off-by: Eneko Lacunza <elacunza@binovo.es>
2022-05-06 09:31:27 +02:00
Samuel Just
8541ad1656 crimson: remove unused PGRecovery method declarations
Signed-off-by: Samuel Just <sjust@redhat.com>
2022-05-06 07:12:17 +00:00
Samuel Just
5aa342c9f0 crimson/osd: replace OpSequencer with simpler intrusive_list based implementation
Signed-off-by: Samuel Just <sjust@redhat.com>
2022-05-05 23:11:34 -07:00
Venky Shankar
40a4478782
Merge pull request #45935 from dparmar18/cephfs-shell-doc-update
doc/man/cephfs-shell.rst: add use of exclamation mark with cmds

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2022-05-06 09:52:03 +05:30
Samuel Just
580b5e24c6 crimson/osd/osd_operations/client_request: refactor for OSD::start_pg_operation
Signed-off-by: Samuel Just <sjust@redhat.com>
2022-05-06 03:45:17 +00:00
Samuel Just
abaa12ff2d crimson/osd/osd_operations/peering_event: refactor to use OSD::start_pg_operation
Signed-off-by: Samuel Just <sjust@redhat.com>
2022-05-06 03:45:17 +00:00
Samuel Just
244c17f738 crimson/osd/osd: introduce start_pg_operation
We're going to unify responsibility for routing requests to requests
to start_pg_operation from the different osd operation types.  Later,
this will move into a new type responsible for dealing with the pg->core
mapping.

Signed-off-by: Samuel Just <sjust@redhat.com>
2022-05-06 02:38:21 +00:00
Samuel Just
557adf64e2 crimson/osd: consolidate connection pipeline definitions
Really, all pg routable events (peering events, client operations, etc)
should have the same sequence of pre-pg blockers.

Signed-off-by: Samuel Just <sjust@redhat.com>
2022-05-06 02:38:21 +00:00
Samuel Just
bdeabe5d97 crimson/common/operation: return intrusive_ptr<T> rather than T::IRef
Signed-off-by: Samuel Just <sjust@redhat.com>
2022-05-06 02:38:21 +00:00
Samuel Just
d41f37c8bd crimson: rename WaitForActiveBlocker::on_active
We need to unblock this in cases other than on_active.

Signed-off-by: Samuel Just <sjust@redhat.com>
2022-05-06 02:38:21 +00:00
Kefu Chai
79639196dc
Merge pull request #46097 from tchaikov/wip-crimson-cleanups
crimson/osd/main: s/values/config_values/

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
2022-05-06 08:02:08 +08:00
Samuel Just
20ec94ccd2
Merge pull request #45788 from rzarzynski/wip-crimson-op-tracking-2
crimson: bring the core of op tracking

Reviewed-by: Samuel Just <sjust@redhat.com>
2022-05-05 12:56:42 -07:00
Samuel Just
ba1594092f vstart: default CEPH_ASOK_DIR to asok/
stop.sh removes the configured asok_dir, so defaulting this to out/
results in logs being removed.  Let's instead just create an
asok/ directory.

Fixes: https://tracker.ceph.com/issues/55563
Signed-off-by: Samuel Just <sjust@redhat.com>
2022-05-05 12:17:43 -07:00
Adam King
cfafb364ab
Merge pull request #46006 from phlogistonjohn/jjm-nfs-cleanups-pt4
mgr/nfs: minor organizational cleanups

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Michael Fritch <mfritch@suse.com>
2022-05-05 14:59:39 -04:00
Adam King
5cec97393f
Merge pull request #46035 from rkachach/fix_issue_52906
mgr/cephadm: adding logic to close ports when removing a daemon

Reviewed-by: Adam King <adking@redhat.com>
2022-05-05 14:52:07 -04:00
Daniel Gryniewicz
a0ae10eb44 RGW - Fix NoSuchTagSet error
A bug in AWS documentation caused this to be named "NoSuchTagSetError",
when the proper name (now fixed in the docs) is "NoSuchTagSet".  Fix
this so we match AWS.

Fixes: https://tracker.ceph.com/issues/55460
Author: Peter Gerber <peter@arbitrary.ch>
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
2022-05-05 12:10:53 -04:00
Rishabh Dave
94d2b1048f qa/vstart_runner: fix bug in LocalFuseMount._run_mount_cmd()
This methods fails to collect return value from
FuseMount._run_mount_cmd() and return it. This leads to a bug for tests
that expect mount command to fail when executed with vstart_runner.py.

Fixes: https://tracker.ceph.com/issues/55553
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2022-05-05 21:03:46 +05:30
Redouane Kachach
ae0cbacd1d
mgr/cephadm: fixing ipv6 handling during bootstrap
Fixes: https://tracker.ceph.com/issues/55556

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
2022-05-05 15:58:27 +02:00
Radosław Zarzyński
ecb25df889 crimson/osd: drop legacy base classes for pipeline stages
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
2022-05-05 12:39:29 +02:00
Radosław Zarzyński
2c1585c625 crimson/osd: drop the old blocking infrastructure
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
2022-05-05 12:39:28 +02:00
Radosław Zarzyński
fe66dc3a3b crimson/osd: strip blokcing_future from OperationT
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
2022-05-05 12:39:28 +02:00
Radosław Zarzyński
0ea3cc8f6a crimson/osd: migrate OperationThrottler to new tracking infra.
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
2022-05-05 12:39:28 +02:00
Radosław Zarzyński
ca9d38e1ec crimson/osd: crimson/osd: drop blocking_future from PGActivationBlocker
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
2022-05-05 12:39:28 +02:00
Radosław Zarzyński
409332f2f3 crimson/osd: crimson/osd: drop blocking_future from PGMap
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
2022-05-05 12:39:28 +02:00
Radosław Zarzyński
f693fabfe8 crimson/osd: drop blocking_future from OSDMapGate
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
2022-05-05 12:39:28 +02:00
Radosław Zarzyński
cd9d6bc2b5 crimson: bring the WaitBarrier tracking
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
2022-05-05 12:38:54 +02:00
Rishabh Dave
04209a1e7e vstart_runner: make LocalRemote inherit RemoteShell
And therefore get rid of methods duplicated in LocalRemote and add a
call to empty constructor of RemoteShell in LocalRemote.__init__().

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2022-05-05 12:30:24 +05:30
Ali Maredia
42b969b8be
Merge pull request #46033 from iqbalredkhan/quota2
rgw: Refactoring Quota Management
2022-05-05 00:42:26 -04:00
Xiubo Li
a328d3264a client: force send global open_files/metadata metrics
This change will fix two missing fixes introduce by commit
e9a26c551c.

Fixes: https://tracker.ceph.com/issues/54411
Signed-off-by: Xiubo Li <xiubli@redhat.com>
2022-05-05 10:24:13 +08:00
Radosław Zarzyński
013661412b crimson: move PipelineStageIT::enter() dispatch to compile-time
The optimization isn't the goal (but rather a side effect). The
reason behind this change is to let pipeline stages define exit
barriers incorporating `OpT`-dependant `Triggers` to track blocking
that happens on the barriers.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
2022-05-05 04:06:32 +02:00
Radosław Zarzyński
75a9cbbc74 crimson/os: add junction between OSD's ops and Seastore's OrderingHandle.
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
2022-05-05 04:06:32 +02:00
Radosław Zarzyński
b7e2b11595 crimson/osd: migrate AggregateBlocker-related ops to new tracking infra
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
2022-05-05 04:06:32 +02:00
Radosław Zarzyński
ee759133fa crimson/osd: bring AggregateBlockingEvent.
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
2022-05-05 04:06:32 +02:00
Radosław Zarzyński
232ea2cf45 crimson/osd: migrate PeeringEvent to new tracking infra, part 2
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
2022-05-05 04:06:32 +02:00
Radosław Zarzyński
df5e76a261 crimson/osd: add BlockingEvent-aware variant of OSD::get_or_create_pg
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
2022-05-05 04:06:32 +02:00
Radosław Zarzyński
69e465b2cf crimson/osd: migrate InternalClientRequest to new tracking infra.
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
2022-05-05 04:06:32 +02:00
Radosław Zarzyński
9498b440e6 crimson/osd: migrate RecoverySubRequest to new tracking infra.
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
2022-05-05 04:06:32 +02:00
Radosław Zarzyński
313337983f crimson/osd: migrate RepRequest to new tracking infra
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
2022-05-05 04:06:31 +02:00
Radosław Zarzyński
11ed546e10 crimson/osd: migrate PGAdvanceMap to new tracking infra.
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
2022-05-05 04:06:31 +02:00
Radosław Zarzyński
6ac63fc43d crimson/osd: reduce unnecessary indentation level in PGAdvanceMap::start()
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
2022-05-05 04:06:31 +02:00
Radosław Zarzyński
e2fc6f9a93 crimson/osd: migrate PeeringEvent to new tracking infra.
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
2022-05-05 04:06:31 +02:00