Commit Graph

98933 Commits

Author SHA1 Message Date
Casey Bodley
09e992ff01 qa/rgw: extra s3tests tasks use rgw endpoint configuration
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2019-06-19 07:50:35 -04:00
Lenz Grimmer
c634bd6f0c
mgr/dashboard: Update translations (#28059)
mgr/dashboard: Update translations

Reviewed-by: Laura Paduano <lpaduano@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
2019-06-18 13:20:20 +02:00
Lenz Grimmer
92a650ad19
Merge pull request #28377 from p-na/wip-pna-message-xlf-opt
mgr/dashboard: Improve hints shown when message.xlf is invalid

Reviewed-by: Tiago Melo <tmelo@suse.com>
2019-06-18 12:16:23 +02:00
Lenz Grimmer
363c81a858
mgr/dashboard: Log's time from UTC to local (#27777)
mgr/dashboard: Log's time from UTC to local

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
2019-06-18 12:14:09 +02:00
Sebastian Wagner
ee12c0c887
Merge pull request #28264 from rhcs-dashboard/mypy-config-to-file
src/script: extract mypy config to mypy.ini

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Sebastian Wagner <sebastian.wagner@suse.com>
2019-06-18 09:09:06 +02:00
Yuri Weinstein
10dfa31e23
Merge pull request #28605 from cbodley/wip-40304
qa/rgw: fix import error in tasks/swift.py

Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
2019-06-17 13:22:49 -07:00
Casey Bodley
2dd5574cf9 qa/rgw: fix import error in tasks/swift.py
> ImportError: No module named packaging

replaces packaging.version.Version with distutils.version.LooseVersion

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2019-06-17 15:07:40 -04:00
Lenz Grimmer
692b78891f
Merge pull request #28095 from Devp00l/wip-39702
mgr/dashboard: OSD custom action button removal

Reviewed-by: Kanika Murarka <kmurarka@redhat.com>
Reviewed-by: Patrick Nawracay <pnawracay@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
Reviewed-by: Tatjana Dehler <tdehler@suse.com>
2019-06-17 15:28:48 +02:00
Jason Dillaman
41334de1ee
Merge pull request #27670 from trociny/wip-rbd-mirror-fetch-autotune
rbd-mirror: adjust journal fetch properties based on memory target

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2019-06-17 09:02:58 -04:00
Jason Dillaman
6dd39a1764
Merge pull request #28524 from trociny/wip-qa-rbd-mirror-compare
qa/workunits/rbd: fix compare_images and compare_image_snapshots

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2019-06-17 09:02:40 -04:00
Jason Dillaman
34f2ba4e8f
Merge pull request #28529 from trociny/wip-journal-in_flight_advance_sets
journal: wait for in flight advance sets on stopping recorder

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
2019-06-17 09:01:04 -04:00
Lenz Grimmer
61c7632a3d
mgr/dashboard: Add QA tests for RBD configuration (#27774)
mgr/dashboard: Add QA tests for RBD configuration

Reviewed-by: Tatjana Dehler <tdehler@suse.com>
2019-06-17 13:29:00 +02:00
Kefu Chai
fbbe078a1e
Merge pull request #28586 from aclamk/fix-vstart-extra-conf
vstart.sh: Fix problem that all extra_conf got merged into single line.

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-06-17 17:57:16 +08:00
Adam Kupczyk
45f070bc12 vstart.sh: Fix problem that all extra_conf got merged into single line.
Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
2019-06-17 09:43:44 +02:00
Mykola Golub
1ddadde664
Merge pull request #28559 from dillaman/wip-40368
librbd: avoid dereferencing an empty container during deep-copy

Reviewed-by: Mykola Golub <mgolub@suse.com>
2019-06-15 11:34:34 +03:00
Xie Xingguo
5ae32b860f
Merge pull request #28487 from xiexingguo/wip-objecter-pg-mapping-cache
osdc/Objecter: pg-mapping cache

Reviewed-by: Sage Weil <sage@redhat.com>
2019-06-15 13:31:02 +08:00
Patrick Donnelly
44b6e4b60e
Merge PR #28082 into master
* refs/pull/28082/head:
	mgr / volumes: improve error handling
	py / cephfs: invoke base class Error::__init__() from OSError::__init__()
	mgr / volumes: carve out subvolume operations as a separate class
	mgr / volumes: introduce subvolume specification class
	mgr / volumes: carve of volume as a separate class
2019-06-14 14:51:07 -07:00
Patrick Donnelly
85470cd171
Merge PR #28198 into master
* refs/pull/28198/head:
	qa/tasks: upgrade command arguments checks in vstart_runner.py

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-06-14 11:44:17 -07:00
Jason Dillaman
0f491cbb96 librbd: avoid dereferencing an empty container during deep-copy
While updating the image copy progress, a 'while' loop will pop the
last item from the queue and then deference the empty queue.

Fixes: http://tracker.ceph.com/issues/40368
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
2019-06-14 13:34:24 -04:00
Kefu Chai
cbf3a1810b
Merge pull request #27773 from istudko/patch-1
doc/releases/nautilus: Correct a systemctl command in an upgrade guide

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-06-15 01:20:51 +08:00
Kefu Chai
afc6c1ea7b
Merge pull request #27201 from bstillwell/bootstrap-keyring-caps-doc-fix
doc: Add missing mgr cap for the bootstrap keyring

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-06-15 01:19:26 +08:00
Kefu Chai
496ac35237
Merge pull request #28526 from Osa1989/patch-1
doc/releases/nautilus.rst: fix command to check min_compat_client

Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-06-15 01:07:24 +08:00
Neha Ojha
94246359f2
Merge pull request #28522 from neha-ojha/wip-add-client-endpoints
qa/tasks/cbt.py: add support for client_endpoints

Reviewed-by: Mark Nelson <mnelson@redhat.com>
2019-06-14 09:34:57 -07:00
Mykola Golub
017bc7db97
Merge pull request #28346 from smithfarm/wip-39447-alt
qa/rbd: add cram-based snap diff test

Reviewed-by: Jason Dillaman <dillaman@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
2019-06-14 18:19:31 +03:00
Stephan Müller
27198db346 mgr/dashboard: OSD custom action button removal
Now the custom action dropdown is removed from the OSD component. It was
nearly a clone of the table actions button component, but it had a
different behavior as it did not show the main action inside the dropdown.

Fixes: https://tracker.ceph.com/issues/39702
Signed-off-by: Stephan Müller <smueller@suse.com>
2019-06-14 17:17:14 +02:00
Yuri Weinstein
2b3719264c
Merge pull request #28532 from cbodley/wip-40304
qa/rgw: skip swift tests on rhel 7.6+
2019-06-14 08:16:32 -07:00
Osa1989
a24323bc7a doc/releases/nautilus.rst: fix command to check min_compat_client
Command should be "ceph osd dump | grep min_compat_client"

Signed-off-by: Osama Elswah <osama.ibrahim.89@gmail.com>
2019-06-14 18:52:28 +08:00
Igor Fedotov
a9e9ceb5b2
Merge pull request #27951 from ifed01/wip-ifed-fix-slowop-log
os/bluestore: fix origin reference in logging slow ops.
2019-06-14 13:43:49 +03:00
Kefu Chai
1d5eba6557
Merge pull request #28490 from xiexingguo/wip-40193
mon/OSDMonitor: report pg[pgp]_num_target instead of pg[pgp]_num

Reviewed-by: Sage Weil <sage@redhat.com>
2019-06-14 18:29:38 +08:00
Kefu Chai
68baa91a2a
Merge pull request #28322 from liewegas/wip-preextend
os/bluestore: bluefs_preextend_wal_files=true

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
2019-06-14 18:27:44 +08:00
Laura Paduano
a6636bd941
Merge pull request #28260 from s0nea/wip-dashboard-pool-delete-flag
mgr/dashboard: consider 'mon_allow_pool_delete' flag

Reviewed-by: Patrick Nawracay <pnawracay@suse.com>
Reviewed-by: Stephan Müller <smueller@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
2019-06-14 12:02:02 +02:00
Kefu Chai
5e1c53e974
Merge pull request #28534 from tchaikov/wip-crimson-mkkey
crimson/osd: add --mkkey support

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-06-14 17:34:42 +08:00
Kefu Chai
1ce9d5a31c
Merge pull request #28464 from majianpeng/fio-ceph-messenger-multi-client
test/fio/fio_ceph_messenger: make exec multi client on the same host.

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>
2019-06-14 17:14:43 +08:00
Kefu Chai
fae1577223
Merge pull request #28404 from xiexingguo/wip-osd-noup-stall
osd/OSD: keep synchronizing with mon if stuck at booting

Reviewed-by: Sage Weil <sage@redhat.com>
2019-06-14 16:37:33 +08:00
Kefu Chai
5461047855 crimson/osd: ignore exception when stopping osd
OSD::stop() is a top-level method in the sense that it will be called
directly when engine stops. so it should not throw any exceptions.
instead, we will print out the error and ignore the exception if any.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-06-14 16:31:22 +08:00
Kefu Chai
d7be5b1f03 crimson/osd: add --mkkey support
see qa/tasks/ceph.py for how it is used, and why we need it.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-06-14 16:31:22 +08:00
Kefu Chai
4087a12890 crimson/os: use buffer::write_file() helper
instead of using the blocking calls

so we can write to file without blocking the reactor

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-06-14 16:31:22 +08:00
Kefu Chai
3c223cb117 crimson: add buffer_io helpers
Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-06-14 16:31:22 +08:00
Kefu Chai
91eb6b1e88
Merge pull request #28507 from tchaikov/wip-cmake-dpdk-boost
cmake: update SPDK to build with GCC-9

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-06-14 15:43:41 +08:00
Nathan Cutler
47645be3bb qa/rbd: add cram-based snap diff test
Fixes: http://tracker.ceph.com/issues/39447
Signed-off-by: Shyukri Shyukriev <shshyukriev@suse.com>
Signed-off-by: Nathan Cutler <ncutler@suse.com>
2019-06-14 09:42:23 +02:00
Kefu Chai
341245f5ba auth/KeyRing: remove KeyRing::create_empty()
it never fails unless out of memory. and it would be simpler to just
allocate it on stack.

Signed-off-by: Kefu Chai <kchai@redhat.com>
2019-06-14 15:19:30 +08:00
xie xingguo
8697db15c4 osdc/Objecter: pg-mapping cache
The CRUSH-based addressing is some kind of CPU intensive task
and hence should be avoid whenever possible.

The patch introduces a per objecter pg-mapping cache, which as
a result can saved us 10%+ CPU (fio, 4k randow read, 24k IOPS):

Was:
$ top -Hp 415864
top - 14:45:39 up 6 days,  5:45,  3 users,  load average: 9.67, 8.66, 8.45
Threads:  23 total,   3 running,  20 sleeping,   0 stopped,   0 zombie
%Cpu(s): 21.6 us, 14.5 sy,  0.0 ni, 59.6 id,  1.4 wa,  0.0 hi,  3.0 si,  0.0 st
KiB Mem : 19616576+total, 12773412+free, 50964508 used, 17467128 buff/cache
KiB Swap:  4194300 total,  4194300 free,        0 used. 14352892+avail Mem

    PID USER      PR  NI    VIRT    RES    SHR S %CPU %MEM     TIME+ COMMAND
 415942 root      20   0 1957800 492820 123880 R 80.0  0.3   0:13.75 tp_librbd

Now:
$ top -Hp 475779
top - 10:22:05 up  1:18,  4 users,  load average: 2.65, 1.44, 1.60
Threads:  23 total,   2 running,  21 sleeping,   0 stopped,   0 zombie
%Cpu(s):  6.1 us,  2.2 sy,  0.0 ni, 91.4 id,  0.0 wa,  0.0 hi,  0.2 si,  0.0 st
KiB Mem : 19616576+total, 13919555+free, 27280820 used, 29689392 buff/cache
KiB Swap:  4194300 total,  4194300 free,        0 used. 16798102+avail Mem

    PID USER      PR  NI    VIRT    RES    SHR S %CPU %MEM     TIME+ COMMAND
 476231 root      20   0 1957808 491712 123836 S 71.1  0.3   0:41.47 tp_librbd

And below is a more detailed report from the perf tool:

Was:
$ perf report -g graph
  Children      Self  Command    Shared Object        Symbol
+   29.33%     0.03%  tp_librbd  librados.so.2.0.0    [.] Objecter::op_submit
+   28.83%     0.09%  tp_librbd  librados.so.2.0.0    [.] Objecter::_op_submit_with_budget
+   27.12%     0.17%  tp_librbd  librados.so.2.0.0    [.] Objecter::_op_submit
+   16.47%     0.26%  tp_librbd  librados.so.2.0.0    [.] Objecter::_calc_target
+   15.04%     0.10%  tp_librbd  libceph-common.so.0  [.] OSDMap::_pg_to_up_acting_osds
+   13.52%     0.16%  tp_librbd  libceph-common.so.0  [.] OSDMap::_pg_to_raw_osds

Now:
$ perf report -g graph
  Children      Self  Command    Shared Object        Symbol
+   17.84%     0.04%  tp_librbd  librados.so.2.0.0    [.] Objecter::op_submit
+   17.34%     0.06%  tp_librbd  librados.so.2.0.0    [.] Objecter::_op_submit_with_budget
+   15.80%     0.17%  tp_librbd  librados.so.2.0.0    [.] Objecter::_op_submit
+    6.11%     2.02%  tp_librbd  librados.so.2.0.0    [.] Objecter::_calc_target

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
2019-06-14 14:42:31 +08:00
Kefu Chai
83b6d1429a
Merge pull request #28535 from tchaikov/wip-crimson-packaging
debian/: use ceph-osd for packaging crimson-osd

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2019-06-14 13:27:45 +08:00
Venky Shankar
241c9cea7c mgr / volumes: improve error handling
This cleans up lots of return-fu statements and make the source
look much more pythonic. Functions should raise an instance of
VolumeException() class wherever necessary (error handling).

Fixes: http://tracker.ceph.com/issues/39969
Signed-off-by: Venky Shankar <vshankar@redhat.com>
2019-06-14 00:26:51 -04:00
Venky Shankar
aad7906fb7 py / cephfs: invoke base class Error::__init__() from OSError::__init__()
This will allow access to `args` when catching `Error`.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
2019-06-14 00:26:51 -04:00
Venky Shankar
8d29816f0f mgr / volumes: carve out subvolume operations as a separate class
Move (and refactor) subvolume specific operations from main module
source to SubVolume class in a new subvolume source. Also, provide
hooks in VolumeClient to forward subvolume specific opertaions to
this class.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
2019-06-14 00:26:51 -04:00
Venky Shankar
021b80495d mgr / volumes: introduce subvolume specification class
Specifications class that represents a unique subvolume
identified by (subvolume-id, group-id) tuple. Provide
heleper functions for fetching  various subvolume specific
attributes such as subvolume path, group path etc.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
2019-06-14 00:26:51 -04:00
Venky Shankar
b3dc3b2dba mgr / volumes: carve of volume as a separate class
Move volume operations (create/delete) from main module source
to VolumeClient class in new volume source.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
2019-06-14 00:26:51 -04:00
Patrick Donnelly
c735b901da
Merge PR #28456 into master
* refs/pull/28456/head:
	mds: ignore sessionmap version mismatch if mds_wipe_sessions is set
	mds: fix corner case of replaying open sessions

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2019-06-13 12:22:05 -07:00
Casey Bodley
c0c00180bd
Merge pull request #28521 from alimaredia/wip-qa-rgw-ssl
qa: use curl in wait_for_radosgw() in util/rgw.py

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2019-06-13 15:00:21 -04:00