* refs/pull/28692/head:
test_volume_client: add positive test for ceph_volume_client method
test_volume_client: rename test_put_object_versioned()
test_volume_client: rewrite test_put_object_versioned
test_volume_client: use sudo_write_file() form teuthology
test_volume_client: make test_object_versioned py3 compatible
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
mgr/dashboard: Allow users to change their password on the UI
Reviewed-by: Ricardo Dias <rdias@suse.com>
Reviewed-by: Ricardo Marques <rimarques@suse.com>
The 'service' command was succeeding but not actually stopping ceph. But
we can safely assume systemd now so get rid of the weirdness here.
Signed-off-by: Sage Weil <sage@redhat.com>
ceph_volume_client.py's put_object_versioned() has only one test. Since
this only test is a negative test it may fail to assure that
put_object_versioned() works as expected with positive inputs even when
it completes successfully. Therefore, write a positive test for better
coverage.
Also, make sure the new test is both python 2 and python3 compatible.
Signed-off-by: Rishabh Dave <ridave@redhat.com>
test_put_object_versioned() is too generic for a negative test that
specifically tests if the version is verified before writing.
Signed-off-by: Rishabh Dave <ridave@redhat.com>
The test's success depends on whether CommandFailedError exception is
raised. This manner of testing is unreliable since there's no way to
check if the exception was raised by the statement (in the embedded
Python program) the test expects to.
This implies that this test's failure may go undetected. This is primary
reason why bugs like tracker #38946 occured despite of having a test.
Fixes: http://tracker.ceph.com/issues/39510
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Instead of defining another method to write a file as root user in
test_volume_client.py, use the method from teuthology/misc.py.
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Convert strings to bytes in the Python program embedded inside this
test. Also, in the process don't lose Python 2 compatibility.
Fixes: http://tracker.ceph.com/issues/39405
Signed-off-by: Rishabh Dave <ridave@redhat.com>
* refs/pull/28978/head:
qa/tasks/mgr/dashboard/test_health: fix test_full_health test
mon: use per-pool stats only when all OSDs are reporting
osd: report whether we have per-pool stats
osd/osd_types: osd_stat_t: include num_per_pool_osds member
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
* refs/pull/28990/head:
qa: vstart_runner fails because of string index out of range
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Laura Paduano <lpaduano@suse.com>
Fix problem in LocalRemote::_perform_checks_and_return_list_of_args() when LocalCephManager::raw_cluster_cmd() is called with a empty command parameter.
Fixes: https://tracker.ceph.com/issues/40729
Signed-off-by: Volker Theile <vtheile@suse.com>
Currently these can be thrown off if the cluster is creating or removing
pools at the same time. Fix by taking a single snapshot of the pg stats
and based our judgement on that.
Signed-off-by: Sage Weil <sage@redhat.com>
lifecycle_expiration tests require some additional configuration.
beast and civetweb are both strict about header parsing and require
fails_strict_rfc2616
Signed-off-by: Casey Bodley <cbodley@redhat.com>
.. and since we have async subvolume deletes now, check
trash directory for emptiness in other tests.
Fixes: http://tracker.ceph.com/issues/40036
Signed-off-by: Venky Shankar <vshankar@redhat.com>
Test `test_subvolume_create_with_desired_mode_in_group()` creates three
subvolume in a subvolume group. During cleanup, it only removed two of
the three subvolumes. This causes failure when removing the subvolume
group since it's not empty.
Signed-off-by: Venky Shankar <vshankar@redhat.com>
osd_repair_during_recovery=true allow explicitly requested reqair
to be scheduled on OSDs with active recovering.
Fixes: http://tracker.ceph.com/issues/40620
Signed-off-by: Jeegn Chen <jeegnchen@tencent.com>
