Commit Graph

12 Commits

Author SHA1 Message Date
Zac Dover
702cedf327 doc/dev: restructure basic-workflow.rst
- Rewrote a sentence about forking.
- s/exactly how to proceed/how to proceed/
- Changed titles to present participles
- Rewrote "Fixing the Bug Locally" to improve its elegance.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2020-12-31 15:18:34 +10:00
Zac Dover
0eaf991bd8 doc/dev: update auto pr validation section
This commit updates the "Automated PR Validation"
section of the "Basic Workflow" page in the
Developer Guide. This is part of a project that
aims to clean all of the sentences currently extant
in the Dev Guide, prior to a slight reorganization
of that guide for the sake of clarity and simplicity.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2020-12-17 00:32:58 +10:00
Anthony D'Atri
d4b0215a84 doc/dev/developer_guide: prefer Latinate verbs to English phrasal verbs
Signed-off-by: Anthony D'Atri <anthony.datri@gmail.com>
Fixes: https://tracker.ceph.com/issues/46365
2020-11-23 13:07:19 -08:00
Zac Dover
85a251f029 doc/dev: improve make check text
This commit fixes the references to the
"make check" section in the "notes on
pr make check test" section and improves
the wording of that section so that it
reads a bit more clearly.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2020-11-13 13:36:07 +10:00
Zac Dover
5985eb9413 doc/dev: added the other four tests
This PR adds a list of tests that are performed
when a PR hits Github.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2020-09-24 09:49:36 +10:00
Zac Dover
f0d1ba50ce doc/dev: updated date from 2016
This updates a date from 2016 to 2020,
so that readers can be confident that the
procedure that they're reading has been recently
tested.

Signed-off-by: Zac Dover <zac.dover@gmail.com>
2020-09-22 19:10:15 +10:00
Kefu Chai
51b7b05026 doc/dev: fix broken "make check" link
Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-05 09:46:57 +08:00
Kefu Chai
40f9e1cee0 doc/dev: link to label not file
it's less error prone, and can help us avoid broken links if we move a
file around

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-05 09:46:57 +08:00
Kefu Chai
0f2489406a doc/dev: use prompt directive when appropriate
for 2 reasons:

* sphinx renders codeblock using python syntax highlighting by default,
  so it's not surprising that it highlight keywords like "export" in
  command line samples. so to render command line code blocks, we'd
  better specify the syntax explicitly for better rendering result.
* with the help of "prompt" directive, user is able to copy and paste
  the command without the prompt. for instance, with the default
  "::" directive, user will copy "$ ceph df", which is not very
  convenient, but with "prompt" directive, user only copies
  "ceph df".

Signed-off-by: Kefu Chai <kchai@redhat.com>
2020-09-05 00:03:52 +08:00
Zac Dover
a62847404c doc/dev: add proper Merge PR format
This commit adds an example of proper Merge PR format
to the Developer Guide. Though this might not be of
great use to most people, Zac Dover will find it most
helpful.

Fixes: https://tracker.ceph.com/issues/46843
Signed-off-by: Zac Dover <zac.dover@gmail.com>
2020-09-04 08:29:51 +10:00
Rishabh Dave
cbcb829575 doc: fix links in developer_guide
Fixes: https://tracker.ceph.com/issues/43663
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2020-01-20 11:33:48 +05:30
Rishabh Dave
5f2e33570a doc: split index.rst of dev guide
Move every section to a different file. Also, fix minor issues like
line-wrapping along.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2020-01-14 15:12:27 +05:30