Commit Graph

127560 Commits

Author SHA1 Message Date
Adam King
70c9c3d341 mgr/cephadm: unit test for osd preview limit warning
Signed-off-by: Adam King <adking@redhat.com>
2021-10-26 11:47:50 -04:00
Javier Cacheiro
8d99512e14 doc: data must be a byte string
Data must be a byte string in python 3.

Signed-off-by: Javier Cacheiro <javier.cacheiro.lopez@cesga.es>
2021-10-26 17:14:15 +02:00
Sebastian Wagner
a9dd13a0f3
Merge pull request #43668 from rhcs-dashboard/kube-v1_events-update
mgr/k8sevents: pin the kubernetes version to 11.0.0 

Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
2021-10-26 16:29:42 +02:00
Prasanna Kumar Kalever
2adfe55bcc qa/workunits/rbd: test map/attach with --show-cookie/--cookie options
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
2021-10-26 19:24:13 +05:30
Prasanna Kumar Kalever
16404dede8 rbd-nbd: allow user to specify cookie at map
Allow user to specify cookie of choice at the time of map

$ rbd device attach rbd-pool/image --device /dev/nbd0 \
	--cookie 6f85d970-10b2-456b-8baf-676aa4d782e4 --options try-netlink

Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
2021-10-26 19:24:13 +05:30
Prasanna Kumar Kalever
6df06c7a62 rbd: add --show-cookie/--cookie option for map/attach commands
Example:
$ rbd device map rbd-pool/image --show-cookie --try-netlink --device-type nbd

$ rbd device attach rbd-pool/image --device /dev/nbd0 \
      --cookie 6f85d970-10b2-456b-8baf-676aa4d782e4 --device-type nbd

older Kernel versions can use --force to skip the cookie validation

Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
2021-10-26 19:24:13 +05:30
Prasanna Kumar Kalever
833e71282a rbd-nbd: allow attach without --cookie for old kernel versions
For backward compatibility allow attach without --cookie option:

[root@linux-vm1]# rbd-nbd attach rbd-pool/image0 --device /dev/nbd0
/dev/nbd0

Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
2021-10-26 19:24:13 +05:30
Prasanna Kumar Kalever
efeb255d10 rbd-nbd: show per device cookie with list command
[root@linux-vm1]# rbd-nbd list-mapped
id    pool      namespace  image   snap  device     cookie
8133  rbd-pool             image0  -     /dev/nbd0  c704cb91-c6cf-466e-a335-0e935c0d5e47

Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
2021-10-26 19:24:13 +05:30
Prasanna Kumar Kalever
6ca70ee4f0 rbd-nbd: mandate device cookie for attach command
[root@linux-vm1]# rbd-nbd attach rbd-pool/image0 --device /dev/nbd0 \
                          --cookie c704cb91-c6cf-466e-a335-0e935c0d5e47
/dev/nbd0

Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
2021-10-26 19:24:13 +05:30
Prasanna Kumar Kalever
59c08eabf1 rbd-nbd: provide a flag to show device cookie with map command
[root@linux-vm1]# rbd-nbd map rbd-pool/image0 --try-netlink --show-cookie
/dev/nbd0 c704cb91-c6cf-466e-a335-0e935c0d5e47

Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
2021-10-26 19:24:13 +05:30
Prasanna Kumar Kalever
eee8d8a32e rbd-nbd: generate and send device cookie with netlink connect request
[root@linux-vm1]# rbd-nbd map rbd-pool/image0 --try-netlink
/dev/nbd0

[root@linux-vm1]# cat /sys/block/nbd0/backend
c704cb91-c6cf-466e-a335-0e935c0d5e47

Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
2021-10-26 19:24:13 +05:30
Cory Snyder
ea507d6c86 mgr/orchestrator: add --zap flag to 'orch osd rm'
Adds the ability to zap OSD devices after removal, implemented as a flag
on the 'orch osd rm' command.

Fixes: https://tracker.ceph.com/issues/43692
Signed-off-by: Cory Snyder <csnyder@iland.com>
2021-10-26 09:48:32 -04:00
Nizamudeen A
f54ea99cab mgr/k8sevents: pin the kubernetes version to 11.0.0
Fixes: https://tracker.ceph.com/issues/53044
Signed-off-by: Nizamudeen A <nia@redhat.com>
2021-10-26 18:16:29 +05:30
Avan Thakkar
78b8af2bda mgr/dashboard: gather facts should only be fetched when orch backend is cephadm
Fixes: https://tracker.ceph.com/issues/52981
Signed-off-by: Avan Thakkar <athakkar@redhat.com>

Gather facts in UI should only be fetched if there is orch available and
get_facts feature is available for that orch backend.
2021-10-26 16:37:40 +05:30
Nizamudeen A
81430251ed mgr/dashboard: Cluster expansion review page minor bug fixes
Fix the Total Memory coming up as NaN Undefined
Remove `Add` Button in the Cluster Details table

Fixes: https://tracker.ceph.com/issues/53038
Signed-off-by: Nizamudeen A <nia@redhat.com>
2021-10-26 15:26:10 +05:30
Sebastian Wagner
eff5c76d88
doc/cephadm/operations: extend CEPHADM_STRAY_DAEMON
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
2021-10-26 11:44:24 +02:00
Sebastian Wagner
d749453ce4
doc/cephadm: osd.rst: s/Note, /.. note:: /
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
2021-10-26 11:40:34 +02:00
Sebastian Wagner
61fe2a21b7
doc/cephadm: osd.rst: s/DriveGroup/OSD spec/
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
2021-10-26 11:40:33 +02:00
Sebastian Wagner
3b6ce664c3
doc/cephadm: osd.rst: Fix yaml comments
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
2021-10-26 11:40:33 +02:00
Sebastian Wagner
358a5ae588
doc/cephadm: Add "Deploying OSDs on multiple similar hosts"
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
2021-10-26 11:40:33 +02:00
Sebastian Wagner
84dce06aa8
doc/cephadm: indent yaml specs
properly conform with other service types

Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
2021-10-26 11:35:49 +02:00
Sebastian Wagner
f127e0829b
mgr/cephadm: Fix RGW ipv6 frontend configuration
Signed-off-by: Sebastian Wagner <sewagner@redhat.com>
2021-10-26 11:20:03 +02:00
Ernesto Puerta
8a4649e651
Merge pull request #43640 from rhcs-dashboard/module-status-guard-error-handling
mgr/dashboard: Proper error handling in module status guard

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2021-10-26 10:52:13 +02:00
Ernesto Puerta
5e1297ce3c
Merge pull request #43639 from rhcs-dashboard/angular-11-form-fix
mgr/dashboard: Fix for form inside form closing issue

Reviewed-by: Alfonso Martínez <almartin@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2021-10-26 10:51:22 +02:00
Sebastian Wagner
21cfba732b
Merge pull request #43560 from pcuzner/fix-orch-device-zap
mgr/cephadm: improve validation of orch device zap

Reviewed-by: Sage Weil <sage@newdream.net>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
2021-10-26 10:42:05 +02:00
Sebastian Wagner
46afe6b1df
Merge pull request #43499 from jecluis/wip-cephadm-insecure
cephadm: allow pulling from insecure registries

Reviewed-by: Michael Fritch <mfritch@suse.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
2021-10-26 10:27:24 +02:00
Sebastian Wagner
7ac3897c0c
Merge pull request #43502 from adk3798/rm-testing2
mgr/cephadm: remove host addr from agent deps

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Sebastian Wagner <sewagner@redhat.com>
2021-10-26 10:26:44 +02:00
Sebastian Wagner
646173097c
Merge pull request #43579 from sebastian-philipp/cephadm-monitoring-ipv6
mgr/cephadm: Fix IPv6 in monitoring services

Reviewed-by: Adam King <adking@redhat.com>
2021-10-26 10:24:32 +02:00
Samuel Just
925316ab35
Merge pull request #43632 from myoungwon/wip-alloc-free-rbm-paddr
seastore: add alloc/free extent for RBM based on paddr_t

Reviewed-by: Samuel Just <sjust@redhat.com>
2021-10-26 01:12:07 -07:00
Samuel Just
6dd58de82f
Merge pull request #43641 from athanatos/sjust/wip-52805
crimson/os/seastore: fix LBABtree::lower_bound behavior

Reviewed-by: Xuehan Xu <xxhdx1985126@gmail.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
2021-10-26 00:40:54 -07:00
Samuel Just
83c42539f7
Merge pull request #43651 from rzarzynski/wip-crimson-net-fix-nonceportcheck
crimson/net: don't enforce peer-perceived-myaddr matches myaddr if haven't learned it yet.

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2021-10-25 15:52:19 -07:00
Paul Cuzner
e6b17cde8b mgr/prometheus: update promtool testcase location
Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
2021-10-26 10:42:49 +13:00
Samuel Just
65e33d1fe5
Merge pull request #43650 from rzarzynski/wip-crimson-improve-dbgs
crimson, monmap: fix / improve miscellaneous debugs

Reviewed-by: Samuel Just <sjust@redhat.com>
2021-10-25 14:18:03 -07:00
Samuel Just
00378ed6f3
Merge pull request #43652 from rzarzynski/wip-crimson-osd-seqmeta
crimson/osd: write object store's meta sequentially.

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2021-10-25 14:17:11 -07:00
Samuel Just
617b87228f crimson/os/seastore/.../lba_btree: fix min_capacity condition
Reducing the size of split_merge_multi has an interesting side effect of
causing removes to happen on some leaf nodes immediately after split.
After split, child nodes would have size 72 or 73.  At size 72, the node
would be at_min_size() and a remove would put it below causing the
at_min_size() condition to fail and hande_merge to misbehave.

Replace at_min_capacity() with below_min_capacity().
below_min_capacity() will not be true for any child of a split, and
asserts that the child is below capacity by no more than 1.

Signed-off-by: Samuel Just <sjust@redhat.com>
2021-10-25 19:59:36 +00:00
Samuel Just
542d237ffe crimson/os/seastore/.../lba_btree: fix lower_bound at_boundary()
Clarify that lookup_depth_range may return an iterator at_boundary() and
audity users.

Fix LBABtree::lookup to correctly handle at_boundary() after the call to
lookup_depth_range.

Fixes: https://tracker.ceph.com/issues/52805
Signed-off-by: Samuel Just <sjust@redhat.com>
2021-10-25 19:59:36 +00:00
Samuel Just
505492844c crimson/os/seastore/lba_manager/lba_btree: factor out iterator::handle_boundary
Factor out helper to adjust iterators at_boundary().

Signed-off-by: Samuel Just <sjust@redhat.com>
2021-10-25 19:59:36 +00:00
Samuel Just
dd2c699892 crimson/os/seastore/lba_manager/lba_btree: add at_boundary helper distinct from is_end
From an external caller, the condition is identical.  However, internally
iterators may be at a leaf boundary without being at end().  For those
checks, use at_boundary() instead.

Signed-off-by: Samuel Just <sjust@redhat.com>
2021-10-25 19:59:36 +00:00
Samuel Just
eb79d8a3bc crimson/test/seastore/test_btree_lba_manager: shorten tests a bit
Signed-off-by: Samuel Just <sjust@redhat.com>
2021-10-25 19:59:36 +00:00
Samuel Just
1c7e53d778 test/crimson/seastore/test_btree_lba_manager: add LBABtree level unit tests
Signed-off-by: Samuel Just <sjust@redhat.com>
2021-10-25 19:59:33 +00:00
J. Eric Ivancich
4edde6a2c9 rgw: explicitly use std namespace in bucket listing functions
Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
2021-10-25 15:30:55 -04:00
J. Eric Ivancich
b1debef085 rgw: add logging to bucket listing so calls are better understood
The logic to bucket listing is complex due to the sharded bucket
indicies. When a log is examined, there should be enough information
to follow the logic.

Logging that touches every entry listed is at 20. Logging that
describes exiting of the listing are at level 10.

Additionally make logging more uniform and streamlined. Remove "INFO"
as that seems redundant (but keep "ERROR" and "WARNING"). Dispense
with class name decorating function name since there aren't any
similar function names.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
2021-10-25 15:30:52 -04:00
Adam King
212f88cbbc mgr/cephadm: inform users if limit set for data devices is not met
Signed-off-by: Adam King <adking@redhat.com>
2021-10-25 13:45:03 -04:00
Daniel Pivonka
441869220c doc/cephadm: note that replacment osd needs to be on same host as removed osd
Signed-off-by: Daniel Pivonka <dpivonka@redhat.com>
2021-10-25 13:04:00 -04:00
Mykola Golub
8c646721c2
Merge pull request #41696 from MrFreezeex/fix-rbd-mirror-remove
rbd-mirror: fix mirror image removal

Reviewed-by: Mykola Golub <mgolub@suse.com>
2021-10-25 18:12:38 +03:00
Aashish Sharma
caa177265c mgr/dashboard: Cluster Creation Add multiple hosts at once
Add multiple hosts at once in cluster creation wizard

Fixes: https://tracker.ceph.com/issues/52759
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2021-10-25 19:53:43 +05:30
Yuval Lifshitz
b932c96b20
Merge pull request #43528 from TRYTOBE8TME/wip-rgw-malformed-url-fix
src/rgw: Fix for malformed url
2021-10-25 17:07:14 +03:00
Mykola Golub
03d922ec87
Merge pull request #41657 from sunnyku/wip-rbd-50787
librbd/object_map: rbd diff between two snapshots lists entire image content

Reviewed-by: Mykola Golub <mgolub@suse.com>
2021-10-25 16:19:48 +03:00
Radoslaw Zarzynski
b3b35dba97 crimson/osd: write object store's meta sequentially.
We're violating the contract on `ObjectStore::write_meta()' that
requires the method must be called in one-by-one manner.
For instance, the implementation in `BlueStore` does read-modify-
write without any locking. Having multiple in-flight requests
the same time (can happen b/c of the thread pool in `AlienStore`)
may lead to a corruption like the following one:

```
[2021-10-25 13:38:38,725][ceph_volume.process][INFO  ] Running command: /home/rzarz/dev/ceph1/build/bin/ceph-bluestore-tool show-label --dev /dev/nvme0n1p3
[2021-10-25 13:38:38,737][ceph_volume.process][INFO  ] stdout {
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "/dev/nvme0n1p3": {
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "osd_uuid": "a11030f3-f41f-482c-916c-98476feaf25f",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "size": 1022903713792,
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "btime": "2021-10-25T12:41:11.938439+0200",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "description": "main",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "bfm_blocks": "249732352",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "bfm_blocks_per_key": "128",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "bfm_bytes_per_block": "4096",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "bfm_size": "1022903713792",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "bluefs": "1",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "ceph_fsid": "f884fe47-b307-46f9-b021-320d7c5a427b",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "kv_backend": "rocksdb",
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout "mkfs_done": "yes"
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout }
[2021-10-25 13:38:38,738][ceph_volume.process][INFO  ] stdout }
[2021-10-25 13:38:38,738][ceph_volume.devices.raw.list][ERROR ] device /dev/nvme0n1p3 does not have all BlueStore data needed to be a valid OSD: ['{', '    "/dev/nvme0n1p3": {', '        "osd_uuid": "a11030f3-f41f-482c-916c-98476feaf25f",', '        "size": 1022903713792,', '        "btime": "2021-10-25T12:41:11.938439+0200",', '        "description": "main",', '        "bfm_blocks": "249732352",', '        "bfm_blocks_per_key": "128",', '        "bfm_bytes_per_block": "4096",', '        "bfm_size": "1022903713792",', '        "bluefs": "1",', '        "ceph_fsid": "f884fe47-b307-46f9-b021-320d7c5a427b",', '        "kv_backend": "rocksdb",', '        "mkfs_done": "yes"', '    }', '}']
'whoami'
[2021-10-25 13:38:38,738][ceph_volume.devices.raw.list][INFO  ] device /dev/nvme0n1p3 does not have BlueStore information
```

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
(cherry picked from commit 92b2fe955f9cafdf6a9c6adb8eadc5f6a9fb9b8b)
2021-10-25 13:18:15 +00:00
Radoslaw Zarzynski
1a41f3c16f crimson/net: don't enforce peer-perceived-myaddr matches myaddr if haven't learned it yet.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2021-10-25 13:16:06 +00:00