Commit Graph

139234 Commits

Author SHA1 Message Date
Rishabh Dave
0584cd34b6
Merge pull request #52709 from rishabh-d-dave/cephfs-test_snapshots
qa/cephfs: fix test_disallow_monitor_managed_snaps_for_fs_pools

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-08-02 19:18:07 +05:30
Casey Bodley
dd4baa9b64
Merge pull request #52762 from yuvalif/wip-yuval-62264
rgw/amqp: skip idleness tests since it needs to sleep longer than 30s

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2023-08-02 09:41:36 -04:00
Ilya Dryomov
81acc943c9
Merge pull request #52559 from adamemerson/wip-62097
build: Remove ceph-libboost* packages in install-deps

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2023-08-02 13:36:17 +02:00
Yuval Lifshitz
11439ecd89 rgw/amqp: skip idleness tests since it needs to sleep longer than 30s
current idle timeout is 30s, so, making the test sleep for 30s may not
be enough. setting sleep time to be longer, and skippign the test so it
won't take too long.

Fixes: https://tracker.ceph.com/issues/62264

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
2023-08-02 10:27:40 +00:00
Avan
bab9535757
Merge pull request #52698 from rhcs-dashboard/fix-instance-id-exporter
exporter: fix instance_id labeld value for rgw in exporter

Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2023-08-02 14:26:47 +05:30
zdover23
7931020f09
Merge pull request #51960 from rzarzynski/wip-doc-encoding
doc: improve doc/dev/encoding.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Neha Ojha <nohja@redhat.com>
2023-08-02 17:45:51 +10:00
Venky Shankar
a920634317 Merge PR #52569 into main
* refs/pull/52569/head:
	test/libcephfs: update delegation test assertions

Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-08-02 11:00:37 +05:30
Adam King
ae3df0adde
Merge pull request #47573 from phlogistonjohn/jjm-cpatch-py
cpatch.py:  a python based cpatch script

Reviewed-by: Adam King <adking@redhat.com>
2023-08-01 17:51:32 -04:00
Casey Bodley
4b912b79c9
Merge pull request #52732 from cbodley/wip-qa-cephfs-flake8-random
qa/cephfs: redefinition of unused 'random' from line 7

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Adam King <adking@redhat.com>
2023-08-01 16:26:23 -04:00
Patrick Donnelly
468a193389
Merge PR #52675 into main
* refs/pull/52675/head:
	test/TestOSDMap: don't use the deprecated std::random_shuffle method

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2023-08-01 14:56:32 -04:00
Casey Bodley
568a21d83c qa/cephfs: redefinition of unused 'random' from line 7
seeing this run-tox-qa failure about tasks/cephfs/test_client_recovery.py:

246/285 Test #264: run-tox-qa ................................***Failed   58.54 sec
Requirement already satisfied: tox in /home/jenkins-build/build/workspace/ceph-pull-requests/build/qa-virtualenv/lib/python3.10/site-packages (4.6.4)
Requirement already satisfied: cachetools>=5.3.1 in /home/jenkins-build/build/workspace/ceph-pull-requests/build/qa-virtualenv/lib/python3.10/site-packages (from tox) (5.3.1)
Requirement already satisfied: chardet>=5.1 in /home/jenkins-build/build/workspace/ceph-pull-requests/build/qa-virtualenv/lib/python3.10/site-packages (from tox) (5.1.0)
Requirement already satisfied: colorama>=0.4.6 in /home/jenkins-build/build/workspace/ceph-pull-requests/build/qa-virtualenv/lib/python3.10/site-packages (from tox) (0.4.6)
Requirement already satisfied: filelock>=3.12.2 in /home/jenkins-build/build/workspace/ceph-pull-requests/build/qa-virtualenv/lib/python3.10/site-packages (from tox) (3.12.2)
Requirement already satisfied: packaging>=23.1 in /home/jenkins-build/build/workspace/ceph-pull-requests/build/qa-virtualenv/lib/python3.10/site-packages (from tox) (23.1)
Requirement already satisfied: platformdirs>=3.8 in /home/jenkins-build/build/workspace/ceph-pull-requests/build/qa-virtualenv/lib/python3.10/site-packages (from tox) (3.10.0)
Requirement already satisfied: pluggy>=1.2 in /home/jenkins-build/build/workspace/ceph-pull-requests/build/qa-virtualenv/lib/python3.10/site-packages (from tox) (1.2.0)
Requirement already satisfied: pyproject-api>=1.5.2 in /home/jenkins-build/build/workspace/ceph-pull-requests/build/qa-virtualenv/lib/python3.10/site-packages (from tox) (1.5.3)
Requirement already satisfied: tomli>=2.0.1 in /home/jenkins-build/build/workspace/ceph-pull-requests/build/qa-virtualenv/lib/python3.10/site-packages (from tox) (2.0.1)
Requirement already satisfied: virtualenv>=20.23.1 in /home/jenkins-build/build/workspace/ceph-pull-requests/build/qa-virtualenv/lib/python3.10/site-packages (from tox) (20.24.2)
Requirement already satisfied: distlib<1,>=0.3.7 in /home/jenkins-build/build/workspace/ceph-pull-requests/build/qa-virtualenv/lib/python3.10/site-packages (from virtualenv>=20.23.1->tox) (0.3.7)
flake8: install_deps /home/jenkins-build/build/workspace/ceph-pull-requests/qa> python -I -m pip install flake8
flake8: freeze /home/jenkins-build/build/workspace/ceph-pull-requests/qa> python -m pip freeze --all
flake8: flake8==6.1.0,mccabe==0.7.0,pip==22.3.1,pycodestyle==2.11.0,pyflakes==3.1.0,setuptools==65.6.3,wheel==0.38.4
flake8: commands[0] /home/jenkins-build/build/workspace/ceph-pull-requests/qa> flake8 --select=F,E9 --exclude=venv,.tox
./tasks/cephfs/test_client_recovery.py:12:1: F811 redefinition of unused 'random' from line 7
flake8: exit 1 (3.72 seconds) /home/jenkins-build/build/workspace/ceph-pull-requests/qa> flake8 --select=F,E9 --exclude=venv,.tox pid=706315
flake8: FAIL ✖ in 15.42 seconds

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2023-08-01 12:31:44 -04:00
Venky Shankar
86c9a7a08d Merge PR #51995 into main
* refs/pull/51995/head:
	qa: wait for file to have correct size

Reviewed-by: Milind Changire <mchangir@redhat.com>
2023-08-01 20:36:59 +05:30
Adam Kupczyk
9673383f29
Merge pull request #52305 from Posrabi/wip-disk-frag-sim-metrics
test/objectstore: Disk Fragmentation Simulator Metrics
2023-08-01 15:50:41 +02:00
avanthakkar
ca5691834c exporter: fix instance_id labeld value for rgw in exporter
Signed-off-by: avanthakkar <avanjohn@gmail.com>
2023-08-01 17:56:47 +05:30
John Mulligan
524385b671 script: add a new cpatch.py that is like cpatch but in python
This is a somewhat straightforward translation of the current cpatch
bash script into python. The image is built in the same manner but some
of the python components can be selected in a more granular manner.

Why do this? I had my own private copy of the cpatch script that I have
been modifying for my own needs, one that has the previously mentioned
more granular selection of python components. However, I had additional
plans for this script and found it difficult to manage and I felt that a
single-source-file python program would allow the use of python's nicer
(IMO) CLI parsing, data structures, and standard library modules. I also
think that this provides a cleaner program structure that will allow for
experimentation with different backends vs. the current approach of
copying files and creating a temporary Dockerfile.

For whatever reason the original cpatch was assuming that the python
version was 3.8, however in the current ceph images using centos 8
stream as a base, python 3.6 is the available python version.

Old versions of ceph kept cephadm as one large single source file in the
source tree. New versions "compile" cephadm into a python zipapp. Try to
automatically detect which case and "install" the correct form of
cephadm.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2023-08-01 07:58:25 -04:00
Pedro Gonzalez Gomez
68dda21953
Merge pull request #52526 from rhcs-dashboard/volume-create
mgr/dashboard: cephfs volume creation form


Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: cloudbehl <NOT@FOUND>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2023-08-01 13:17:13 +02:00
Pedro Gonzalez Gomez
172133f18b
Merge pull request #52493 from rhcs-dashboard/cluster-upgrade-ui
mgr/dashboard: cluster upgrade start UI


Reviewed-by: Pegonzal <pegonzal@redhat.com>
Reviewed-by: cloudbehl <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2023-08-01 10:46:51 +02:00
Leonid Usov
0355021e8f test/TestOSDMap: don't use the deprecated std::random_shuffle method
Signed-off-by: Leonid Usov <leonid.usov@ibm.com>
Fixes: https://tracker.ceph.com/issues/62203
2023-08-01 11:44:19 +03:00
Nizamudeen A
88170fe5dd
Merge pull request #52701 from rhcs-dashboard/flake8-fix
mgr: fix flake8 compliants

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: phlogistonjohn <NOT@FOUND>
2023-08-01 11:06:50 +05:30
Casey Bodley
501ddc2b27
Merge pull request #52341 from mkogan1/wip-T52363-xrmeng8756
rgw: fix the Content-Length in response header of static website

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2023-07-31 18:15:05 -04:00
zdover23
f4a421f8ab
Merge pull request #52131 from cityofships/docs_radosgw
doc/radosgw: correct emphasis in rate limit section

Reviewed-by: Zac Dover <zac.dover@proton.me>
2023-08-01 06:31:41 +10:00
Adam Emerson
0c3f511e14 build: Remove old ceph-libboost* packages in install-deps
Here, we extract `clean_boost_on_ubuntu()` and call it before other
installs on Debian distributions so that if we install a system boost,
a potentially newer `ceph-libboost` won't get in the way.

As the sources.list.d being removed in the original cleanup code isn't
the one we're currently installing in the install code, add a removal
for the currently used source, then do apt-update so packages from the
removed source are no longer included as available.

Two subsidiary dev packages from conflicting boost libraries can be
installed, but it leaves apt in an inconsistent state. To clean this
up, add `--fix-missing` to the removal line and call
`clean_boost_on_ubuntu()` before other uses of apt.

Fixes: https://tracker.ceph.com/issues/62097
Signed-off-by: Adam Emerson <aemerson@redhat.com>
2023-07-31 11:17:43 -04:00
Piotr Parczewski
50bfbab6d9
doc/radosgw: correct emphasis in rate limit section
Signed-off-by: Piotr Parczewski <piotr@stackhpc.com>
2023-07-31 16:42:26 +02:00
Casey Bodley
e23241ee72
Merge pull request #52603 from cbodley/wip-62135
qa/rgw: pacific upgrade disables centos9

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2023-07-31 10:25:06 -04:00
Rishabh Dave
27f43c9a89 qa/cephfs: fix test_disallow_monitor_managed_snaps_for_fs_pools
run_cluster_cmd() method is not available anymore because it was deleted
here on this PR -
https://github.com/ceph/ceph/pull/50569/files#diff-1c6c246ba42f343603d7174198dd1fb9c2654b6c883594d1a0891096b7a35875L408

Fixes: https://tracker.ceph.com/issues/62243
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2023-07-31 18:18:51 +05:30
Adam King
ed852fecee
Merge pull request #51987 from rkachach/fix_issue_61628
mgr/cephadm: storing prometheus/alertmanager credentials in monstore

Reviewed-by: Adam King <adking@redhat.com>
2023-07-31 08:34:54 -04:00
Nizamudeen A
0ab7e2ca0e
Merge pull request #52622 from rhcs-dashboard/allow-put-cors
mgr/dashboard: allow PUT in CORS

Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2023-07-31 14:54:49 +05:30
Nizamudeen A
d199782fb5 mgr: fix some flake8 complaints
Signed-off-by: Nizamudeen A <nia@redhat.com>
2023-07-31 14:50:57 +05:30
avanthakkar
31055fab98 mgr/dashboard: cluster upgrade start UI
Fixes: https://tracker.ceph.com/issues/61928
Signed-off-by: avanthakkar <avanjohn@gmail.com>
2023-07-31 14:14:07 +05:30
Pere Diaz Bou
fa35ea07e9 mgr/dashboard: cephfs volume creation form
Fixes: https://tracker.ceph.com/issues/62085
Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
2023-07-31 10:17:46 +02:00
Aashish Sharma
d32b6c2751
Merge pull request #52317 from rhcs-dashboard/rgw-overview-dashboard
mgr/dashboard: add inventory card  and single stat cards to rgw overview dashboard


Reviewed-by: Nizamudeen A <nia@redhat.com>
2023-07-31 11:06:44 +05:30
Yuval Lifshitz
b111d8c6ba
Merge pull request #52435 from vedanshbhartia/coverity_invalid_typename
rgw: typecast long long to int when passing length to format string
2023-07-30 15:58:16 +03:00
Ilya Dryomov
e45272df04
Merge pull request #52688 from petrutlucian94/avoid_tzset
build: globally set FMT_USE_TZSET=0 for Windows

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2023-07-29 00:23:42 +02:00
Anthony D'Atri
8bb6cad041
Merge pull request #52668 from bluikko/patch-16
doc/radosgw: Add missing space to date option spec in admin.rst
2023-07-28 12:38:55 -04:00
Anthony D'Atri
cc6b9ae620
Merge pull request #52685 from bluikko/patch-17
doc/mgr/ceph_api: Promptify example commands in index.rst
2023-07-28 11:15:19 -04:00
Lucian Petrut
5fd67e1f88 build: globally set FMT_USE_TZSET=0 for Windows
We're currently setting FMT_USE_TZSET=0 when building libfmt
in order to avoid the _tzset function, which is unavailable
under Mingw:
aa5769ecf1

The issue is that it still gets used by fmt/chrono.h, which is
why we'll move this definition to the top level cmake file.

Note that the Windows build is currently failing as a result of
a recent change: https://github.com/ceph/ceph/pull/52590/files

  In file included from ceph/src/common/ceph_time.h:22,
                   from ceph/src/include/encoding.h:31,
                   from ceph/src/include/uuid.h:9,
                   from ceph/src/include/types.h:21,
                   from ceph/src/crush/CrushWrapper.h:14,
                   from ceph/src/crush/CrushCompiler.h:7,
                   from ceph/src/crush/CrushCompiler.cc:4:
  ceph/src/fmt/include/fmt/chrono.h: In lambda function:
  ceph/src/fmt/include/fmt/chrono.h:953:5: error: ‘_tzset’ was
  not declared in this scope; did you mean ‘tzset’?
    953 |     _tzset();
        |     ^~~~~~
        |     tzset

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
2023-07-28 14:34:37 +00:00
Nizamudeen A
7b3a4f2b4e
Merge pull request #52191 from rhcs-dashboard/fix-daemon-labels-exporter
mgr/dashboard: empty grafana panels for performance of daemons 

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: cloudbehl <NOT@FOUND>
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2023-07-28 18:46:35 +05:30
Nizamudeen A
8da2a2c0e2 mgr/dashboard: allow PUT in CORS
Fixes: https://tracker.ceph.com/issues/62222
Signed-off-by: Nizamudeen A <nia@redhat.com>
2023-07-28 18:35:20 +05:30
avanthakkar
fa2d1f9f07 mgr/dashboard: empty grafana panels for performance of daemons
Fixes: https://tracker.ceph.com/issues/61792
Signed-off-by: avanthakkar <avanjohn@gmail.com>

Removing the `ceph-` prefix from ceph_daemon label to adopt it with the label
format used by queries in grafana dashboards. Also changing the
`instance_id` label for rgw to match the values coming from
exporter and prometheus module
2023-07-28 16:05:32 +05:30
Ville Ojamo
4f9bd62f37
doc/mgr/ceph_api: Promptify example commands in index.rst
Use the more modern prompt block instead of
using code blocks for example commands.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
2023-07-28 11:49:19 +07:00
Ville Ojamo
dd16ad9055 doc/radosgw: Add missing space to date option spec in admin.rst
The start time and end time CLI option specification is missing a space between the date and the optional time value. Also expand the text to talk about "optional time" after the date.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
2023-07-28 10:54:06 +07:00
Ilya Dryomov
23f9ebb115
Merge pull request #52549 from cbodley/wip-qa-distros-centos9-no-copr
qa/distros: disable ceph/el9 copr workaround for missing python deps

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2023-07-27 21:40:07 +02:00
zdover23
8e6c03fdda
Merge pull request #52671 from zdover23/wip-doc-2023-07-27-readmemd-2-of-x
doc: update README.md install procedure

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2023-07-28 05:11:44 +10:00
Ronen Friedman
190be730ff
Merge pull request #52591 from ronen-fr/wip-rf-cephx-init
cephx: initializing two member variables in the ctors


Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2023-07-27 19:13:06 +03:00
Ronen Friedman
c14e94d0d1
Merge pull request #52590 from ronen-fr/wip-rf-res-type2
osd/scrub: fixing & improving ReservationTimeout handler messages

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2023-07-27 18:24:06 +03:00
Adam King
408c1cc056
Merge pull request #52084 from rhcs-dashboard/fix-exporter-addrs
exporter: ceph-exporter scrapes failing on multi-homed server

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@ibm.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2023-07-27 09:58:51 -04:00
Zac Dover
0b0009bf1f doc: update README.md install procedure
Add instructions directing the reader to install the "python3-routes"
package. This package is required in order to launch the dashboard after
the installation procedure has completed, but is not yet included in the
install-deps.sh script.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2023-07-27 21:49:19 +10:00
Venky Shankar
67f334d047 Merge PR #52376 into main
* refs/pull/52376/head:
	mds: skip forwarding request if the session were removed

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-07-27 16:38:36 +05:30
Venky Shankar
bdde984397 Merge PR #52176 into main
* refs/pull/52176/head:
	mds: remove calculating caps after adding revokes back

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2023-07-27 16:37:55 +05:30
Venky Shankar
d3f9d14022 Merge PR #51536 into main
* refs/pull/51536/head:
	mds: do not send split_realms for CEPH_SNAP_OP_UPDATE msg

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
2023-07-27 13:38:54 +05:30