RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-02-24 19:47:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

* fixed bug with writefile/readfile data fingerprinting (for detecting data corruption errors)

Browse Source 
git-svn-id: https://ceph.svn.sf.net/svnroot/ceph@1217 29311d96-e01e-0410-9327-a35deaab8ce9
This commit is contained in:
sageweil 2007-03-12 22:08:13 +00:00
parent b803102e8e
commit f35b883067
1 changed files with 16 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
trunk/ceph/client/SyntheticClient.cc
View File

@ -973,17 +973,16 @@ int SyntheticClient::write_file(string& fn, int size, int wrsize) // size is i
}
dout(2) << "writing block " << i << "/" << chunks << endl;
// fill buf with a fingerprint
int *p = (int*)buf;
// fill buf with a 16 byte fingerprint
// 64 bits : file offset
// 64 bits : client id
// = 128 bits (16 bytes)
__uint64_t *p = (__uint64_t*)buf;
while ((char*)p < buf + wrsize) {
*p = (char*)p - buf;
p++;
*p = i;
*p = i*wrsize + (char*)p - buf;
p++;
*p = client->get_nodeid();
p++;
*p = 0;
p++;
}
client->write(fd, buf, wrsize, i*wrsize);
@ -1021,39 +1020,26 @@ int SyntheticClient::read_file(string& fn, int size, int rdsize) // size is in
client->read(fd, buf, rdsize, i*rdsize);
// verify fingerprint
int *p = (int*)buf;
int bad = 0;
int boff, bgoff, bchunk, bclient, bzero;
__int64_t *p = (__int64_t*)buf;
__int64_t readoff, readclient;
while ((char*)p + 32 < buf + rdsize) {
boff = *p;
bgoff = (int)((char*)p - buf);
readoff = *p;
__int64_t wantoff = i*rdsize + (__int64_t)((char*)p - buf);
p++;
bchunk = *p;
readclient = *p;
p++;
bclient = *p;
p++;
bzero = *p;
p++;
if (boff != bgoff ||
bchunk != (int)i ||
bclient != client->get_nodeid() ||
bzero != 0) {
if (readoff != wantoff ||
readclient != client->get_nodeid()) {
if (!bad)
dout(0) << "WARNING: wrong data from OSD, it should be "
<< "(block=" << i
<< " offset=" << bgoff
<< " client=" << client->get_nodeid() << ")"
<< " .. but i read back .. "
<< "(block=" << bchunk
<< " offset=" << boff
<< " client=" << bclient << " zero=" << bzero << ")" << endl;
dout(0) << "WARNING: wrong data from OSD, block says fileoffset=" << readoff << " client=" << readclient
<< ", should be offset " << wantoff << " clietn " << client->get_nodeid()
<< endl;
bad++;
}
}
if (bad)
dout(0) << " + " << (bad-1) << " other bad 16-byte bits in this block" << endl;
}
client->close(fd);