RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-01-19 17:41:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

librbd: small improvements for TaskFinisher

Browse Source 
1) cancel: make return success status
2) queue: allow to pass return value
3) add method to reschedule event

Signed-off-by: Mykola Golub <mgolub@suse.com>
This commit is contained in:
Mykola Golub 2020-04-09 17:43:21 +01:00
parent 39a5fc1af3
commit f3590d6334
1 changed files with 24 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/librbd/TaskFinisher.h
View File

@ -51,14 +51,17 @@ public:
m_finisher = singleton.m_finisher; m_finisher = singleton.m_finisher;
} }
void cancel(const Task& task) { bool cancel(const Task& task) {
std::lock_guard l{*m_lock}; std::lock_guard l{*m_lock};
typename TaskContexts::iterator it = m_task_contexts.find(task); typename TaskContexts::iterator it = m_task_contexts.find(task);
if (it != m_task_contexts.end()) { if (it == m_task_contexts.end()) {
delete it->second.first; return false;
m_safe_timer->cancel_event(it->second.second);
m_task_contexts.erase(it);
} }
delete it->second.first;
bool canceled = m_safe_timer->cancel_event(it->second.second);
ceph_assert(canceled);
m_task_contexts.erase(it);
return true;
} }
void cancel_all(Context *comp) { void cancel_all(Context *comp) {
@ -88,8 +91,22 @@ public:
return true; return true;
} }
void queue(Context *ctx) { bool reschedule_event_after(const Task& task, double seconds) {
m_finisher->queue(ctx); std::lock_guard l{*m_lock};
auto it = m_task_contexts.find(task);
if (it == m_task_contexts.end()) {
return false;
}
bool canceled = m_safe_timer->cancel_event(it->second.second);
ceph_assert(canceled);
auto timer_ctx = new C_Task(this, task);
it->second.second = timer_ctx;
m_safe_timer->add_event_after(seconds, timer_ctx);
return true;
}
void queue(Context *ctx, int r = 0) {
m_finisher->queue(ctx, r);
} }
bool queue(const Task& task, Context *ctx) { bool queue(const Task& task, Context *ctx) {