RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-02-23 19:17:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

crimson/os: drop the old FuturizedStore::Exception class.

Browse Source 
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
This commit is contained in:
Radoslaw Zarzynski 2019-08-26 12:38:21 +02:00
parent a7e44dbe15
commit ef9e52300f
1 changed files with 0 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/crimson/os/futurized_store.h
View File

@ -26,36 +26,6 @@ class FuturizedCollection;
class FuturizedStore {
public:
// TODO: replace with the crimson::errorator concept
template <class ConcreteExceptionT>
class Exception : public std::logic_error {
public:
using std::logic_error::logic_error;
// Throwing an exception isn't the sole way to signalize an error
// with it. This approach nicely fits cold, infrequent issues but
// when applied to a hot one (like ENOENT on write path), it will
// likely hurt performance.
// Alternative approach for hot errors is to create exception_ptr
// on our own and place it in the future via make_exception_future.
// When ::handle_exception is called, handler would inspect stored
// exception whether it's hot-or-cold before rethrowing it.
// The main advantage is both types flow through very similar path
// based on future::handle_exception.
static bool is_class_of(const std::exception_ptr& ep) {
// Seastar offers hacks for making throwing lock-less but stack
// unwinding still can be a problem so painful to justify going
// with non-standard, obscure things like this one.
return *ep.__cxa_exception_type() == typeid(ConcreteExceptionT);
}
};
struct EnoentException : public Exception<EnoentException> {
using Exception<EnoentException>::Exception;
};
struct EnodataException : public Exception<EnodataException> {
using Exception<EnodataException>::Exception;
};
static std::unique_ptr<FuturizedStore> create(const std::string& type,
const std::string& data);
FuturizedStore() = default;