RepoMirrors/ceph
1
0
Fork 0
mirror of https://github.com/ceph/ceph synced 2025-01-04 02:02:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

cephadm: validate that the constructed YumDnf baseurl is usable

Browse Source 
If the inputs to the `cephadm add-repo` command would result in an
invalid URL for repo metadata fail the command early with a (somewhat)
helpful error.

Fixes: https://tracker.ceph.com/issues/46773

Signed-off-by: John Mulligan <jmulligan@redhat.com>
This commit is contained in:
John Mulligan 2022-01-20 14:48:28 -05:00
parent 266e3f4667
commit ee71ff79a3
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/cephadm/cephadm
View File

@ -6967,6 +6967,18 @@ class YumDnf(Packager):
if self.version and self.version.split('.')[0] >= '16':
raise Error('Ceph does not support 16.y.z or later for this version of this linux distro and therefore cannot add a repo for it')
if self.stable or self.version:
# we know that yum & dnf require there to be a
# $base_url/$arch/repodata/repomd.xml so we can test if this URL
# is gettable in order to validate the inputs
test_url = self.repo_baseurl() + '/noarch/repodata/repomd.xml'
try:
urlopen(test_url)
except HTTPError as err:
logger.error('unable to fetch repo metadata: %r', err)
raise Error('failed to fetch repository metadata. please check'
' the provided parameters are correct and try again')
def add_repo(self) -> None:
if self.stable or self.version:
content = ''