From ec5133b09c284796d872571afbbc60add36e6fa7 Mon Sep 17 00:00:00 2001 From: Sage Weil Date: Fri, 24 Aug 2012 19:47:44 -0700 Subject: [PATCH] msg/Pipe: make banner buffer slightly bigger CID 717023: Out-of-bounds access (OVERRUN_DYNAMIC) At (4): Allocating insufficient memory for the terminating null of the string. This appears to be a false positive (we don't interpret the buffer as a string, ever), but it will make coverity happier. Signed-off-by: Sage Weil --- src/msg/Pipe.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/msg/Pipe.cc b/src/msg/Pipe.cc index e26c818d3a7..3e409f1042b 100644 --- a/src/msg/Pipe.cc +++ b/src/msg/Pipe.cc @@ -594,7 +594,7 @@ int Pipe::connect() struct msghdr msg; struct iovec msgvec[2]; int msglen; - char banner[strlen(CEPH_BANNER)]; + char banner[strlen(CEPH_BANNER) + 1]; // extra byte makes coverity happy entity_addr_t paddr; entity_addr_t peer_addr_for_me, socket_addr; AuthAuthorizer *authorizer = NULL;