From e74ec0b27dfb480a2951f85bf00072e95d944772 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Sat, 3 Feb 2024 13:46:05 +0800 Subject: [PATCH] debian/cephadm.postinst: stop using adduser --gecos --gecos option of adduser is deprecated in debian/bookworm, and will be removed in debian/trixie, see https://manpages.debian.org/bookworm/adduser/adduser.8.en.html. so to be future-proof, let's switch to `usermod --comment`. please note, since we still need to support ubuntu/jammy which is used in our CI, and `adduser` shipped by ubuntu/jammy does not support `--comment` yet, so we cannot use this option. Signed-off-by: Kefu Chai --- debian/cephadm.postinst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/cephadm.postinst b/debian/cephadm.postinst index 274b7f7846a..50aa6f8dd51 100644 --- a/debian/cephadm.postinst +++ b/debian/cephadm.postinst @@ -29,8 +29,8 @@ case "$1" in --system \ --disabled-password \ --home /home/cephadm \ - --gecos 'cephadm user for mgr/cephadm' \ --shell /bin/bash cephadm 2>/dev/null || true + usermod --comment "cephadm user for mgr/cephadm" cephadm echo "..done" fi