1
0
mirror of https://github.com/ceph/ceph synced 2025-03-23 10:48:12 +00:00

don't eat exceptions for breakfast

fixes 0c2bee1514
This commit is contained in:
Sage Weil 2011-09-02 11:07:10 -07:00
parent 7c4a5ac83b
commit e66dffc3d3

View File

@ -212,29 +212,29 @@ def valgrind_post(ctx, config):
try:
yield
finally:
if not config.get('valgrind'):
return
lookup_procs = list()
val_path = '/tmp/cephtest/archive/log/{val_dir}/*'.format(val_dir=config.get('valgrind').get('logs', "valgrind"))
for remote in ctx.cluster.remotes.iterkeys():
#look at valgrind logs for each node
proc = remote.run(
args=[
'grep', "<kind>", run.Raw(val_path), run.Raw('|'),
'grep', '-v', '-q', "PossiblyLost"],
wait = False,
check_status=False
)
lookup_procs.append((proc, remote))
valgrind_exception = None
for (proc, remote) in lookup_procs:
result = proc.exitstatus.get()
if result is not 1:
valgrind_exception = Exception("saw valgrind issues in {node}".format(node=remote.name))
if valgrind_exception is not None:
raise valgrind_exception
if config.get('valgrind'):
lookup_procs = list()
val_path = '/tmp/cephtest/archive/log/{val_dir}/*'.format(
val_dir=config.get('valgrind').get('logs', "valgrind"))
for remote in ctx.cluster.remotes.iterkeys():
#look at valgrind logs for each node
proc = remote.run(
args=[
'grep', "<kind>", run.Raw(val_path), run.Raw('|'),
'grep', '-v', '-q', "PossiblyLost"],
wait = False,
check_status=False
)
lookup_procs.append((proc, remote))
valgrind_exception = None
for (proc, remote) in lookup_procs:
result = proc.exitstatus.get()
if result is not 1:
valgrind_exception = Exception("saw valgrind issues in {node}".format(node=remote.name))
if valgrind_exception is not None:
raise valgrind_exception
@contextlib.contextmanager