From e3b27b7b67e138cec150380ae325d24828af30ac Mon Sep 17 00:00:00 2001 From: Danny Al-Gaaf Date: Tue, 26 Feb 2013 11:15:35 +0100 Subject: [PATCH] mon_store_converter.cc: use empty() instead of size() Use empty() since it should be prefered as it has, following the standard, a constant time complexity regardless of the containter type. The same is not guaranteed for size(). Signed-off-by: Danny Al-Gaaf --- src/mon_store_converter.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mon_store_converter.cc b/src/mon_store_converter.cc index 3d8e53067e8..1c0d3af98e2 100644 --- a/src/mon_store_converter.cc +++ b/src/mon_store_converter.cc @@ -247,7 +247,7 @@ class MonitorStoreConverter { } void _convert_paxos() { - assert(gvs.size() > 0); + assert(!gvs.empty()); set::reverse_iterator rit = gvs.rbegin(); version_t highest_gv = *rit; @@ -320,7 +320,7 @@ int main(int argc, const char *argv[]) common_init_finish(g_ceph_context); g_ceph_context->_conf->apply_changes(NULL); - if (args.size() < 1) { + if (args.empty()) { usage(our_name); return 1; }